[GitHub] [kafka] tombentley commented on pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

tombentley commented on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-730988517 Thanks @chia7712 for the review! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] showuon commented on pull request #9629: KAFKA-10754: fix flaky tests by waiting kafka streams be in running state before assert

showuon commented on pull request #9629: URL: https://github.com/apache/kafka/pull/9629#issuecomment-730972399 @ableegoldman @wcarlson5 , could you help review this PR? Thanks. This is an automated message from the Apache

[GitHub] [kafka] chia7712 commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

chia7712 commented on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-730972056 @iprithv Could you share your jira account to me? I want to assign https://issues.apache.org/jira/browse/KAFKA-6181 to you.

[GitHub] [kafka] showuon commented on a change in pull request #9629: KAFKA-10754: fix flaky tests by waiting kafka streams be in running state before assert

showuon commented on a change in pull request #9629: URL: https://github.com/apache/kafka/pull/9629#discussion_r527495985 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java ## @@ -145,48 +142,12 @@

[GitHub] [kafka] showuon commented on a change in pull request #9629: KAFKA-10754: fix flaky tests by waiting kafka streams be in running state before assert

showuon commented on a change in pull request #9629: URL: https://github.com/apache/kafka/pull/9629#discussion_r527495475 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java ## @@ -145,48 +142,12 @@

[GitHub] [kafka] showuon opened a new pull request #9629: KAFKA-10754: fix flaky tests by waiting kafka streams be in running state before assert

showuon opened a new pull request #9629: URL: https://github.com/apache/kafka/pull/9629 The flaky test is because we didn't wait for the streams become RUNNING before verifying the state becoming ERROR state. This fix explicitly wait for the streams become RUNNING state. Also, I found we

[jira] [Commented] (KAFKA-10743) Fix NumRequestsForwardingToControllerPerSec metric in ForwardingManager

[ https://issues.apache.org/jira/browse/KAFKA-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235960#comment-17235960 ] Chia-Ping Tsai commented on KAFKA-10743: Is this still valid?

[GitHub] [kafka] chia7712 commented on pull request #9502: MINOR: mark StandbyTaskEOSIntegrationTest as an IntegrationTest

chia7712 commented on pull request #9502: URL: https://github.com/apache/kafka/pull/9502#issuecomment-730963422 @dajac Could you take a look? one line fix :) This is an automated message from the Apache Git Service. To

[GitHub] [kafka] splett2 opened a new pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

splett2 opened a new pull request #9628: URL: https://github.com/apache/kafka/pull/9628 This PR adds support for IP entities to the `DescribeClientQuotas` and `AlterClientQuotas` APIs. This change does not require any protocol version bumps. This PR also adds support for

[GitHub] [kafka] chia7712 merged pull request #9625: MINOR: remove semicolon

chia7712 merged pull request #9625: URL: https://github.com/apache/kafka/pull/9625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Comment Edited] (KAFKA-10753) check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG > 0

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235957#comment-17235957 ] Luke Chen edited comment on KAFKA-10753 at 11/20/20, 7:33 AM: -- [~17hao], I

[jira] [Commented] (KAFKA-10753) check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG > 0

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235957#comment-17235957 ] Luke Chen commented on KAFKA-10753: --- [~17hao], I don't think it'll make any difference if the

[jira] [Commented] (KAFKA-10753) check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG > 0

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235956#comment-17235956 ] shiqihao commented on KAFKA-10753: -- If AUTO_COMMIT_INTERVAL_MS_CONFIG == 0, CPU usage is at 100%. I

[jira] [Updated] (KAFKA-10607) Ensure the error counts contains the NONE

[ https://issues.apache.org/jira/browse/KAFKA-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10607: --- Fix Version/s: 2.8.0 > Ensure the error counts contains the NONE >

[jira] [Resolved] (KAFKA-10607) Ensure the error counts contains the NONE

[ https://issues.apache.org/jira/browse/KAFKA-10607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10607. Resolution: Fixed > Ensure the error counts contains the NONE >

[GitHub] [kafka] chia7712 commented on pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

chia7712 commented on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-730960958 @tombentley Thanks for your patch! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] chia7712 merged pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

chia7712 merged pull request #9433: URL: https://github.com/apache/kafka/pull/9433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-10753) check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG > 0

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shiqihao updated KAFKA-10753: - Description: I accidentally set ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG = 0, CPU running at

[jira] [Commented] (KAFKA-10753) check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG != 0

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235946#comment-17235946 ] lqjacklee commented on KAFKA-10753: --- [~showuon] org.apache.kafka.common.utils.Time need check whether

[jira] [Assigned] (KAFKA-10753) check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG != 0

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lqjacklee reassigned KAFKA-10753: - Assignee: lqjacklee > check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG != 0 >

[jira] [Created] (KAFKA-10754) Fix flaky shouldShutdownSingleThreadApplication test

Luke Chen created KAFKA-10754: - Summary: Fix flaky shouldShutdownSingleThreadApplication test Key: KAFKA-10754 URL: https://issues.apache.org/jira/browse/KAFKA-10754 Project: Kafka Issue Type:

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r527470855 ## File path: clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java ## @@ -159,24 +159,25 @@ private static ChannelBuilder

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r527469991 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -366,8 +379,9 @@ public void testMetadataFetch()

[GitHub] [kafka] showuon opened a new pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

showuon opened a new pull request #9627: URL: https://github.com/apache/kafka/pull/9627 This improvement is side effect of this PR: https://github.com/apache/kafka/pull/6972, where we tried to fix flooding number of warning messages but never left group case. So we move the warn logs

[jira] [Commented] (KAFKA-10753) check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG != 0

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235921#comment-17235921 ] Luke Chen commented on KAFKA-10753: --- We did check the AUTO_COMMIT_INTERVAL_MS_CONFIG value should >=

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-730880740 @abbccdda @guozhangwang , please help review this PR. Thanks. This is an automated message from the Apache Git

[jira] [Updated] (KAFKA-10753) check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG != 0

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shiqihao updated KAFKA-10753: - Description: I accidentally set ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG = 0, CPU running at

[jira] [Updated] (KAFKA-10753) check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG != 0

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shiqihao updated KAFKA-10753: - Summary: check if ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG != 0 (was: check if 

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527398919 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTest.java ## @@ -0,0 +1,370 @@ +/*

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527398919 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTest.java ## @@ -0,0 +1,370 @@ +/*

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527398919 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTest.java ## @@ -0,0 +1,370 @@ +/*

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527398230 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTest.java ## @@ -0,0 +1,370 @@ +/*

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527396830 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -0,0 +1,407 @@

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527396830 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -0,0 +1,407 @@

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527396144 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -0,0 +1,407 @@

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527395668 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationSSLTest.java ## @@ -0,0 +1,89 @@

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527393326 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationSSLTest.java ## @@ -0,0 +1,89 @@

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527391656 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/TestUtils.java ## @@ -32,4 +32,15 @@ } return props;

[GitHub] [kafka] ning2008wisc commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

ning2008wisc commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527391154 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -0,0 +1,407 @@

[jira] [Updated] (KAFKA-10753) check if `ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG != 0`

[ https://issues.apache.org/jira/browse/KAFKA-10753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shiqihao updated KAFKA-10753: - Summary: check if `ConsumerConfig.AUTO_COMMIT_INTERVAL_MS_CONFIG != 0` (was: Kafka) > check if 

[jira] [Created] (KAFKA-10753) Kafka

shiqihao created KAFKA-10753: Summary: Kafka Key: KAFKA-10753 URL: https://issues.apache.org/jira/browse/KAFKA-10753 Project: Kafka Issue Type: Improvement Components: consumer

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-730815895 Hi, any updates on this? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] hachikuji merged pull request #9617: MINOR: Factor out common response parsing logic

hachikuji merged pull request #9617: URL: https://github.com/apache/kafka/pull/9617 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r527359444 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -88,20 +88,33 @@ class AlterIsrManagerImpl(val controllerChannelManager:

[GitHub] [kafka] abbccdda commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

abbccdda commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r527359174 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -88,20 +88,33 @@ class AlterIsrManagerImpl(val controllerChannelManager:

[jira] [Commented] (KAFKA-10746) Consumer poll timeout Expiration should be logged as WARNING not INFO.

[ https://issues.apache.org/jira/browse/KAFKA-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235843#comment-17235843 ] Luke Chen commented on KAFKA-10746: --- Nice suggestion! Will submit patch for this! > Consumer poll

[jira] [Assigned] (KAFKA-10746) Consumer poll timeout Expiration should be logged as WARNING not INFO.

[ https://issues.apache.org/jira/browse/KAFKA-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-10746: - Assignee: Luke Chen > Consumer poll timeout Expiration should be logged as WARNING not INFO.

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r527352682 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -2588,6 +2589,21 @@ public void

[jira] [Commented] (KAFKA-10752) One topic partition multiple consumer

[ https://issues.apache.org/jira/browse/KAFKA-10752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235842#comment-17235842 ] AaronTrazona commented on KAFKA-10752: -- Sorry. I posted here my questions. Thanks. > One topic

[jira] [Created] (KAFKA-10752) One topic partition multiple consumer

AaronTrazona created KAFKA-10752: Summary: One topic partition multiple consumer Key: KAFKA-10752 URL: https://issues.apache.org/jira/browse/KAFKA-10752 Project: Kafka Issue Type: Task

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r527352078 ## File path: clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java ## @@ -79,14 +79,29 @@ public SslFactory(Mode mode,

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r527347652 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -105,7 +105,9 @@ public AbstractConfig(ConfigDef definition,

[GitHub] [kafka] hachikuji commented on a change in pull request #9564: KAFKA-10667: add timeout for forwarding requests

hachikuji commented on a change in pull request #9564: URL: https://github.com/apache/kafka/pull/9564#discussion_r527324620 ## File path: core/src/main/scala/kafka/server/AlterIsrManager.scala ## @@ -88,20 +88,33 @@ class AlterIsrManagerImpl(val controllerChannelManager:

[jira] [Updated] (KAFKA-10745) Please let me know how I check the time which Source connector receive the data from source table.

[ https://issues.apache.org/jira/browse/KAFKA-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] NAYUSIK updated KAFKA-10745: Issue Type: Improvement (was: Bug) > Please let me know how I check the time which Source connector

[jira] [Updated] (KAFKA-10745) Please let me know how I check the time which Source connector receive the data from source table.

[ https://issues.apache.org/jira/browse/KAFKA-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] NAYUSIK updated KAFKA-10745: Issue Type: Bug (was: Improvement) > Please let me know how I check the time which Source connector

[GitHub] [kafka] jolshan edited a comment on pull request #9622: KAFKA-10547; add topicId in MetadataResp

jolshan edited a comment on pull request #9622: URL: https://github.com/apache/kafka/pull/9622#issuecomment-730710397 Hi @dengziming! Thanks for the PR! I was hoping to add LeaderAndIsrRequests before UpdateMetadata/Metadata, following the ordering of the [JIRA

[GitHub] [kafka] jolshan edited a comment on pull request #9622: KAFKA-10547; add topicId in MetadataResp

jolshan edited a comment on pull request #9622: URL: https://github.com/apache/kafka/pull/9622#issuecomment-730710397 Hi @dengziming! Thanks for the PR! I was hoping to add LeaderAndIsrRequests before UpdateMetadata/Metadata, following the ordering of the [JIRA

[GitHub] [kafka] jolshan commented on pull request #9622: KAFKA-10547; add topicId in MetadataResp

jolshan commented on pull request #9622: URL: https://github.com/apache/kafka/pull/9622#issuecomment-730710397 Hi @dengziming! Thanks for the PR! I was hoping to add LeaderAndIsrRequests before UpdateMetadata/Metadata, as ordered in the [JIRA

[jira] [Commented] (KAFKA-10547) Add topic IDs to MetadataResponse

[ https://issues.apache.org/jira/browse/KAFKA-10547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235796#comment-17235796 ] Justine Olshan commented on KAFKA-10547: Hi [~dengziming] I'm sorry I didn't see this until now.

[GitHub] [kafka] jolshan opened a new pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

jolshan opened a new pull request #9626: URL: https://github.com/apache/kafka/pull/9626 This change takes the topic IDs created in https://github.com/apache/kafka/pull/9473 and propagates them to brokers using LeaderAndIsr Request. It also removes the topic name from the LeaderAndIsr

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r527277048 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,11 +904,72 @@ private KafkaStreams(final

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r527277135 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,11 +904,72 @@ private KafkaStreams(final

[GitHub] [kafka] Hamza-Slama opened a new pull request #9625: MINOR: remove semicolon

Hamza-Slama opened a new pull request #9625: URL: https://github.com/apache/kafka/pull/9625 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Comment Edited] (KAFKA-9458) Kafka crashed in windows environment

[ https://issues.apache.org/jira/browse/KAFKA-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235769#comment-17235769 ] Daniel Dube edited comment on KAFKA-9458 at 11/19/20, 10:10 PM: Hi

[jira] [Commented] (KAFKA-9458) Kafka crashed in windows environment

[ https://issues.apache.org/jira/browse/KAFKA-9458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235769#comment-17235769 ] Daniel Dube commented on KAFKA-9458: Hi everyone. "Windows is not an officially supported platform".

[GitHub] [kafka] hachikuji merged pull request #9608: MINOR: Enable testLogCleanerStats

hachikuji merged pull request #9608: URL: https://github.com/apache/kafka/pull/9608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] lmr3796 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

lmr3796 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r527192802 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1333,7 +1343,17 @@ class KafkaApis(val requestChannel: RequestChannel, }

[jira] [Assigned] (KAFKA-8872) Improvements to controller "deleting" state / topic Identifiers

[ https://issues.apache.org/jira/browse/KAFKA-8872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-8872: - Assignee: Justine Olshan > Improvements to controller "deleting" state / topic

[GitHub] [kafka] hachikuji merged pull request #9619: MINOR: Reduce sends created by `SendBuilder`

hachikuji merged pull request #9619: URL: https://github.com/apache/kafka/pull/9619 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] cadonna commented on a change in pull request #9615: KAFKA-10500: Add thread option

cadonna commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r527145996 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -588,6 +592,29 @@ public void testCloseIsIdempotent() {

[jira] [Commented] (KAFKA-10751) Generate log to help estimate messages lost during ULE

[ https://issues.apache.org/jira/browse/KAFKA-10751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235702#comment-17235702 ] Lucas Wang commented on KAFKA-10751: PR submitted: https://github.com/apache/kafka/pull/9533 >

[jira] [Created] (KAFKA-10751) Generate log to help estimate messages lost during ULE

Lucas Wang created KAFKA-10751: -- Summary: Generate log to help estimate messages lost during ULE Key: KAFKA-10751 URL: https://issues.apache.org/jira/browse/KAFKA-10751 Project: Kafka Issue

[jira] [Resolved] (KAFKA-10723) LogManager leaks internal thread pool activity during shutdown

[ https://issues.apache.org/jira/browse/KAFKA-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-10723. - Fix Version/s: 2.8.0 Resolution: Fixed merged to trunk > LogManager leaks internal thread pool

[GitHub] [kafka] cadonna commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

cadonna commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r527122772 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -221,6 +221,9 @@ State setState(final State

[GitHub] [kafka] junrao merged pull request #9596: KAFKA-10723: Fix LogManager shutdown error handling

junrao merged pull request #9596: URL: https://github.com/apache/kafka/pull/9596 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r527117685 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -221,6 +221,9 @@ State setState(final State

[GitHub] [kafka] junrao commented on a change in pull request #9621: KAFKA-9892: Producer state snapshot needs to be forced to disk

junrao commented on a change in pull request #9621: URL: https://github.com/apache/kafka/pull/9621#discussion_r527105252 ## File path: core/src/main/scala/kafka/log/ProducerStateManager.scala ## @@ -437,7 +437,7 @@ object ProducerStateManager { val fileChannel =

[GitHub] [kafka] hachikuji commented on a change in pull request #9617: MINOR: Factor out common response parsing logic

hachikuji commented on a change in pull request #9617: URL: https://github.com/apache/kafka/pull/9617#discussion_r527101086 ## File path: clients/src/main/java/org/apache/kafka/common/requests/CorrelationIdMismatchException.java ## @@ -0,0 +1,45 @@ +/* + * Licensed to the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r527099779 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,11 +904,57 @@ private KafkaStreams(final

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r527099742 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,11 +904,57 @@ private KafkaStreams(final

[GitHub] [kafka] junrao commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

junrao commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r527096607 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -366,8 +379,9 @@ public void testMetadataFetch() throws

[GitHub] [kafka] hachikuji commented on a change in pull request #9617: MINOR: Factor out common response parsing logic

hachikuji commented on a change in pull request #9617: URL: https://github.com/apache/kafka/pull/9617#discussion_r527095539 ## File path: clients/src/main/java/org/apache/kafka/common/requests/CorrelationIdMismatchException.java ## @@ -0,0 +1,45 @@ +/* + * Licensed to the

[GitHub] [kafka] hachikuji commented on a change in pull request #9617: MINOR: Factor out common response parsing logic

hachikuji commented on a change in pull request #9617: URL: https://github.com/apache/kafka/pull/9617#discussion_r527095050 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -974,21 +969,6 @@ private void

[GitHub] [kafka] cadonna commented on a change in pull request #9615: KAFKA-10500: Add thread option

cadonna commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r527055689 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,11 +904,57 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] mimaison commented on a change in pull request #9224: KAFKA-10304: refactor MM2 integration tests

mimaison commented on a change in pull request #9224: URL: https://github.com/apache/kafka/pull/9224#discussion_r527014720 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java ## @@ -0,0 +1,407 @@ +/*

[GitHub] [kafka] hachikuji commented on a change in pull request #9619: MINOR: Reduce sends created by `SendBuilder`

hachikuji commented on a change in pull request #9619: URL: https://github.com/apache/kafka/pull/9619#discussion_r527073144 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java ## @@ -122,6 +123,14 @@ public void writeVarlong(long i) {

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

vamossagar12 commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r527073514 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -709,6 +709,9 @@ static void verifyLeaderChangeMessage(

[GitHub] [kafka] hachikuji commented on a change in pull request #9619: MINOR: Reduce sends created by `SendBuilder`

hachikuji commented on a change in pull request #9619: URL: https://github.com/apache/kafka/pull/9619#discussion_r527073144 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java ## @@ -122,6 +123,14 @@ public void writeVarlong(long i) {

[jira] [Created] (KAFKA-10750) test failure scenarios of MirrorMaker 2

Ning Zhang created KAFKA-10750: -- Summary: test failure scenarios of MirrorMaker 2 Key: KAFKA-10750 URL: https://issues.apache.org/jira/browse/KAFKA-10750 Project: Kafka Issue Type: Improvement

[jira] [Assigned] (KAFKA-10580) Add topic ID support to Fetch request

[ https://issues.apache.org/jira/browse/KAFKA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-10580: -- Assignee: Justine Olshan > Add topic ID support to Fetch request >

[GitHub] [kafka] chia7712 commented on pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

chia7712 commented on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-730516709 @tombentley thanks! I will merge this PR tomorrow if no objection :) This is an automated message from the

[jira] [Assigned] (KAFKA-10548) Implement deletion logic for LeaderAndIsrRequests

[ https://issues.apache.org/jira/browse/KAFKA-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-10548: -- Assignee: Justine Olshan > Implement deletion logic for LeaderAndIsrRequests >

[GitHub] [kafka] tombentley commented on pull request #9433: KAFKA-10607: Consistent behaviour for response errorCounts()

tombentley commented on pull request #9433: URL: https://github.com/apache/kafka/pull/9433#issuecomment-730508481 @chia7712 done This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda opened a new pull request #9624: KAFKA-10655: wrap and catch exception for appendAsLeader failure

abbccdda opened a new pull request #9624: URL: https://github.com/apache/kafka/pull/9624 When leader append fails, we should trigger the resign process and do a graceful shutdown afterwards. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] hachikuji commented on a change in pull request #9601: KAFKA-10729: Bump remaining RPC's to use tagged fields.

hachikuji commented on a change in pull request #9601: URL: https://github.com/apache/kafka/pull/9601#discussion_r527045689 ## File path: core/src/main/scala/kafka/api/ApiVersion.scala ## @@ -108,7 +108,9 @@ object ApiVersion { // Bup Fetch protocol for Raft protocol

[jira] [Assigned] (KAFKA-10549) Add topic ID support to DeleteTopics,ListOffsets, OffsetForLeaders, StopReplica

[ https://issues.apache.org/jira/browse/KAFKA-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-10549: -- Assignee: Justine Olshan > Add topic ID support to DeleteTopics,ListOffsets,

[GitHub] [kafka] jolshan commented on pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on pull request #9590: URL: https://github.com/apache/kafka/pull/9590#issuecomment-730503145 @chia7712 I did think about this solution initially. I'm wondering if we do want to update the segment offsets and logStartOffsets correctly though. If that isn't as important

[GitHub] [kafka] wcarlson5 commented on pull request #9615: KAFKA-10500: Add thread option

wcarlson5 commented on pull request #9615: URL: https://github.com/apache/kafka/pull/9615#issuecomment-730500854 @cadonna @mjsax @vvcephei Part 3 of KIP-663 add threads is ready for review This is an automated message from

[GitHub] [kafka] chia7712 commented on pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

chia7712 commented on pull request #9590: URL: https://github.com/apache/kafka/pull/9590#issuecomment-730491021 > Are you suggesting removing ListOffsetRequest.EARLIEST_TIMESTAMP and replacing it with 0? yep, it seems like a simple solution without much changes. However, I have

[GitHub] [kafka] jolshan commented on pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

jolshan commented on pull request #9590: URL: https://github.com/apache/kafka/pull/9590#issuecomment-730487839 @chia7712 The code path you linked is the code path beginningOffsets uses. Are you suggesting removing `ListOffsetRequest.EARLIEST_TIMESTAMP` and replacing it with 0?

  1   2   >