[GitHub] [kafka] chia7712 merged pull request #9861: MINOR: Modify unnecessary access specifiers

chia7712 merged pull request #9861: URL: https://github.com/apache/kafka/pull/9861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] dongjinleekr commented on pull request #10402: MINOR: Remove unthrown exceptions, fix typo, etc.

dongjinleekr commented on pull request #10402: URL: https://github.com/apache/kafka/pull/10402#issuecomment-822992332 @chia7712 This PR seems already approved but not merged yet. Could you have a look? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dongjinleekr commented on pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

dongjinleekr commented on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-822991690 > I know @vvcephei was quite swamped in the past months with pretty heavy release management duties. Totally agree. It's also why I did not press him. :smile: I

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r616349554 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon edited a comment on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon edited a comment on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-822975764 @ableegoldman (cc. @guozhangwang) After completing the sticky general assignor improvement (https://github.com/apache/kafka/pull/10552), I started to think... why

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r616350866 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -234,23 +245,28 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r616350866 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -234,23 +245,28 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r616349554 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615229332 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -527,12 +615,23 @@ private int

[GitHub] [kafka] showuon commented on a change in pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on a change in pull request #10509: URL: https://github.com/apache/kafka/pull/10509#discussion_r616347985 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -263,16 +279,59 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615229332 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -527,12 +615,23 @@ private int

[GitHub] [kafka] showuon edited a comment on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon edited a comment on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-822975764 @ableegoldman (cc. @guozhangwang) After completing the sticky general assignor improvement (https://github.com/apache/kafka/pull/10552), I started to think... why

[GitHub] [kafka] showuon commented on pull request #10509: KAFKA-12464: enhance constrained sticky Assign algorithm

showuon commented on pull request #10509: URL: https://github.com/apache/kafka/pull/10509#issuecomment-822975764 @ableegoldman (cc. @guozhangwang) After completing the sticky general assignor improvement (https://github.com/apache/kafka/pull/10552), I started to think why don't I

[GitHub] [kafka] wenbingshen commented on pull request #10551: MINOR: Fix nonsense test line from TopicCommandTest

wenbingshen commented on pull request #10551: URL: https://github.com/apache/kafka/pull/10551#issuecomment-822973514 Merge trunk to trigger QA again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] guozhangwang commented on a change in pull request #9640: KAFKA-10283; Consolidate client-level and consumer-level assignment within ClientState

guozhangwang commented on a change in pull request #9640: URL: https://github.com/apache/kafka/pull/9640#discussion_r616343033 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -100,40 +94,41 @@ boolean

[jira] [Created] (KAFKA-12693) Consecutive rebalances with zombie instances may cause corrupted changelogs

Guozhang Wang created KAFKA-12693: - Summary: Consecutive rebalances with zombie instances may cause corrupted changelogs Key: KAFKA-12693 URL: https://issues.apache.org/jira/browse/KAFKA-12693

[GitHub] [kafka] highluck commented on pull request #9861: MINOR: Modify unnecessary access specifiers

highluck commented on pull request #9861: URL: https://github.com/apache/kafka/pull/9861#issuecomment-822967573 @chia7712 Thank you for the comment Code was modified -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] guozhangwang commented on pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

guozhangwang commented on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-822965530 @dongjinleekr just FYI, I know @vvcephei was quite swamped in the past months with pretty heavy release management duties -- you'd see his email about 2.8.0 release, which

[GitHub] [kafka] mjsax commented on a change in pull request #10565: KAFKA-12691: Add case where task can be considered idling

mjsax commented on a change in pull request #10565: URL: https://github.com/apache/kafka/pull/10565#discussion_r616324780 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -692,6 +699,7 @@ public boolean process(final long

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325430#comment-17325430 ] Sagar Rao commented on KAFKA-9168: -- Sure thanks [~ableegoldman], i have assinged this to myself.

[jira] [Assigned] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-9168: Assignee: Sagar Rao > Integrate JNI direct buffer support to RocksDBStore >

[GitHub] [kafka] showuon commented on pull request #10547: KAFKA-12284: increase request timeout to make tests reliable

showuon commented on pull request #10547: URL: https://github.com/apache/kafka/pull/10547#issuecomment-822930347 Thanks @ning2008wisc ! @mimaison , see if you have any comments. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] chia7712 commented on pull request #10556: MINOR: Remove redundant code from BrokerApiVersionsCommand

chia7712 commented on pull request #10556: URL: https://github.com/apache/kafka/pull/10556#issuecomment-822928272 > These test failures seem to have nothing to do with this pr. Apart from merging the backbone, can we still trigger the inspection? I do not know what to do. It seems

[GitHub] [kafka] chia7712 merged pull request #10556: MINOR: Remove redundant code from BrokerApiVersionsCommand

chia7712 merged pull request #10556: URL: https://github.com/apache/kafka/pull/10556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Commented] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325423#comment-17325423 ] Haoran Xuan commented on KAFKA-10800: - [~jagsancio] Thanks so much for the additional information, I

[GitHub] [kafka] chia7712 commented on a change in pull request #9861: MINOR: Modify unnecessary access specifiers

chia7712 commented on a change in pull request #9861: URL: https://github.com/apache/kafka/pull/9861#discussion_r616298454 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java ## @@ -58,7 +58,7 @@ } -

[GitHub] [kafka] vitojeng commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

vitojeng commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-822913986 @cadonna , @ableegoldman Thanks for great discussion. I'll rebase trunk and update the streams upgrade guide. -- This is an automated message from the Apache Git

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615228600 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -387,58 +398,121 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615228600 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -387,58 +398,121 @@ private boolean

[GitHub] [kafka] showuon commented on a change in pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

showuon commented on a change in pull request #10552: URL: https://github.com/apache/kafka/pull/10552#discussion_r615229166 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -387,58 +398,121 @@ private boolean

[GitHub] [kafka] showuon edited a comment on pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

showuon edited a comment on pull request #10552: URL: https://github.com/apache/kafka/pull/10552#issuecomment-822200511 The performance comparison in jenkins for uniform subscription and non-equal subscription with the setting: ``` topicCount = 500; partitionCount = 2000;

[jira] [Commented] (KAFKA-7878) Connect Task already exists in this worker when failed to create consumer

[ https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325411#comment-17325411 ] Daniel Huang commented on KAFKA-7878: - Also seeing a similar "Task already exists in this worker"

[GitHub] [kafka] showuon edited a comment on pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

showuon edited a comment on pull request #10552: URL: https://github.com/apache/kafka/pull/10552#issuecomment-822292217 Failed tests are all flaky and unrelated. Thanks. The fix to flaky `MirrorConnectorsIntegration` tests issue is in my another PR:

[GitHub] [kafka] showuon commented on pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

showuon commented on pull request #10552: URL: https://github.com/apache/kafka/pull/10552#issuecomment-822906608 @guozhangwang @ableegoldman , PR is ready for review. Thank you. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] showuon edited a comment on pull request #10552: KAFKA-12675: improve the sticky general assignor scalability and performance

showuon edited a comment on pull request #10552: URL: https://github.com/apache/kafka/pull/10552#issuecomment-822292217 Failed tests are all flaky and unrelated. Thanks. ``` Build / JDK 8 and Scala 2.12 /

[jira] [Commented] (KAFKA-12207) Do not maintain list of latest producer append information

[ https://issues.apache.org/jira/browse/KAFKA-12207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325405#comment-17325405 ] Yi Ding commented on KAFKA-12207: - We can remove the restriction on

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616269613 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -93,23 +136,118 @@ public void process(final

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616268402 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -93,23 +136,118 @@ public void process(final

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616266276 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616266276 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/LeftOrRightValue.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] satishd commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

satishd commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r616265276 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -255,19 +261,21 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason {

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616264850 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +142,47 @@ final

[GitHub] [kafka] showuon commented on pull request #10559: MINOR: diable RaftClusterTest first

showuon commented on pull request #10559: URL: https://github.com/apache/kafka/pull/10559#issuecomment-822883918 @jsancio , good question. I just checked the recent 10 trunk builds, and found that there are only 3 tests flaky. So, I updated to only disable 3 tests. Thanks. -- This is

[GitHub] [kafka] junrao commented on a change in pull request #10564: MINOR: clean up some replication code

junrao commented on a change in pull request #10564: URL: https://github.com/apache/kafka/pull/10564#discussion_r616258845 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -1119,6 +1039,77 @@ void

[jira] [Comment Edited] (KAFKA-12675) Improve sticky general assignor scalability and performance

[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324358#comment-17324358 ] Travis Bischel edited comment on KAFKA-12675 at 4/19/21, 11:58 PM: ---

[GitHub] [kafka] guozhangwang commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

guozhangwang commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r616218643 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -60,20 +83,44 @@ } private

[GitHub] [kafka] wcarlson5 commented on pull request #10565: KAFKA-12691: Add case where task can be considered idling

wcarlson5 commented on pull request #10565: URL: https://github.com/apache/kafka/pull/10565#issuecomment-822850426 @rodesai @ableegoldman @abbccdda @mjsax Turns out there is another case where we should consider a task to be idling. If you can give this a review soon that would be

[GitHub] [kafka] wcarlson5 opened a new pull request #10565: KAFKA-12691: Add case where task can be considered idling

wcarlson5 opened a new pull request #10565: URL: https://github.com/apache/kafka/pull/10565 Currently task is reporting the time it started idling as when the task is suspended where it should also take into account enforced non processing. ### Committer Checklist (excluded from

[GitHub] [kafka] junrao commented on a change in pull request #10271: KAFKA-12429: Added serdes for the default implementation of RLMM based on an internal topic as storage.

junrao commented on a change in pull request #10271: URL: https://github.com/apache/kafka/pull/10271#discussion_r616081872 ## File path: storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerdes.java ## @@ -0,0 +1,54 @@

[jira] [Updated] (KAFKA-12692) Enforce config types in ConfigurationControlManager

[ https://issues.apache.org/jira/browse/KAFKA-12692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Dielhenn updated KAFKA-12692: -- Priority: Major (was: Minor) > Enforce config types in ConfigurationControlManager >

[jira] [Commented] (KAFKA-12502) Quorum controller should return topic configs in CreateTopic response

[ https://issues.apache.org/jira/browse/KAFKA-12502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325345#comment-17325345 ] Ryan Dielhenn commented on KAFKA-12502: --- Added KAFKA-12692 as a prerequisite. > Quorum controller

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r616208904 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -196,8 +214,10 @@ private

[jira] [Created] (KAFKA-12692) Enforce config types in ConfigurationControlManager

Ryan Dielhenn created KAFKA-12692: - Summary: Enforce config types in ConfigurationControlManager Key: KAFKA-12692 URL: https://issues.apache.org/jira/browse/KAFKA-12692 Project: Kafka Issue

[GitHub] [kafka] cmccabe opened a new pull request #10564: MINOR: clean up some replication code

cmccabe opened a new pull request #10564: URL: https://github.com/apache/kafka/pull/10564 Centralize leader and ISR changes in generateLeaderAndIsrUpdates. Consolidate handleNodeDeactivated and handleNodeActivated into this function. Rename BrokersToIsrs#noLeaderIterator to

[jira] [Created] (KAFKA-12691) TaskMetadata timeSinceIdlingStarted not reporting correctly

Walker Carlson created KAFKA-12691: -- Summary: TaskMetadata timeSinceIdlingStarted not reporting correctly Key: KAFKA-12691 URL: https://issues.apache.org/jira/browse/KAFKA-12691 Project: Kafka

[GitHub] [kafka] C0urante commented on pull request #10563: KAFKA-12487: Add support for cooperative consumer protocol with sink connectors

C0urante commented on pull request #10563: URL: https://github.com/apache/kafka/pull/10563#issuecomment-822792962 @ncliang @gharris1727 do either of you have time to take a look? @ableegoldman @showuon @guozhangwang FYI, this should be the only change to Connect necessary for

[jira] [Updated] (KAFKA-12690) Remove deprecated Producer#sendOffsetsToTransaction

[ https://issues.apache.org/jira/browse/KAFKA-12690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12690: --- Description: In

[jira] [Created] (KAFKA-12690) Remove deprecated Producer#sendOffsetsToTransaction

A. Sophie Blee-Goldman created KAFKA-12690: -- Summary: Remove deprecated Producer#sendOffsetsToTransaction Key: KAFKA-12690 URL: https://issues.apache.org/jira/browse/KAFKA-12690 Project:

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r616169919 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -208,6 +228,22 @@ protected

[jira] [Created] (KAFKA-12689) Remove deprecated EOS configs

A. Sophie Blee-Goldman created KAFKA-12689: -- Summary: Remove deprecated EOS configs Key: KAFKA-12689 URL: https://issues.apache.org/jira/browse/KAFKA-12689 Project: Kafka Issue

[GitHub] [kafka] rhauch commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

rhauch commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r616119723 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -196,8 +214,10 @@ private static

[GitHub] [kafka] cmccabe commented on a change in pull request #10561: KAFKA-12686 AlterIsr and LeaderAndIsr race condition

cmccabe commented on a change in pull request #10561: URL: https://github.com/apache/kafka/pull/10561#discussion_r616115604 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1341,13 +1335,15 @@ class Partition(val topicPartition: TopicPartition,

[GitHub] [kafka] cmccabe edited a comment on pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

cmccabe edited a comment on pull request #10550: URL: https://github.com/apache/kafka/pull/10550#issuecomment-822694203 Thanks for tackling this, @rondagostino ! We have to be a bit careful about the structure here. This is a plugin architecture, which means that the ZK-based

[GitHub] [kafka] cmccabe edited a comment on pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

cmccabe edited a comment on pull request #10550: URL: https://github.com/apache/kafka/pull/10550#issuecomment-822694203 Thanks for tackling this, @rondagostino ! We have to be a bit careful about the structure here. This is a plugin architecture, which means that the ZK-based

[GitHub] [kafka] cmccabe edited a comment on pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

cmccabe edited a comment on pull request #10550: URL: https://github.com/apache/kafka/pull/10550#issuecomment-822694203 Thanks for tackling this, @rondagostino ! We have to be a bit careful about the structure here. This is a plugin architecture, which means that the ZK-based

[GitHub] [kafka] cmccabe commented on pull request #10550: MINOR: Add support for ZK Authorizer with KRaft

cmccabe commented on pull request #10550: URL: https://github.com/apache/kafka/pull/10550#issuecomment-822694203 Thanks for tackling this. Please keep in mind that this is a plugin architecture. The ZK-based authorizer shouldn't get any special treatment, nor should its setup be

[jira] [Created] (KAFKA-12688) Sources and maven artifact in runtime classpath

Cosmin Giurgiu created KAFKA-12688: -- Summary: Sources and maven artifact in runtime classpath Key: KAFKA-12688 URL: https://issues.apache.org/jira/browse/KAFKA-12688 Project: Kafka Issue

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r616074220 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoaderTest.java ## @@ -129,4 +133,32 @@

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r616073878 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -187,17 +192,24 @@ private

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325234#comment-17325234 ] Guozhang Wang commented on KAFKA-12675: --- Wow this is super! Thanks [~showuon] [~twmb], please ping

[GitHub] [kafka] C0urante opened a new pull request #10563: KAFKA-12487: Add support for cooperative consumer protocol with sink connectors

C0urante opened a new pull request #10563: URL: https://github.com/apache/kafka/pull/10563 [Jira](https://issues.apache.org/jira/browse/KAFKA-12487) Currently, the `WorkerSinkTask`'s consumer rebalance listener (and related logic) is hardcoded to assume eager rebalancing, which

[GitHub] [kafka] kpatelatwork commented on pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

kpatelatwork commented on pull request #10530: URL: https://github.com/apache/kafka/pull/10530#issuecomment-822663074 @tombentley could you please review and merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] jsancio commented on pull request #10559: MINOR: diable RaftClusterTest first

jsancio commented on pull request #10559: URL: https://github.com/apache/kafka/pull/10559#issuecomment-822658214 @showuon Do we need to disable the entire suite of tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (KAFKA-10231) Broken Kafka Connect node to node communication if invalid hostname is in place

[ https://issues.apache.org/jira/browse/KAFKA-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10231: -- Description: As a Kafka Connect operator I would expect a more definitive error when the

[jira] [Updated] (KAFKA-10231) Broken Kafka Connect node to node communication if invalid hostname is in place

[ https://issues.apache.org/jira/browse/KAFKA-10231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10231: -- Description: As a Kafka Connect operator I would expect a more definitive error when the

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325187#comment-17325187 ] A. Sophie Blee-Goldman commented on KAFKA-9168: --- [~sagarrao] Feel free to pick this up, but

[GitHub] [kafka] ableegoldman commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

ableegoldman commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-822625233 Fine with me. It does seem odd that we'd be inconsistent, but I don't think we need to solve everything with this one KIP/PR. Let's just file a ticket for this so we don't

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10468: Kafka 12373:Improve KafkaRaftClient handling of graceful shutdown

vamossagar12 commented on a change in pull request #10468: URL: https://github.com/apache/kafka/pull/10468#discussion_r616018841 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -1673,6 +1673,69 @@ public void

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

vamossagar12 commented on a change in pull request #9756: URL: https://github.com/apache/kafka/pull/9756#discussion_r616018340 ## File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java ## @@ -76,6 +76,11 @@ "wait for writes to accumulate before flushing

[GitHub] [kafka] vamossagar12 commented on pull request #10278: KAFKA-10526: leader fsync deferral on write

vamossagar12 commented on pull request #10278: URL: https://github.com/apache/kafka/pull/10278#issuecomment-822622340 hey @jsancio / @hachikuji could you plz review the PR whenever you get the chance? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vamossagar12 commented on pull request #9779: KAFKA-10767: Adding test cases for all, reverseAll and reverseRange for ThreadCache

vamossagar12 commented on pull request #9779: URL: https://github.com/apache/kafka/pull/9779#issuecomment-822621642 hey @guozhangwang , would you be able to review this whenever you get the chance? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Issue Comment Deleted] (KAFKA-12313) Consider deprecating the default.windowed.serde.inner.class configs

[ https://issues.apache.org/jira/browse/KAFKA-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao updated KAFKA-12313: -- Comment: was deleted (was: https://github.com/apache/kafka/pull/10468#pullrequestreview-628083086) >

[jira] [Commented] (KAFKA-9168) Integrate JNI direct buffer support to RocksDBStore

[ https://issues.apache.org/jira/browse/KAFKA-9168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325182#comment-17325182 ] Sagar Rao commented on KAFKA-9168: -- hey [~guozhang], the benchmarks that I had talked about were for the

[jira] [Commented] (KAFKA-12675) Improve sticky general assignor scalability and performance

[ https://issues.apache.org/jira/browse/KAFKA-12675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325181#comment-17325181 ] A. Sophie Blee-Goldman commented on KAFKA-12675: Nice! It would be great if we could get

[GitHub] [kafka] rhauch commented on a change in pull request #9541: KAFKA-10675: Add schema name to ConnectSchema.validateValue() error message

rhauch commented on a change in pull request #9541: URL: https://github.com/apache/kafka/pull/9541#discussion_r615975188 ## File path: connect/api/src/main/java/org/apache/kafka/connect/data/ConnectSchema.java ## @@ -266,7 +267,7 @@ public static void validateValue(String

[GitHub] [kafka] vvcephei opened a new pull request #10562: MINOR: Update tests to include the 2.8.0 release

vvcephei opened a new pull request #10562: URL: https://github.com/apache/kafka/pull/10562 Add the 2.8 release to our tests. Before this will work, someone with access will have to upload these artifacts: ( https://home.apache.org/~vvcephei/2.8.0-mirror/ ) to this bucket:

[GitHub] [kafka] wenbingshen closed pull request #10327: MINOR: No fetcher for partitions don't need to print remove fetcher log

wenbingshen closed pull request #10327: URL: https://github.com/apache/kafka/pull/10327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] wenbingshen commented on pull request #10556: MINOR: Remove redundant code from BrokerApiVersionsCommand

wenbingshen commented on pull request #10556: URL: https://github.com/apache/kafka/pull/10556#issuecomment-822586978 > > Dear @chia7712 According to your instructions, I have reverted all imports. In your free time, please help me to review again. Thanks. :) -- This is an automated

[GitHub] [kafka] wenbingshen commented on pull request #10556: MINOR: Remove redundant code from BrokerApiVersionsCommand

wenbingshen commented on pull request #10556: URL: https://github.com/apache/kafka/pull/10556#issuecomment-822587200 @chia7712 These test failures seem to have nothing to do with this pr. Apart from merging the backbone, can we still trigger the inspection? I do not know what to do.

[GitHub] [kafka] wenbingshen closed pull request #10556: MINOR: Remove redundant code from BrokerApiVersionsCommand

wenbingshen closed pull request #10556: URL: https://github.com/apache/kafka/pull/10556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] wenbingshen commented on pull request #10556: MINOR: Remove redundant code from BrokerApiVersionsCommand

wenbingshen commented on pull request #10556: URL: https://github.com/apache/kafka/pull/10556#issuecomment-822583575 > Dear @chia7712 According to your instructions, I have reverted all imports. In your free time, please help me to review again. Thanks. :) -- This is an

[GitHub] [kafka] highluck commented on a change in pull request #9861: MINOR: Modify unnecessary access specifiers

highluck commented on a change in pull request #9861: URL: https://github.com/apache/kafka/pull/9861#discussion_r615971825 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStore.java ## @@ -96,7 +96,7 @@ public boolean

[GitHub] [kafka] wenbingshen commented on a change in pull request #10558: KAFKA-12684: Fix noop set is incorrectly replaced with succeeded set from LeaderElectionCommand

wenbingshen commented on a change in pull request #10558: URL: https://github.com/apache/kafka/pull/10558#discussion_r615967262 ## File path: core/src/test/scala/unit/kafka/admin/LeaderElectionCommandTest.scala ## @@ -273,6 +273,48 @@ final class LeaderElectionCommandTest

[jira] [Commented] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325140#comment-17325140 ] Jose Armando Garcia Sancio commented on KAFKA-10800: Yes. Please take it. Can you

[jira] [Assigned] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-10800: -- Assignee: Haoran Xuan (was: Jose Armando Garcia Sancio) >

[jira] [Assigned] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-10800: -- Assignee: Jose Armando Garcia Sancio > Validate the snapshot

[GitHub] [kafka] kpatelatwork commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

kpatelatwork commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615310932 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -187,17 +192,24 @@ private

[GitHub] [kafka] C0urante commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

C0urante commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615928396 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -187,17 +192,24 @@ private

[GitHub] [kafka] mumrah opened a new pull request #10561: KAFKA-12686 AlterIsr and LeaderAndIsr race condition

mumrah opened a new pull request #10561: URL: https://github.com/apache/kafka/pull/10561 Copied from the JIRA: > In Partition.scala, there is a race condition between the handling of an AlterIsrResponse and a LeaderAndIsrRequest. This is a pretty rare scenario and would involve the

[GitHub] [kafka] C0urante commented on a change in pull request #10549: KAFKA-8605 log an error message when we detect multiple copies of sam…

C0urante commented on a change in pull request #10549: URL: https://github.com/apache/kafka/pull/10549#discussion_r615928396 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java ## @@ -187,17 +192,24 @@ private

  1   2   >