[GitHub] [kafka] C0urante commented on a change in pull request #11986: KAFKA-7509: Clean up incorrect warnings logged by Connect

2022-04-01 Thread GitBox
C0urante commented on a change in pull request #11986: URL: https://github.com/apache/kafka/pull/11986#discussion_r841016535 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -366,6 +369,29 @@ public WorkerConfig(ConfigDef

[jira] [Commented] (KAFKA-7509) Kafka Connect logs unnecessary warnings about unused configurations

2022-04-01 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516226#comment-17516226 ] Chris Egerton commented on KAFKA-7509: -- Alright, I dug a little deeper and it looks like this has

[GitHub] [kafka] C0urante opened a new pull request #11986: KAFKA-7509: Clean up incorrect warnings logged by Connect

2022-04-01 Thread GitBox
C0urante opened a new pull request #11986: URL: https://github.com/apache/kafka/pull/11986 [Jira](https://issues.apache.org/jira/browse/KAFKA-7509) **NOTE: This may require a KIP. Please do not merge until it has been explicitly confirmed that a KIP is not required, or a KIP for

[GitHub] [kafka] RivenSun2 commented on pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-01 Thread GitBox
RivenSun2 commented on pull request #11985: URL: https://github.com/apache/kafka/pull/11985#issuecomment-1086549836 Hi @showuon @dajac please help to review the PR . Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] RivenSun2 opened a new pull request #11985: MINOR: Supplement the description of `Valid Values` in the documentation of `compression.type`

2022-04-01 Thread GitBox
RivenSun2 opened a new pull request #11985: URL: https://github.com/apache/kafka/pull/11985 Supplement the description of `Valid Values` in the documentation of `compression.type` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (KAFKA-7509) Kafka Connect logs unnecessary warnings about unused configurations

2022-04-01 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-7509: Assignee: Chris Egerton > Kafka Connect logs unnecessary warnings about unused

[GitHub] [kafka] ijuma opened a new pull request #11984: MINOR: Upgrade build and test dependencies

2022-04-01 Thread GitBox
ijuma opened a new pull request #11984: URL: https://github.com/apache/kafka/pull/11984 * gradle: 7.3.3 -> 7.4.2 TBD https://docs.gradle.org/7.4.2/release-notes.html * dependencycheck gradle plugin: 6.5.3 -> 7.0.3 Minor fixes. * spotbugs gradle plugin: 5.0.5 -> 5.0.6

[GitHub] [kafka] C0urante commented on pull request #11974: KAFKA-13763 (1): Improve unit testing coverage and flexibility for IncrementalCooperativeAssignor

2022-04-01 Thread GitBox
C0urante commented on pull request #11974: URL: https://github.com/apache/kafka/pull/11974#issuecomment-1086232261 Filed https://github.com/apache/kafka/pull/11983 as a more aggressive follow-up that touches on the `IncrementalCooperativeAssignor` class. -- This is an automated message

[GitHub] [kafka] C0urante opened a new pull request #11983: KAFKA-13763 (2): Refactor IncrementalCooperativeAssignor for improved unit testing

2022-04-01 Thread GitBox
C0urante opened a new pull request #11983: URL: https://github.com/apache/kafka/pull/11983 [Jira](https://issues.apache.org/jira/browse/KAFKA-13763) Builds on the changes from https://github.com/apache/kafka/pull/11974, which exclusively touched on the

[jira] [Commented] (KAFKA-13787) Failed to delete state store directory for it is not empty

2022-04-01 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516068#comment-17516068 ] Matthias J. Sax commented on KAFKA-13787: - `StateDirectory` should have all relevant code. Not

[GitHub] [kafka] cmccabe merged pull request #11941: KAFKA-13749: CreateTopics in KRaft must return configs

2022-04-01 Thread GitBox
cmccabe merged pull request #11941: URL: https://github.com/apache/kafka/pull/11941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13782) Producer may fail to add the correct partition to transaction

2022-04-01 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17516001#comment-17516001 ] Tom Bentley commented on KAFKA-13782: - This is currently the last remaining blocker for 3.1.1.

[GitHub] [kafka] mumrah commented on a change in pull request #11941: KAFKA-13749: CreateTopics in KRaft must return configs

2022-04-01 Thread GitBox
mumrah commented on a change in pull request #11941: URL: https://github.com/apache/kafka/pull/11941#discussion_r840670498 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -530,21 +543,38 @@ private ApiError

[GitHub] [kafka] akatona84 opened a new pull request #11982: MINOR: Adjustments for jacoco

2022-04-01 Thread GitBox
akatona84 opened a new pull request #11982: URL: https://github.com/apache/kafka/pull/11982 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] dengziming commented on pull request #11910: KAFKA-13743: Prevent topics with conflicting metrics names from being created in KRaft mode

2022-04-01 Thread GitBox
dengziming commented on pull request #11910: URL: https://github.com/apache/kafka/pull/11910#issuecomment-1085768659 Thank you @cmccabe for the reminders, I added a TimelineMap here, I'm not sure should we use a TimelineMap> since the user may already create some topics colliding with

[GitHub] [kafka] kamalcph commented on pull request #9340: Improving Fetch Session Caching for KAFKA-10558

2022-04-01 Thread GitBox
kamalcph commented on pull request #9340: URL: https://github.com/apache/kafka/pull/9340#issuecomment-1085675534 gentle reminder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ddrid commented on a change in pull request #11979: MINOR: Clean up of TransactionManager and RecordAccumulator

2022-04-01 Thread GitBox
ddrid commented on a change in pull request #11979: URL: https://github.com/apache/kafka/pull/11979#discussion_r840399831 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -790,7 +781,6 @@ private void

[GitHub] [kafka] ddrid commented on a change in pull request #11979: MINOR: Clean up of TransactionManager and RecordAccumulator

2022-04-01 Thread GitBox
ddrid commented on a change in pull request #11979: URL: https://github.com/apache/kafka/pull/11979#discussion_r840397657 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -113,16 +113,7 @@ private

[jira] [Commented] (KAFKA-13783) Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-04-01 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515805#comment-17515805 ] Tom Bentley commented on KAFKA-13783: - [~dajac] do you want to update the KIP? > Remove reason

[GitHub] [kafka] showuon commented on a change in pull request #11979: MINOR: Clean up of TransactionManager and RecordAccumulator

2022-04-01 Thread GitBox
showuon commented on a change in pull request #11979: URL: https://github.com/apache/kafka/pull/11979#discussion_r840353943 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -378,12 +378,12 @@ public int

[GitHub] [kafka] showuon merged pull request #11978: KAFKA-13786: Optimized documentation for control.plane.listener.name parameter

2022-04-01 Thread GitBox
showuon merged pull request #11978: URL: https://github.com/apache/kafka/pull/11978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13787) Failed to delete state store directory for it is not empty

2022-04-01 Thread Nico Pommerening (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17515781#comment-17515781 ] Nico Pommerening commented on KAFKA-13787: -- Hi [~mjsax] : I'm experiencing the warnings on

[GitHub] [kafka] ddrid commented on pull request #11979: MINOR: Clean up of TransactionManager and RecordAccumulator

2022-04-01 Thread GitBox
ddrid commented on pull request #11979: URL: https://github.com/apache/kafka/pull/11979#issuecomment-1085512862 Hi, @showuon @dajac, could you please take a look at this easy one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dengziming closed pull request #9770: MINOR: Add ByteBufferAccessorTest

2022-04-01 Thread GitBox
dengziming closed pull request #9770: URL: https://github.com/apache/kafka/pull/9770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: