artemlivshits commented on code in PR #12570:
URL: https://github.com/apache/kafka/pull/12570#discussion_r964385141
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -378,6 +415,16 @@ private MemoryRecordsBuilder
ashmeet13 commented on PR #12414:
URL: https://github.com/apache/kafka/pull/12414#issuecomment-1238875586
Hi @jsancio could you please review this PR? Sorry for the multiple changes
this has requires.
--
This is an automated message from the Apache Git Service.
To respond to the
showuon commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r964347667
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -41,8 +43,19 @@ class BrokerMetadataListener(
val maxBytesBetweenSnapshots: Long,
ijuma merged PR #12588:
URL: https://github.com/apache/kafka/pull/12588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on PR #12588:
URL: https://github.com/apache/kafka/pull/12588#issuecomment-1238861151
I verified that the build was aborted as expected when there's a new commit:
https://user-images.githubusercontent.com/24747/188781201-59fc1ec1-41ea-4575-8843-52719e3dfe18.png;>
ijuma merged PR #12592:
URL: https://github.com/apache/kafka/pull/12592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
guozhangwang commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r964339811
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -685,6 +691,7 @@ private void recycleTask(final Task task,
guozhangwang commented on PR #12583:
URL: https://github.com/apache/kafka/pull/12583#issuecomment-1238855791
LGTM! Thanks @cadonna . No more major comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon commented on code in PR #12595:
URL: https://github.com/apache/kafka/pull/12595#discussion_r964335502
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -1148,19 +1225,12 @@ private void renounce() {
[
https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17601095#comment-17601095
]
Luke Chen edited comment on KAFKA-14196 at 9/7/22 1:49 AM:
---
[~pnee]
# I
[
https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17601095#comment-17601095
]
Luke Chen commented on KAFKA-14196:
---
[~pnee]
# I don't think we need to pause the fetch if the
jsancio commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r964302029
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -41,8 +43,19 @@ class BrokerMetadataListener(
val maxBytesBetweenSnapshots: Long,
jsancio opened a new pull request, #12597:
URL: https://github.com/apache/kafka/pull/12597
Document process for recovering and formatting the metadata log directory
for the KRaft controller.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
cmccabe commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r964237398
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -147,7 +160,9 @@ class BrokerMetadataListener(
private def maybeStartSnapshot():
mumrah commented on code in PR #12596:
URL: https://github.com/apache/kafka/pull/12596#discussion_r964234278
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -147,7 +160,9 @@ class BrokerMetadataListener(
private def maybeStartSnapshot():
mumrah opened a new pull request, #12596:
URL: https://github.com/apache/kafka/pull/12596
When we encounter an error while processing metadata on the broker, we have
a "best effort" strategy (log the error and continue). One problem with this is
that the broker's metadata state (in
Jose Armando Garcia Sancio created KAFKA-14205:
--
Summary: Document how to recover from kraft controller disk failure
Key: KAFKA-14205
URL: https://issues.apache.org/jira/browse/KAFKA-14205
junrao commented on code in PR #12570:
URL: https://github.com/apache/kafka/pull/12570#discussion_r964182091
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -378,6 +415,16 @@ private MemoryRecordsBuilder
[
https://issues.apache.org/jira/browse/KAFKA-14204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14204:
---
Affects Version/s: (was: 3.3.0)
> QuorumController must
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14197:
---
Affects Version/s: 3.3
> Kraft broker fails to startup after topic
[
https://issues.apache.org/jira/browse/KAFKA-14204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14204:
---
Affects Version/s: 3.3.0
> QuorumController must correctly handle
[
https://issues.apache.org/jira/browse/KAFKA-14204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14204:
---
Component/s: controller
kraft
> QuorumController
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14197:
---
Fix Version/s: (was: 3.3.0)
> Kraft broker fails to startup
[
https://issues.apache.org/jira/browse/KAFKA-14204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14204:
---
Fix Version/s: 3.3.0
> QuorumController must correctly handle
cmccabe commented on PR #12586:
URL: https://github.com/apache/kafka/pull/12586#issuecomment-1238657851
> If we're performing multiple feature operations in one invocation, and one
fails, we will just see exit code 1 with "1 out of N operation(s) failed". Can
you confirm that we'll see
cmccabe commented on code in PR #12586:
URL: https://github.com/apache/kafka/pull/12586#discussion_r964178116
##
clients/src/main/java/org/apache/kafka/common/utils/Exit.java:
##
@@ -33,14 +33,22 @@ public interface ShutdownHookAdder {
private static final Procedure
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe resolved KAFKA-14197.
--
Resolution: Duplicate
> Kraft broker fails to startup after topic creation failure
>
cmccabe opened a new pull request, #12595:
URL: https://github.com/apache/kafka/pull/12595
Originally, the QuorumController did not try to limit the number of records
in a batch that it sent to the Raft layer. This caused two problems. Firstly,
we were not correctly handling the exception
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r964174732
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -685,6 +691,7 @@ private void recycleTask(final Task task,
[
https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600985#comment-17600985
]
Guozhang Wang commented on KAFKA-14196:
---
[~pnee] Thanks for reporting this. While reviewing
vincent81jiang commented on code in PR #12516:
URL: https://github.com/apache/kafka/pull/12516#discussion_r964150701
##
core/src/main/scala/kafka/log/LogSegment.scala:
##
@@ -176,10 +179,28 @@ class LogSegment private[log] (val log: FileRecords,
throw new
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r964144146
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -685,6 +691,7 @@ private void recycleTask(final Task task,
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r964144146
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -685,6 +691,7 @@ private void recycleTask(final Task task,
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r964143315
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -610,73 +610,79 @@ private StreamTask convertStandbyToActive(final
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r964139165
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -867,37 +870,47 @@ void runOnce() {
}
private void
cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r964139165
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -867,37 +870,47 @@ void runOnce() {
}
private void
philipnee commented on PR #12593:
URL: https://github.com/apache/kafka/pull/12593#issuecomment-1238583494
@dajac - The issue is actually quite complicated, but i'm seeing consumer
consuming duplicated records because of the fetching in between the start of
async commit and partition revoke
philipnee commented on PR #12593:
URL: https://github.com/apache/kafka/pull/12593#issuecomment-1238575066
sorry.. didn't mean to publish this for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Colin McCabe created KAFKA-14204:
Summary: QuorumController must correctly handle overly large
batches
Key: KAFKA-14204
URL: https://issues.apache.org/jira/browse/KAFKA-14204
Project: Kafka
wcarlson5 opened a new pull request, #12594:
URL: https://github.com/apache/kafka/pull/12594
When building streams metadata we want to build even if the host is empty as
it is a common way to find the other host addresses
*Summary of testing strategy (including rationale)
for
Jose Armando Garcia Sancio created KAFKA-14203:
--
Summary: KRaft broker should disable snapshot generation after
error replaying the metadata log
Key: KAFKA-14203
URL:
dajac commented on PR #12593:
URL: https://github.com/apache/kafka/pull/12593#issuecomment-1238523595
Hum… Isn’t fetching expected during a rebalance in the cooperative mode?
Could you elaborate more on the issue that you are trying to solve?
--
This is an automated message from the
mumrah commented on code in PR #12586:
URL: https://github.com/apache/kafka/pull/12586#discussion_r964045673
##
clients/src/main/java/org/apache/kafka/common/utils/Exit.java:
##
@@ -33,14 +33,22 @@ public interface ShutdownHookAdder {
private static final Procedure
[
https://issues.apache.org/jira/browse/KAFKA-14200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14200:
---
Fix Version/s: 3.3.0
> kafka-features.sh must exit with non-zero
philipnee opened a new pull request, #12593:
URL: https://github.com/apache/kafka/pull/12593
```
1203
{"timestamp":1662486291187,"name":"records_consumed","count":2,"partitions":[{"topic":"test_topic","partition":0,"count":2,"minOffset":3566,"maxOffset":3567}]}
1204
[
https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600910#comment-17600910
]
Chenxi Zhao commented on KAFKA-7870:
Seeing this on kafka-clients 3.2.0. An observed pattern is that
[
https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600910#comment-17600910
]
Chenxi Zhao edited comment on KAFKA-7870 at 9/6/22 5:37 PM:
Seeing this on
[
https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600897#comment-17600897
]
Philip Nee edited comment on KAFKA-14196 at 9/6/22 5:36 PM:
Thanks Luke, per
yashmayya commented on code in PR #12478:
URL: https://github.com/apache/kafka/pull/12478#discussion_r963990153
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java:
##
@@ -268,8 +275,12 @@ void backoff(int attempt, long
yashmayya commented on code in PR #12478:
URL: https://github.com/apache/kafka/pull/12478#discussion_r963989928
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java:
##
@@ -199,112 +202,156 @@ private
[
https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600897#comment-17600897
]
Philip Nee commented on KAFKA-14196:
Thanks Luke, per your suggestion, could you elaborate more
gitlw commented on PR #11285:
URL: https://github.com/apache/kafka/pull/11285#issuecomment-1238416784
@C0urante Thank you! Yes, I'm still interested and will make an update to
this PR within this week.
--
This is an automated message from the Apache Git Service.
To respond to the
jsancio merged PR #12579:
URL: https://github.com/apache/kafka/pull/12579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
John Roesler created KAFKA-14202:
Summary: IQv2: Expose binary store schema to store implementations
Key: KAFKA-14202
URL: https://issues.apache.org/jira/browse/KAFKA-14202
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600876#comment-17600876
]
Jose Armando Garcia Sancio commented on KAFKA-14201:
[~hachikuji] [~dajac] Is this a
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600874#comment-17600874
]
Jose Armando Garcia Sancio commented on KAFKA-14197:
We should get this fixed in
[
https://issues.apache.org/jira/browse/KAFKA-14179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio resolved KAFKA-14179.
Fix Version/s: (was: 3.3.0)
Resolution: Duplicate
>
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14197:
---
Fix Version/s: 3.3.0
> Kraft broker fails to startup after topic
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Armando Garcia Sancio updated KAFKA-14197:
---
Priority: Blocker (was: Major)
> Kraft broker fails to startup
C0urante commented on PR #11285:
URL: https://github.com/apache/kafka/pull/11285#issuecomment-1238362604
@gitlw Are you still interested in pursuing this fix? I can provide a round
of review if so.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ijuma opened a new pull request, #12592:
URL: https://github.com/apache/kafka/pull/12592
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
ijuma commented on PR #12588:
URL: https://github.com/apache/kafka/pull/12588#issuecomment-1238353652
@showuon This only affects commits within a PR, so I don't think your
concern applies here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton updated KAFKA-10548:
--
Description:
This will allow for specialized deletion logic when receiving
cmccabe commented on PR #12586:
URL: https://github.com/apache/kafka/pull/12586#issuecomment-1238332467
Test failures look like unrelated flakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600844#comment-17600844
]
Colin McCabe commented on KAFKA-14197:
--
{quote}And one silly question: Why don't we do renounce for
rondagostino commented on code in PR #12587:
URL: https://github.com/apache/kafka/pull/12587#discussion_r963820227
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/expiring/ExpiringCredentialRefreshingLogin.java:
##
@@ -421,17 +419,17 @@ private
junrao commented on PR #12570:
URL: https://github.com/apache/kafka/pull/12570#issuecomment-1238270117
@artemlivshits : Thanks for the reply. Could you share some perf results
with this PR? It would be useful to test for both 0 and non-zero linger.
--
This is an automated message from
vamossagar12 commented on PR #12561:
URL: https://github.com/apache/kafka/pull/12561#issuecomment-1238247255
> The changes look good. Left some comments. Also, could you re-enable the
test in
`RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining`? This
fix should resolve
C0urante commented on code in PR #12478:
URL: https://github.com/apache/kafka/pull/12478#discussion_r963794209
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java:
##
@@ -199,112 +202,156 @@ private
vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r963789374
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -520,6 +554,9 @@ protected void
vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r963791864
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java:
##
@@ -118,6 +118,152 @@ public void
vamossagar12 commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r963789374
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##
@@ -520,6 +554,9 @@ protected void
[
https://issues.apache.org/jira/browse/KAFKA-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-14201:
---
Assignee: David Jacot
> Consumer should not send group instance ID if committing with
C0urante commented on code in PR #12478:
URL: https://github.com/apache/kafka/pull/12478#discussion_r963777991
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java:
##
@@ -268,8 +275,12 @@ void backoff(int attempt, long
[
https://issues.apache.org/jira/browse/KAFKA-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600784#comment-17600784
]
Ismael Juma commented on KAFKA-14201:
-
If it's reasonably simple, it does make sense to do it on
divijvaidya opened a new pull request, #12591:
URL: https://github.com/apache/kafka/pull/12591
**Why**
Current set of integration tests leak files in the `/tmp` directory which
makes it cumbersome if you don't restart the machine often.
**Fix**
Replace the usage of
[
https://issues.apache.org/jira/browse/KAFKA-9543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600773#comment-17600773
]
Ismael Juma commented on KAFKA-9543:
I updated the fix version for KAFKA-9838, the commit was
[
https://issues.apache.org/jira/browse/KAFKA-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-9838:
---
Fix Version/s: 2.4.2
2.5.1
> Add additional log concurrency test cases
>
C0urante merged PR #12568:
URL: https://github.com/apache/kafka/pull/12568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
[
https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600675#comment-17600675
]
Luke Chen commented on KAFKA-14196:
---
[~pnee] , thanks for the analysis. Yes, we forgot about during
[
https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600675#comment-17600675
]
Luke Chen edited comment on KAFKA-14196 at 9/6/22 8:50 AM:
---
[~pnee] , thanks
[
https://issues.apache.org/jira/browse/KAFKA-6599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600611#comment-17600611
]
Jan Filipiak commented on KAFKA-6599:
-
Just jumping in here as I'm prepping with this included now.
showuon commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r963289740
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java:
##
@@ -843,12 +1002,6 @@ public void
84 matches
Mail list logo
