[
https://issues.apache.org/jira/browse/KAFKA-1704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akshay Bhadange reassigned KAFKA-1704:
--
Assignee: Akshay Bhadange
> Add PartitionConfig besides LogConfig
>
hachikuji merged PR #12673:
URL: https://github.com/apache/kafka/pull/12673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon merged PR #12660:
URL: https://github.com/apache/kafka/pull/12660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #12660:
URL: https://github.com/apache/kafka/pull/12660#issuecomment-1254392246
Failed tests are unrelated:
```
Build / JDK 8 and Scala 2.12 /
kafka.api.TransactionsTest.testBumpTransactionalEpoch(String).quorum=kraft
Build / JDK 17 and Scala 2.13 /
[
https://issues.apache.org/jira/browse/KAFKA-14236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-14236.
-
Fix Version/s: 3.4.0
Resolution: Fixed
> ListGroups request produces too much
hachikuji merged PR #12652:
URL: https://github.com/apache/kafka/pull/12652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hachikuji commented on code in PR #12660:
URL: https://github.com/apache/kafka/pull/12660#discussion_r977073273
##
raft/src/main/java/org/apache/kafka/raft/internals/BatchMemoryPool.java:
##
@@ -54,12 +54,12 @@ public BatchMemoryPool(int maxRetainedBatches, int
batchSize) {
hachikuji commented on code in PR #12669:
URL: https://github.com/apache/kafka/pull/12669#discussion_r977071628
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2523,19 +2522,29 @@ class PlaintextAdminIntegrationTest extends
mumrah commented on code in PR #12673:
URL: https://github.com/apache/kafka/pull/12673#discussion_r977059162
##
docs/security.html:
##
@@ -1136,13 +1136,38 @@
7.4 Authorization and
ACLs
-Kafka ships with a pluggable Authorizer and an out-of-box authorizer
vvcephei commented on PR #12020:
URL: https://github.com/apache/kafka/pull/12020#issuecomment-1254308832
Note: I might want to adjust the approach here, as in a subsequent
investigation, I have realized it would be quite nice to prefix the cluster
membership lines with the generation id as
John Roesler created KAFKA-14254:
Summary: Format timestamps in assignor logs as dates instead of
integers
Key: KAFKA-14254
URL: https://issues.apache.org/jira/browse/KAFKA-14254
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-14254:
-
Labels: newbie newbie++ (was: )
> Format timestamps in assignor logs as dates instead of
[
https://issues.apache.org/jira/browse/KAFKA-14253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-14253:
-
Labels: newbie newbie++ (was: newbie++)
> StreamsPartitionAssignor should print the member
[
https://issues.apache.org/jira/browse/KAFKA-14253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-14253:
-
Labels: newbie++ (was: )
> StreamsPartitionAssignor should print the member count in
John Roesler created KAFKA-14253:
Summary: StreamsPartitionAssignor should print the member count in
assignment logs
Key: KAFKA-14253
URL: https://issues.apache.org/jira/browse/KAFKA-14253
Project:
bpetersen commented on PR #9493:
URL: https://github.com/apache/kafka/pull/9493#issuecomment-1254283030
Still would be lovely to get this merged. I'm about to write an SMT using
the logic in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message,
hachikuji commented on code in PR #12673:
URL: https://github.com/apache/kafka/pull/12673#discussion_r977019044
##
docs/security.html:
##
@@ -1136,13 +1136,29 @@
7.4 Authorization and
ACLs
-Kafka ships with a pluggable Authorizer and an out-of-box authorizer
guozhangwang commented on PR #12659:
URL: https://github.com/apache/kafka/pull/12659#issuecomment-1254220185
@cadonna ready for another quick look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mumrah commented on code in PR #12673:
URL: https://github.com/apache/kafka/pull/12673#discussion_r976972071
##
docs/security.html:
##
@@ -1136,13 +1136,29 @@
7.4 Authorization and
ACLs
-Kafka ships with a pluggable Authorizer and an out-of-box authorizer
philipnee commented on code in PR #12672:
URL: https://github.com/apache/kafka/pull/12672#discussion_r976960716
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation
philipnee commented on code in PR #12672:
URL: https://github.com/apache/kafka/pull/12672#discussion_r976960434
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/EventHandler.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation
philipnee commented on code in PR #12672:
URL: https://github.com/apache/kafka/pull/12672#discussion_r976959558
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultEventHandler.java:
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation
philipnee commented on code in PR #12672:
URL: https://github.com/apache/kafka/pull/12672#discussion_r976958108
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerBackgroundThread.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
hachikuji opened a new pull request, #12673:
URL: https://github.com/apache/kafka/pull/12673
Update security documentation to describe how to configure the KRaft
`Authorizer` implementation and include a note about principal forwarding.
Additionally, this patch renames
philipnee commented on code in PR #12663:
URL: https://github.com/apache/kafka/pull/12663#discussion_r976908482
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/EventHandler.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation
kirktrue commented on code in PR #12672:
URL: https://github.com/apache/kafka/pull/12672#discussion_r976889155
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerBackgroundThread.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
hachikuji commented on code in PR #12663:
URL: https://github.com/apache/kafka/pull/12663#discussion_r976872471
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/EventHandler.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation
philipnee opened a new pull request, #12672:
URL: https://github.com/apache/kafka/pull/12672
This is the skeleton code for the background thread. More implementation
details will be added there.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit
guozhangwang commented on code in PR #12659:
URL: https://github.com/apache/kafka/pull/12659#discussion_r976844948
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -785,6 +787,22 @@ private void addTasksToStateUpdater() {
}
Philip Nee created KAFKA-14252:
--
Summary: Create background thread skeleton
Key: KAFKA-14252
URL: https://issues.apache.org/jira/browse/KAFKA-14252
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-6393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607899#comment-17607899
]
Kirk True commented on KAFKA-6393:
--
[~hachikuji] - is there still value in a tool like this?
> Add tool
philipnee commented on PR #12663:
URL: https://github.com/apache/kafka/pull/12663#issuecomment-1254001382
Thanks @guozhangwang! Agreed, we can make incremental changes to these
implementation as we make more progress.
--
This is an automated message from the Apache Git Service.
To
guozhangwang commented on PR #12663:
URL: https://github.com/apache/kafka/pull/12663#issuecomment-1253989824
Thanks @philipnee , I think we can merge the PR as is since it's new
interfaces and if we found anything in follow-up developments we can always
come back and change them. So LGTM.
philipnee commented on PR #12663:
URL: https://github.com/apache/kafka/pull/12663#issuecomment-1253980979
Thanks @hachikuji and @guozhangwang - I just updated the PR. I'm settling
with `ApplicationEvent` and `BackgroundEvent`. Also, brief definitions for the
abstract classes have been
guozhangwang commented on PR #12641:
URL: https://github.com/apache/kafka/pull/12641#issuecomment-1253980815
LGTM. Thanks @vpapavas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hachikuji merged PR #12668:
URL: https://github.com/apache/kafka/pull/12668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hachikuji commented on PR #12668:
URL: https://github.com/apache/kafka/pull/12668#issuecomment-1253950491
I will go ahead and merge since the build does not validate docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1253949072
@divijvaidya Thank you for your thoughts. I don't quite agree that
attempting to terminate the JVM is a symptom rather than the root cause, since
there are cases where these attempts
C0urante commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1253948953
@showuon Thanks for taking a look. I did some local testing by injecting
calls to `System::exit` into existing unit tests, both on the actual test
thread and on separate threads with a
divijvaidya commented on PR #12669:
URL: https://github.com/apache/kafka/pull/12669#issuecomment-1253922789
@showuon please take a look whenever you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
divijvaidya commented on PR #12669:
URL: https://github.com/apache/kafka/pull/12669#issuecomment-1253922098
Test failures are unrelated:
```
Build / JDK 8 and Scala 2.12 / testFailureToFenceEpoch(String).quorum=kraft
– kafka.api.TransactionsTest
Build / JDK 11 and Scala 2.13 /
[
https://issues.apache.org/jira/browse/KAFKA-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607839#comment-17607839
]
Vicky Papavasileiou commented on KAFKA-14251:
-
>From private discussion with [~guozhang]
jolshan commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r976703508
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2594,27 +2596,20 @@ public void testDropCommitOnBatchExpiry()
Vicky Papavasileiou created KAFKA-14251:
---
Summary: Improve CPU usage of self-joins by sacrificing order
Key: KAFKA-14251
URL: https://issues.apache.org/jira/browse/KAFKA-14251
Project: Kafka
vvcephei commented on PR #12641:
URL: https://github.com/apache/kafka/pull/12641#issuecomment-1253859372
That red `x` is spurious. The build is ongoing:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12641/6/
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-14063:
--
Summary: CVE-2022-34917: Kafka message parsing can cause ooms with small
antagonistic payloads (was:
C0urante commented on PR #12671:
URL: https://github.com/apache/kafka/pull/12671#issuecomment-1253855738
@viktorsomogyi I'm not sure I understand the motivation for this change yet.
The only time the offset reader should only be closed while the
`MirrorSourceTask` is still running is
[
https://issues.apache.org/jira/browse/KAFKA-14209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vicky Papavasileiou reassigned KAFKA-14209:
---
Assignee: Vicky Papavasileiou
> Optimize stream stream self join to use
[
https://issues.apache.org/jira/browse/KAFKA-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607810#comment-17607810
]
Manikumar commented on KAFKA-14063:
---
CVE Reference: https://nvd.nist.gov/vuln/detail/CVE-2022-34917
>
viktorsomogyi opened a new pull request, #12671:
URL: https://github.com/apache/kafka/pull/12671
Exception during normal operation in MirrorSourceTask causes the task to
fail instead of shutting down gracefully.
In MirrorSourceTask we are loading offsets for the topic partitions. At
Viktor Somogyi-Vass created KAFKA-14250:
---
Summary: Exception during normal operation in MirrorSourceTask
causes the task to fail instead of shutting down gracefully
Key: KAFKA-14250
URL:
vvcephei commented on code in PR #12641:
URL: https://github.com/apache/kafka/pull/12641#discussion_r976572108
##
docs/streams/developer-guide/config-streams.html:
##
@@ -942,7 +942,7 @@ topology.optimizationnum.standby.replicastopology.optimization
Medium
-
ahmedsobeh opened a new pull request, #12670:
URL: https://github.com/apache/kafka/pull/12670
This PR makes the following changes:
- Moves the only test in StateRestorationIntegrationTest into
RestoreIntegrationTest
- Deletes Merge StateRestorationIntegrationTest into
dajac merged PR #12623:
URL: https://github.com/apache/kafka/pull/12623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #12643:
URL: https://github.com/apache/kafka/pull/12643#discussion_r976538294
##
core/src/main/scala/kafka/log/ProducerStateManager.scala:
##
@@ -939,3 +940,24 @@ object SnapshotFile {
SnapshotFile(file, offset)
}
}
+
+class
dajac commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r976472636
##
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java:
##
@@ -590,6 +595,14 @@ public boolean handleResponse(FetchResponse response,
short version)
vpapavas commented on code in PR #12641:
URL: https://github.com/apache/kafka/pull/12641#discussion_r976472322
##
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##
@@ -1263,6 +1263,54 @@ public void testInvalidSecurityProtocol() {
[
https://issues.apache.org/jira/browse/KAFKA-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-12319:
-
Fix Version/s: 3.4.0
> Flaky test
>
[
https://issues.apache.org/jira/browse/KAFKA-14248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14248:
-
Fix Version/s: 3.4.0
> Flaky test PlaintextAdminIntegrationTest.testCreateTopicsReturnsConfigs
[
https://issues.apache.org/jira/browse/KAFKA-14248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-14248:
Assignee: Divij Vaidya
> Flaky test
divijvaidya opened a new pull request, #12669:
URL: https://github.com/apache/kafka/pull/12669
Test is failing intermittently because we do not wait for propagation of the
altered config (LogRetentionTimeMillisProp) across all brokers before
proceeding ahead with the test.
This PR
mdedetrich commented on code in PR #12524:
URL: https://github.com/apache/kafka/pull/12524#discussion_r976398952
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java:
##
@@ -310,48 +301,30 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-9926:
Labels: flaky-test (was: )
> Flaky test PlaintextAdminIntegrationTest.testCreatePartitions
>
cadonna commented on code in PR #12524:
URL: https://github.com/apache/kafka/pull/12524#discussion_r976349585
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java:
##
@@ -211,32 +205,22 @@ public void shouldThrowIfCommittingOnIllegalState()
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yash Mayya updated KAFKA-14133:
---
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
put
cadonna commented on code in PR #12524:
URL: https://github.com/apache/kafka/pull/12524#discussion_r976346195
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StandbyTaskTest.java:
##
@@ -177,10 +181,7 @@ public void
cadonna commented on code in PR #12524:
URL: https://github.com/apache/kafka/pull/12524#discussion_r976323246
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java:
##
@@ -360,14 +333,8 @@ public void
cadonna commented on code in PR #12524:
URL: https://github.com/apache/kafka/pull/12524#discussion_r976321806
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java:
##
@@ -360,14 +333,8 @@ public void
divijvaidya commented on PR #12590:
URL: https://github.com/apache/kafka/pull/12590#issuecomment-1253486602
The failing tests pass locally and are unrelated to this change.
```
Build / JDK 8 and Scala 2.12 / testReturnRecordsDuringRebalance() –
[
https://issues.apache.org/jira/browse/KAFKA-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17607648#comment-17607648
]
Nikolay Izhikov commented on KAFKA-13866:
-
KIP-870 created -
[
https://issues.apache.org/jira/browse/KAFKA-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolay Izhikov reassigned KAFKA-13866:
---
Assignee: Nikolay Izhikov
> Support more advanced time retention policies
>
[
https://issues.apache.org/jira/browse/KAFKA-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14249:
-
Description:
Execution run:
cadonna commented on code in PR #12524:
URL: https://github.com/apache/kafka/pull/12524#discussion_r976311215
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorStateManagerTest.java:
##
@@ -310,48 +301,30 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-14248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-14248:
-
Description:
Failure run:
Divij Vaidya created KAFKA-14249:
Summary: Flaky test Tls13SelectorTest. testCloseOldestConnection
Key: KAFKA-14249
URL: https://issues.apache.org/jira/browse/KAFKA-14249
Project: Kafka
Divij Vaidya created KAFKA-14248:
Summary: Flaky test
PlaintextAdminIntegrationTest.testCreateTopicsReturnsConfigs
Key: KAFKA-14248
URL: https://issues.apache.org/jira/browse/KAFKA-14248
Project:
divijvaidya commented on PR #12666:
URL: https://github.com/apache/kafka/pull/12666#issuecomment-1253460398
This is a good idea and definitely an improvement over what already exists.
But I think that the downside of taking a dependency on something that is
deprecated as soon as JDK 18 is
urbandan commented on code in PR #12392:
URL: https://github.com/apache/kafka/pull/12392#discussion_r976275357
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -2594,27 +2596,20 @@ public void testDropCommitOnBatchExpiry()
cadonna commented on code in PR #12659:
URL: https://github.com/apache/kafka/pull/12659#discussion_r976201996
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -785,6 +787,22 @@ private void addTasksToStateUpdater() {
}
[
https://issues.apache.org/jira/browse/KAFKA-14063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-14063:
--
Fix Version/s: 3.3.0
> Kafka message parsing can cause ooms with small antagonistic payloads
>
80 matches
Mail list logo
