dajac closed pull request #14743: ignore
URL: https://github.com/apache/kafka/pull/14743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac opened a new pull request, #14862:
URL: https://github.com/apache/kafka/pull/14862
Includes https://github.com/apache/kafka/pull/14687 and
https://github.com/apache/kafka/pull/14850.
This patch adds the `reports.junitXml.mergeReruns` setting to gradle build.
From the
cmccabe merged PR #14854:
URL: https://github.com/apache/kafka/pull/14854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #14843:
URL: https://github.com/apache/kafka/pull/14843#discussion_r1408822009
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -294,4 +296,14 @@ public static List
metricsReporters(Map clientI
}
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1408805454
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryProvider.java:
##
@@ -0,0 +1,141 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
apoorvmittal10 commented on PR #14620:
URL: https://github.com/apache/kafka/pull/14620#issuecomment-1831291999
> Was actually hoping to get an official approval from @xvrl before merging,
but I think the PR is ok and feature freeze deadline is close. Merged as-is. If
there is more comments
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1399921134
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryEmitter.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
mjsax commented on code in PR #14724:
URL: https://github.com/apache/kafka/pull/14724#discussion_r1408799213
##
clients/src/main/java/org/apache/kafka/clients/ClientTelemetryReporter.java:
##
@@ -0,0 +1,914 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
mjsax commented on PR #14620:
URL: https://github.com/apache/kafka/pull/14620#issuecomment-1831279466
Was actually hoping to get an official approval from @xvrl before merging,
but I think the PR is ok and feature freeze deadline is close. Merged as-is. If
there is more comments from
mjsax merged PR #14620:
URL: https://github.com/apache/kafka/pull/14620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #14714:
URL: https://github.com/apache/kafka/pull/14714#discussion_r1408740752
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareGraphConstructor.java:
##
@@ -0,0 +1,47 @@
+package
satishd commented on PR #14649:
URL: https://github.com/apache/kafka/pull/14649#issuecomment-1831257480
@nikramakrishnan There may be an intermittent issue within the test
framework. It needs to be resolved for merging this PR as the
`ReassignToEmptyReplicaTest` is introduced as part of
hanyuzheng7 commented on PR #14745:
URL: https://github.com/apache/kafka/pull/14745#issuecomment-1831225734
@mjsax ready for code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on code in PR #14711:
URL: https://github.com/apache/kafka/pull/14711#discussion_r1408735450
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -760,13 +760,14 @@ public class StreamsConfig extends AbstractConfig {
public static
mjsax merged PR #14198:
URL: https://github.com/apache/kafka/pull/14198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on PR #12988:
URL: https://github.com/apache/kafka/pull/12988#issuecomment-1831199541
@ashmeet13 -- Any update on this PR? We are coming up to 3.7 release code
freeze deadline. Might be nice to finish this on time?
--
This is an automated message from the Apache Git
hachikuji commented on code in PR #14861:
URL: https://github.com/apache/kafka/pull/14861#discussion_r1408670312
##
core/src/main/scala/kafka/server/ControllerApis.scala:
##
@@ -802,16 +798,13 @@ class ControllerApis(
createPartitionsRequest.data(),
hachikuji opened a new pull request, #14861:
URL: https://github.com/apache/kafka/pull/14861
With `AbstractResponse.maybeSetThrottleTimeMs`, we don't need to use a
callback to build the response with the respective throttle.
### Committer Checklist (excluded from commit message)
-
showuon commented on PR #14631:
URL: https://github.com/apache/kafka/pull/14631#issuecomment-1831129790
@rondagostino @cmccabe , please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
showuon merged PR #14840:
URL: https://github.com/apache/kafka/pull/14840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apoorvmittal10 closed pull request #14699: KAFKA-15778 & KAFKA-15779: Implement
metrics manager (KIP-714)
URL: https://github.com/apache/kafka/pull/14699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
apoorvmittal10 commented on PR #14699:
URL: https://github.com/apache/kafka/pull/14699#issuecomment-1831074267
> @apoorvmittal10 : It seems that the build for JDK 17 and Scala 2.13 didn't
complete.
Thanks @junrao. Strange to see the failure in. `:clients:test`. I can see
below
nikramakrishnan commented on PR #14649:
URL: https://github.com/apache/kafka/pull/14649#issuecomment-1831064818
@satishd thanks for pointing it out. This is odd because the same tests pass
for JDK 17-kraft and JDK 11-zk -
showuon commented on PR #14428:
URL: https://github.com/apache/kafka/pull/14428#issuecomment-1831052748
> I took at look at the build and there seem to be a lot of failures. Can
you confirm that they are not related to this change?
No, they doesn't look related. Let's check the
showuon commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1408609808
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -79,6 +88,55 @@ protected LeaderState(
this.grantingVoters =
[
https://issues.apache.org/jira/browse/KAFKA-15768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17790835#comment-17790835
]
Matthias J. Sax commented on KAFKA-15768:
-
Thanks for the details [~vvcephei]!
{quote}In other
jolshan commented on PR #14844:
URL: https://github.com/apache/kafka/pull/14844#issuecomment-1831020682
Took a first pass and seems reasonable. The build had issues so I restarted
it. I will look back again tomorrow.
--
This is an automated message from the Apache Git Service.
To respond
jolshan commented on code in PR #14844:
URL: https://github.com/apache/kafka/pull/14844#discussion_r1408586225
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -590,12 +590,18 @@ private ApiMessage
cmccabe opened a new pull request, #14860:
URL: https://github.com/apache/kafka/pull/14860
Assign MetadataVersion.IBP_3_7_IV2 to JBOD.
Move KIP-966 support to MetadataVersion.IBP_3_7_IV3.
Create MetadataVersion.LATEST_PRODUCTION as the latest metadata version that
can be used
Colin McCabe created KAFKA-15922:
Summary: Add MetadataVersion for JBOD
Key: KAFKA-15922
URL: https://issues.apache.org/jira/browse/KAFKA-15922
Project: Kafka
Issue Type: Improvement
jolshan commented on PR #14826:
URL: https://github.com/apache/kafka/pull/14826#issuecomment-1830995652
We should check `testCoordinatorFailover` and `testRackAwareRangeAssignor`
since they failed for both builds. I will rerun. If they fail and this is
unrelated, we should disable them. I
jolshan commented on PR #14826:
URL: https://github.com/apache/kafka/pull/14826#issuecomment-1830993699
Sorry I was too slow to review. Looks like there is a conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
pprovenzano commented on PR #14854:
URL: https://github.com/apache/kafka/pull/14854#issuecomment-1830990251
> LGTM. However, please add a test that the `directory.id` is only added in
the situations you expect.
Done!
--
This is an automated message from the Apache Git Service.
To
satishd commented on PR #14649:
URL: https://github.com/apache/kafka/pull/14649#issuecomment-1830974318
@nikramakrishnan Please look into the below [test
failures](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14649/5/tests).
```
Build / JDK 17
philipnee commented on PR #14842:
URL: https://github.com/apache/kafka/pull/14842#issuecomment-1830970851
Here are the failures:
```
Build / JDK 21 and Scala 2.13 / testOffsetTranslationBehindReplicationFlow()
–
[
https://issues.apache.org/jira/browse/KAFKA-15920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-15920:
-
Attachment: stdout.log
> Flaky test - PlaintextConsumerTest.testCoordinatorFailover
>
[
https://issues.apache.org/jira/browse/KAFKA-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-15921:
-
Attachment: stdout.log
> Flaky test - SaslScramSslEndToEndAuthorizationTest.testAuthentications
[
https://issues.apache.org/jira/browse/KAFKA-15919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-15919:
-
Description:
[
https://issues.apache.org/jira/browse/KAFKA-15918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-15918:
-
Attachment: stdout.log
> Flaky test - OffsetsApiIntegrationTest.testResetSinkConnectorOffsets
>
[
https://issues.apache.org/jira/browse/KAFKA-15917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-15917:
-
Attachment: stdout.log
> Flaky test -
>
jeffkbkim commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1408532337
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -543,8 +543,14 @@ private void transitionTo(
cmccabe commented on PR #14854:
URL: https://github.com/apache/kafka/pull/14854#issuecomment-1830915953
Please add a test that the `directory.id` is only added in the situations
you expect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
jeffkbkim commented on code in PR #14849:
URL: https://github.com/apache/kafka/pull/14849#discussion_r1408531602
##
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##
@@ -55,17 +56,21 @@ class CoordinatorLoaderImpl[T](
* Loads the coordinator by
Haruki Okada created KAFKA-15921:
Summary: Flaky test -
SaslScramSslEndToEndAuthorizationTest.testAuthentications
Key: KAFKA-15921
URL: https://issues.apache.org/jira/browse/KAFKA-15921
Project:
Haruki Okada created KAFKA-15920:
Summary: Flaky test - PlaintextConsumerTest.testCoordinatorFailover
Key: KAFKA-15920
URL: https://issues.apache.org/jira/browse/KAFKA-15920
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-15917:
-
Summary: Flaky test -
OffsetsApiIntegrationTest.testAlterSinkConnectorOffsetsZombieSinkTasks
Haruki Okada created KAFKA-15919:
Summary: Flaky test -
BrokerLifecycleManagerTest.testAlwaysSendsAccumulatedOfflineDirs
Key: KAFKA-15919
URL: https://issues.apache.org/jira/browse/KAFKA-15919
[
https://issues.apache.org/jira/browse/KAFKA-15918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-15918:
-
Summary: Flaky test -
OffsetsApiIntegrationTest.testResetSinkConnectorOffsets (was: Flaky test
Haruki Okada created KAFKA-15918:
Summary: Flaky test - OffsetsApiIntegrationTest.
testResetSinkConnectorOffsets
Key: KAFKA-15918
URL: https://issues.apache.org/jira/browse/KAFKA-15918
Project: Kafka
Haruki Okada created KAFKA-15917:
Summary: Flaky test - OffsetsApiIntegrationTest.
testAlterSinkConnectorOffsetsZombieSinkTasks
Key: KAFKA-15917
URL: https://issues.apache.org/jira/browse/KAFKA-15917
CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1408490077
##
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##
@@ -466,6 +466,10 @@ private void
AndrewJSchofield opened a new pull request, #14859:
URL: https://github.com/apache/kafka/pull/14859
This PR fixes some details of the interface to KafkaConsumer.committed which
were different between the existing consumer and the new consumer.
Adds a unit test that validates the
soarez commented on code in PR #14836:
URL: https://github.com/apache/kafka/pull/14836#discussion_r1408475724
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest {
while (!future.isDone ||
cmccabe merged PR #14160:
URL: https://github.com/apache/kafka/pull/14160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AndrewJSchofield closed pull request #14811: KAFKA-15831: KIP-1000 protocol and
admin client
URL: https://github.com/apache/kafka/pull/14811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cmccabe opened a new pull request, #14858:
URL: https://github.com/apache/kafka/pull/14858
DirectoryId.MIGRATING should be all zeros, because all zeros is the default
Uuid value in KPRC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
junrao commented on PR #14699:
URL: https://github.com/apache/kafka/pull/14699#issuecomment-1830813531
@apoorvmittal10 : It seems that the build for JDK 17 and Scala 2.13 didn't
complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
junrao commented on code in PR #14836:
URL: https://github.com/apache/kafka/pull/14836#discussion_r1408460800
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest {
while (!future.isDone ||
soarez commented on code in PR #14820:
URL: https://github.com/apache/kafka/pull/14820#discussion_r1408437951
##
metadata/src/main/java/org/apache/kafka/metadata/placement/DefaultDirProvider.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
CalvinConfluent commented on PR #14612:
URL: https://github.com/apache/kafka/pull/14612#issuecomment-1830751681
@mumrah Thanks for the review. The integration tests will be introduced in
the client side change.
--
This is an automated message from the Apache Git Service.
To respond to
soarez commented on code in PR #14820:
URL: https://github.com/apache/kafka/pull/14820#discussion_r1408411422
##
metadata/src/test/java/org/apache/kafka/metadata/util/MetadataFeatureUtil.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
soarez commented on code in PR #14836:
URL: https://github.com/apache/kafka/pull/14836#discussion_r1408408855
##
core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala:
##
@@ -201,7 +201,7 @@ class BrokerLifecycleManagerTest {
while (!future.isDone ||
cmccabe commented on code in PR #14820:
URL: https://github.com/apache/kafka/pull/14820#discussion_r1408398490
##
metadata/src/test/java/org/apache/kafka/metadata/util/MetadataFeatureUtil.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cmccabe commented on code in PR #14820:
URL: https://github.com/apache/kafka/pull/14820#discussion_r1408398490
##
metadata/src/test/java/org/apache/kafka/metadata/util/MetadataFeatureUtil.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
cmccabe commented on code in PR #14820:
URL: https://github.com/apache/kafka/pull/14820#discussion_r1408398127
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -377,7 +386,7 @@ public ApiMessageAndVersion toRecord(Uuid topicId, int
cmccabe commented on code in PR #14820:
URL: https://github.com/apache/kafka/pull/14820#discussion_r1408396365
##
metadata/src/main/java/org/apache/kafka/metadata/placement/DefaultDirProvider.java:
##
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15898:
---
Labels: flaky-test (was: )
> Flaky test: testFenceMultipleBrokers() –
>
[
https://issues.apache.org/jira/browse/KAFKA-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15524:
---
Labels: flaky flaky-test (was: flaky)
> Flaky test
>
[
https://issues.apache.org/jira/browse/KAFKA-15892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15892:
---
Labels: flaky-test (was: )
> Flaky test: testAlterSinkConnectorOffsets –
>
[
https://issues.apache.org/jira/browse/KAFKA-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15474:
---
Labels: flaky-test (was: )
>
[
https://issues.apache.org/jira/browse/KAFKA-8073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-8073:
--
Labels: flaky-test (was: )
> Transient failure in
[
https://issues.apache.org/jira/browse/KAFKA-15544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy resolved KAFKA-15544.
Resolution: Fixed
> Enable existing client integration tests for new protocol
>
lucasbru merged PR #14758:
URL: https://github.com/apache/kafka/pull/14758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on PR #14758:
URL: https://github.com/apache/kafka/pull/14758#issuecomment-1830668394
I created 3 new flaky test tickets, but all failed tests were flaky before
on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Lucas Brutschy created KAFKA-15916:
--
Summary: Flaky test -
testClientSideTimeoutAfterFailureToReceiveResponse - KafkaAdminClientTest
Key: KAFKA-15916
URL: https://issues.apache.org/jira/browse/KAFKA-15916
[
https://issues.apache.org/jira/browse/KAFKA-15916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15916:
---
Labels: flaky-test (was: )
> Flaky test -
[
https://issues.apache.org/jira/browse/KAFKA-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15914:
---
Description:
Test intermittently gives the following result:
{code}
[
https://issues.apache.org/jira/browse/KAFKA-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15914:
---
Description:
Test intermittently gives the following result:
{code}
[
https://issues.apache.org/jira/browse/KAFKA-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15915:
---
Labels: flaky-test (was: )
> Flaky test - testUnrecoverableError - ProducerIdManagerTest
>
Lucas Brutschy created KAFKA-15915:
--
Summary: Flaky test - testUnrecoverableError -
ProducerIdManagerTest
Key: KAFKA-15915
URL: https://issues.apache.org/jira/browse/KAFKA-15915
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-15914:
---
Labels: flaky-test (was: )
> Flaky test -
Lucas Brutschy created KAFKA-15914:
--
Summary: Flaky test -
testAlterSinkConnectorOffsetsOverriddenConsumerGroupId -
OffsetsApiIntegrationTest
Key: KAFKA-15914
URL:
riedelmax commented on code in PR #14544:
URL: https://github.com/apache/kafka/pull/14544#discussion_r1408365148
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -468,6 +468,52 @@ public List
listGroups(List statesFi
lianetm commented on PR #14690:
URL: https://github.com/apache/kafka/pull/14690#issuecomment-1830640924
Follow-up PR https://github.com/apache/kafka/pull/14857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1408361923
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MemberState.java:
##
@@ -17,57 +17,113 @@
package org.apache.kafka.clients.consumer.internals;
mjsax merged PR #14855:
URL: https://github.com/apache/kafka/pull/14855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1408357542
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -192,6 +221,26 @@ private NetworkClientDelegate.UnsentRequest
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1408355119
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -192,6 +221,26 @@ private NetworkClientDelegate.UnsentRequest
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1408354526
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -168,76 +329,686 @@ public void
lianetm commented on code in PR #14690:
URL: https://github.com/apache/kafka/pull/14690#discussion_r1408353902
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -168,76 +329,686 @@ public void
lianetm opened a new pull request, #14857:
URL: https://github.com/apache/kafka/pull/14857
Updates for the client state machine, including:
- handling transitions to fatal and fenced while member is leaving the group.
- minor improvements addressing comments.
- support for
[
https://issues.apache.org/jira/browse/KAFKA-15913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15913:
---
Labels: consumer-threading-refactor (was: )
> Remove excessive use of spy in CosumerTestBuilder
>
[
https://issues.apache.org/jira/browse/KAFKA-15913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15913:
---
Component/s: consumer
> Remove excessive use of spy in CosumerTestBuilder
>
[
https://issues.apache.org/jira/browse/KAFKA-15913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-15913:
---
Parent: KAFKA-14246
Issue Type: Sub-task (was: Improvement)
> Remove excessive use of spy
Philip Nee created KAFKA-15913:
--
Summary: Remove excessive use of spy in CosumerTestBuilder
Key: KAFKA-15913
URL: https://issues.apache.org/jira/browse/KAFKA-15913
Project: Kafka
Issue Type:
jsancio commented on code in PR #14428:
URL: https://github.com/apache/kafka/pull/14428#discussion_r1408235310
##
raft/src/main/java/org/apache/kafka/raft/LeaderState.java:
##
@@ -79,6 +88,55 @@ protected LeaderState(
this.grantingVoters =
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1408238807
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -234,11 +235,20 @@ public void
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1408236793
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -269,60 +275,56 @@ void cleanup() {
* completed in time.
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1408236102
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -210,17 +210,19 @@ public CompletableFuture
philipnee commented on code in PR #14842:
URL: https://github.com/apache/kafka/pull/14842#discussion_r1408235006
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -184,7 +184,7 @@ private static long findMinTime(final
1 - 100 of 165 matches
Mail list logo
