[GitHub] [kafka] avalsa commented on a change in pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on a change in pull request #8221: URL: https://github.com/apache/kafka/pull/8221#discussion_r412015236 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java ## @@ -50,7 +53,7 @@ */ public class PartitionGroup

[GitHub] [kafka] leonardge opened a new pull request #8524: Avoid starting election for topics where preferred leader is not in s…

2020-04-21 Thread GitBox
leonardge opened a new pull request #8524: URL: https://github.com/apache/kafka/pull/8524 …ync. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.*

[GitHub] [kafka] stanislavkozlovski commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

2020-04-21 Thread GitBox
stanislavkozlovski commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r412014026 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1066,6 +1066,7 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] avalsa commented on a change in pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on a change in pull request #8221: URL: https://github.com/apache/kafka/pull/8221#discussion_r412055008 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -305,6 +297,12 @@ public void resume() {

[GitHub] [kafka] avalsa commented on a change in pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on a change in pull request #8221: URL: https://github.com/apache/kafka/pull/8221#discussion_r412178952 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -179,6 +179,44 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-04-21 Thread GitBox
dajac commented on a change in pull request #8238: URL: https://github.com/apache/kafka/pull/8238#discussion_r412182105 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -1553,6 +1554,50 @@ class KafkaApisTest {

[GitHub] [kafka] avalsa commented on issue #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on issue #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-61720 > I saw that the stream time update codepath is missing, could we add it back? I was thinking about a simpler approach here: since we could not decrement the stream-time, no matter we

[GitHub] [kafka] cadonna commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-21 Thread GitBox
cadonna commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r412047332 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ValidClientsByTaskLoadQueue.java ## @@ -0,0 +1,106 @@ +/* + *

[GitHub] [kafka] avalsa commented on a change in pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on a change in pull request #8221: URL: https://github.com/apache/kafka/pull/8221#discussion_r412099165 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -115,7 +115,7 @@ public void suspend() { }

[GitHub] [kafka] avalsa commented on a change in pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on a change in pull request #8221: URL: https://github.com/apache/kafka/pull/8221#discussion_r412178952 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -179,6 +179,44 @@ public void

[GitHub] [kafka] avalsa commented on a change in pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on a change in pull request #8221: URL: https://github.com/apache/kafka/pull/8221#discussion_r412178952 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -179,6 +179,44 @@ public void

[GitHub] [kafka] dajac commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-21 Thread GitBox
dajac commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-617137684 @apovzner Yeah, you're right. It does not increase the overall coverage. I spent quite some time in the `KafkaApis` recently and I noticed that its unit test coverage is quite low.

[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-21 Thread GitBox
chia7712 commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r412279368 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-21 Thread GitBox
chia7712 commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r412284404 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,23 @@ import java.util.concurrent._ import

[GitHub] [kafka] tombentley commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

2020-04-21 Thread GitBox
tombentley commented on a change in pull request #8417: URL: https://github.com/apache/kafka/pull/8417#discussion_r412287986 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java ## @@ -57,6 +59,10 @@ public ByteBuffer serialize(ApiKeys

[GitHub] [kafka] bbejeck commented on issue #8504: KAFKA-9298: reuse mapped stream error in joins

2020-04-20 Thread GitBox
bbejeck commented on issue #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-616620722 ping @mjsax and @vvcephei, I know you guys are busy, but do you mind having a look? This is an automated message from

[GitHub] [kafka] vvcephei commented on issue #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-21 Thread GitBox
vvcephei commented on issue #8497: URL: https://github.com/apache/kafka/pull/8497#issuecomment-617265836 Test this, please. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] mjsax commented on issue #8508: MINOR: Improve usage of LogCaptureAppender

2020-04-21 Thread GitBox
mjsax commented on issue #8508: URL: https://github.com/apache/kafka/pull/8508#issuecomment-617266065 Java 8 and Java 11 passed. Java 14: failed with unknown error... This is an automated message from the Apache Git

[GitHub] [kafka] vvcephei commented on issue #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-21 Thread GitBox
vvcephei commented on issue #8497: URL: https://github.com/apache/kafka/pull/8497#issuecomment-617266153 Test this, please. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-21 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r412305902 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,23 @@ import java.util.concurrent._ import

[GitHub] [kafka] vvcephei commented on issue #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-21 Thread GitBox
vvcephei commented on issue #8497: URL: https://github.com/apache/kafka/pull/8497#issuecomment-617264248 Test this, please. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] ijuma commented on a change in pull request #8417: KAFKA-8955: Add an AbstractResponse#errorCounts(Stream) and tidy

2020-04-21 Thread GitBox
ijuma commented on a change in pull request #8417: URL: https://github.com/apache/kafka/pull/8417#discussion_r412309101 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java ## @@ -57,6 +59,10 @@ public ByteBuffer serialize(ApiKeys apiKey,

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-21 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r412313524 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,23 @@ import java.util.concurrent._ import

[GitHub] [kafka] jiameixie opened a new pull request #8559: KAFKA-9922:Update examples README

2020-04-27 Thread GitBox
jiameixie opened a new pull request #8559: URL: https://github.com/apache/kafka/pull/8559 Class kafka.examples.SimpleConsumerDemo was removed. But the java-simple-consumer-demo.sh was not removed and README was not updated. Change-Id: Iff057ce91454b493859ace6c6959e674048e9678

[GitHub] [kafka] lkokhreidze opened a new pull request #8558: KAFKA-8611 / KIP-221 documentation

2020-04-27 Thread GitBox
lkokhreidze opened a new pull request #8558: URL: https://github.com/apache/kafka/pull/8558 Added KIP-221 documentation https://user-images.githubusercontent.com/8927925/80348679-d5a37800-8876-11ea-90a6-b5e30576efbe.png;>

[GitHub] [kafka] leonardge commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-27 Thread GitBox
leonardge commented on pull request #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-619813438 The tests that are failing doesn't seem to be relevant to my change which are the following: - kafka.api.TransactionsTest.testBumpTransactionalEpoch -

[GitHub] [kafka] tombentley commented on a change in pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-04-27 Thread GitBox
tombentley commented on a change in pull request #8311: URL: https://github.com/apache/kafka/pull/8311#discussion_r415618607 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3382,6 +3388,70 @@ public void

[GitHub] [kafka] jiameixie commented on pull request #8559: KAFKA-9922:Update examples README

2020-04-27 Thread GitBox
jiameixie commented on pull request #8559: URL: https://github.com/apache/kafka/pull/8559#issuecomment-619838295 @hachikuji @guozhangwang Call for review This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] scoopex opened a new pull request #8573: Add posibility to append parameters for tool execution

2020-04-28 Thread GitBox
scoopex opened a new pull request #8573: URL: https://github.com/apache/kafka/pull/8573 Provides the possibility to append connection infos to all executed commands: ``` $ export KAFKA_OPTS="--bootstrap-server 10.1.1.1:9092,10.1.1.1:9092,10.1.1.1:9092" kafka-topics.sh --create

[GitHub] [kafka] jeqo opened a new pull request #8572: fix (docs): from p to p-1 numbered partitions

2020-04-28 Thread GitBox
jeqo opened a new pull request #8572: URL: https://github.com/apache/kafka/pull/8572 nit. Protocol docs describe partition numbers as follows: > Topic partitions themselves are just ordered "commit logs" numbered 0, 1, ..., P. I assume this is a typo, as partition numbers

[GitHub] [kafka] bbejeck commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-04-25 Thread GitBox
bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-619376755 >I'm on the fence about whether this is an "optimization" or "reasonable behavior". It sort of feels like the latter, and the only reason we needed to introduce the

[GitHub] [kafka] dengziming opened a new pull request #8552: [MINOR]: Fix some java docs

2020-04-25 Thread GitBox
dengziming opened a new pull request #8552: URL: https://github.com/apache/kafka/pull/8552 Modify the java docs of ZkReplicaStateMachine, the java docs is not in agreement with `OfflineReplica.validPreviousStates` and `OnlineReplica.validPreviousStates` ### Committer Checklist

[GitHub] [kafka] chia7712 opened a new pull request #8551: KAFKA-9918 SslEngineFactory is NOT closed when channel is closing

2020-04-25 Thread GitBox
chia7712 opened a new pull request #8551: URL: https://github.com/apache/kafka/pull/8551 https://issues.apache.org/jira/browse/KAFKA-9918 the default implementation (**DefaultSslEngineFactory**) does not have any releasable object so we didn't notice this issue. However, it would be

[GitHub] [kafka] MikeSchlosser16 commented on pull request #8427: KAFKA-9761: Use Admin Client default timeout instead of using 5sec timeout default

2020-04-25 Thread GitBox
MikeSchlosser16 commented on pull request #8427: URL: https://github.com/apache/kafka/pull/8427#issuecomment-619409886 Thanks and noted, @ijuma. I will work on getting one created shortly. This is an automated message from

[GitHub] [kafka] chia7712 commented on a change in pull request #8551: KAFKA-9918 SslEngineFactory is NOT closed when channel is closing

2020-04-25 Thread GitBox
chia7712 commented on a change in pull request #8551: URL: https://github.com/apache/kafka/pull/8551#discussion_r415040205 ## File path: clients/src/main/java/org/apache/kafka/common/security/ssl/SslFactory.java ## @@ -230,6 +231,11 @@ public SslEngineFactory

[GitHub] [kafka] leonardge commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-25 Thread GitBox
leonardge commented on pull request #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-619397708 Hi @ijuma it will be great if you can re start the tests. Thanks! This is an automated message from the Apache

[GitHub] [kafka] leonardge commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

2020-04-25 Thread GitBox
leonardge commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r415085874 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] abbccdda opened a new pull request #8553: KAFKA-9891: Add integration test to replicate standby task failover

2020-04-25 Thread GitBox
abbccdda opened a new pull request #8553: URL: https://github.com/apache/kafka/pull/8553 This integration test is trying to mimic the scenario where the active task writes an invalid record while the standby task replicates it under at_least_once. For EOS, it should not happen because the

[GitHub] [kafka] cadonna commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-27 Thread GitBox
cadonna commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r415797071 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private boolean

[GitHub] [kafka] leonardge edited a comment on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-27 Thread GitBox
leonardge edited a comment on pull request #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-620047615 QueryableStateIntegrationTest.shouldAllowConcurrentAccesses JIRA: https://issues.apache.org/jira/browse/KAFKA-9798

[GitHub] [kafka] omkreddy commented on pull request #8184: KAKFA-9612 CLI Dynamic Configuration with file input

2020-04-27 Thread GitBox
omkreddy commented on pull request #8184: URL: https://github.com/apache/kafka/pull/8184#issuecomment-620048310 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] tombentley commented on pull request #8450: KAFKA-7613: Enable -Xlint:rawtypes in clients, fixing warnings

2020-04-27 Thread GitBox
tombentley commented on pull request #8450: URL: https://github.com/apache/kafka/pull/8450#issuecomment-620014014 @ijuma done & rebased for conflict. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] tombentley commented on pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-04-27 Thread GitBox
tombentley commented on pull request #8311: URL: https://github.com/apache/kafka/pull/8311#issuecomment-619986596 Rebased for conflict. @dajac thanks for the review. I agree about the case of the unexpected partition. The only way it could happen would be a bug in either the client

[GitHub] [kafka] showuon opened a new pull request #8560: MINOR: update raft borken link

2020-04-27 Thread GitBox
showuon opened a new pull request #8560: URL: https://github.com/apache/kafka/pull/8560 Update the raft introduction link. The old link is not accessible now. Update to the official usenix conference link where the raft paper published. It also contains the paper introduction, paper pdf,

[GitHub] [kafka] leonardge commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-27 Thread GitBox
leonardge commented on pull request #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-620047615 QueryableStateIntegrationTest.shouldAllowConcurrentAccesses JIRA: https://issues.apache.org/jira/browse/KAFKA-9798

[GitHub] [kafka] WanderingStar commented on pull request #8184: KAKFA-9612 CLI Dynamic Configuration with file input

2020-04-27 Thread GitBox
WanderingStar commented on pull request #8184: URL: https://github.com/apache/kafka/pull/8184#issuecomment-620043557 Thanks for your review, @omkreddy! I've rebased and incorporated your feedback. This is an automated

[GitHub] [kafka] steverod commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-28 Thread GitBox
steverod commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-620710529 > @steverod : There seems to be compilation errors in JDK 8 test? Hi @junrao -- Yes, there are, but they aren't mine (!!). No, really. > @steverod : There seems to

[GitHub] [kafka] pan3793 opened a new pull request #8575: KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null

2020-04-28 Thread GitBox
pan3793 opened a new pull request #8575: URL: https://github.com/apache/kafka/pull/8575 https://issues.apache.org/jira/browse/KAFKA-8713 https://cwiki.apache.org/confluence/display/KAFKA/KIP-581:+Value+of+optional+null+field+which+has+default+value ### Committer Checklist

[GitHub] [kafka] guozhangwang commented on pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

2020-04-28 Thread GitBox
guozhangwang commented on pull request #8564: URL: https://github.com/apache/kafka/pull/8564#issuecomment-620783397 Also cherry-picked to 2.5. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] junrao commented on a change in pull request #8562: Test compilation fixes for Scala 2.11

2020-04-28 Thread GitBox
junrao commented on a change in pull request #8562: URL: https://github.com/apache/kafka/pull/8562#discussion_r416760588 ## File path: core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala ## @@ -243,9 +245,9 @@ class ReplicaAlterLogDirsThreadTest {

[GitHub] [kafka] junrao commented on pull request #8566: Fix minor code issue

2020-04-28 Thread GitBox
junrao commented on pull request #8566: URL: https://github.com/apache/kafka/pull/8566#issuecomment-620701631 @leonardge : The failed test seems unrelated to the PR. Could you file a separate PR to track that? This is an

[GitHub] [kafka] vvcephei opened a new pull request #8574: KAFKA-9925: decorate pseudo-topics with app id

2020-04-28 Thread GitBox
vvcephei opened a new pull request #8574: URL: https://github.com/apache/kafka/pull/8574 * ensure that pseudo-topics get correctly prefixed with the app id at run time * update test to expect the app id prefix ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] ableegoldman commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
ableegoldman commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416814163 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableEOSIntegrationTest.java ## @@ -158,8 +158,9 @@ public void

[GitHub] [kafka] guozhangwang commented on pull request #8574: KAFKA-9925: decorate pseudo-topics with app id

2020-04-28 Thread GitBox
guozhangwang commented on pull request #8574: URL: https://github.com/apache/kafka/pull/8574#issuecomment-620787049 cc @abbccdda @mjsax to take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] kkonstantine commented on pull request #8204: Ensure ConfigProviders are closed

2020-04-28 Thread GitBox
kkonstantine commented on pull request #8204: URL: https://github.com/apache/kafka/pull/8204#issuecomment-620795402 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] leonardge commented on pull request #8566: Fix minor code issue

2020-04-28 Thread GitBox
leonardge commented on pull request #8566: URL: https://github.com/apache/kafka/pull/8566#issuecomment-620716514 Sure will do. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cadonna commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-28 Thread GitBox
cadonna commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416761719 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java ## @@ -41,132 +54,107 @@

[GitHub] [kafka] hachikuji commented on pull request #8562: Test compilation fixes for Scala 2.11

2020-04-28 Thread GitBox
hachikuji commented on pull request #8562: URL: https://github.com/apache/kafka/pull/8562#issuecomment-620749823 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] hachikuji commented on pull request #8562: Test compilation fixes for Scala 2.11

2020-04-28 Thread GitBox
hachikuji commented on pull request #8562: URL: https://github.com/apache/kafka/pull/8562#issuecomment-620749686 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] hachikuji commented on pull request #8562: Test compilation fixes for Scala 2.11

2020-04-28 Thread GitBox
hachikuji commented on pull request #8562: URL: https://github.com/apache/kafka/pull/8562#issuecomment-620749977 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
ableegoldman commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416809469 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -163,8 +159,10 @@ public void

[GitHub] [kafka] kkonstantine commented on pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

2020-04-28 Thread GitBox
kkonstantine commented on pull request #8204: URL: https://github.com/apache/kafka/pull/8204#issuecomment-620803829 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] pan3793 commented on pull request #7112: KAFKA-8713: JsonConverter NULL Values are replaced by default values even in NULLABLE fields

2020-04-28 Thread GitBox
pan3793 commented on pull request #7112: URL: https://github.com/apache/kafka/pull/7112#issuecomment-620746182 I do a new implement at https://github.com/apache/kafka/pull/8575 follow the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-28 Thread GitBox
ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416810713 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java ## @@ -41,132

[GitHub] [kafka] hachikuji commented on a change in pull request #8562: Test compilation fixes for Scala 2.11

2020-04-28 Thread GitBox
hachikuji commented on a change in pull request #8562: URL: https://github.com/apache/kafka/pull/8562#discussion_r416760519 ## File path: core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala ## @@ -243,9 +245,9 @@ class ReplicaAlterLogDirsThreadTest {

[GitHub] [kafka] vvcephei commented on a change in pull request #8574: KAFKA-9925: decorate pseudo-topics with app id

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8574: URL: https://github.com/apache/kafka/pull/8574#discussion_r416764158 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/SubscriptionWrapperSerde.java ## @@ -76,6 +78,10 @@ public

[GitHub] [kafka] leonardge commented on pull request #8566: Fix minor code issue

2020-04-28 Thread GitBox
leonardge commented on pull request #8566: URL: https://github.com/apache/kafka/pull/8566#issuecomment-620735042 JIRA [here](https://issues.apache.org/jira/browse/KAFKA-9926). This is an automated message from the Apache Git

[GitHub] [kafka] junrao commented on pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

2020-04-27 Thread GitBox
junrao commented on pull request #8524: URL: https://github.com/apache/kafka/pull/8524#issuecomment-620110244 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] steverod opened a new pull request #8562: Test compilation fixes for Scala 2.11

2020-04-27 Thread GitBox
steverod opened a new pull request #8562: URL: https://github.com/apache/kafka/pull/8562 What Earlier log test changes went into trunk (for KAFKA-9807, KAFKA-9838) and were cherry-picked to 2.4, but they broke the Scala 2.11 build. This change cherry-picks the fixes needed to

[GitHub] [kafka] omkreddy commented on pull request #8184: KAKFA-9612 CLI Dynamic Configuration with file input

2020-04-27 Thread GitBox
omkreddy commented on pull request #8184: URL: https://github.com/apache/kafka/pull/8184#issuecomment-620145498 JDK 8, 11 tests passed. JDK 14 test failures are not related. Merging to trunk. This is an automated message

[GitHub] [kafka] lkokhreidze commented on pull request #8558: KAFKA-8611 / KIP-221 documentation

2020-04-27 Thread GitBox
lkokhreidze commented on pull request #8558: URL: https://github.com/apache/kafka/pull/8558#issuecomment-620101449 call for review @vvcephei @mjsax This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response

2020-04-27 Thread GitBox
ableegoldman commented on a change in pull request #8548: URL: https://github.com/apache/kafka/pull/8548#discussion_r415991034 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -1231,13 +1235,13 @@ public void

[GitHub] [kafka] jeffwidman opened a new pull request #8561: MINOR: Fix typos in test mm2 config

2020-04-27 Thread GitBox
jeffwidman opened a new pull request #8561: URL: https://github.com/apache/kafka/pull/8561 Fix typo in mirrormaker 2 configs: `stoage` --> `storage` This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] jeffwidman edited a comment on pull request #2394: KAFKA-4668: Replicate mirrormaker topics from earliest

2020-04-27 Thread GitBox
jeffwidman edited a comment on pull request #2394: URL: https://github.com/apache/kafka/pull/2394#issuecomment-612325594 That sounds reasonable, created [KIP-592](https://cwiki.apache.org/confluence/display/KAFKA/KIP-592%3A+MirrorMaker+should+replicate+topics+from+earliest) and I'll send

[GitHub] [kafka] ableegoldman commented on pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response

2020-04-27 Thread GitBox
ableegoldman commented on pull request #8548: URL: https://github.com/apache/kafka/pull/8548#issuecomment-620144298 Flaky test failures: `QueryableStateIntegrationTest.shouldAllowConcurrentAccesses`

[GitHub] [kafka] jtrenholm-jask commented on pull request #8196: KAFKA-9478: Remove zombie partition reassignments from ZooKeeper

2020-04-27 Thread GitBox
jtrenholm-jask commented on pull request #8196: URL: https://github.com/apache/kafka/pull/8196#issuecomment-620121750 I've found when we restart the kafka leader or remove /controller in zk, this will usually kick the reassignment and it will continue for a while before stopping again. Is

[GitHub] [kafka] ableegoldman commented on a change in pull request #8546: MINOR: document how to escape json parameters to ducktape tests

2020-04-27 Thread GitBox
ableegoldman commented on a change in pull request #8546: URL: https://github.com/apache/kafka/pull/8546#discussion_r415994385 ## File path: tests/README.md ## @@ -36,6 +36,10 @@ TC_PATHS="tests/kafkatest/tests/client/pluggable_test.py::PluggableConsumerTest" ```

[GitHub] [kafka] mjsax commented on pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

2020-04-27 Thread GitBox
mjsax commented on pull request #8564: URL: https://github.com/apache/kafka/pull/8564#issuecomment-620235837 Makes sense to me. +1 Curious to hear what @guozhangwang @vvcephei think? This is an automated message from

[GitHub] [kafka] mjsax commented on pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

2020-04-27 Thread GitBox
mjsax commented on pull request #8564: URL: https://github.com/apache/kafka/pull/8564#issuecomment-620235547 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-27 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-620243830 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-27 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-620243639 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] junrao commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

2020-04-27 Thread GitBox
junrao commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r416164863 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-27 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416168944 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private boolean

[GitHub] [kafka] abbccdda commented on a change in pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

2020-04-27 Thread GitBox
abbccdda commented on a change in pull request #8549: URL: https://github.com/apache/kafka/pull/8549#discussion_r416057712 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -297,46 +298,271 @@ class KafkaApisTest { val topic = "topic"

[GitHub] [kafka] ableegoldman opened a new pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

2020-04-27 Thread GitBox
ableegoldman opened a new pull request #8564: URL: https://github.com/apache/kafka/pull/8564 These two options are essentially incompatible, as caching will do nothing to reduce downstream traffic and writes when it has to allow non-unique keys (skipping records where the value is also

[GitHub] [kafka] vvcephei commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-27 Thread GitBox
vvcephei commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-620251131 The system tests passed, by the way:

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-27 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416161091 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java ## @@ -16,49 +16,50 @@ */

[GitHub] [kafka] bdbyrne commented on a change in pull request #7982: MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters.

2020-04-27 Thread GitBox
bdbyrne commented on a change in pull request #7982: URL: https://github.com/apache/kafka/pull/7982#discussion_r416110108 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/internals/BufferPoolTest.java ## @@ -416,6 +418,10 @@ public Void call() throws

[GitHub] [kafka] ijuma commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

2020-04-27 Thread GitBox
ijuma commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r416151605 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,12 +1068,23 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] guozhangwang opened a new pull request #8565: KAFKA-9798: Send one record before starting the async producer

2020-04-27 Thread GitBox
guozhangwang opened a new pull request #8565: URL: https://github.com/apache/kafka/pull/8565 Comparing all other test cases, the `shouldAllowConcurrentAccesses` starts an async producer sending records throughout the test other than just synchronously sent and acked a few records before

[GitHub] [kafka] wj1918 opened a new pull request #8563: Fix broken JMX URL

2020-04-27 Thread GitBox
wj1918 opened a new pull request #8563: URL: https://github.com/apache/kafka/pull/8563 The "Monitoring and Management Using JMX Technology" link on the operations page is broken because of a missing double quote in the html a tag.

[GitHub] [kafka] ijuma commented on pull request #7982: MINOR: Improve producer test BufferPoolTest#testCloseNotifyWaiters.

2020-04-27 Thread GitBox
ijuma commented on pull request #7982: URL: https://github.com/apache/kafka/pull/7982#issuecomment-620205559 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] guozhangwang commented on pull request #8565: KAFKA-9798: Send one record before starting the async producer

2020-04-27 Thread GitBox
guozhangwang commented on pull request #8565: URL: https://github.com/apache/kafka/pull/8565#issuecomment-620242776 @mjsax @cadonna to take a look. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-28 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620846265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-28 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620846462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vvcephei commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416921971 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -810,21 +808,9 @@ private void

[GitHub] [kafka] junrao commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-28 Thread GitBox
junrao commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-620879490 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cmccabe commented on a change in pull request #8569: KIP-551: Expose disk read and write metrics

2020-04-28 Thread GitBox
cmccabe commented on a change in pull request #8569: URL: https://github.com/apache/kafka/pull/8569#discussion_r416961523 ## File path: core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala ## @@ -0,0 +1,96 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on pull request #8567: KAFKA-9652: Fix throttle metric in RequestChannel and request log due to KIP-219

2020-04-28 Thread GitBox
ijuma commented on pull request #8567: URL: https://github.com/apache/kafka/pull/8567#issuecomment-620887867 2 jobs passed, 1 unrelated flaky test failed: > org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses

[GitHub] [kafka] guozhangwang commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
guozhangwang commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416910725 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableEOSIntegrationTest.java ## @@ -158,8 +158,9 @@ public void

<    1   2   3   4   5   6   7   8   9   10   >