vvcephei commented on a change in pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#discussion_r424718290
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java
##
@@ -75,4 +94,303 @@
static
vvcephei commented on pull request #8588:
URL: https://github.com/apache/kafka/pull/8588#issuecomment-628236334
It looks like the test failures were unrelated (because they were all
different), some known flaky:
java
lbradstreet commented on pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#issuecomment-628192600
@ijuma can this be merged?
This is an automated message from the Apache Git Service.
To respond to the
ijuma commented on pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#issuecomment-628200880
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
guozhangwang commented on pull request #8659:
URL: https://github.com/apache/kafka/pull/8659#issuecomment-629677117
Thanks @chia7712
This is an automated message from the Apache Git Service.
To respond to the message,
abbccdda commented on pull request #8221:
URL: https://github.com/apache/kafka/pull/8221#issuecomment-629694343
Double checked the failures are due to known flaky test
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
bdbyrne commented on pull request #8658:
URL: https://github.com/apache/kafka/pull/8658#issuecomment-629714866
@cmccabe this is ready for review. Thanks!
This is an automated message from the Apache Git Service.
To respond
guozhangwang commented on a change in pull request #8671:
URL: https://github.com/apache/kafka/pull/8671#discussion_r426170554
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -673,11 +673,17 @@ private boolean isInternalTopic(final String topicName) {
guozhangwang merged pull request #8659:
URL: https://github.com/apache/kafka/pull/8659
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on pull request #8671:
URL: https://github.com/apache/kafka/pull/8671#issuecomment-629672739
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
bdbyrne commented on pull request #8658:
URL: https://github.com/apache/kafka/pull/8658#issuecomment-629713796
I've applied @d8tltanc's updates to `quota_test.py` and verified their
success:
```
docker exec ducker01 bash -c "cd /opt/kafka-dev && ducktape --cluster-file
ijuma opened a new pull request #8678:
URL: https://github.com/apache/kafka/pull/8678
This fixes critical bugs in Gradle 6.4:
* Regression: Different daemons are used between IDE and CLI builds for the
same project
* Regression: Main-Class attribute always added to jar manifest
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211270
##
File path: docs/streams/developer-guide/dsl-api.html
##
@@ -3679,58 +3670,6 @@ KTable-KTable
Foreign-Key
// Write the stream to the output topic, using
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426212066
##
File path:
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/ProducedTest.scala
##
@@ -37,15 +37,15 @@ class ProducedTest
ijuma commented on pull request #8678:
URL: https://github.com/apache/kafka/pull/8678#issuecomment-629745862
Unrelated Streams failures like:
>
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]
ijuma commented on pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#issuecomment-629745896
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
ijuma commented on pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#issuecomment-629731366
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax opened a new pull request #8679:
URL: https://github.com/apache/kafka/pull/8679
- part of KIP-221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211984
##
File path:
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala
##
@@ -218,7 +218,7 @@ class KStream[K, V](val
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211787
##
File path:
streams/src/test/java/org/apache/kafka/streams/tests/EosTestClient.java
##
@@ -132,7 +132,8 @@ private KafkaStreams createKafkaStreams(final
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211719
##
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
##
@@ -1393,6 +1409,11 @@ public void
mjsax commented on pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#issuecomment-629734751
Call for review @lkokhreidze @vvcephei
Also updates the Scala API...
This is an automated message from the
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211688
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ResetIntegrationWithSslTest.java
##
@@ -42,7 +42,7 @@
private static final
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211685
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java
##
@@ -213,7 +213,8 @@ private void runSimpleCopyTest(final
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211624
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java
##
@@ -484,8 +493,14 @@ private Topology
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211526
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/RepartitionedInternal.java
##
@@ -21,33 +21,33 @@
import
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211555
##
File path:
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
##
@@ -285,7 +286,28 @@ public void shouldProcessViaThroughTopic() {
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211408
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1082,7 +1081,7 @@ public void cleanUp() {
* This will use the
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211425
##
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##
@@ -846,16 +847,13 @@
* from the auto-generated topic using
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426211457
##
File path: streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java
##
@@ -925,9 +920,8 @@ void to(final TopicNameExtractor topicExtractor,
mjsax commented on a change in pull request #8679:
URL: https://github.com/apache/kafka/pull/8679#discussion_r426214228
##
File path:
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/Repartitioned.scala
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the
kowshik opened a new pull request #8680:
URL: https://github.com/apache/kafka/pull/8680
**TL;DR:**
In this PR, I have implemented various classes and integration for the read
path of the feature versioning system
ijuma commented on pull request #8486:
URL: https://github.com/apache/kafka/pull/8486#issuecomment-629826859
Where are with this?
This is an automated message from the Apache Git Service.
To respond to the message, please
ijuma commented on pull request #8678:
URL: https://github.com/apache/kafka/pull/8678#issuecomment-629837125
Similar flaky failures as last time. Since it's clearly unrelated, I'll go
ahead and merge.
This is an automated
ijuma merged pull request #8678:
URL: https://github.com/apache/kafka/pull/8678
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
abbccdda opened a new pull request #8681:
URL: https://github.com/apache/kafka/pull/8681
Standby task could also at risk of getting into illegal state when not being
closed during `HandleLostAll`
1. The standby task was initializing as `CREATED` state, and task corrupted
exception
guozhangwang commented on pull request #8221:
URL: https://github.com/apache/kafka/pull/8221#issuecomment-629840240
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
guozhangwang commented on pull request #8681:
URL: https://github.com/apache/kafka/pull/8681#issuecomment-629840150
I left a comment on the JIRA ticket.
This is an automated message from the Apache Git Service.
To respond to
abbccdda opened a new pull request #8682:
URL: https://github.com/apache/kafka/pull/8682
As stated, we couldn't wait for handleRebalanceComplete in the case of
handleLostAll, as we already closed the active task as dirty, and could
potentially require its offset in the next thread.runOnce
pgwhalen commented on a change in pull request #6824:
URL: https://github.com/apache/kafka/pull/6824#discussion_r426309015
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java
##
@@ -213,6 +215,48 @@ public void
efgpinto commented on pull request #7539:
URL: https://github.com/apache/kafka/pull/7539#issuecomment-629873632
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
d8tltanc opened a new pull request #8683:
URL: https://github.com/apache/kafka/pull/8683
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
d8tltanc commented on pull request #8544:
URL: https://github.com/apache/kafka/pull/8544#issuecomment-629901163
Close due to https://github.com/apache/kafka/pull/8683
This is an automated message from the Apache Git Service.
showuon commented on pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#issuecomment-629912212
No problem @bbejeck . PR to update then version 25 doc in`kafka-site` repo
is ready: https://github.com/apache/kafka-site/pull/265. Thank you.
louxiu commented on pull request #7797:
URL: https://github.com/apache/kafka/pull/7797#issuecomment-629917586
> If i understand correctly, one of the difference in behaviour provided by
this PR is to avoid redundant calls to `partitionsForNode`?
Yes
showuon edited a comment on pull request #8622:
URL: https://github.com/apache/kafka/pull/8622#issuecomment-629912212
No problem @bbejeck . PR to update the version 25 doc in`kafka-site` repo
is ready: https://github.com/apache/kafka-site/pull/265. Thank you.
pgwhalen commented on pull request #6824:
URL: https://github.com/apache/kafka/pull/6824#issuecomment-629933557
@mjsax Thanks for the initial review!
I believe I have addressed all comments (some of which I had questions
about) except for comments on documentation in
abbccdda commented on pull request #8682:
URL: https://github.com/apache/kafka/pull/8682#issuecomment-629937689
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
abbccdda commented on pull request #8681:
URL: https://github.com/apache/kafka/pull/8681#issuecomment-629937609
All failed tests are due to flaky:
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta
kowshik edited a comment on pull request #8680:
URL: https://github.com/apache/kafka/pull/8680#issuecomment-629872893
Hi @junrao and @abbccdda,
This PR is ready for code review.
Please have a look and do let me know your thoughts.
cc @cmccabe and @hachikuji
Thank
kowshik commented on pull request #8680:
URL: https://github.com/apache/kafka/pull/8680#issuecomment-629872893
Hi @junrao, @abbccdda,
This PR is ready for code review.
Please have a look and do let me know your thoughts.
cc @cmccabe and @hachikuji
Thank you!
efgpinto commented on pull request #7539:
URL: https://github.com/apache/kafka/pull/7539#issuecomment-629868514
Thanks for your insights @ocadaruma and @baltiyskiy . I've reverted back to
the previous version.
retest this please
pgwhalen commented on a change in pull request #6824:
URL: https://github.com/apache/kafka/pull/6824#discussion_r426334050
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java
##
@@ -700,12 +703,29 @@ public void process(final
navina opened a new pull request #8684:
URL: https://github.com/apache/kafka/pull/8684
`SelectorMetrics` has a per-connection metrics, which means the number of
`MetricName` objects and the strings associated with it (such as group name and
description) grows with the number of
abbccdda commented on pull request #8221:
URL: https://github.com/apache/kafka/pull/8221#issuecomment-629937949
All failed due to
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta
akatona84 commented on a change in pull request #8673:
URL: https://github.com/apache/kafka/pull/8673#discussion_r426401253
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java
##
@@ -297,6 +295,15 @@ public void
akatona84 commented on a change in pull request #8673:
URL: https://github.com/apache/kafka/pull/8673#discussion_r426401253
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java
##
@@ -297,6 +295,15 @@ public void
abbccdda commented on a change in pull request #8677:
URL: https://github.com/apache/kafka/pull/8677#discussion_r426380898
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java
##
@@ -171,7 +173,7 @@ public
akatona84 commented on pull request #8673:
URL: https://github.com/apache/kafka/pull/8673#issuecomment-629983824
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
abbccdda commented on a change in pull request #8221:
URL: https://github.com/apache/kafka/pull/8221#discussion_r426377894
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java
##
@@ -170,6 +170,8 @@ public boolean isValidTransition(final
akatona84 commented on a change in pull request #8673:
URL: https://github.com/apache/kafka/pull/8673#discussion_r426402078
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java
##
@@ -314,8 +321,7 @@ private
brary commented on a change in pull request #8395:
URL: https://github.com/apache/kafka/pull/8395#discussion_r426485550
##
File path: docs/upgrade.html
##
@@ -39,7 +39,8 @@ Notable changes in 2
https://github.com/apache/kafka/tree/2.5/examples;>examples folder.
Check
chia7712 opened a new pull request #8685:
URL: https://github.com/apache/kafka/pull/8685
https://issues.apache.org/jira/browse/KAFKA-10014
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
qq619618919 commented on pull request #8656:
URL: https://github.com/apache/kafka/pull/8656#issuecomment-630040397
> I'm still not sure what is going on here. What does it mean to update the
config if !isLeader()? Only the leader actually has a config store.
The following
avalsa commented on a change in pull request #8221:
URL: https://github.com/apache/kafka/pull/8221#discussion_r426498877
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java
##
@@ -93,6 +96,28 @@ long partitionTimestamp(final
avalsa commented on a change in pull request #8221:
URL: https://github.com/apache/kafka/pull/8221#discussion_r426499189
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java
##
@@ -170,6 +170,8 @@ public boolean isValidTransition(final
chia7712 commented on pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#issuecomment-630066071
```EmbeddedKafkaCluster``` created by Stream UT uses ```MockTime``` to
create ```KafkaServer```(
avalsa commented on a change in pull request #8221:
URL: https://github.com/apache/kafka/pull/8221#discussion_r426498753
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java
##
@@ -93,6 +96,28 @@ long partitionTimestamp(final
gharris1727 commented on a change in pull request #8618:
URL: https://github.com/apache/kafka/pull/8618#discussion_r421009491
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java
##
@@ -856,6 +858,47 @@ public void run() {
hachikuji opened a new pull request #8625:
URL: https://github.com/apache/kafka/pull/8625
Currently we add "Data" to all generated classnames in order to avoid naming
collisions. Generated classes for other persistent schema definitions (such as
those used in `GroupCoordinator` and
ableegoldman commented on pull request #8616:
URL: https://github.com/apache/kafka/pull/8616#issuecomment-624859671
@vvcephei Both Java 11 builds passed, Java 8 failed with flaky
`DynamicBrokerReconfigurationTest.testAddRemoveSaslListeners`
C0urante commented on a change in pull request #8069:
URL: https://github.com/apache/kafka/pull/8069#discussion_r421091305
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java
##
@@ -536,20 +561,37 @@ private void
bdbyrne opened a new pull request #8628:
URL: https://github.com/apache/kafka/pull/8628
Fixes ConfigCommand client quotas w/ default users when using
--bootstrap-servers.
Test is expanded to handle all valid (user, client-id) enumerations.
### Committer Checklist (excluded
ijuma commented on a change in pull request #8585:
URL: https://github.com/apache/kafka/pull/8585#discussion_r421039469
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig,
else
scott-hendricks opened a new pull request #8627:
URL: https://github.com/apache/kafka/pull/8627
The current latency histograms for ProduceBenchWorker and ConsumeBenchWorker
are limited to 5000ms, causing the histograms to truncate and report 5000ms on
requests that take longer. This
kkonstantine commented on a change in pull request #8618:
URL: https://github.com/apache/kafka/pull/8618#discussion_r421005156
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java
##
@@ -856,6 +858,47 @@ public void run() {
cmccabe commented on pull request #8625:
URL: https://github.com/apache/kafka/pull/8625#issuecomment-624851509
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
d8tltanc commented on pull request #8615:
URL: https://github.com/apache/kafka/pull/8615#issuecomment-624857586
Thanks for the review. Since we are adding a unit test, move the argument
checking in checkArgs()
This is an
d8tltanc edited a comment on pull request #8615:
URL: https://github.com/apache/kafka/pull/8615#issuecomment-624857586
Thanks for the review. Since we are adding a unit test, move the argument
checking in checkArgs()
Edit: Since the existing tests are assuming that alter user entity
rhauch commented on pull request #8379:
URL: https://github.com/apache/kafka/pull/8379#issuecomment-624894538
Still waiting for final approval of
https://cwiki.apache.org/confluence/display/KAFKA/KIP-586%3A+Deprecate+commit+records+without+record+metadata
gharris1727 commented on a change in pull request #8618:
URL: https://github.com/apache/kafka/pull/8618#discussion_r420998369
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java
##
@@ -856,6 +858,47 @@ public void run() {
rhauch commented on pull request #8230:
URL: https://github.com/apache/kafka/pull/8230#issuecomment-624837748
okay to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on pull request #8602:
URL: https://github.com/apache/kafka/pull/8602#issuecomment-624845577
Sounds good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
andrewchoi5 commented on pull request #8479:
URL: https://github.com/apache/kafka/pull/8479#issuecomment-624858200
@mjsax Hi Matthias, would you happen to know if there were any other
reviewers available? I don't mind waiting, but was curious what the ETA usually
appears to be.
d8tltanc edited a comment on pull request #8610:
URL: https://github.com/apache/kafka/pull/8610#issuecomment-624421790
I think `ClientQuotaEntity` is only used in client quota alternation. But
the description doesn't use that.
Update: I've pushed my latest local changes if that helps.
ableegoldman opened a new pull request #8626:
URL: https://github.com/apache/kafka/pull/8626
In general the behavior of window stores with `retainDuplicates` is not well
documented or enforced, so we should attempt to clarify things better in the
javadocs and in the code itself. This
d8tltanc edited a comment on pull request #8610:
URL: https://github.com/apache/kafka/pull/8610#issuecomment-624421790
I think `ClientQuotaEntity` is only used in client quota alternation. But
the description doesn't use that.
Update: I've pushed the my latest local changes if that
cmccabe commented on pull request #8627:
URL: https://github.com/apache/kafka/pull/8627#issuecomment-624872970
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hachikuji commented on a change in pull request #8585:
URL: https://github.com/apache/kafka/pull/8585#discussion_r421026806
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -949,8 +949,11 @@ class ReplicaManager(val config: KafkaConfig,
else
hachikuji commented on pull request #8602:
URL: https://github.com/apache/kafka/pull/8602#issuecomment-624842318
I changed the patch to set the request timeout the same as the delivery
timeout for this test case, which was the old behavior.
C0urante commented on a change in pull request #8069:
URL: https://github.com/apache/kafka/pull/8069#discussion_r421091035
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java
##
@@ -239,9 +236,10 @@ private
rhauch commented on pull request #2604:
URL: https://github.com/apache/kafka/pull/2604#issuecomment-624891952
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kkonstantine commented on pull request #8360:
URL: https://github.com/apache/kafka/pull/8360#issuecomment-624821936
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
gharris1727 commented on a change in pull request #8069:
URL: https://github.com/apache/kafka/pull/8069#discussion_r421079889
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java
##
@@ -239,9 +236,10 @@ private
ambroff commented on pull request #4468:
URL: https://github.com/apache/kafka/pull/4468#issuecomment-624160139
Abandoning this PR since it looks like PR #6800 fixed this problem.
This is an automated message from the Apache
gharris1727 commented on pull request #8618:
URL: https://github.com/apache/kafka/pull/8618#issuecomment-624196656
@rhauch @kkonstantine This is ready for committer review. Thanks for taking
a look!
This is an automated
bdbyrne commented on pull request #8610:
URL: https://github.com/apache/kafka/pull/8610#issuecomment-624225725
So I believe the error to be here:
https://github.com/apache/kafka/pull/8610/files#diff-faf8cea6a3a0fab5e056ad5fee22ff3eR369-R375
It should be translating the default
bdbyrne edited a comment on pull request #8610:
URL: https://github.com/apache/kafka/pull/8610#issuecomment-624225725
So I believe the error to be here:
https://github.com/apache/kafka/pull/8610/files#diff-faf8cea6a3a0fab5e056ad5fee22ff3eR369-R375
(In case the link doesn't
ijuma commented on pull request #8434:
URL: https://github.com/apache/kafka/pull/8434#issuecomment-624230380
`0` to mean `infinite` is a bit confusing. Maybe we can use `-1` instead?
This is an automated message from the
C0urante commented on a change in pull request #8618:
URL: https://github.com/apache/kafka/pull/8618#discussion_r420248205
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java
##
@@ -856,6 +857,49 @@ public void run() {
1101 - 1200 of 51425 matches
Mail list logo
