[GitHub] [kafka] fantayeneh opened a new pull request #8576: format with correct syntax

fantayeneh opened a new pull request #8576: URL: https://github.com/apache/kafka/pull/8576 small change fix string formatting ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

[GitHub] [kafka] steverod commented on pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

steverod commented on pull request #8542: URL: https://github.com/apache/kafka/pull/8542#issuecomment-620893016 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] abbccdda commented on a change in pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

abbccdda commented on a change in pull request #8518: URL: https://github.com/apache/kafka/pull/8518#discussion_r416879514 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types,

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416916295 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java ## @@ -41,132 +54,107

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r416969713 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalThreadShutDownOrderTest.java ## @@ -101,8 +102,8 @@ public void before()

[GitHub] [kafka] guozhangwang commented on pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

guozhangwang commented on pull request #8568: URL: https://github.com/apache/kafka/pull/8568#issuecomment-620847306 I looked at the three failed tests: * `OptimizedKTableIntegrationTest.shouldApplyUpdatesToStandbyStore` is actually due to the issue that

[GitHub] [kafka] fantayeneh opened a new pull request #8577: use appropriate fn for readability. (maybe)

fantayeneh opened a new pull request #8577: URL: https://github.com/apache/kafka/pull/8577 using the min, max might make the code a little easier to read. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

[GitHub] [kafka] guozhangwang commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

guozhangwang commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416944392 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -269,24 +271,20 @@ public static void

[GitHub] [kafka] guozhangwang commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

guozhangwang commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416943907 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreUpgradeIntegrationTest.java ## @@ -337,8 +336,11 @@ public void

[GitHub] [kafka] kkonstantine commented on a change in pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

kkonstantine commented on a change in pull request #8204: URL: https://github.com/apache/kafka/pull/8204#discussion_r416866064 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -220,6 +220,8 @@ public void stop() {

[GitHub] [kafka] vvcephei commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

vvcephei commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416947800 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -269,24 +271,20 @@ public static void

[GitHub] [kafka] junrao commented on pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

junrao commented on pull request #8542: URL: https://github.com/apache/kafka/pull/8542#issuecomment-620880304 @steverod : Does the JDK 8 and Scala 2.12 tests pass for you locally? Not sure why the jenkins test failed. This

[GitHub] [kafka] cmccabe edited a comment on pull request #8569: KIP-551: Expose disk read and write metrics

cmccabe edited a comment on pull request #8569: URL: https://github.com/apache/kafka/pull/8569#issuecomment-620884289 > In addition to block-level read/write, would there be a benefit to expose file system read/write metrics? It's better to have that discussion on the mailing list.

[GitHub] [kafka] cmccabe commented on pull request #8569: KIP-551: Expose disk read and write metrics

cmccabe commented on pull request #8569: URL: https://github.com/apache/kafka/pull/8569#issuecomment-620884289 > In addition to block-level read/write, would there be a benefit to expose file system read/write metrics? It's better to have that discussion on the mailing list. This PR is

[GitHub] [kafka] vvcephei opened a new pull request #8578: KAFKA-9875: Make integration tests more resilient

vvcephei opened a new pull request #8578: URL: https://github.com/apache/kafka/pull/8578 The ticket is for a flaky test that failed to clean up topics _after_ the test, which isn't strictly necessary for test success. * alter the "clean up after test" method to never throw an

[GitHub] [kafka] gwenshap commented on pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

gwenshap commented on pull request #8518: URL: https://github.com/apache/kafka/pull/8518#issuecomment-620826970 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] guozhangwang commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

guozhangwang commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416942992 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -810,21 +808,9 @@ private void

[GitHub] [kafka] kkonstantine commented on a change in pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

kkonstantine commented on a change in pull request #8554: URL: https://github.com/apache/kafka/pull/8554#discussion_r417055199 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -281,9 +281,18 @@ private void readToLogEnd() {

[GitHub] [kafka] C0urante commented on pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

C0urante commented on pull request #8554: URL: https://github.com/apache/kafka/pull/8554#issuecomment-620992508 Thanks @kkonstantine! These all seem like reasonable suggestions and I've applied them all. Ready for the next round when you have time.

[GitHub] [kafka] C0urante commented on a change in pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

C0urante commented on a change in pull request #8554: URL: https://github.com/apache/kafka/pull/8554#discussion_r417070806 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -281,9 +281,18 @@ private void readToLogEnd() {

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-620847005 Whew! System tests passed:

[GitHub] [kafka] guozhangwang commented on pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

guozhangwang commented on pull request #8568: URL: https://github.com/apache/kafka/pull/8568#issuecomment-620879654 Merged to trunk. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma opened a new pull request #8582: KAFKA-9932: Don't load configs from ZK when the log has already been loaded

ijuma opened a new pull request #8582: URL: https://github.com/apache/kafka/pull/8582 If a broker contains 8k replicas, we would previously issue 8k ZK calls to retrieve topic configs when processing the first LeaderAndIsr request. That should translate to 0 after these changes.

[GitHub] [kafka] gwenshap commented on pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

gwenshap commented on pull request #8518: URL: https://github.com/apache/kafka/pull/8518#issuecomment-620932278 No failures, nice :) Great update @lbradstreet and thanks for contributing. This is an automated message from

[GitHub] [kafka] vvcephei commented on pull request #8580: KAFKA-9832: fix attempt to commit non-running tasks

vvcephei commented on pull request #8580: URL: https://github.com/apache/kafka/pull/8580#issuecomment-620962357 Hey @mjsax , do you have time for a quick review? This bug seems to have been introduced by https://github.com/apache/kafka/pull/8440/files#r407722022 , which attempts to

[GitHub] [kafka] kkonstantine commented on pull request #8442: KAFKA-9830: Implement AutoCloseable in ErrorReporter and subclasses

kkonstantine commented on pull request #8442: URL: https://github.com/apache/kafka/pull/8442#issuecomment-620964908 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kkonstantine commented on pull request #8442: KAFKA-9830: Implement AutoCloseable in ErrorReporter and subclasses

kkonstantine commented on pull request #8442: URL: https://github.com/apache/kafka/pull/8442#issuecomment-620964776 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

ijuma commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r417044882 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417044713 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -145,12 +162,12 @@ public static void

[GitHub] [kafka] guozhangwang commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

guozhangwang commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417015562 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -215,13 +216,13 @@ public void

[GitHub] [kafka] kkonstantine commented on pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

kkonstantine commented on pull request #8204: URL: https://github.com/apache/kafka/pull/8204#issuecomment-620971604 JDK8 build failed on a relevant test:

[GitHub] [kafka] showuon opened a new pull request #8581: MINOR: Fix typo and rephrase content in docs

showuon opened a new pull request #8581: URL: https://github.com/apache/kafka/pull/8581 1. fix typo: `atleast` -> `at least` 2. add missing `--` to be consistent 3. rephrase a sentence, to make it more clear: before: `LinkedIn is currently running JDK 1.8 u5 (looking to upgrade

[GitHub] [kafka] ableegoldman commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620909428 One unrelated failure: `MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete` This is

[GitHub] [kafka] ning2008wisc commented on a change in pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

ning2008wisc commented on a change in pull request #7577: URL: https://github.com/apache/kafka/pull/7577#discussion_r416995009 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -190,4 +227,103 @@ public void

[GitHub] [kafka] zhaohaidao commented on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

zhaohaidao commented on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-620915590 @abbccdda Hi, pr updated. Could you continue to review it? This is an automated message from the Apache Git

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417040202 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -215,13 +216,13 @@ public void

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417046624 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ResetPartitionTimeIntegrationTest.java ## @@ -156,7 +157,7 @@ public void

[GitHub] [kafka] vvcephei commented on pull request #8574: KAFKA-9925: decorate pseudo-topics with app id

vvcephei commented on pull request #8574: URL: https://github.com/apache/kafka/pull/8574#issuecomment-620971180 Thanks, @arkins ! Shame is a powerful motivator :) This is an automated message from the Apache Git Service. To

[GitHub] [kafka] vvcephei commented on pull request #8578: KAFKA-9875: Make integration tests more resilient

vvcephei commented on pull request #8578: URL: https://github.com/apache/kafka/pull/8578#issuecomment-620970911 Thanks for the review, @guozhangwang . I've addressed (or responded to) your comments. This is an automated

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620976620 Cherry-picked to 2.5 as 9e2785fd1ba0ed16604e01058bae6b60ff9f3d96 This is an automated message from the Apache

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417047054 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java ## @@ -106,7 +108,7 @@ public void before() {

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620973163 Cherry-pick for 2.5 in progress... This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] bseenu commented on a change in pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

bseenu commented on a change in pull request #7577: URL: https://github.com/apache/kafka/pull/7577#discussion_r417002126 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -190,4 +227,103 @@ public void

[GitHub] [kafka] efeg opened a new pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

efeg opened a new pull request #8579: URL: https://github.com/apache/kafka/pull/8579 When does UnknownTopicOrPartitionException typically occur? * Upon a topic creation, a follower broker of a new partition starts replica fetcher before the prospective leader broker of the new

[GitHub] [kafka] vvcephei opened a new pull request #8580: KAFKA-9832: fix attempt to commit non-running tasks

vvcephei opened a new pull request #8580: URL: https://github.com/apache/kafka/pull/8580 Fixes an attempt to commit potentially non-running tasks while recovering from task corruption. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] ijuma commented on pull request #8364: MINOR: Partition is under reassignment when adding and removing

ijuma commented on pull request #8364: URL: https://github.com/apache/kafka/pull/8364#issuecomment-619439283 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] guozhangwang commented on pull request #7862: KAFKA-9246:Update Heartbeat timeout when ConsumerCoordinator commit offset

guozhangwang commented on pull request #7862: URL: https://github.com/apache/kafka/pull/7862#issuecomment-619456093 cc @hachikuji . @dengziming could you rebase the current PR? This is an automated message from the

[GitHub] [kafka] C0urante opened a new pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

C0urante opened a new pull request #8554: URL: https://github.com/apache/kafka/pull/8554 [Jira ticket](https://issues.apache.org/jira/browse/KAFKA-9919) Just some simple logging additions that should make life easier when the worker can't get caught up to the end of an internal

[GitHub] [kafka] guozhangwang commented on a change in pull request #8103: KAFKA-7061: KIP-280 Enhanced log compaction

guozhangwang commented on a change in pull request #8103: URL: https://github.com/apache/kafka/pull/8103#discussion_r415156119 ## File path: clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java ## @@ -109,6 +109,19 @@ public static final String

[GitHub] [kafka] cmccabe commented on pull request #8528: System tests should use --bootstrap-server rather than --zookeeper when testing new Kafka versions

cmccabe commented on pull request #8528: URL: https://github.com/apache/kafka/pull/8528#issuecomment-619440794 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] gwenshap commented on pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

gwenshap commented on pull request #8554: URL: https://github.com/apache/kafka/pull/8554#issuecomment-619456920 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] C0urante commented on pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

C0urante commented on pull request #8554: URL: https://github.com/apache/kafka/pull/8554#issuecomment-619449604 @ncliang, @gharris1727, @aakashnshah would you mind taking a look when you have a chance? This is an automated

[GitHub] [kafka] jiameixie commented on pull request #8555: KAFKA-9920:Fix NetworkDegradeTest.test_rate test error

jiameixie commented on pull request #8555: URL: https://github.com/apache/kafka/pull/8555#issuecomment-619464996 @abbccdda @mjsax PTAL, thanks This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ijuma commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

ijuma commented on pull request #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-619439574 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] jiameixie opened a new pull request #8555: KAFKA-9920:Fix NetworkDegradeTest.test_rate test error

jiameixie opened a new pull request #8555: URL: https://github.com/apache/kafka/pull/8555 The test case of kafkatest.tests.core.network_degrade_test.NetworkDegradeTest.test_rate. rate_limit_kbit=100.device_name=eth0.task_name=rate-1000-latency-50.latency_ms=50 failed. And the

[GitHub] [kafka] mimaison commented on pull request #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

mimaison commented on pull request #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618893486 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-618768435 Also, kicked off https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3915/ This is an automated

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414227525 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

ConcurrencyPractitioner commented on pull request #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-618768078 Reported in JIRA here: https://issues.apache.org/jira/browse/INFRA-20182 This is an automated

[GitHub] [kafka] lbradstreet commented on a change in pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

lbradstreet commented on a change in pull request #8518: URL: https://github.com/apache/kafka/pull/8518#discussion_r414250681 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types,

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414193901 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/PriorTaskAssignor.java ## @@ -0,0 +1,40 @@ +/* + * Licensed

[GitHub] [kafka] leonardge commented on a change in pull request #8524: KAFKA-9866: Avoid election for topics where preferred leader is not in ISR

leonardge commented on a change in pull request #8524: URL: https://github.com/apache/kafka/pull/8524#discussion_r414467090 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1068,7 +1068,12 @@ class KafkaController(val config: KafkaConfig,

[GitHub] [kafka] d8tltanc opened a new pull request #8544: [WIP]KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

d8tltanc opened a new pull request #8544: URL: https://github.com/apache/kafka/pull/8544 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] lbradstreet commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

lbradstreet commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414190233 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r414247204 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskCreationIntegrationTest.java ## @@ -148,6 +161,82 @@ public void

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414251894 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java ## @@ -1,349 +0,0 @@ -/* - * Licensed to the Apache

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414195680 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -515,84 +520,114 @@ public void

[GitHub] [kafka] ableegoldman commented on pull request #8248: KAFKA-9501: convert between active and standby without closing stores

ableegoldman commented on pull request #8248: URL: https://github.com/apache/kafka/pull/8248#issuecomment-618726059 Finally ready for review @vvcephei @cadonna @guozhangwang This is an automated message from the Apache Git

[GitHub] [kafka] ableegoldman commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

ableegoldman commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414201107 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -161,6 +165,9 @@ public void before() throws Exception {

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-618729924 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] steverod opened a new pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

steverod opened a new pull request #8543: URL: https://github.com/apache/kafka/pull/8543 …ng. (#8469) In KAFKA-9826, a log whose first dirty offset was past the start of the active segment and past the last cleaned point resulted in an endless cycle of picking the segment to clean

[GitHub] [kafka] steverod opened a new pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

steverod opened a new pull request #8542: URL: https://github.com/apache/kafka/pull/8542 …ng. (#8469) In KAFKA-9826, a log whose first dirty offset was past the start of the active segment and past the last cleaned point resulted in an endless cycle of picking the segment to clean

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-618766447 ok to test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ConcurrencyPractitioner removed a comment on pull request #8254: KIP-557: Add Emit On Change Support

ConcurrencyPractitioner removed a comment on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-618687469 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

ConcurrencyPractitioner commented on pull request #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-618766295 @junrao Did try on another PR. Looks like it didn't work. I will fire a JIRA. This is an

[GitHub] [kafka] mjsax commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

mjsax commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414205108 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -701,18 +703,33 @@ private KafkaStreams(final InternalTopologyBuilder

[GitHub] [kafka] ijuma commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

ijuma commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414296613 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir to

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414188592 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -1146,4 +1146,13 @@ private static byte checkRange(final byte i) {

[GitHub] [kafka] thspinto commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

thspinto commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-618732263 Could you post your configuration file @bseenu? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-618732741 Hi @bseenu , it will be very helpful to elaborate the operational sequence of your testing case? e.g. which cluster your consumer initially consume from? Did you switch your

[GitHub] [kafka] vvcephei opened a new pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei opened a new pull request #8541: URL: https://github.com/apache/kafka/pull/8541 * add a config to set the TaskAssignor * set the default assignor to HighAvailabilityTaskAssignor * fix broken tests ### Committer Checklist (excluded from commit message) - [ ] Verify

[GitHub] [kafka] vvcephei commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

vvcephei commented on a change in pull request #8540: URL: https://github.com/apache/kafka/pull/8540#discussion_r414214864 ## File path: checkstyle/suppressions.xml ## @@ -181,7 +181,7 @@ files="StreamsPartitionAssignor.java"/> +

[GitHub] [kafka] dajac commented on pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached

dajac commented on pull request #8525: URL: https://github.com/apache/kafka/pull/8525#issuecomment-618992102 cc @hachikuji @abbccdda This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] lbradstreet opened a new pull request #8545: MINOR: smoke test for jmh benchmarks

lbradstreet opened a new pull request #8545: URL: https://github.com/apache/kafka/pull/8545 Adds a smoke test to run a single jmh benchmark on each CI build. Without this change it is possible for the jmh benchmarks to break if we change our build setup.

[GitHub] [kafka] lbradstreet commented on pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

lbradstreet commented on pull request #8467: URL: https://github.com/apache/kafka/pull/8467#issuecomment-619035931 I have updated the benchmark results in the OP with the new `forEach` code. It is strictly better than the old `foreach` code.

[GitHub] [kafka] mimaison commented on pull request #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

mimaison commented on pull request #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-619041569 Test failure is unrelated, merging This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ijuma commented on a change in pull request #8364: MINOR: Partition is under reassignment when adding and removing

ijuma commented on a change in pull request #8364: URL: https://github.com/apache/kafka/pull/8364#discussion_r414551549 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandTest.scala ## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] vvcephei commented on pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on pull request #8541: URL: https://github.com/apache/kafka/pull/8541#issuecomment-619051055 29 system tests failed, so I'll pin them to the StickyTaskAssignor and fix them in follow-up PRs.

[GitHub] [kafka] lbradstreet commented on a change in pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

lbradstreet commented on a change in pull request #8467: URL: https://github.com/apache/kafka/pull/8467#discussion_r414592818 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -1003,9 +1003,17 @@ class LogManager(logDirs: Seq[File], /** * Map of log dir

[GitHub] [kafka] ijuma commented on pull request #8467: MINOR: reduce allocations in log start and recovery checkpoints

ijuma commented on pull request #8467: URL: https://github.com/apache/kafka/pull/8467#issuecomment-619037866 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac commented on pull request #8525: KAFKA-9885; Evict last members of a group when the maximum allowed is reached

dajac commented on pull request #8525: URL: https://github.com/apache/kafka/pull/8525#issuecomment-619001260 Related to #8437. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda commented on pull request #8221: KAFKA-9561: update task input partitions after rebalance

abbccdda commented on pull request #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-619474699 @avalsa Thanks for the updates, this LGTM. Will let @guozhangwang take another look. This is an automated

[GitHub] [kafka] abbccdda commented on a change in pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

abbccdda commented on a change in pull request #8550: URL: https://github.com/apache/kafka/pull/8550#discussion_r415209254 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java ## @@ -312,6 +312,7 @@ public void

[GitHub] [kafka] ijuma commented on pull request #8364: MINOR: Partition is under reassignment when adding and removing

ijuma commented on pull request #8364: URL: https://github.com/apache/kafka/pull/8364#issuecomment-619470164 Unrelated failures for JDK 8: > kafka.api.CustomQuotaCallbackTest.testCustomQuotaCallback > kafka.api.CustomQuotaCallbackTest.testCustomQuotaCallback >

[GitHub] [kafka] cmccabe commented on pull request #7709: MINOR: Generated classes should have standard equals

cmccabe commented on pull request #7709: URL: https://github.com/apache/kafka/pull/7709#issuecomment-619481476 Superseded by #8539 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] dengziming commented on pull request #7886: KAFKA-9353: Add groupInstanceId to DescribeGroup for better visibility

dengziming commented on pull request #7886: URL: https://github.com/apache/kafka/pull/7886#issuecomment-619492636 cc @hachikuji , PTAL. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dengziming commented on pull request #7862: KAFKA-9246:Update Heartbeat timeout when ConsumerCoordinator commit offset

dengziming commented on pull request #7862: URL: https://github.com/apache/kafka/pull/7862#issuecomment-619470669 > cc @hachikuji . > > @dengziming could you rebase the current PR? Thanks, done. This is an

[GitHub] [kafka] cmccabe opened a new pull request #8556: MINOR: Add a duplicate() method to Message classes

cmccabe opened a new pull request #8556: URL: https://github.com/apache/kafka/pull/8556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] big-andy-coates commented on pull request #8483: KAFKA-9865: Expose output topic names from TopologyTestDriver

big-andy-coates commented on pull request #8483: URL: https://github.com/apache/kafka/pull/8483#issuecomment-619509083 Give a man a chance! ;) On Fri, 24 Apr 2020 at 18:12, Matthias J. Sax wrote: > *@mjsax* commented on this pull request. >

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r414208673 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java ## @@ -41,132 +54,107

<    1   2   3   4   5   6   7   8   9   10   >