fvaleri commented on PR #13136:
URL: https://github.com/apache/kafka/pull/13136#issuecomment-1398707514
Output example:
```sh
$ bin/kafka-run-class.sh org.apache.kafka.tools.JmxCommand --jmx-url
service:jmx:rmi:///jndi/rmi://:/jmxrmi --object-name
kamalcph commented on PR #13060:
URL: https://github.com/apache/kafka/pull/13060#issuecomment-1398673057
@ijuma @showuon
Please take a look when you get chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kamalcph commented on PR #13059:
URL: https://github.com/apache/kafka/pull/13059#issuecomment-1398670571
@ijuma @showuon
can you please merge the patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
fvaleri opened a new pull request, #13136:
URL: https://github.com/apache/kafka/pull/13136
This PR is based on https://github.com/apache/kafka/pull/13131.
This class is also used by the system tests, so I need to check if the
replacement works fine there too.
--
This is an
fvaleri commented on code in PR #13131:
URL: https://github.com/apache/kafka/pull/13131#discussion_r1082712140
##
server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
clolov commented on code in PR #13131:
URL: https://github.com/apache/kafka/pull/13131#discussion_r1082663006
##
server-common/src/main/java/org/apache/kafka/server/util/CommandLineUtils.java:
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
ijuma commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1082623877
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -126,6 +144,11 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buffer,
ijuma commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1082622801
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -126,6 +144,11 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
buffer,
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1082615267
##
clients/src/main/java/org/apache/kafka/common/record/CompressionType.java:
##
@@ -126,6 +144,11 @@ public OutputStream wrapForOutput(ByteBufferOutputStream
ijuma commented on PR #13135:
URL: https://github.com/apache/kafka/pull/13135#issuecomment-1398459548
One more thing: when it comes to the testing, can we include the case where
the batches have a single 10 byte message?
--
This is an automated message from the Apache Git Service.
To
ijuma commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1082588469
##
clients/src/main/java/org/apache/kafka/common/compress/ZstdFactory.java:
##
@@ -62,10 +68,11 @@ public void release(ByteBuffer buffer) {
}
divijvaidya commented on PR #13135:
URL: https://github.com/apache/kafka/pull/13135#issuecomment-1398428117
@ijuma please review when you get a chance since you already have context
about this code change.
--
This is an automated message from the Apache Git Service.
To respond to the
divijvaidya commented on code in PR #13135:
URL: https://github.com/apache/kafka/pull/13135#discussion_r1082366873
##
clients/src/main/java/org/apache/kafka/common/compress/ZstdFactory.java:
##
@@ -26,21 +26,25 @@
import org.apache.kafka.common.utils.ByteBufferInputStream;
clolov commented on PR #12821:
URL: https://github.com/apache/kafka/pull/12821#issuecomment-1398172190
Thank you very much for the review and merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
divijvaidya opened a new pull request, #13135:
URL: https://github.com/apache/kafka/pull/13135
This covers two JIRAs https://issues.apache.org/jira/browse/KAFKA-14632 and
https://issues.apache.org/jira/browse/KAFKA-14633
## Background
![Screenshot 2023-01-19 at 18 27
ableegoldman opened a new pull request, #13134:
URL: https://github.com/apache/kafka/pull/13134
This test is supposed to be a sanity check that rebalancing with a large
number of partitions/consumers won't start to take obscenely long or approach
the `max.poll.interval.ms` -- bumping up
hzh0425 opened a new pull request, #13133:
URL: https://github.com/apache/kafka/pull/13133
Fix some typos in storage module / remote.metadata.storage
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI
dajac merged PR #13112:
URL: https://github.com/apache/kafka/pull/13112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on code in PR #13099:
URL: https://github.com/apache/kafka/pull/13099#discussion_r1082162567
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String
oldSuffix, String
yufeiyan1220 commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1397979098
> Seems like we aren't particularly consistent at removing these metrics and
sensors, fetcher would be another example. Mind making the clean up more
comprehensive?
Never
philipnee commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1397952270
Seems like we aren't particularly consistent at removing these metrics and
sensors, fetcher would be another example. Mind making the clean up more
comprehensive?
--
This is an
ableegoldman opened a new pull request, #13132:
URL: https://github.com/apache/kafka/pull/13132
While working on the 3.4 release I noticed we've built up an embarrassingly
long list of warnings within the Streams javadocs. It's unavoidable for some
links to break as the source code
mjsax merged PR #13129:
URL: https://github.com/apache/kafka/pull/13129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yufeiyan1220 commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1397837046
> Thanks for the PR and the issue @yufeiyan1220 - I wonder if the clean up
is necessary, as the metrics will be closed upon the client closing. Willing to
hear what others say.
Ge commented on PR #13129:
URL: https://github.com/apache/kafka/pull/13129#issuecomment-1397815859
@hachikuji @jolshan I don't have Kafka committer privileges. Can you please
commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Ge commented on code in PR #13129:
URL: https://github.com/apache/kafka/pull/13129#discussion_r1081881848
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -318,7 +318,8 @@ public class ProducerConfig extends AbstractConfig {
/**
hachikuji commented on code in PR #13129:
URL: https://github.com/apache/kafka/pull/13129#discussion_r1081878202
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -318,7 +318,8 @@ public class ProducerConfig extends AbstractConfig {
Ge commented on code in PR #13129:
URL: https://github.com/apache/kafka/pull/13129#discussion_r1081848092
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -319,6 +319,7 @@ public class ProducerConfig extends AbstractConfig {
/**
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1081788435
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -557,25 +557,25 @@ private[group] class GroupCoordinatorAdapter(
}
override
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1081688123
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -557,25 +557,25 @@ private[group] class GroupCoordinatorAdapter(
}
override
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1081688123
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -557,25 +557,25 @@ private[group] class GroupCoordinatorAdapter(
}
override
jolshan commented on code in PR #13129:
URL: https://github.com/apache/kafka/pull/13129#discussion_r1081661935
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -319,6 +319,7 @@ public class ProducerConfig extends AbstractConfig {
/**
jeffkbkim commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1081656322
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one
jeffkbkim commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1081655338
##
clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json:
##
@@ -0,0 +1,70 @@
+// Licensed to the Apache Software Foundation (ASF) under one
hachikuji commented on code in PR #13129:
URL: https://github.com/apache/kafka/pull/13129#discussion_r1081629522
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -319,6 +319,7 @@ public class ProducerConfig extends AbstractConfig {
/**
hachikuji commented on code in PR #13129:
URL: https://github.com/apache/kafka/pull/13129#discussion_r1081629522
##
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##
@@ -319,6 +319,7 @@ public class ProducerConfig extends AbstractConfig {
/**
cadonna merged PR #12821:
URL: https://github.com/apache/kafka/pull/12821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #12821:
URL: https://github.com/apache/kafka/pull/12821#issuecomment-1397370205
Build failures are unrelated:
```
Build / JDK 11 and Scala 2.13 /
org.apache.kafka.clients.consumer.KafkaConsumerTest.testReturnRecordsDuringRebalance()
Build / JDK 11 and Scala
kirktrue commented on code in PR #13119:
URL: https://github.com/apache/kafka/pull/13119#discussion_r1081589480
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetriever.java:
##
@@ -240,6 +240,9 @@ static String
dajac commented on PR #13112:
URL: https://github.com/apache/kafka/pull/13112#issuecomment-1397338100
@jolshan Updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1081583343
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -215,4 +223,86 @@ CompletableFuture deleteOffsets(
kirktrue commented on code in PR #13119:
URL: https://github.com/apache/kafka/pull/13119#discussion_r1081575409
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetriever.java:
##
@@ -240,6 +240,9 @@ static String
kirktrue commented on code in PR #13119:
URL: https://github.com/apache/kafka/pull/13119#discussion_r1081575409
##
clients/src/main/java/org/apache/kafka/common/security/oauthbearer/internals/secured/HttpAccessTokenRetriever.java:
##
@@ -240,6 +240,9 @@ static String
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1081571516
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3448,7 +3445,7 @@ class KafkaApisTest {
val expectedJoinGroupResponse = new
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1081571061
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -511,4 +532,53 @@ class GroupCoordinatorAdapter(
future
}
+
+ override def
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1397311675
Take a look at `DumpLogSegments` to see how `CommandDefaultOptions` is used.
It is much better than building the option list at the start of the
`main/execute` method.
--
This is an
bbejeck commented on PR #8431:
URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397212359
cherry-picked to 3.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mumrah merged PR #13130:
URL: https://github.com/apache/kafka/pull/13130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bbejeck commented on PR #8431:
URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397198456
Hi @maseiler, can you do the same PR for the [3.3 version of the streams
developer
guide](https://github.com/apache/kafka-site/blob/asf-site/33/streams/developer-guide/dsl-api.html)?
bbejeck commented on PR #8431:
URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397167523
Thanks for the contribution @maseiler !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bbejeck commented on PR #8431:
URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397166959
Merged #8431 into trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
bbejeck merged PR #8431:
URL: https://github.com/apache/kafka/pull/8431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
maseiler commented on PR #8431:
URL: https://github.com/apache/kafka/pull/8431#issuecomment-1397133912
@mjsax, I solved the merge conflict and rebased it on the latest version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
clolov commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1081305288
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java:
##
@@ -187,151 +137,107 @@ public void
cadonna merged PR #12818:
URL: https://github.com/apache/kafka/pull/12818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #12818:
URL: https://github.com/apache/kafka/pull/12818#issuecomment-1397015212
Build failures are unrelated:
```
Build / JDK 11 and Scala 2.13 /
kafka.controller.ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir()
Build / JDK 8
fvaleri commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1081230571
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1396923697
@clolov @vamossagar12 @tinaselenge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1396922639
@mimaison @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
fvaleri opened a new pull request, #13131:
URL: https://github.com/apache/kafka/pull/13131
These classes are required by most commands, so they must be migrated first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cadonna commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1081170724
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java:
##
@@ -187,151 +137,107 @@ public void
yashmayya commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1081145849
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -712,8 +733,16 @@ KafkaBasedLog
clolov commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1081139070
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java:
##
@@ -187,151 +137,107 @@ public void
fvaleri commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1081057443
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
vamossagar12 commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1081021244
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
cadonna commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1081015656
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
vamossagar12 commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1081010418
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
vamossagar12 commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1081009344
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
clolov commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1081007952
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
cadonna commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1081000404
##
build.gradle:
##
@@ -1757,6 +1757,7 @@ project(':tools') {
archivesBaseName = "kafka-tools"
dependencies {
+implementation project(':core')
Review
cadonna commented on code in PR #12821:
URL: https://github.com/apache/kafka/pull/12821#discussion_r1080946697
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateManagerUtilTest.java:
##
@@ -187,151 +137,107 @@ public void
cadonna commented on PR #12739:
URL: https://github.com/apache/kafka/pull/12739#issuecomment-1396582822
@shekhar-rajak Do you have any updates for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vamossagar12 commented on PR #13127:
URL: https://github.com/apache/kafka/pull/13127#issuecomment-1396439952
Adding @fvaleri . There are checkstyle issues, which I would fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
philipnee commented on code in PR #13021:
URL: https://github.com/apache/kafka/pull/13021#discussion_r1080743797
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software
akhileshchg commented on code in PR #13130:
URL: https://github.com/apache/kafka/pull/13130#discussion_r1080739852
##
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##
@@ -157,7 +157,8 @@ case class MetaProperties(
object BrokerMetadataCheckpoint extends
ijuma commented on code in PR #13130:
URL: https://github.com/apache/kafka/pull/13130#discussion_r1080736930
##
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##
@@ -157,7 +157,8 @@ case class MetaProperties(
object BrokerMetadataCheckpoint extends Logging {
akhileshchg opened a new pull request, #13130:
URL: https://github.com/apache/kafka/pull/13130
3.4 introduced a change that requires cluster.id to be present in
meta.properties if the file is available. This information is not persisted by
the brokers in old versions (< 0.10). So on
Ge opened a new pull request, #13129:
URL: https://github.com/apache/kafka/pull/13129
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
hachikuji commented on code in PR #13021:
URL: https://github.com/apache/kafka/pull/13021#discussion_r1080689650
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software
philipnee commented on PR #13125:
URL: https://github.com/apache/kafka/pull/13125#issuecomment-1396238469
Thanks for the PR and the issue @yufeiyan1220 - I wonder if the clean up is
necessary, as the metrics will be closed upon the client closing. Willing to
hear what others say.
--
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080666149
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -215,4 +223,86 @@ CompletableFuture deleteOffsets(
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080665363
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -215,4 +223,86 @@ CompletableFuture deleteOffsets(
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080662718
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -215,4 +223,86 @@ CompletableFuture deleteOffsets(
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080661020
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3448,7 +3445,7 @@ class KafkaApisTest {
val expectedJoinGroupResponse = new
erichaagdev opened a new pull request, #13128:
URL: https://github.com/apache/kafka/pull/13128
It is a good practice to always define a root project name. However, this
change is specifically being made to address a build caching miss as a result
of not having the root project name
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080653448
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -511,4 +532,53 @@ class GroupCoordinatorAdapter(
future
}
+
+ override
hachikuji commented on PR #12922:
URL: https://github.com/apache/kafka/pull/12922#issuecomment-1396203599
Note I'm holding off on merging this patch because I realized when writing
the test case that Justine suggested that the code was not correctly handling
the case when the next in-line
rishiraj88 commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080573968
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1080547019
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
ijuma commented on PR #13040:
URL: https://github.com/apache/kafka/pull/13040#issuecomment-1387745094
@satishd No worries, it happens to all of us. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1074022302
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -310,9 +307,9 @@ class KafkaApis(val requestChannel: RequestChannel,
if (topicPartition.topic ==
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073982833
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073964326
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073964326
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073960778
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073960778
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073960778
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
dajac commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073958844
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -511,4 +532,53 @@ class GroupCoordinatorAdapter(
future
}
+
+ override def
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073948248
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
jolshan commented on code in PR #13112:
URL: https://github.com/apache/kafka/pull/13112#discussion_r1073945942
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -810,19 +810,22 @@ class GroupMetadataManager(brokerId: Int,
*/
private def
1 - 100 of 51425 matches
Mail list logo
