[GitHub] [kafka] apovzner commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-22 Thread GitBox
apovzner commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-618044488 @dajac and @hachikuji thanks for your comments, I addressed them. This is an automated message from the Apache Git

[GitHub] [kafka] apovzner commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-21 Thread GitBox
apovzner commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-617525619 @dajac Sounds good! I added unit tests to KafkaApisTest as you suggested. This is an automated message from the Apache

[GitHub] [kafka] apovzner commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-20 Thread GitBox
apovzner commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-616658368 @dajac I did initially add a unit test to `KafkaApisTest` for UpdateMetadataRequest. However, since `KafkaApisTest` mocks pretty much every other component (like replica manager, etc),