[GitHub] [kafka] apovzner commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-22 Thread GitBox 


apovzner commented on issue #8509:
URL: https://github.com/apache/kafka/pull/8509#issuecomment-618044488


   @dajac and @hachikuji thanks for your comments, I addressed them.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] apovzner commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-21 Thread GitBox 


apovzner commented on issue #8509:
URL: https://github.com/apache/kafka/pull/8509#issuecomment-617525619


   @dajac Sounds good! I added unit tests to KafkaApisTest as you suggested.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [kafka] apovzner commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-20 Thread GitBox 


apovzner commented on issue #8509:
URL: https://github.com/apache/kafka/pull/8509#issuecomment-616658368


   @dajac I did initially add a unit test to `KafkaApisTest` for 
UpdateMetadataRequest. However, since `KafkaApisTest` mocks pretty much every 
other component (like replica manager, etc), the only thing it would test is 
the fact that passing newer broker epoch would know throw 
`IllegalStateException`. Basically, it does not add any more coverage in 
addition to `BrokerEpochIntegrationTest` which also tests more of a code path. 
Given this info, you still think we should add it? Or perhaps there are more 
reasons I missed?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org