[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-02-08 Thread via GitHub
jeffkbkim commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1100490932 ## clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java: ## @@ -212,24 +248,32 @@ public static ApiVersionCollection collectApis(Set

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-01-19 Thread GitBox
jeffkbkim commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1081656322 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json: ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-01-19 Thread GitBox
jeffkbkim commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1081655338 ## clients/src/main/resources/common/message/ConsumerGroupHeartbeatResponse.json: ## @@ -0,0 +1,70 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

2023-01-17 Thread GitBox
jeffkbkim commented on code in PR #12972: URL: https://github.com/apache/kafka/pull/12972#discussion_r1072528536 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -619,6 +619,9 @@ object KafkaConfig { val PasswordEncoderKeyLengthProp =