[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946280#comment-16946280
]
ASF GitHub Bot commented on KAFKA-7245:
---
mjsax commented on pull request #7105: KAFKA-7245
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891195#comment-16891195
]
Matthias J. Sax commented on KAFKA-7245:
[~omanges] Please keep the discussion about PR details
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890877#comment-16890877
]
Omkar Mestry commented on KAFKA-7245:
-
Hi [~mjsax], as the method in the WindowStore interface and
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890347#comment-16890347
]
Omkar Mestry commented on KAFKA-7245:
-
Submitted PR by making appropriate changes.
> Deprecate
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890343#comment-16890343
]
ASF GitHub Bot commented on KAFKA-7245:
---
omanges commented on pull request #7105: KAFKA-7245
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886489#comment-16886489
]
Matthias J. Sax commented on KAFKA-7245:
You can prepare a PR. I am not sure atm if we use the
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885855#comment-16885855
]
Omkar Mestry commented on KAFKA-7245:
-
So should I start making changes in code for removing the
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879559#comment-16879559
]
Matthias J. Sax commented on KAFKA-7245:
Thanks for updating the KIP. We will use this ticket to
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877520#comment-16877520
]
Omkar Mestry commented on KAFKA-7245:
-
[~mjsax] as the KIP accepted shall I close this Jira or any
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872006#comment-16872006
]
Omkar Mestry commented on KAFKA-7245:
-
[~mjsax] I have updated the status of [KIP -
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848387#comment-16848387
]
Omkar Mestry commented on KAFKA-7245:
-
Thread:-
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848302#comment-16848302
]
Matthias J. Sax commented on KAFKA-7245:
Please also update
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848301#comment-16848301
]
Matthias J. Sax commented on KAFKA-7245:
[~omanges]: KIPs are discussed on the dev mailing list.
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848072#comment-16848072
]
Omkar Mestry commented on KAFKA-7245:
-
Added KIP Please review it
> Deprecate WindowStore#put(key,
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847373#comment-16847373
]
Omkar Mestry commented on KAFKA-7245:
-
Please provide permission for the username :- omanges on
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846800#comment-16846800
]
Matthias J. Sax commented on KAFKA-7245:
Yes. The classes you listed _implement_ the interface,
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846598#comment-16846598
]
Omkar Mestry commented on KAFKA-7245:
-
[~mjsax] The core stream also has some class which are using
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846416#comment-16846416
]
Matthias J. Sax commented on KAFKA-7245:
All public API changes need a KIP. Hence, if we want to
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846402#comment-16846402
]
Omkar Mestry commented on KAFKA-7245:
-
Jira :- https://issues.apache.org/jira/browse/KAFKA-7928
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845839#comment-16845839
]
Omkar Mestry commented on KAFKA-7245:
-
[~mjsax], can you please elaborate on the issue as the KIP is
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845782#comment-16845782
]
Matthias J. Sax commented on KAFKA-7245:
Well. First we need a KIP to deprecate the method. Not
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845478#comment-16845478
]
Omkar Mestry commented on KAFKA-7245:
-
So we need to update only the tests which have put() call with
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845161#comment-16845161
]
Matthias J. Sax commented on KAFKA-7245:
No problem [~panuwat.anawatmongk...@gmail.com]! Thanks
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845160#comment-16845160
]
Panuwat Anawatmongkhon commented on KAFKA-7245:
---
[~mjsax] [~omanges] I forgot that I have
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845126#comment-16845126
]
Matthias J. Sax commented on KAFKA-7245:
Well. [~panuwat.anawatmongk...@gmail.com] wanted to work
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844764#comment-16844764
]
Omkar Mestry commented on KAFKA-7245:
-
[~mjsax] Please add me to the contributors list, so that I can
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629798#comment-16629798
]
Matthias J. Sax commented on KAFKA-7245:
Just added you to the list of contributors. You should
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629739#comment-16629739
]
Panuwat Anawatmongkhon commented on KAFKA-7245:
---
Ok, I will be working on this issue. By
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621347#comment-16621347
]
Guozhang Wang commented on KAFKA-7245:
--
No you're right. I was on an older branch.
> Deprecate
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621341#comment-16621341
]
Matthias J. Sax commented on KAFKA-7245:
I see only this line:
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621243#comment-16621243
]
Guozhang Wang commented on KAFKA-7245:
--
[~mjsax] I think the put(key, value) is still used in
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620974#comment-16620974
]
Matthias J. Sax commented on KAFKA-7245:
[~panuwat.anawatmongk...@gmail.com] [~guozhang] I
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620805#comment-16620805
]
Guozhang Wang commented on KAFKA-7245:
--
[~mjsax] before anyone taking on this, could you provide
[
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620268#comment-16620268
]
panuwat anawatmongkhon commented on KAFKA-7245:
---
Can I take this task?
> Deprecate
34 matches
Mail list logo