[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-10-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946280#comment-16946280 ] ASF GitHub Bot commented on KAFKA-7245: --- mjsax commented on pull request #7105: KAFKA-7245

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-07-23 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891195#comment-16891195 ] Matthias J. Sax commented on KAFKA-7245: [~omanges] Please keep the discussion about PR details

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-07-23 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890877#comment-16890877 ] Omkar Mestry commented on KAFKA-7245: - Hi [~mjsax], as the method in the WindowStore interface and

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-07-22 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890347#comment-16890347 ] Omkar Mestry commented on KAFKA-7245: - Submitted PR by making appropriate changes. > Deprecate

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890343#comment-16890343 ] ASF GitHub Bot commented on KAFKA-7245: --- omanges commented on pull request #7105: KAFKA-7245

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-07-16 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886489#comment-16886489 ] Matthias J. Sax commented on KAFKA-7245: You can prepare a PR. I am not sure atm if we use the

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-07-15 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885855#comment-16885855 ] Omkar Mestry commented on KAFKA-7245: - So should I start making changes in code for removing the

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-07-05 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879559#comment-16879559 ] Matthias J. Sax commented on KAFKA-7245: Thanks for updating the KIP. We will use this ticket to

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-07-03 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877520#comment-16877520 ] Omkar Mestry commented on KAFKA-7245: - [~mjsax] as the KIP accepted shall I close this Jira or any 

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-06-24 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872006#comment-16872006 ] Omkar Mestry commented on KAFKA-7245: - [~mjsax] I have updated the status of  [KIP -

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-26 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848387#comment-16848387 ] Omkar Mestry commented on KAFKA-7245: - Thread:- 

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-25 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848302#comment-16848302 ] Matthias J. Sax commented on KAFKA-7245: Please also update 

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-25 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848301#comment-16848301 ] Matthias J. Sax commented on KAFKA-7245: [~omanges]: KIPs are discussed on the dev mailing list.

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-25 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848072#comment-16848072 ] Omkar Mestry commented on KAFKA-7245: - Added KIP Please review it > Deprecate WindowStore#put(key,

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-24 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16847373#comment-16847373 ] Omkar Mestry commented on KAFKA-7245: - Please provide permission for the username :- omanges on 

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-23 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846800#comment-16846800 ] Matthias J. Sax commented on KAFKA-7245: Yes. The classes you listed _implement_ the interface,

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-23 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846598#comment-16846598 ] Omkar Mestry commented on KAFKA-7245: - [~mjsax]  The core stream also has some class which are using

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-22 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846416#comment-16846416 ] Matthias J. Sax commented on KAFKA-7245: All public API changes need a KIP. Hence, if we want to

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-22 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846402#comment-16846402 ] Omkar Mestry commented on KAFKA-7245: - Jira :- https://issues.apache.org/jira/browse/KAFKA-7928

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-22 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845839#comment-16845839 ] Omkar Mestry commented on KAFKA-7245: - [~mjsax], can you please elaborate on the issue as the KIP is

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-22 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845782#comment-16845782 ] Matthias J. Sax commented on KAFKA-7245: Well. First we need a KIP to deprecate the method. Not

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-21 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845478#comment-16845478 ] Omkar Mestry commented on KAFKA-7245: - So we need to update only the tests which have put() call with

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-21 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845161#comment-16845161 ] Matthias J. Sax commented on KAFKA-7245: No problem [~panuwat.anawatmongk...@gmail.com]! Thanks

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-21 Thread Panuwat Anawatmongkhon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845160#comment-16845160 ] Panuwat Anawatmongkhon commented on KAFKA-7245: --- [~mjsax] [~omanges] I forgot that I have

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-21 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845126#comment-16845126 ] Matthias J. Sax commented on KAFKA-7245: Well. [~panuwat.anawatmongk...@gmail.com] wanted to work

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2019-05-21 Thread Omkar Mestry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844764#comment-16844764 ] Omkar Mestry commented on KAFKA-7245: - [~mjsax] Please add me to the contributors list, so that I can

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2018-09-27 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629798#comment-16629798 ] Matthias J. Sax commented on KAFKA-7245: Just added you to the list of contributors. You should

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2018-09-26 Thread Panuwat Anawatmongkhon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16629739#comment-16629739 ] Panuwat Anawatmongkhon commented on KAFKA-7245: --- Ok, I will be working on this issue. By

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2018-09-19 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621347#comment-16621347 ] Guozhang Wang commented on KAFKA-7245: -- No you're right. I was on an older branch. > Deprecate

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2018-09-19 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621341#comment-16621341 ] Matthias J. Sax commented on KAFKA-7245: I see only this line:

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2018-09-19 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16621243#comment-16621243 ] Guozhang Wang commented on KAFKA-7245: -- [~mjsax] I think the put(key, value) is still used in

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2018-09-19 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620974#comment-16620974 ] Matthias J. Sax commented on KAFKA-7245: [~panuwat.anawatmongk...@gmail.com] [~guozhang] I

***UNCHECKED*** [jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2018-09-19 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620805#comment-16620805 ] Guozhang Wang commented on KAFKA-7245: -- [~mjsax] before anyone taking on this, could you provide

[jira] [Commented] (KAFKA-7245) Deprecate WindowStore#put(key, value)

2018-09-19 Thread panuwat anawatmongkhon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620268#comment-16620268 ] panuwat anawatmongkhon commented on KAFKA-7245: --- Can I take this task? > Deprecate