Re: [jokosher-devel] [PATCH] Patch for Launchpad bug 85938 - Usability for selection-based editing

2008-05-27 Thread Laszlo Pandy
Sorry, I haven't been ignoring this I am just really busy. There is also a few bugs in my new levels data code which is causing exceptions in the fade point function. I want to make sure I fix those before I commit this patch because they are making it hard to test everything entirely, and I do

Re: [jokosher-devel] [PATCH] Patch for Launchpad bug 85938 - Usability for selection-based editing

2008-05-21 Thread Tom Halligan
Woops silly me - I have indeed been using Eclipse, with some third-party SVN plugin. I just assumed it was doing things right - obviously not! Anyway, here's a new patch with your suggestions duly noted and taken care of: 1) (I assume you meant EventLaneViewer.py for this - EventViewer does indeed

Re: [jokosher-devel] [PATCH] Patch for Launchpad bug 85938 - Usability for selection-based editing

2008-05-21 Thread Laszlo Pandy
Hey, thanks Tom. It looks like a pretty good. Here are my comments: 1) Did anything change in EventViewer.py? It looks like just a space was added. Maybe you should revert that file. 2) It looks like you are using Eclipse which has generated a patch with absolute paths in it. This means when I