Re: [josm-dev] [PATCH 04/26] make Commands able to fail

2008-04-29 Thread Dave Hansen
On Tue, 2008-04-29 at 16:14 +0100, Alexander Wright wrote: > As a JOSM user, I can say that it would be much nicer if JOSM could handle > errors gracefully, rather than crash, potentially taking hours of work I'd > forgotten to back up with it. I've actually been really happy with it after it cr

Re: [josm-dev] [PATCH 04/26] make Commands able to fail

2008-04-29 Thread Alexander Wright
On Tuesday 29 April 2008 14:28:08 Frederik Ramm wrote: > Hi, > > > DESC > > Make SequenceCommand able to do rollbacks > > EDESC > > If one command in a sequence fails, we can roll back all the > > previously successful ones. > > Why would a command ever fail? > > In understanding, a command can onl

Re: [josm-dev] [PATCH 01/26] Enhance OsmPrimitive a bit

2008-04-29 Thread Dave Hansen
On Tue, 2008-04-29 at 15:20 +0200, Frederik Ramm wrote: > > @Override public final boolean equals(Object obj) { > > - if (obj == null || getClass() != obj.getClass() || id == 0 || > > ((OsmPrimitive)obj).id == 0) > > + if (obj == null || getClass() != obj.getClass()) > > +

Re: [josm-dev] [PATCH 04/26] make Commands able to fail

2008-04-29 Thread Dave Hansen
On Tue, 2008-04-29 at 15:28 +0200, Frederik Ramm wrote: > In understanding, a command can only fail if there's a programming > error in JOSM. Even so it is, of course, a good thing to handle that > gracefully rather than just throw an exception. - But are your > patches introducing commands t

Re: [josm-dev] [PATCH 04/26] make Commands able to fail

2008-04-29 Thread Frederik Ramm
Hi, > DESC > Make SequenceCommand able to do rollbacks > EDESC > If one command in a sequence fails, we can roll back all the > previously successful ones. Why would a command ever fail? In understanding, a command can only fail if there's a programming error in JOSM. Even so it is, of course,

Re: [josm-dev] [PATCH 01/26] Enhance OsmPrimitive a bit

2008-04-29 Thread Frederik Ramm
Hi, > @Override public final boolean equals(Object obj) { > - if (obj == null || getClass() != obj.getClass() || id == 0 || > ((OsmPrimitive)obj).id == 0) > + if (obj == null || getClass() != obj.getClass()) > + return super.equals(obj); > +

Re: [josm-dev] AgpifoJ plugin better than JOSM built-in?

2008-04-29 Thread christian . gallioz
Hi, The source of Agpifoj is in the jar. If you can't access it, I can also send you a zip package with the source. In fact, I wrote Agpifoj by modifying the Geotag plugin from Rob Neild. It was great but I had some ideas to make it more practical for my use (the picture in the main window, an