Re: [josm-dev] How to ask for confirmation at layer deletion or exit?

2016-01-06 Thread Russ Nelson
Holger Mappt writes: > If we never ask for confirmations then you would be able to quit JOSM > while it has modified data. Indeed, and you'll get the notice about having modified data before JOSM quits. The whole point of this is to avoid the "oh crap I just discarded my edits" moment. When pe

Re: [josm-dev] How to ask for confirmation at layer deletion or exit?

2016-01-02 Thread Martin Koppenhoefer
sent from a phone > Am 01.01.2016 um 21:37 schrieb Russ Nelson : > > Never ask for confirmations. It's never the right thing to do unless > you're very short of resources, which we never are these days. that's not exactly true, you can always come to the limits, especially when working with

Re: [josm-dev] How to ask for confirmation at layer deletion or exit?

2016-01-02 Thread Holger Mappt
If we never ask for confirmations then you would be able to quit JOSM while it has modified data. There can be no notice about saved changes at that point. The earliest time to display that notice would be the next JOSM start. But the data might have changed on the server in the meantime. In th

Re: [josm-dev] How to ask for confirmation at layer deletion or exit?

2016-01-01 Thread Russ Nelson
Never ask for confirmations. It's never the right thing to do unless you're very short of resources, which we never are these days. Instead, provide an undo of a layer delete. When they ask to delete a layer that has changes in it, simply delete it, and pop up a non-confirmation notice that says "

Re: [josm-dev] How to ask for confirmation at layer deletion or exit?

2015-12-31 Thread Vincent Privat
A ticket with a patch? :) 2015-12-31 16:47 GMT+01:00 Holger Mappt : > Hi Vincent, > > The idea behind requiresSomeAction() was to display a message like "use > the layer context menu to store modified data" to tell the user that there > is more than "save session", "delete/exit now", and "cancel"

Re: [josm-dev] How to ask for confirmation at layer deletion or exit?

2015-12-31 Thread Holger Mappt
Hi Vincent, The idea behind requiresSomeAction() was to display a message like "use the layer context menu to store modified data" to tell the user that there is more than "save session", "delete/exit now", and "cancel". Kind of an "other ways to handle modified data" information in the SaveL

Re: [josm-dev] How to ask for confirmation at layer deletion or exit?

2015-12-30 Thread Vincent Privat
isAbleToUploadToServer() and isAbleToSaveToFile() sound fine. Concerning the "action" string I don't know: what would you propose as action in your case? 2015-12-28 16:44 GMT+01:00 Holger Mappt : > Hi, > > See https://josm.openstreetmap.de/ticket/12075. > The idea is to ask for confirmation if a

[josm-dev] How to ask for confirmation at layer deletion or exit?

2015-12-28 Thread Holger Mappt
Hi, See https://josm.openstreetmap.de/ticket/12075. The idea is to ask for confirmation if a GeoImageLayer with modified image properties is deleted. What is the best/right way to do that? The AbstractModifiableLayer seems to serve that purpose. GeoImageLayer could extend AbstractModifiable