[josm-dev] Layer specific history

[Holger Mappt]

Hi,

See https://josm.openstreetmap.de/ticket/11904.
What is the recommended way to add a command history with undo/redo 
functionality to a layer that is not an OSM data layer?  In this case 
the GeoImageLayer.


The other software I know has one history stack.  Every modification 
generates a history entry.  JOSM default is to have history only for OSM 
data layers.  The Mapillary plugin implements a history as toggle dialog 
with separate undo/redo buttons.


I can imagine three options:
1) One linear history stack for all actions with one interface.  This is 
what is usually done in other software.  The interface is the undo/redo 
in the edit menu and the main toolbar and the command stack toggle dialog.


2) One history stack per layer with one interface.  Similar to 1), but 
undo/redo applies only to the active layer.  This decouples the actions 
done in different layers.  It requires that actions done in one layer do 
not depend on actions in another layer.  "Layer" can either be a single 
layer or one layer type.


3) Each layer implements a custom history.  Similar to 2), but different 
interface for each layer.  Has the advantage that fancy things can be 
done.  E.g. for the GeoImageLayer the history could be per image.  But 
the user is confronted with many history dialogs and undo mechanisms.


To be useful the history needs a concept of "connected actions" and the 
possibility to undo unconnected actions independently.  Example: The key 
"opening_hours" is added to a POI node, then the key "name" of an other 
PI node is changed.  To undo the opening_hours the name change has to 
undone too with the current implementation.  But the two POI nodes are 
not connected, it should be possible to undo either change.


Regards,
Holger

___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev

[josm-dev] Early Access builds b99 for JDK 9 & build b96 for JDK 9 with Project Jigsaw are available on java.net

[Rory O'Donnell]

Hi Vincent,

I forgot to mention that a fix for JDK-8140572 
went into b92 of JDK 
9, can you confirm the fix ?


Early Access b99  for JDK 9 is 
available on java.net, summary of  changes are listed here 
.


Early Access b96  for JDK 9 with Project 
Jigsaw is available on java.net, summary of changes are listed here 
 .


We have reached a milestone of 100 bugs logged by Open Source projects , 
thank you for your continued

support in testing Early Access builds based on various OpenJDK Projects.

Best wishes for the New Year, hope to catch up with you at FOSDEM in 
January.


Rgds,Rory

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin,Ireland

___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev

Re: [josm-dev] Early Access builds b99 for JDK 9 & build b96 for JDK 9 with Project Jigsaw are available on java.net

[Rory O'Donnell]

Thanks for that!

Rgds,Rory

On 29/12/2015 13:43, Wiktor Niesiobedzki wrote:

Hi,

Yes, I confirm that the bug is fixed in b92.

Cheers,

Wiktor

2015-12-29 13:58 GMT+01:00 Vincent Privat :

Hi Rory,
Thank you for your feedback!
I believe the bug is fixed, but unfortunately I cannot check for sure right
now during holidays.
Wiktor, can you confirm the bug resolution?
Cheers,
Vincent

2015-12-29 12:31 GMT+01:00 Rory O'Donnell :


Hi Vincent,

I forgot to mention that a fix for JDK-8140572 went into b92 of JDK 9, can
you confirm the fix ?

Early Access b99 for JDK 9 is available on java.net, summary of  changes
are listed here .

Early Access b96 for JDK 9 with Project Jigsaw is available on java.net,
summary of changes are listed here .

We have reached a milestone of 100 bugs logged by Open Source projects ,
thank you for your continued
support in testing Early Access builds based on various OpenJDK Projects.

Best wishes for the New Year, hope to catch up with you at FOSDEM in
January.

Rgds,Rory

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin,Ireland




--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland


___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev

Re: [josm-dev] Early Access builds b99 for JDK 9 & build b96 for JDK 9 with Project Jigsaw are available on java.net

[Vincent Privat]

Hi Rory,
Thank you for your feedback!
I believe the bug is fixed, but unfortunately I cannot check for sure right
now during holidays.
Wiktor, can you confirm the bug resolution?
Cheers,
Vincent

2015-12-29 12:31 GMT+01:00 Rory O'Donnell :

>
> Hi Vincent,
>
> I forgot to mention that a fix for JDK-8140572
>  went into b92 of JDK
> 9, can you confirm the fix ?
>
> Early Access b99  for JDK 9 is available
> on java.net, summary of  changes are listed here
> 
> .
>
> Early Access b96  for JDK 9 with Project
> Jigsaw is available on java.net, summary of changes are listed here
>  .
>
> We have reached a milestone of 100 bugs logged by Open Source projects ,
> thank you for your continued
> support in testing Early Access builds based on various OpenJDK Projects.
>
> Best wishes for the New Year, hope to catch up with you at FOSDEM in
> January.
>
> Rgds,Rory
>
> --
> Rgds,Rory O'Donnell
> Quality Engineering Manager
> Oracle EMEA, Dublin,Ireland
>
>
___
josm-dev mailing list
josm-dev@openstreetmap.org
https://lists.openstreetmap.org/listinfo/josm-dev