Re: Python-Django

2017-05-22 Thread James Beedy
The python-Django charm is largely outdated in many respects. I have been meaning to do a deep dive on it and turn it into something usable (there have been a few attempts at this over the years we can also look at). I can apply some of the goodies I've developed for my rails-layer i

[review queue] Python Django

2015-06-16 Thread Charles Butler
https://code.launchpad.net/~thumper/charms/trusty/python-django/support-1.7/+merge/260389 I had a chance ot review thumpers python-django merge set which preps the charm for django 1.7 and refactors several of the integration tests. +1 and merged. Charles Butler - Juju Charmer Come see the

[Review Queue] python-django, rabbitmq-server, nrpe

2015-04-06 Thread Kevin Monroe
Hello friends! Amir, Cory, and I had some 'que last week: + python-django https://code.launchpad.net/~nicopace/charms/trusty/python-django/allowed_host_patch/+merge/254958 This was a bugfix MP from Nico. An empty config option was not being handled correctly, resulting in page request fai

[Review Queue] Owncloud, python-django, and quassel-core

2015-02-17 Thread Charles Butler
[1] python-django: this appears to have suffered from some bitrot, as the MP did not apply cleanly, and the tests were not running under bundletester. [2] quassel-core: The charm is coming along nicely, its only remaining blocker that I found was the lack of included tests. There's an op

[Review Queue] ksplice, and python-django

2015-02-04 Thread Cory Johns
Kevin and I worked together yesterday to review a new charm submission for KSplice / Uptrack [1], and a merge proposal to (re?)add pip_extra_args support to the trusty python-django charm [2]. The KSplice charm had an issue with the provided test requiring manual input, which would break the

Re: python-django test plan

2015-02-03 Thread Nicolás Pace
On Mon, Feb 2, 2015 at 10:33 PM, sheila miguez wrote: > I'm grateful and happy to see this. I've been working off of a branch of > python-django and haven't put together merge requests because I'm > relatively new to this and wasn't sure how to go through the

Re: python-django test plan

2015-02-02 Thread sheila miguez
I'm grateful and happy to see this. I've been working off of a branch of python-django and haven't put together merge requests because I'm relatively new to this and wasn't sure how to go through the process of testing changes. I've been using mojo as a brute forc

python-django test plan

2015-01-29 Thread Nicolás Pace
Hi guys, I've defined a test plan for the Python-Django charm. I would like to know your thoughts about the scenaries, and propose any other that you might thought important. https://bugs.launchpad.net/charms/+source/python-django/+bug/1416108 Thanks, -- Ing. Nicolás Pace -- Juju mailing

Re: python-django charm and absent python-yaml package

2015-01-16 Thread sheila miguez
I notice the Makefile does not install test dependencies. I'll mention it in the issue. On Fri, Jan 16, 2015 at 3:38 AM, Vahric Muhtaryan wrote: > > Hello All > > Newly i tried to install the python-django charm. > Installation is failed, when i debug i saw that python

Re: python-django charm and absent python-yaml package

2015-01-16 Thread Vahric Muhtaryan
Thank you VM On 16/01/15 12:02, "Dimiter Naydenov" wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >Hey Vahric, > >Please, file a bug here: >https://bugs.launchpad.net/charms/+source/python-django > >This is indeed the right place to report issues

Re: python-django charm and absent python-yaml package

2015-01-16 Thread Dimiter Naydenov
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey Vahric, Please, file a bug here: https://bugs.launchpad.net/charms/+source/python-django This is indeed the right place to report issues with charms. So far I can't see this exact issue reported. Thanks, Dimiter On 16.01.2015 11:38, V

python-django charm and absent python-yaml package

2015-01-16 Thread Vahric Muhtaryan
Hello All Newly i tried to install the python-django charm. Installation is failed, when i debug i saw that python-yaml package is not installed after manually install it i can resubmit the charm deployment and its succeed . Looks like Patrick Hetu is the maintainer , is this list right place

[Review Queue] fail2ban, mysql, python-django, wildfly-ha-slave, wordpress

2015-01-14 Thread Tim Van Steenburgh
Merged: fail2ban https://code.launchpad.net/~jose/charms/trusty/fail2ban/tag-security/+merge/245923 mysql https://code.launchpad.net/~niedbalski/charms/precise/mysql/precise-syncup/+merge/244436 Not merged: (sent back for further work or clarification from submitter) python-django https

[Review Queue] chamilo, bitlbee, python-django, rabbitmq-server

2014-12-19 Thread Cory Johns
* chamilo: -1 (test failure due to race; submitted fix) * bitlbee: +1 * python-django: +1 * rabbitmq-server: -1 (merge conflict; tried to resolve but wasn't confident in my resolution) https://code.launchpad.net/~jose/charms/precise/chamilo/add-tests/+merge/241363 https://code.launchpad.net/

Re: python-django charm questions

2014-12-02 Thread sheila miguez
On Tue, Dec 2, 2014 at 11:38 AM, Simon Davy wrote: > On 2 December 2014 at 17:04, sheila miguez wrote: > > Hi all, > > > > > > Pip wishes > > > > * pip_extra_args support so that I can use --no-index > > --find-links=/path/to/wheels (this is in my fork) > > * remove --upgrade --use-mirrors, leav

Re: python-django charm questions

2014-12-02 Thread Tim Penhey
On 03/12/14 06:38, Simon Davy wrote: > On 2 December 2014 at 17:04, sheila miguez wrote: >> * Why is django_extra_settings used in config_changed but not during >> install? > > I expect that's a bug. The config_changed hook is called after the install hook when first installing. Tim -- Juju m

Re: python-django charm questions

2014-12-02 Thread Simon Davy
On 2 December 2014 at 17:04, sheila miguez wrote: > Hi all, > > > Pip wishes > > * pip_extra_args support so that I can use --no-index > --find-links=/path/to/wheels (this is in my fork) > * remove --upgrade --use-mirrors, leave it up to the user (in my fork) First class support for wheels in the

python-django charm questions

2014-12-02 Thread sheila miguez
Hi all, I'm working with the assumption that the pure-python fork of python-django will be in trunk soon, and will be around until the ansible reboot fork replaces it. If this is a bad assumption, let me know. There are some nice to haves that I'd like to have in the python-django ch

[Review Queue] mongodb rs.initiate(), python-django, and bip

2014-11-26 Thread Cory Johns
/+merge/236599 * [approve] python-django, pure python charm implementation https://code.launchpad.net/~patrick-hetu/charms/precise/python-django/pure-python/+merge/226742 * [needs fixing] bip, adding tests https://code.launchpad.net/~brad-marshall/charms/precise/bip/add-amulet-tests/+merge

[Review Queue] python-django and pubphoto

2014-11-19 Thread Cory Johns
I reviewed the following items: [1]: https://code.launchpad.net/~patrick-hetu/charms/precise/python-django/pure-python/+merge/226742 [2]: https://bugs.launchpad.net/charms/+bug/1331844 The changes in [1] mostly look good, but the tests are missing "expose" directives which is causi

Re: Migrating the python-django charm to Ansible

2014-11-17 Thread Patrick Hetu
and wanted to contribute to it but I got blocked. > > I found that tagging the tasks with Juju's hook names make it difficult to > produce a reusable role. > Because you will have to set a tag to all your tasks in the role > and always be running untagged task. > Th

Re: Migrating the python-django charm to Ansible

2014-11-07 Thread Patrick Hetu
ot blocked. I found that tagging the tasks with Juju's hook names make it difficult to produce a reusable role. Because you will have to set a tag to all your tasks in the role and always be running untagged task. This also make the charm specific to Juju. I've chose to use tags only in

Re: Migrating the python-django charm to Ansible

2014-11-07 Thread Simon Davy
On 6 November 2014 01:03, Michael Nelson wrote: > Hi Patrick, > > On Thu, Nov 6, 2014 at 4:22 AM, Patrick Hetu wrote: [snip] >> The shim would do things like: >> >> * Translating Juju variable to role variable > > That can be done in the playbook where needed as above. > >> * Sanitize variable li

Re: Migrating the python-django charm to Ansible

2014-11-05 Thread Michael Nelson
Hi Patrick, On Thu, Nov 6, 2014 at 4:22 AM, Patrick Hetu wrote: > Since the last UDS, I'm trying to make the python-django charm evolve > to use Ansible for is various tasks instead of using pure Python scripts. > > My previous attempt: > > lp:~patrick-hetu/charms/precis

Migrating the python-django charm to Ansible

2014-11-05 Thread Patrick Hetu
Since the last UDS, I'm trying to make the python-django charm evolve to use Ansible for is various tasks instead of using pure Python scripts. My previous attempt: lp:~patrick-hetu/charms/precise/python-django/ansible had some problems so I decided to restart from scratch here (wo

[Review Queue] hdpstorm & zk, python-django, apache2 ssl cypher suite

2014-09-26 Thread Charles Butler
[1] hortonworks hdp-storm & ZK bundle - n'acked [2] merge for python-django - updated status to 'work in progress' no review as no author activity (but prior reviews) [3] merge for precise apache2 ssl cyper - n'acked needs readme update [4] merge for trusty apache2 ss

[Review Queue] rabbitmq-server, python-django

2014-08-28 Thread Tim Van Steenburgh
ere no instructions on how to do so. Set to Needs Fixing. The python-django [2] merge proposal is a patch to add some new relations and remove ansible dependencies. This review ended rather quickly after I hit charm-proof, lint, and test failures. Set to Needs Fixing. [1] https://code.laun