tests around,
but I would prefer if the tests were uncommented and
made to pass (fixing whatever is necessary to make
them pass while thinking through to what logic they
were supposed to be testing in the first place).
For the record, the commented out tests were introduced
here:
https
tests around,
but I would prefer if the tests were uncommented and
made to pass (fixing whatever is necessary to make
them pass while thinking through to what logic they
were supposed to be testing in the first place).
For the record, the commented out tests were introduced
here:
https
Hey all,
I ran into some commented out tests while making a change:
https://github.com/juju/juju/pull/630/files#r16874739
I deleted them since keeping things around that we might need later is the
job of source control, not comments ;)
Ian just wanted me to check just to make sure this was OK
at 3:28 PM, Katherine Cox-Buday
katherine.cox-bu...@canonical.com wrote:
Hey all,
I ran into some commented out tests while making a change:
https://github.com/juju/juju/pull/630/files#r16874739
I deleted them since keeping things around that we might need later is the
job of source
On 30/08/14 05:55, Nate Finch wrote:
Git blame says ask Roger ;)
100% agree... don't leave in commented out code.
If you feel you must, because you expect it to get uncommented very soon,
then leave a very clear comment about why it was commented out and when it
should get uncommented.
On Fri, Aug 29, 2014 at 4:28 PM, Katherine Cox-Buday
katherine.cox-bu...@canonical.com wrote:
Hey all,
I ran into some commented out tests while making a change:
https://github.com/juju/juju/pull/630/files#r16874739
I deleted them since keeping things around that we might need later
