Re: First customer pain point pull request - default-hook

2014-08-17 Thread Nate Finch
That's an interesting document, but I feel like it doesn't really explain the problem it's trying to solve. Why does a single entry point cause a lot of boilerplate (I presume he means code boilerplate)? Isn't it just a switch on the name of the hook? What does it mean when a new hook is

Re: First customer pain point pull request - default-hook

2014-08-17 Thread Marco Ceppi
This might be a true problem when you don't map what event should fire what code in the hook. The majority, if not all, of charms that currently implement this pattern do so by either using charm-helpers or by having a giant if/else case statement at the bottom of the hook which maps which code

Re: First customer pain point pull request - default-hook

2014-08-17 Thread Tim Penhey
-BEGIN PGP MESSAGE- Charset: windows-1252 Version: GnuPG v1 hQIMA233D38ktbXXAQ//W+ymYmuIbjOlDOtOTwJ494ZP5dB0K4ITftBo8ESeZDjM m+av246NKJlXsH+iyFJNOUC3ouaNF/W/1NuBCJXa/IJNKX//TyMCVF3yh5m5R77h CWbcTwguameiDsA0pmcuf1ezZgtFA3SeSf9Tuhu5CkGbRVXkSunQOTwP7nAUcYsC

Re: First customer pain point pull request - default-hook

2014-08-17 Thread Tim Penhey
WTH happened there? /me tries to remember what he wrote. Tim -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev

Re: First customer pain point pull request - default-hook

2014-08-17 Thread Tim Penhey
-BEGIN PGP MESSAGE- Charset: windows-1252 Version: GnuPG v1 hQIMA233D38ktbXXAQ/+OxwEOmqX/SS+lyJGh7WBYOZge3P8G9+bdu0u8v/sGioD xbPcpRAp4D3GaCyaMS231JTdvWjMgegw9f6AnnaeLiEdcmFi3YBEzvnDCR5+Lfpb KNMZFUsL9CYtsBy+tWBFkowsFwiKy66UiOQDRGW6G6V+5v/L2v4TUoDN+LE74/h2

Re: First customer pain point pull request - default-hook

2014-08-17 Thread David Cheney
Nope, still not receiving you clearly On Mon, Aug 18, 2014 at 7:20 AM, Tim Penhey tim.pen...@canonical.com wrote: -BEGIN PGP MESSAGE- Charset: windows-1252 Version: GnuPG v1 hQIMA233D38ktbXXAQ/+OxwEOmqX/SS+lyJGh7WBYOZge3P8G9+bdu0u8v/sGioD

Re: First customer pain point pull request - default-hook

2014-08-17 Thread Tim Penhey
On 18/08/14 09:11, Tim Penhey wrote: WTH happened there? /me tries to remember what he wrote. Tim Some encryption settings have been changed somewhere. Again, what I was saying was that my concerns seem to be moot after reading the code. As long as the script can be told which hook is

Landing bot restrictions

2014-08-17 Thread Tim Penhey
Hi all, I'm sure everyone is aware of the landing bot changes that have gone in from CI. While these are painful now, they are helping us improve our test passing percentages. There was a pressure release valve added, the JFDI flag, to override the restrictions. I've seen this flag used more