Possible CI affecting change

2014-05-27 Thread John Meinel
I just proposed this branch: http://code.launchpad.net/~jameinel/juju-core/login-returns-env-tag/+merge/221021 This will make it so that we end up caching the environment UUID into our ENV.jenv file, and passing it up when we try to connect, and having it validated to match the running

Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo)

2014-05-27 Thread roger peppe
On 27 May 2014 04:02, Tim Penhey tim.pen...@canonical.com wrote: On 23/05/14 02:47, roger peppe wrote: Any particular reason to wrap the errgo functions rather than using errgo directly? Personally, I see the role of the errors package to be about specific error classifications (something that

Re: Possible CI affecting change

2014-05-27 Thread roger peppe
On 27 May 2014 07:55, John Meinel j...@arbash-meinel.com wrote: I just proposed this branch: http://code.launchpad.net/~jameinel/juju-core/login-returns-env-tag/+merge/221021 This will make it so that we end up caching the environment UUID into our ENV.jenv file, and passing it up when we try

Re: Possible CI affecting change

2014-05-27 Thread John Meinel
They are/were hard-coding CACert and control-bucket (because they can). I believe they tried dropping control-bucket and then ended up getting locked out of their Canonistack account (not necessarily more than random correlation, but I believe it spooked off Curtis from making that change again).

Re: new alpha beta support broke CI

2014-05-27 Thread Curtis Hovey-Canonical
On Tue, May 27, 2014 at 12:16 AM, Ian Booth ian.bo...@canonical.com wrote: PS. I still don't know the arch name for PPC64el tools. CI is createing ppc64el and ppc64 each time it sees the former. My deployment to stilson-06 implies ppc63el is ignored, the arch has to be ppc64 The expected

Re: Possible CI affecting change

2014-05-27 Thread Aaron Bentley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 14-05-27 02:55 AM, John Meinel wrote: I just proposed this branch: http://code.launchpad.net/~jameinel/juju-core/login-returns-env-tag/+merge/221021 This will make it so that we end up caching the environment UUID into our ENV.jenv file, and

Version numbering (was Re: new alpha beta support broke CI)

2014-05-27 Thread Tim Penhey
On 27/05/14 16:09, Curtis Hovey-Canonical wrote: The alpha beta support affects packaging.and tools naming. This chagne should have been discussed with Juju QA before landing. CI cannot make a package or extract tools. http://juju-ci.vapour.ws:8080/job/publish-revision/415/console We

Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo)

2014-05-27 Thread William Reade
Roger We have had many long discussions, and you have provided much valuable input: in particular, explaining to us that we were completely off-base re: the attempts to use a slice vs a linked list in the error stacks. And we did indeed agree to use errgo (as the only proposed implementation that

Re: interface identity (was Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo))

2014-05-27 Thread Tim Penhey
On 28/05/14 12:43, Nate Finch wrote: This sounds like one of those if you have to ask this question, you're doing something wrong. Can you give an example of where we need this? Sure... let's say we have a stack of errors, for simplicity of the argument lets say it is a slice of error

Re: interface identity (was Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo))

2014-05-27 Thread Tim Penhey
On 28/05/14 13:31, Nate Finch wrote: If you're talking about errgo, if all we care about is transition, but not what the actual types are, we could just record in the list when we mask the type. We could, but that would mean walking the list every time you want to check the cause. It would

Re: interface identity (was Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo))

2014-05-27 Thread Andrew Wilkins
On Wed, May 28, 2014 at 8:47 AM, Tim Penhey tim.pen...@canonical.comwrote: On 28/05/14 12:43, Nate Finch wrote: This sounds like one of those if you have to ask this question, you're doing something wrong. Can you give an example of where we need this? Sure... let's say we have a stack

Re: interface identity (was Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo))

2014-05-27 Thread Tim Penhey
On 28/05/14 13:48, Andrew Wilkins wrote: On Wed, May 28, 2014 at 8:47 AM, Tim Penhey tim.pen...@canonical.com mailto:tim.pen...@canonical.com wrote: On 28/05/14 12:43, Nate Finch wrote: This sounds like one of those if you have to ask this question, you're doing something

Re: interface identity (was Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo))

2014-05-27 Thread Andrew Wilkins
On Wed, May 28, 2014 at 9:52 AM, Tim Penhey tim.pen...@canonical.comwrote: On 28/05/14 13:48, Andrew Wilkins wrote: On Wed, May 28, 2014 at 8:47 AM, Tim Penhey tim.pen...@canonical.com mailto:tim.pen...@canonical.com wrote: On 28/05/14 12:43, Nate Finch wrote: This sounds like

Re: interface identity (was Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo))

2014-05-27 Thread Andrew Wilkins
On Wed, May 28, 2014 at 10:39 AM, John Meinel j...@arbash-meinel.comwrote: The address of the real value is the same. Are you referring to the backing array? That is not what is being compared, so that's not a useful property. John =:- On May 28, 2014 6:04 AM, Andrew Wilkins

Re: interface identity (was Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo))

2014-05-27 Thread John Meinel
I think we need concrete examples which Tim should have in the test suite. John =:- On May 28, 2014 6:50 AM, Andrew Wilkins andrew.wilk...@canonical.com wrote: On Wed, May 28, 2014 at 10:39 AM, John Meinel j...@arbash-meinel.comwrote: The address of the real value is the same. Are you

Re: interface identity (was Re: Proposed new dependency: github.com/juju/errors (and github.com/juju/errgo))

2014-05-27 Thread Tim Penhey
On 28/05/14 15:48, John Meinel wrote: I think we need concrete examples which Tim should have in the test suite. John =:- On May 28, 2014 6:50 AM, Andrew Wilkins andrew.wilk...@canonical.com mailto:andrew.wilk...@canonical.com wrote: On Wed, May 28, 2014 at 10:39 AM, John Meinel