As it's something we need to be doing for a while yet is there value in
adding this as a task that gets run by the landing bot?
Thanks
Matty
On Thu, Aug 28, 2014 at 11:48 PM, Tim Penhey tim.pen...@canonical.com
wrote:
Hi folks,
I spent some time this morning looking at
nah, we have a fix upstream, we just need to get that backported to
trusty then this becomes a non issue.
On Fri, Aug 29, 2014 at 7:44 PM, Matthew Williams
matthew.willi...@canonical.com wrote:
As it's something we need to be doing for a while yet is there value in
adding this as a task that
I think the bot could be taught to at least compile all the tests under
gccgo (with go test -compiler=gcc -c). That would at least let us detect
compile failures.
John
=:-
On Fri, Aug 29, 2014 at 2:45 PM, David Cheney david.che...@canonical.com
wrote:
nah, we have a fix upstream, we just need
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
juju-core 1.20.6
A new stable release of Juju, juju-core 1.20.6, is now available.
This release replaces 1.20.5.
juju-core 1.20.6 is available for utopic and backported to earlier
series in the following PPA:
Hey all,
I ran into some commented out tests while making a change:
https://github.com/juju/juju/pull/630/files#r16874739
I deleted them since keeping things around that we might need later is the
job of source control, not comments ;)
Ian just wanted me to check just to make sure this was OK.
Git blame says ask Roger ;)
100% agree... don't leave in commented out code.
If you feel you must, because you expect it to get uncommented very soon,
then leave a very clear comment about why it was commented out and when it
should get uncommented.
But mostly just don't.
On Fri, Aug 29, 2014
On 30/08/14 05:55, Nate Finch wrote:
Git blame says ask Roger ;)
100% agree... don't leave in commented out code.
If you feel you must, because you expect it to get uncommented very soon,
then leave a very clear comment about why it was commented out and when it
should get uncommented.
On Fri, Aug 29, 2014 at 4:28 PM, Katherine Cox-Buday
katherine.cox-bu...@canonical.com wrote:
Hey all,
I ran into some commented out tests while making a change:
https://github.com/juju/juju/pull/630/files#r16874739
I deleted them since keeping things around that we might need later is the
