Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-02-22 Thread Giuseppe Aruta
Hi Landon, I added two classes under org.openjump.core.ui.util (LayerableUtil.class and GeometryUtil.class) where I collect some methods for future development. Best regards Peppe 2016-02-04 17:02 GMT+01:00 Giuseppe Aruta : > Thanks Landon for your help. I will add a

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-02-04 Thread Giuseppe Aruta
Thanks Landon for your help. I will add a class (probably on a test Package) just to collect all (layerable/layer) usable methods 2016-02-03 23:40 GMT+01:00 Michaël Michaud : > Hi, > > To give more food for thought about layerable hierarchy, I have an old > project

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-02-03 Thread Michaël Michaud
Hi, To give more food for thought about layerable hierarchy, I have an old project in mind to create VirtualLayers. A VirtualLayer would be the dataset of another Layer. It may be read-only. Its main purpose is to have more than one style associated to a single datasource and to be able to

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-02-03 Thread Landon Blake
How do you guys feel about having Peppe and I review our existing layerable class/interface architecture and come up with a proposal for clean-up and revisions. I think some of Peppe's suggested methods are useful, but agree with Ede that we need to plug them into the correct interface. I think

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-02-03 Thread edgar . soldin
sure, go ahead. it's just important to me that we talk about it first and find an ordered approach that takes into account the existing API. i am a big fan of small steps, but into the right direction. meaning a big overhaul refactoring is possibly bringing more problems than the whole cleanup

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-27 Thread Alberto De Luca
Ede, yes I am aware of the majority of the additions relate to Layer.java, but I wouldn't venture into commenting on those since my knowledge with regards to the Layer class is limited. What I could say though is that for what I've seen the design of Layer is very neat and though-through in

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-27 Thread edgar . soldin
thx! and exactly my point :) ..ede On 27.01.2016 12:17, Alberto De Luca wrote: > Ede, > > yes I am aware of the majority of the additions relate to Layer.java, but I > wouldn't venture into commenting on those since my knowledge with regards > to the Layer class is limited. What I could say

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-27 Thread edgar . soldin
On 26.01.2016 17:31, Giuseppe Aruta wrote: > Just few extra details: > > 1) Temporary vector (Layer.class) and raster (RasterImageLayer.class) > layers (isTemporaryLayer()) > - Sextante is a different software and it handles raster and vector in a > separate way from OpenJUMP > - while TEMP files

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-27 Thread Alberto De Luca
Hey guys, at the moment RasterImageLayer is quite a messy class (a mess to whom I've been contributing, by the way), because there's a bit of everything in in, from methods that manipulate the raster values to methods that take care of the rendering on screen... So while we wait for the lucky

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-27 Thread edgar . soldin
Alberto, you are aware most additions Peppe did were to Layer.java where they definitely don't belong? if it's needed in RasterImageLayer, i don't oppose at all. ..ede On 27.01.2016 10:53, Alberto De Luca wrote: > Hey guys, > > at the moment RasterImageLayer is quite a messy class (a mess to

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-27 Thread Michaël Michaud
Hi, I think that Peppe's request show some flaws in layerable hierarchy. Some may be addressed by adding helper methods to existing class. Others maybe addressed by introducing new interfaces. Some are not so difficult to find in current implementation. My main complain about the design is that

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-27 Thread Giuseppe Aruta
OK, I had the response of everybody. - I am going to remove all the Layer.class parts and restore as it is before - I am going to leave only the RasterImageLayer.class method isTemporaryLayer() - I will create an external class, called maybe LayerbleUtils - no implementation to Layerable or other

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-26 Thread edgar . soldin
> *Datum: *26.01.2016 8:22 > *An: *OpenJump develop and use; > *Betreff:*Re: [JPP-Devel] Add some useful methods on Layer.class and > RasterImageLayer.class > > Peppe, > > > first of all while i commend your drive i really think that API > changes/additions this deep in

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-26 Thread Stefan Steiniger
Hey, i think some of the stuff is quite usefull and even having it in Layer class... for an OJ programmer who knows clases etc., probabky not the right place, but for someone who writes scripts (python, bash, etc) this is the obvious place to get to know layer properties. Of course i don't know

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-26 Thread Giuseppe Aruta
place, but > > for someone who writes scripts (python, bash, etc) this is the obvious > place to > > get to know layer properties. > > > > Of course i don't know how many do scripting with OJ, but... > > > > cheers, > > > > stefan > > > >

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-26 Thread Stefan Steiniger
see below Am 26.01.16 um 13:31 schrieb Giuseppe Aruta: > Just few extra details: > > 1) Temporary vector (Layer.class) and raster (RasterImageLayer.class) > layers (isTemporaryLayer()) > - Sextante is a different software and it handles raster and vector in a > separate way from OpenJUMP > -

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-26 Thread edgar . soldin
Peppe, first of all while i commend your drive i really think that API changes/additions this deep in CORE should be discussed first and committed only after. this is unless you - are absolutely sure what you are doing ;) and - know how to revert the commit cleanly (keeping revisions) further

Re: [JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-25 Thread Michaël Michaud
Hi Peppe, Interesting changes. Here are some comments, some of which have to be discussed furter with Ede and others, Le 26/01/2016 07:26, Giuseppe Aruta a écrit : Hi Ede, Michael, Jukka, Stefan and others I added some simple boolean ans String methods on

[JPP-Devel] Add some useful methods on Layer.class and RasterImageLayer.class

2016-01-25 Thread Giuseppe Aruta
Hi Ede, Michael, Jukka, Stefan and others I added some simple boolean ans String methods on com.vividsolutions.jump.workbench.model.Layer class and org.openjump.core.rasterimage.RasterImageLayer class I ask you to give a look and your opinion, these methods should cover many aspects and can be