Hi,
now the PIROL RasterImage-PlugIn works fine again :-)
Thank you for your help!
Regards
Uwe
Stefan Steiniger schrieb:
> great, thank you!
>
> no objections from my side
> ..as far as the old plugins still run ;)
>
> stefan
>
> Paul Austin schrieb:
>> I've added a new interface and depreca
Paul Austin wrote:
Hi,
> Without a factory in the RendererManager class you have to have the
> following.
>
> if (object instanceof Layer) {
>return new LayerRenderer(...);
> } else if (object instanceof WMSLayer) {
> return new WMSLayerRenderer();
> }
ah, I thought you were talking about
Andreas,
Without a factory in the RendererManager class you have to have the
following.
if (object instanceof Layer) {
return new LayerRenderer(...);
} else if (object instanceof WMSLayer) {
return new WMSLayerRenderer();
}
with the factory it becomes
RendererFactory factory = getRenderer(
Paul Austin wrote:
Hi,
> I was thinking that we could clean up this code a little, at the moment
> there is hard coded implementations for layers and WMS layers. We could
> change this to use a factory approach by creating implementations for these.
>
> There are actually a whole bunch of places
Stefan,
It was pretty easy so I have migrated the Layer and WMSLayer to use
RenderingFactory implementations to create the renderers. I have set it
up so that if it can't find a renderer for a class it will look at the
super classes until it finds a match. If that fails and the old stuff
fails the
great, thank you!
no objections from my side
..as far as the old plugins still run ;)
stefan
Paul Austin schrieb:
> I've added a new interface and deprecated the old one.
>
> I was thinking that we could clean up this code a little, at the moment
> there is hard coded implementations for layers
mhm.. ok
seems that the situation is more complicated then i thought.
However, as for you, I consider the duplicated code not as a problem.
thank you for your efforts, Paul
Stefan :)
Paul Austin schrieb:
> Hi Stefan,
>
> The problem is that if you add another method then you also break the
> cod
I've added a new interface and deprecated the old one.
I was thinking that we could clean up this code a little, at the moment
there is hard coded implementations for layers and WMS layers. We could
change this to use a factory approach by creating implementations for these.
There are actually a
Hi Stefan,
The problem is that if you add another method then you also break the
code as the implementers also have to implement that method.
The other option is that I define a completely new interface with the
additional method in it. This has the disadvantage that we have a whole
bunch of dupl
Hei Paul,
is it possible to restore the old method? - i.e. to have the method
twice with different params? Because breaking old code is not what I
would like to see during the core development.
You could use then the new method while the old one is still working for
others.
If we do such core
Uwe,
I made a change to the API to pass in the LayerViewPanel so that the
renderers can get access to it.
If you can update the pirol plug-ins to have that additional parameter
that would be great.
Paul
Uwe Dalluege wrote:
> Hi,
>
> when I use the PIROL rasterImage-PlugIn (rasterImage.jar)
> wi
Hi,
when I use the PIROL rasterImage-PlugIn (rasterImage.jar)
with OJ-NightBuild I receive the following error:
java.lang.AbstractMethodError:
de.fhOsnabrueck.jump.pirol.utilities.RasterImageSupport.RasterImageLayerRendererFactory.create(Ljava/lang/Object;Lcom/vividsolutions/jump/workbench/ui/L
12 matches
Mail list logo
