5896 should work.. was a bit more complex because of the legacy loaders, which
i deprecated while being at it.
..ede
On 22.06.2018 15:07, Giuseppe Aruta wrote:
> 5894?
>
> 2018-06-22 14:51 GMT+02:00 mailto:edgar.sol...@web.de>>:
>
> Peppe,
>
> you still kept the overall reformat..
Peppe,
do you to want try again after the restore?
..ede
On 22.06.2018 14:22, Giuseppe Aruta wrote:
> I will revomove the patch. The icon comes from Kosmo SAIG
>
> 2018-06-22 14:09 GMT+02:00 mailto:edgar.sol...@web.de>>:
>
> ohh,
>
> and Logger.error() in the catch should be
I will revomove the patch. The icon comes from Kosmo SAIG
2018-06-22 14:09 GMT+02:00 :
> ohh,
>
> and Logger.error() in the catch should be implemented for the kind
> developer to be notified in case of an error.
>
> ..ede
>
> On 22.06.2018 14:07, edgar.sol...@web.de wrote:
> > Peppe,
> >
> >
ohh,
and Logger.error() in the catch should be implemented for the kind developer
to be notified in case of an error.
..ede
On 22.06.2018 14:07, edgar.sol...@web.de wrote:
> Peppe,
>
> apart from the fact that you reformatted the whole class (again!) with
> 4spaces indention an wrongly
Peppe,
apart from the fact that you reformatted the whole class (again!) with 4spaces
indention an wrongly broken comments, you simply replaced the method icon() .
that is wrong! the method used allover this class is getIcon(url), which would
be the right place to apply your patch.
the
Yes Ede, thanks
I saw they extended the main class.
String resolveFile(...) on IconLoader (raw 131) should solve icon location
between main folder and famfam, fugue ones, right?
Peppe
2018-06-22 13:59 GMT+02:00 Giuseppe Aruta :
> I applied the patch on OJ 5821
> The default icon (in case the
I applied the patch on OJ 5821
The default icon (in case the choosen one doesn't exist) is the following:
2018-06-22 13:52 GMT+02:00 Giuseppe Aruta :
> Hi Ede,Michale
> ther are actually 3 Iconloader in OJ
> 1) com.vividsolutions.jump.workbench.ui.images.IconLoader - The main
> class, widely
right, but you can check, all of them extend
com.vividsolutions.jump.workbench.ui.images.IconLoader already.
..ede
On 22.06.2018 13:52, Giuseppe Aruta wrote:
> Hi Ede,Michale
> ther are actually 3 Iconloader in OJ
> 1) com.vividsolutions.jump.workbench.ui.images.IconLoader - The main class,
>
Hi Ede,Michale
ther are actually 3 Iconloader in OJ
1) com.vividsolutions.jump.workbench.ui.images.IconLoader - The main class,
widely used in OJ
2) com.vividsolutions.jump.workbench.ui.images.famfam.IconLoader - which it
is actually used by 2 plugins: CopyImagePlugIn and CutSelectedItemsPlugIn
3)
On 22.06.2018 09:09, Michaël Michaud wrote:
> Making IconLoader more robust is a good idea. Note that we have several
> IconLoader in the distribution (plus some included in extensions), but maybe
> we can try to use some kind of heritage to implement it only once.
i seem to remember to have
good idea,
what would be a good default icon? an empty icon is no good as it might be
displayed unaccompinied by some label text.
..ede
On 22.06.2018 08:15, Giuseppe Aruta wrote:
> Hi Michael,
> thanks for taking care. Indeed I am a little confused as I am not familiar
> with maven.
>
>
Hi,
I'm no more familiar with eclipse, but I think recent versions come with
maven bundled.
If you have maven installed, it comes with a number of "goals" or "targets"
https://books.sonatype.com/m2eclipse-book/reference/running-sect-running-maven-builds.html
If you use package target (i.e.
Hi Peppe,
I partly fixed your last commit.
Please check that the change I made in ProfileUtils line 340 is OK, and
commit missing resources (ex. fugue/clock.png)
You should check that the project compile before committing. Missing
resources like icons are more difficult to detect until you
13 matches
Mail list logo
