Re: [JPP-Devel] @Michael. Bug on LayerView and other observations

2018-08-28 Thread Giuseppe Aruta 
Hi Michaël
I gave a look to OJ 5932.
Everything seems to work fine. See the following notes about a project with
a layer and some layer views.

a) When I click to save the project, the warning to save layers with no
datasource comes anyhow if there are layer views
b) if I accept to save those layer views, OpenJUMP records them to project
file. No new file is saved. By the time I open the project, layer views are
correctly loaded  with their style applied
c) If I deny to save those layer views, OpenJUMP doesn't record them to the
project files. No new file is saved. Opening the project no layerview is
show.

I think we should add a filter to  SaveLayerWithNoDatasource plugin in
order to not consider layer views (in the list of layer to save) allowing
OJ to record layer views to project file anyhow.

Bets regards

Peppe

2018-08-24 18:56 GMT+02:00 Giuseppe Aruta :

> Thanks Michael
> I will give a try on this weekend and let you know
> Best regards
> Peppe
>
> 2018-08-22 9:11 GMT+02:00 Michaël Michaud :
>
>> Hi Peppe,
>>
>> It should be almost repaired. It is still missing a fix to prevent
>> writing the data file for the view while saving the project.
>>
>> Let me know if there is still something wrong.
>>
>> Michaël
>>
>> Le 19/08/2018 à 21:52, Michaël Michaud a écrit :
>>
>> Hi Peppe,
>>
>> Thanks a lot for letting me know. I'll try to check that as soon as
>> possible.
>>
>> Michaël
>>
>> Le 19/08/2018 à 18:04, Giuseppe Aruta a écrit :
>>
>> Hi Michael,
>> I gave a look at the usage of LayerView class and I found a bug on
>> opening project if layerViews are saved into a project file
>> This is the sequence:
>>
>> 1) I create a project and load (or create) a new layer
>> 2) I create a layerView of selected layer and click to save the project
>> 3) OpenJUMP asks to save the newly created layer (=layerView) as JMP or
>> SHP.
>> 4) I select to create a new layer. The the saving project is finalized
>> and a project file is saved.
>> 5) I try to open the project.the *project is not opened* and an error
>> message shows the problem is in OpenProjectWizard, possibly on
>> loadLayers(...) method:
>>
>> j
>>
>>
>>
>>
>> *ava.lang.Exception: Caricando il file progetto
>> 'C:\Users\Beppe\Desktop\2.jmp' fallito con errore:
>> com.vividsolutions.jump.workbench.model.LayerView. at
>> org.openjump.core.ui.plugin.fi
>> le.open.OpenProjectWizard.open(OpenProjectWizard.java:195)
>> at org.openjump.core.ui.plugin.fi
>> le.open.OpenProjectWizard.open(OpenProjectWizard.java:132)
>> at org.openjump.core.ui.plugin.fi
>> le.open.OpenProjectWizard.run(OpenProjectWizard.java:127)
>> at
>> org.openjump.core.ui.plugin.AbstractWizardPlugin.run(AbstractWizardPlugin.java:73)*
>> *   ...*
>>
>> I opened the project file with a text editor and substitute
>> any
>> layer class="com.vividsolutions.jump.workbench.model.LayerView"
>> with
>> layer class="com.vividsolutions.jump.workbench.model.Layer"
>>
>> In this case I can open the project file in openjump with no problem.
>>
>> 
>> --
>> Apart from the bug, I have some observations for possible further
>> development
>>
>> a) a LayerView is be a simple "view" of a layer: the modification action
>> is syncroniozed: whenever I modified the geometries of a layer, the
>> modification affects also the conresponding LayerView. In this case the
>> "view" could be a parameter to save only into the project file without  the
>> need to create a clone of the layer.
>>
>> b) II found the LayerView can have a great positive impact on OJ style as
>> users can create multiple views of the same layer with different styles.
>> I explored the possibility to create subviews of a selected layer,
>> according to defined attribute (*). The easy way was to create sub feature
>> collections according to the attribute, create conresponding sub-layers
>> (which are not opened into the view, create conresponding views to load
>> into the view.
>> Of coarse  those subviews are not subviews of the original layer but
>> subviews of sub-layers. The syncronized modification is lost.
>>
>>
>>
>> (*) This could be extremely useful as OJ lacks of a good point/linestring
>> decoration symbology according to attribute. I am Thinking about vertex
>> symbol rotation, the usage of wkt files, text display next to symbols -
>> what is available in CadPlann symbology plugin available only for basic
>> style
>>
>>
>> Best regards and thanks for your job
>>
>> Peppe
>>
>>
>>
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>
>>
>>
>> ___
>> Jump-pilot-devel mailing 
>>

Re: [JPP-Devel] @Michael. Bug on LayerView and other observations

2018-08-24 Thread Giuseppe Aruta 
Thanks Michael
I will give a try on this weekend and let you know
Best regards
Peppe

2018-08-22 9:11 GMT+02:00 Michaël Michaud :

> Hi Peppe,
>
> It should be almost repaired. It is still missing a fix to prevent writing
> the data file for the view while saving the project.
>
> Let me know if there is still something wrong.
>
> Michaël
>
> Le 19/08/2018 à 21:52, Michaël Michaud a écrit :
>
> Hi Peppe,
>
> Thanks a lot for letting me know. I'll try to check that as soon as
> possible.
>
> Michaël
>
> Le 19/08/2018 à 18:04, Giuseppe Aruta a écrit :
>
> Hi Michael,
> I gave a look at the usage of LayerView class and I found a bug on opening
> project if layerViews are saved into a project file
> This is the sequence:
>
> 1) I create a project and load (or create) a new layer
> 2) I create a layerView of selected layer and click to save the project
> 3) OpenJUMP asks to save the newly created layer (=layerView) as JMP or
> SHP.
> 4) I select to create a new layer. The the saving project is finalized and
> a project file is saved.
> 5) I try to open the project.the *project is not opened* and an error
> message shows the problem is in OpenProjectWizard, possibly on
> loadLayers(...) method:
>
> j
>
>
>
>
> *ava.lang.Exception: Caricando il file progetto
> 'C:\Users\Beppe\Desktop\2.jmp' fallito con errore:
> com.vividsolutions.jump.workbench.model.LayerView. at
> org.openjump.core.ui.plugin.file.open.OpenProjectWizard.open(OpenProjectWizard.java:195)
> at
> org.openjump.core.ui.plugin.file.open.OpenProjectWizard.open(OpenProjectWizard.java:132)
> at
> org.openjump.core.ui.plugin.file.open.OpenProjectWizard.run(OpenProjectWizard.java:127)
> at
> org.openjump.core.ui.plugin.AbstractWizardPlugin.run(AbstractWizardPlugin.java:73)*
> *   ...*
>
> I opened the project file with a text editor and substitute
> any
> layer class="com.vividsolutions.jump.workbench.model.LayerView"
> with
> layer class="com.vividsolutions.jump.workbench.model.Layer"
>
> In this case I can open the project file in openjump with no problem.
>
> 
> --
> Apart from the bug, I have some observations for possible further
> development
>
> a) a LayerView is be a simple "view" of a layer: the modification action
> is syncroniozed: whenever I modified the geometries of a layer, the
> modification affects also the conresponding LayerView. In this case the
> "view" could be a parameter to save only into the project file without  the
> need to create a clone of the layer.
>
> b) II found the LayerView can have a great positive impact on OJ style as
> users can create multiple views of the same layer with different styles.
> I explored the possibility to create subviews of a selected layer,
> according to defined attribute (*). The easy way was to create sub feature
> collections according to the attribute, create conresponding sub-layers
> (which are not opened into the view, create conresponding views to load
> into the view.
> Of coarse  those subviews are not subviews of the original layer but
> subviews of sub-layers. The syncronized modification is lost.
>
>
>
> (*) This could be extremely useful as OJ lacks of a good point/linestring
> decoration symbology according to attribute. I am Thinking about vertex
> symbol rotation, the usage of wkt files, text display next to symbols -
> what is available in CadPlann symbology plugin available only for basic
> style
>
>
> Best regards and thanks for your job
>
> Peppe
>
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>
>
>
> ___
> Jump-pilot-devel mailing 
> listJump-pilot-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
>
>
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Jump-pilot-devel mailing list
> Jump-pilot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel
>
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] @Michael. Bug on LayerView and other observations

2018-08-22 Thread Michaël Michaud 

Hi Peppe,

It should be almost repaired. It is still missing a fix to prevent 
writing the data file for the view while saving the project.


Let me know if there is still something wrong.

Michaël


Le 19/08/2018 à 21:52, Michaël Michaud a écrit :


Hi Peppe,

Thanks a lot for letting me know. I'll try to check that as soon as 
possible.


Michaël


Le 19/08/2018 à 18:04, Giuseppe Aruta a écrit :

Hi Michael,
I gave a look at the usage of LayerView class and I found a bug on 
opening project if layerViews are saved into a project file

This is the sequence:

1) I create a project and load (or create) a new layer
2) I create a layerView of selected layer and click to save the project
3) OpenJUMP asks to save the newly created layer (=layerView) as JMP 
or SHP.
4) I select to create a new layer. The the saving project is 
finalized and a project file is saved.
5) I try to open the project.the _project is not opened_ and an error 
message shows the problem is in OpenProjectWizard, possibly on 
loadLayers(...) method:


j/ava.lang.Exception: Caricando il file progetto 
'C:\Users\Beppe\Desktop\2.jmp' fallito con errore:

com.vividsolutions.jump.workbench.model.LayerView.
    at 
org.openjump.core.ui.plugin.file.open.OpenProjectWizard.open(OpenProjectWizard.java:195)
    at 
org.openjump.core.ui.plugin.file.open.OpenProjectWizard.open(OpenProjectWizard.java:132)
    at 
org.openjump.core.ui.plugin.file.open.OpenProjectWizard.run(OpenProjectWizard.java:127)
    at 
org.openjump.core.ui.plugin.AbstractWizardPlugin.run(AbstractWizardPlugin.java:73)/

/   .../

I opened the project file with a text editor and substitute
any
layer class="com.vividsolutions.jump.workbench.model.LayerView"
with
layer class="com.vividsolutions.jump.workbench.model.Layer"

In this case I can open the project file in openjump with no problem.

--
Apart from the bug, I have some observations for possible further 
development


a) a LayerView is be a simple "view" of a layer: the modification 
action is syncroniozed: whenever I modified the geometries of a 
layer, the modification affects also the conresponding LayerView. In 
this case the "view" could be a parameter to save only into the 
project file without  the need to create a clone of the layer.


b) II found the LayerView can have a great positive impact on OJ 
style as users can create multiple views of the same layer with 
different styles.
I explored the possibility to create subviews of a selected layer, 
according to defined attribute (*). The easy way was to create sub 
feature collections according to the attribute, create conresponding 
sub-layers (which are not opened into the view, create conresponding 
views to load into the view.
Of coarse  those subviews are not subviews of the original layer but 
subviews of sub-layers. The syncronized modification is lost.




(*) This could be extremely useful as OJ lacks of a good 
point/linestring decoration symbology according to attribute. I am 
Thinking about vertex symbol rotation, the usage of wkt files, text 
display next to symbols - what is available in CadPlann symbology 
plugin available only for basic style



Best regards and thanks for your job

Peppe



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org!http://sdm.link/slashdot


___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel




--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] @Michael. Bug on LayerView and other observations

2018-08-19 Thread Michaël Michaud 

Hi Peppe,

Thanks a lot for letting me know. I'll try to check that as soon as 
possible.


Michaël


Le 19/08/2018 à 18:04, Giuseppe Aruta a écrit :

Hi Michael,
I gave a look at the usage of LayerView class and I found a bug on 
opening project if layerViews are saved into a project file

This is the sequence:

1) I create a project and load (or create) a new layer
2) I create a layerView of selected layer and click to save the project
3) OpenJUMP asks to save the newly created layer (=layerView) as JMP 
or SHP.
4) I select to create a new layer. The the saving project is finalized 
and a project file is saved.
5) I try to open the project.the _project is not opened_ and an error 
message shows the problem is in OpenProjectWizard, possibly on 
loadLayers(...) method:


j/ava.lang.Exception: Caricando il file progetto 
'C:\Users\Beppe\Desktop\2.jmp' fallito con errore:

com.vividsolutions.jump.workbench.model.LayerView.
    at 
org.openjump.core.ui.plugin.file.open.OpenProjectWizard.open(OpenProjectWizard.java:195)
    at 
org.openjump.core.ui.plugin.file.open.OpenProjectWizard.open(OpenProjectWizard.java:132)
    at 
org.openjump.core.ui.plugin.file.open.OpenProjectWizard.run(OpenProjectWizard.java:127)
    at 
org.openjump.core.ui.plugin.AbstractWizardPlugin.run(AbstractWizardPlugin.java:73)/

/   .../

I opened the project file with a text editor and substitute
any
layer class="com.vividsolutions.jump.workbench.model.LayerView"
with
layer class="com.vividsolutions.jump.workbench.model.Layer"

In this case I can open the project file in openjump with no problem.

--
Apart from the bug, I have some observations for possible further 
development


a) a LayerView is be a simple "view" of a layer: the modification 
action is syncroniozed: whenever I modified the geometries of a layer, 
the modification affects also the conresponding LayerView. In this 
case the "view" could be a parameter to save only into the project 
file without  the need to create a clone of the layer.


b) II found the LayerView can have a great positive impact on OJ style 
as users can create multiple views of the same layer with different 
styles.
I explored the possibility to create subviews of a selected layer, 
according to defined attribute (*). The easy way was to create sub 
feature collections according to the attribute, create conresponding 
sub-layers (which are not opened into the view, create conresponding 
views to load into the view.
Of coarse  those subviews are not subviews of the original layer but 
subviews of sub-layers. The syncronized modification is lost.




(*) This could be extremely useful as OJ lacks of a good 
point/linestring decoration symbology according to attribute. I am 
Thinking about vertex symbol rotation, the usage of wkt files, text 
display next to symbols - what is available in CadPlann symbology 
plugin available only for basic style



Best regards and thanks for your job

Peppe



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel