[jira] [Resolved] (KAFKA-569) Cleanup kafka.utils.Utils

2012-10-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-569. - Resolution: Fixed > Cleanup kafka.utils.Ut

[jira] [Closed] (KAFKA-569) Cleanup kafka.utils.Utils

2012-10-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-569. --- > Cleanup kafka.utils.Utils > - > > Ke

[jira] [Commented] (KAFKA-569) Cleanup kafka.utils.Utils

2012-10-12 Thread Neha Narkhede (JIRA)
and don't know what else to say). Great catch ! > Cleanup kafka.utils.Utils > - > > Key: KAFKA-569 > URL: https://issues.apache.org/jira/browse/KAFKA-569 > Project: Kafka &g

[jira] [Commented] (KAFKA-569) Cleanup kafka.utils.Utils

2012-10-12 Thread Jay Kreps (JIRA)
gt; Cleanup kafka.utils.Utils > - > > Key: KAFKA-569 > URL: https://issues.apache.org/jira/browse/KAFKA-569 > Project: Kafka > Issue Type: Bug >Affects Versions: 0.8 >Reporter: Jay Kre

[jira] [Commented] (KAFKA-569) Cleanup kafka.utils.Utils

2012-10-12 Thread Neha Narkhede (JIRA)
the first review - I see you added a counter to DefaultEventHandler for the round-robin load-balancing. For a long running producer, the counter could overflow to a negative value. I think we need to reset it to 0, no ? +1 otherwise. > Cleanup kafka.util

[jira] [Updated] (KAFKA-569) Cleanup kafka.utils.Utils

2012-10-12 Thread Jay Kreps (JIRA)
requested - Rebased - Changed naming of ISR to be consistent (we had, for example, LeaderAndIsrRequest but LeaderAndISRResponse) > Cleanup kafka.utils.Utils > - > > Key: KAFKA-569 > URL: https://issues.apache.org/ji

[jira] [Commented] (KAFKA-569) Cleanup kafka.utils.Utils

2012-10-11 Thread Neha Narkhede (JIRA)
this cleanup patch ! Just one minor suggestion - Can we add a description in ClientUtils similar to the one in Utils and ApiUtils ? > Cleanup kafka.utils.Utils > - > > Key: KAFKA-569 > URL: https://issues.apache.or

[jira] [Updated] (KAFKA-569) Cleanup kafka.utils.Utils

2012-10-11 Thread Jay Kreps (JIRA)
evenly distributed since it is true round-robin. - Delete ~5 custom property parsing methods that were jammed into Utils. Add a generic method VerifiableProperties.getMap that replaces them all. > Cleanup kafka.utils.Utils > - > >

[jira] [Created] (KAFKA-569) Cleanup kafka.utils.Utils

2012-10-11 Thread Jay Kreps (JIRA)
Jay Kreps created KAFKA-569: --- Summary: Cleanup kafka.utils.Utils Key: KAFKA-569 URL: https://issues.apache.org/jira/browse/KAFKA-569 Project: Kafka Issue Type: Bug Affects Versions: 0.8

Re: kafka.utils.Utils

2012-03-25 Thread Chris Burroughs
It would also be nice if the truly generic ZKUtils (createEphemeralPathExpectConflict) and the kafka specific (getConsumersPerTopic) were in separate classes. On 03/25/2012 06:23 PM, Jay Kreps wrote: > Hey guys, > > The Utils helpers are meant to be generic non-kafka-specific utility > functions.

kafka.utils.Utils

2012-03-25 Thread Jay Kreps
Hey guys, The Utils helpers are meant to be generic non-kafka-specific utility functions. Ideally it should not have dependencies outside java.* and scala.*. I notice a lot of code in there that is zookeeper-specific (my fault I think), that should really be a ZkUtils class. I also notice a lot of