Re: Talk on Kallithea at OSCON

2015-06-18 Thread Thomas De Schampheleire
On June 18, 2015 11:09:48 PM CEST, Mads Kiilerich wrote: >On 06/04/2015 03:04 PM, Bradley M. Kuhn wrote: >> I am writing to let you all know that my talk on Kallithea was >accepted >> at OSCON: >> >http://www.oscon.com/open-source-2015/public/schedule/detail/42015 >> >> Some of you saw an earl

Re: [PATCH] backout "pullrequests: don't add automatic 'status change' message - it will be added in template"

2015-06-18 Thread Mads Kiilerich
On 06/17/2015 07:40 AM, Jan Heylen wrote: What I also wanted to say is that the original change is most probably not the issue, it just triggers an underlying issue... Yeah, the issue were elsewhere. Thanks for pointing in the right direction! My 5 cents in solving it: * It is not the first t

Re: Talk on Kallithea at OSCON

2015-06-18 Thread Mads Kiilerich
On 06/04/2015 03:04 PM, Bradley M. Kuhn wrote: I am writing to let you all know that my talk on Kallithea was accepted at OSCON: http://www.oscon.com/open-source-2015/public/schedule/detail/42015 Some of you saw an earlier version of this talk at FOSDEM earlier this year. As you may recall,

[PATCH 2 of 2] db: add explicit constraint for the implicit invariant that all status changes have a comment

2015-06-18 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1434650132 -7200 # Thu Jun 18 19:55:32 2015 +0200 # Node ID 4c64c061bd3b4f4162fbfe57eedcade1be5290d3 # Parent 7b75c8877364c24c72281759d9959255def3b159 db: add explicit constraint for the implicit invariant that all status changes have a comm

[PATCH 1 of 2] pullrequsts: really create a comment when creating a PR and setting status to 'under review'

2015-06-18 Thread Mads Kiilerich
# HG changeset patch # User Mads Kiilerich # Date 1434647232 -7200 # Thu Jun 18 19:07:12 2015 +0200 # Node ID 7b75c8877364c24c72281759d9959255def3b159 # Parent 5fb4e6f884cec710b34736756d4eadaa53dd51d0 pullrequsts: really create a comment when creating a PR and setting status to 'under revie

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

2015-06-18 Thread Thomas De Schampheleire
On Thu, Jun 18, 2015 at 3:50 PM, Mads Kiilerich wrote: > On 06/17/2015 10:02 PM, Thomas De Schampheleire wrote: >> >> On Wed, Jun 17, 2015 at 12:27 AM, Mads Kiilerich >> wrote: >>> >>> On 06/15/2015 04:23 PM, Thomas De Schampheleire wrote: On Mon, Jun 15, 2015 at 2:10 PM, Mads Kiilerich

Re: [PATCH] notification: use Sender and From header to clarify comment and pull request mails

2015-06-18 Thread Mads Kiilerich
On 06/17/2015 10:02 PM, Thomas De Schampheleire wrote: On Wed, Jun 17, 2015 at 12:27 AM, Mads Kiilerich wrote: On 06/15/2015 04:23 PM, Thomas De Schampheleire wrote: On Mon, Jun 15, 2015 at 2:10 PM, Mads Kiilerich wrote: On 06/14/2015 09:05 PM, Thomas De Schampheleire wrote: Hi Mads, On Fr

Re: [PATCH] comments: remove dysfunctional comment bubble on compare and file views (issue #84)

2015-06-18 Thread Andrew Shadura
Hey, On 18 June 2015 at 09:01, Thomas De Schampheleire wrote: > I just sent another approach, using the surrounding commentable-diff > idea. The patch turns out to be very small, indeed much better than > the first approach. > > Let me know what you think... I like it! :) -- Cheers, Andrew

Re: [PATCH] comments: remove dysfunctional comment bubble on compare and file views (issue #84)

2015-06-18 Thread Thomas De Schampheleire
On Wed, Jun 17, 2015 at 9:39 PM, Thomas De Schampheleire wrote: > On Wed, Jun 17, 2015 at 1:23 AM, Mads Kiilerich wrote: >> On 06/13/2015 08:46 AM, Thomas De Schampheleire wrote: >>> >>> On June 12, 2015 11:45:31 PM CEST, Mads Kiilerich >>> wrote: On 06/11/2015 10:59 AM, Thomas De Scha