Re: Changelog table crashes if it tries to render a commit with an empty message

2020-12-22 Thread Mads Kiilerich
We landed the fix as https://kallithea-scm.org/repos/kallithea/changeset/f950740985f47ea09ef3361fa56b3d7581429156 Thanks, Mads On 12/15/20 4:10 PM, Brett Smith wrote: On 12/14/20 5:15 PM, Mads Kiilerich wrote: Ouch, yeah, .splitlines() is confusingly different from .split('\n') . Thanks for

Re: Changelog table crashes if it tries to render a commit with an empty message

2020-12-15 Thread Brett Smith
On 12/14/20 5:15 PM, Mads Kiilerich wrote: Ouch, yeah, .splitlines() is confusingly different from .split('\n') . Thanks for the patch. Would it perhaps be better to just use .split instead of .splitlines()? Your call but on balance I do think splitlines is better. It splits on all kinds of

Re: Changelog table crashes if it tries to render a commit with an empty message

2020-12-14 Thread Mads Kiilerich
Ouch, yeah, .splitlines() is confusingly different from .split('\n') . Thanks for the patch. Would it perhaps be better to just use .split instead of .splitlines()? But since the commit message text is shown as a link, would it perhaps be even better to avoid the void and show a text like

Changelog table crashes if it tries to render a commit with an empty message

2020-12-14 Thread Brett Smith
Hi, I recently upgraded a Kallithea server to 0.6.3, and I was running into an issue where trying to view the landing page for one specific repository, but not others, was crashing. I tracked this down to the changelog_table.html template. It runs message_lines = cs.message.splitlines() and