Re: [PATCH] middleware: use secure cookies over secure connections
Hello, On Thu, 05 Mar 2015 06:58:30 +0100 Thomas De Schampheleire patrickdeping...@gmail.com wrote: Then with this wrapper, can't we also change the cookie name to append the port, as an alternative to my recent patch fixing it in the config file? In theory, yes, but I'm not sure we should :) I'm not sure however, the port is the only thing to distinguish between different services. If it were me, I'd have different services running on the same port, but I'd had them available at different domains. Given that, I think your original patch might be better. -- Cheers, Andrew ___ kallithea-general mailing list kallithea-general@sfconservancy.org http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
Issue #105: comment handling / e-mail: link to specific comments only works when page is already loaded (conservancy/kallithea)
New issue 105: comment handling / e-mail: link to specific comments only works when page is already loaded https://bitbucket.org/conservancy/kallithea/issue/105/comment-handling-e-mail-link-to-specific Thomas De Schampheleire: Scenario: - receive a mail about a pull request comment - click on the link that points to the pullrequest#comment-xxx The pullrequest will open, but your browser (at least Firefox) will not jump to the comment. Once the page is loaded, you can reload the URL and then you jump correctly. I assume this is because the comments are loaded dynamically, and the anchor is not yet available when the browser wants to jump, but I'm not sure. ___ kallithea-general mailing list kallithea-general@sfconservancy.org http://lists.sfconservancy.org/mailman/listinfo/kallithea-general
