Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-24 Thread Mads Kiilerich
On 02/23/2015 10:17 PM, Thomas De Schampheleire wrote: root.html has some special hacks for using c.repo_name when it is defined. For now I think it would be fine to handle branding and repo name the same way. (A related "feature request": People often have multiple tabs open and they only see 1

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-23 Thread Thomas De Schampheleire
On Mon, Feb 23, 2015 at 4:21 PM, Mads Kiilerich wrote: [..] >>> >>> Yes. "Pages working in the context of a repo (and usually a >>> changeset/branch)" is so common and important that I think it makes sense >>> to >>> have extra support and convenience functions for that. >>> >>> It would perhaps b

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-23 Thread Mads Kiilerich
On 02/23/2015 04:10 PM, Thomas De Schampheleire wrote: On Mon, Feb 23, 2015 at 3:57 PM, Mads Kiilerich wrote: On 02/22/2015 10:19 PM, Thomas De Schampheleire wrote: On Sun, Feb 22, 2015 at 4:44 PM, Mads Kiilerich wrote: On 02/21/2015 08:48 PM, Thomas De Schampheleire wrote: # HG changeset p

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-23 Thread Thomas De Schampheleire
On Mon, Feb 23, 2015 at 3:57 PM, Mads Kiilerich wrote: > On 02/22/2015 10:19 PM, Thomas De Schampheleire wrote: >> >> On Sun, Feb 22, 2015 at 4:44 PM, Mads Kiilerich >> wrote: >>> >>> On 02/21/2015 08:48 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Scham

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-23 Thread Mads Kiilerich
On 02/22/2015 10:19 PM, Thomas De Schampheleire wrote: On Sun, Feb 22, 2015 at 4:44 PM, Mads Kiilerich wrote: On 02/21/2015 08:48 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1423170039 -3600 # Thu Feb 05 22:00:39 2015 +0100 # Node ID d5ca

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-22 Thread Thomas De Schampheleire
On Sun, Feb 22, 2015 at 4:44 PM, Mads Kiilerich wrote: > On 02/21/2015 08:48 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> >> # Date 1423170039 -3600 >> # Thu Feb 05 22:00:39 2015 +0100 >> # Node ID d5ca82fa417e49d1cec4989e895bb95397fccdc2

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-22 Thread Thomas De Schampheleire
On Sun, Feb 22, 2015 at 4:44 PM, Mads Kiilerich wrote: > On 02/21/2015 08:48 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> >> # Date 1423170039 -3600 >> # Thu Feb 05 22:00:39 2015 +0100 >> # Node ID d5ca82fa417e49d1cec4989e895bb95397fccdc2

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-22 Thread Mads Kiilerich
On 02/21/2015 08:48 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1423170039 -3600 # Thu Feb 05 22:00:39 2015 +0100 # Node ID d5ca82fa417e49d1cec4989e895bb95397fccdc2 # Parent 9df497f29cf2538f29440e66013bc7f864395082 my pull requests: fix pag

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-21 Thread Thomas De Schampheleire
On Sat, Feb 21, 2015 at 8:48 PM, Thomas De Schampheleire wrote: > # HG changeset patch > # User Thomas De Schampheleire > # Date 1423170039 -3600 > # Thu Feb 05 22:00:39 2015 +0100 > # Node ID d5ca82fa417e49d1cec4989e895bb95397fccdc2 > # Parent 9df497f29cf2538f29440e66013bc7f864395082 > my

[PATCH] my pull requests: fix page title when no site branding is set

2015-02-21 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire # Date 1423170039 -3600 # Thu Feb 05 22:00:39 2015 +0100 # Node ID d5ca82fa417e49d1cec4989e895bb95397fccdc2 # Parent 9df497f29cf2538f29440e66013bc7f864395082 my pull requests: fix page title when no site branding is set Just like any other