[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 Christoph Feck changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #10 from o.freyerm...@googlemail.com --- Hi, here the friendly "ping", as requested. Cheers, Oliver -- You are receiving this mail because: You are watching all bug changes.

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #9 from o.freyerm...@googlemail.com --- Hi, just to document: I have now uploaded the PR, as seems to be the correct way for KDE contributions, to: https://phabricator.kde.org/D7325 -- You are receiving this mail because: You are

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #8 from o.freyerm...@googlemail.com --- Hi, it seems you are correct, the CUPS server may also return 403 if the user uses a wrong password (I was pretty sure it would return NOT_AUTHENTICATED or NOT_AUTHORIZED in that case...). Based on

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #7 from Daniel Nicoletti --- To be honest I'm not sure what is best. I think b is received if the password is wrong, but I'm not sure (old code :P) if you can try both solutions would be great, I'll have more time to

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #6 from o.freyerm...@googlemail.com --- Can you confirm my understanding of the code is correct? If yes, and you tell me which way you prefer it to be solved: a) adding an additional error counting mechanism independent from the callback b)

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #5 from o.freyerm...@googlemail.com --- If you allow for a comment: I'd say relying on the callback function to work (and thus relying on cups API callback behaviour to break the loop) is not a good idea in general. Maybe, at least as

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #4 from o.freyerm...@googlemail.com --- You made me have a deeper look at the code, the bug is obvious in: https://github.com/KDE/print-manager/blob/master/libkcups/KCupsConnection.cpp 1) KCupsConnection::request() calls retry(). 2)

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #3 from o.freyerm...@googlemail.com --- Well, if the server responds with 403 but the client retries (endlessly), I'd say it's clearly a client-side bug. So something must go wrong with the error handling in the forked connection thread.

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #2 from Daniel Nicoletti --- That line is only a problem if there is a programming error with Qt parenting, which is unlikely. What can help here is the server configuration tho I sadly don't have much more time to

[print-manager] [Bug 383305] Endless loop when configuring a printer from central CUPS server and permission denied (403)

https://bugs.kde.org/show_bug.cgi?id=383305 --- Comment #1 from o.freyerm...@googlemail.com --- I believe the endless loop starts here: https://github.com/KDE/print-manager/blob/afd4609014e9aa938cb02be858f880deb56ade8e/libkcups/KCupsRequest.cpp#L564 -- You are receiving this mail because: You