https://bugs.kde.org/show_bug.cgi?id=452758
Mark Wielaard changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
https://bugs.kde.org/show_bug.cgi?id=452758
Elvis Angelaccio changed:
What|Removed |Added
CC||elvis.angelac...@kde.org
--
You are
https://bugs.kde.org/show_bug.cgi?id=452758
Mark Wielaard changed:
What|Removed |Added
CC||jojo19@gmail.com
--- Comment #48 from Mark
https://bugs.kde.org/show_bug.cgi?id=452758
Luke-Jr changed:
What|Removed |Added
CC||luke-jr+kdeb...@utopios.org
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=452758
Evgeniy A. Dushistov changed:
What|Removed |Added
CC||dushis...@mail.ru
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=452758
Markus Stange changed:
What|Removed |Added
CC||mstange@gmail.com
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #47 from Nick Nethercote ---
My test Rust program was this, in `a.rs`:
> fn main() {
> println!("hello world");
> }
And I compiled with `rustc +nightly a.rs` to produce the executable `a`.
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #46 from Nick Nethercote ---
> Could you test again with top of tree and see whether --read-var-info=yes
> also works OK?
My normal workflow works well. It uses Cachegrind and DHAT, which don't need
`--read-var-info=yes`.
I also tested
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #45 from Mark Wielaard ---
(In reply to Nick Nethercote from comment #35)
> With the additional commits things are working again for Rust code, thanks!
And that was without some of the patches been pushed yet :)
Could you test again with
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #44 from Mark Wielaard ---
(In reply to Lubos Lunak from comment #42)
> I don't see the dwarf spec being specific on how to interpret this, but then
> I think my way is the only logical one.
Yes, I keep getting confused. We only want the
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #43 from Mark Wielaard ---
(In reply to Lubos Lunak from comment #42)
> > It looks almost correct. I would just remove the following debug (TD3) part
> > from get_debug_addr_entry_common:
>
> Updated.
Thanks, pushed as:
commit
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #42 from Lubos Lunak ---
> It looks almost correct. I would just remove the following debug (TD3) part
> from get_debug_addr_entry_common:
Updated.
> It is a little tricky to know how to interpret endianness for these "3-byte"
> values.
>
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #149672|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #40 from Mark Wielaard ---
(In reply to Lubos Lunak from comment #38)
> > imho to use #if defined(VG_BIGENDIAN) instead of doing a runtime trick.
>
> Updated.
Thanks, looks good.
> > Is the big endian variant correct?
>
> I don't have
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #39 from Mark Wielaard ---
(In reply to Lubos Lunak from comment #38)
> > But the error handling in get_debug_addr_entry looks off.
> > The second argument is DW_FORM form. But it is given either a DW_FORM,
> > DW_LLE or DW_LRE.
> > I think
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #38 from Lubos Lunak ---
> But the error handling in get_debug_addr_entry looks off.
> The second argument is DW_FORM form. But it is given either a DW_FORM,
> DW_LLE or DW_LRE.
> I think it would be better if the second argument would be a
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #148380|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #148368|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #35 from Nick Nethercote ---
With the additional commits things are working again for Rust code, thanks!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #34 from Mark Wielaard ---
For support DW_FORM_addrx3 and DW_FORM_strx3 it would be easier/clearer imho
to use #if defined(VG_BIGENDIAN) instead of doing a runtime trick.
Is the big endian variant correct?
return c1 << 16 | c2 << 8 |
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #33 from Mark Wielaard ---
treat DW_TAG_skeleton_unit like DW_TAG_compile_unit looks good, pushed as:
commit e95904b99c87606eae1372ee4661e9db03833f08
Author: Luboš Luňák
Date: Tue Apr 26 08:35:16 2022 +0200
treat
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #32 from Mark Wielaard ---
For "implement support for missing DW_LLE_* and DW_RLE_* values" the code looks
good.
But the error handling in get_debug_addr_entry looks off.
The second argument is DW_FORM form. But it is given either a
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #31 from Lubos Lunak ---
> So I reviewed, tested and applied the first four numbered ones. What would
> be correct order for the next three patches/attachements?
In the order they are listed in the attachment list here. If you managed to
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #30 from Mark Wielaard ---
(In reply to Lubos Lunak from comment #28)
> The 7 patches should be applied in the order they
> are attached. You appear to be applying them based on their subject line,
> but those got meaningless as I was
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #29 from Mark Wielaard ---
(In reply to Mark Wielaard from comment #27)
> But this also handles DW_FORM_rnglistx and DW_FORM_loclistx.
> Shouldn't setup_cu_bases also handle these?
And that is what patch4 does.
> And if so, should we have
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #28 from Lubos Lunak ---
> But this also handles DW_FORM_rnglistx and DW_FORM_loclistx.
> Shouldn't setup_cu_bases also handle these?
The 2nd patch does that. The 7 patches should be applied in the order they are
attached. You appear to be
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #27 from Mark Wielaard ---
Patch3 looks correct on its own. So I'll push it as is:
commit 383f36462fdc25a0e849391cf845e22703a95c08
Author: Luboš Luňák
Date: Mon Apr 25 22:11:27 2022 +0200
avoid warning about missing DW_AT_*_base in
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #26 from Mark Wielaard ---
Patch 2 doesn't handle DW_AT_GNU_addr_base, DW_FORM_GNU_addr_index and
DW_FORM_GNU_str_index. But those are only used as extensions to DWARF4 with
split-dwarf. Support could be added later if people really use
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #25 from Nick Nethercote ---
(In reply to Nick Nethercote from comment #23)
> FYI: several people are experiencing this when running Valgrind on code
> compiled with the current nightly Rust compiler.
Unfortunately, this is still
https://bugs.kde.org/show_bug.cgi?id=452758
Mark Wielaard changed:
What|Removed |Added
Status|REPORTED|ASSIGNED
Assignee|pjfl...@wanadoo.fr
https://bugs.kde.org/show_bug.cgi?id=452758
Nick Nethercote changed:
What|Removed |Added
CC||n.netherc...@gmail.com
--- Comment #23 from
https://bugs.kde.org/show_bug.cgi?id=452758
blub...@gmail.com changed:
What|Removed |Added
CC||blub...@gmail.com
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=452758
Jiri Slaby changed:
What|Removed |Added
CC||jirisl...@gmail.com
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #19 from Paul Floyd ---
Hi Lubos
Do all these patches only affect llvm 14+?
Or will there be any improvement for older llvm versions?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #21 from Paul Floyd ---
I'm keen to get these changes in and if Mark approves I'll push the changes.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #22 from Mark Wielaard ---
I am really happy to see these patches. But have not read them yet. Also I am
on vacation till next week. Sorry for being slow,
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #20 from Lubos Lunak ---
They affect compilations does using Clang when it generates DWARF5. So
presumably they also affect older versions if explicitly asked to generate
DWARF5, but otherwise no.
BTW, since you're not going to actually
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #18 from Lubos Lunak ---
Created attachment 148380
--> https://bugs.kde.org/attachment.cgi?id=148380=edit
support DW_FORM_addrx3 and DW_FORM_strx3
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #17 from Lubos Lunak ---
Created attachment 148376
--> https://bugs.kde.org/attachment.cgi?id=148376=edit
treat DW_TAG_skeleton_unit like DW_TAG_compile_unit
Ok, I've figured out the split-dwarf debug line problem too, this fixes it for
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #148240|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #148233|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #148243|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #148242|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #148234|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #11 from Paul Floyd ---
On FreeBSD 13 and64 with clang and clang devel (11 and 15 respectively) no
problems building, no new regression test failures.
This will need some new regression tests.
I know little about DWARF so I'll leave that
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #10 from Lubos Lunak ---
The only remaining issue I can see is that DWARF5 + -gsplit-dwarf does not
output source locations in backtraces. So far I have not been able to find out
which part of Valgrind code is responsible, the furthest I
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #9 from Paul Floyd ---
I'll try the patches tomorrow.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
Paul Floyd changed:
What|Removed |Added
Assignee|jsew...@acm.org |pjfl...@wanadoo.fr
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #8 from Paul Floyd ---
Here are my results with clang-devel (15.0.0) on FreeBSD 13.0.
== 757 tests, 15 stderr failures, 4 stdout failures, 0 stderrB failures, 0
stdoutB failures, 0 post failures ==
memcheck/tests/amd64/insn-pmovmskb
https://bugs.kde.org/show_bug.cgi?id=452758
Mark Wielaard changed:
What|Removed |Added
CC||m...@klomp.org
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #7 from Lubos Lunak ---
Created attachment 148243
--> https://bugs.kde.org/attachment.cgi?id=148243=edit
implement support for missing DW_LLE_* and DW_RLE_* values
--
You are receiving this mail because:
You are watching all bug
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #148239|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #6 from Lubos Lunak ---
Created attachment 148242
--> https://bugs.kde.org/attachment.cgi?id=148242=edit
read dwarf5 DW_FORM_rnglistx and DW_FORM_loclistx
Removed left-over debug statement.
--
You are receiving this mail because:
You
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #5 from Lubos Lunak ---
Created attachment 148240
--> https://bugs.kde.org/attachment.cgi?id=148240=edit
avoid warning about missing DW_AT_*_base in skip_DIE()
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
Lubos Lunak changed:
What|Removed |Added
Attachment #148235|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=452758
Paul Floyd changed:
What|Removed |Added
CC||pjfl...@wanadoo.fr
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #3 from Lubos Lunak ---
Created attachment 148235
--> https://bugs.kde.org/attachment.cgi?id=148235=edit
valgrind patch
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #2 from Lubos Lunak ---
Created attachment 148234
--> https://bugs.kde.org/attachment.cgi?id=148234=edit
valgrind patch
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=452758
--- Comment #1 from Lubos Lunak ---
Created attachment 148233
--> https://bugs.kde.org/attachment.cgi?id=148233=edit
valgrind patch
--
You are receiving this mail because:
You are watching all bug changes.
59 matches
Mail list logo
