[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 Andreas Arnez changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED

[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 --- Comment #8 from Mark Wielaard --- I believe this is good to go. I have been testing it, including the new testcase on various fedora systems. Andreas, could you push the fix. Let me know if you want me to add the testcase separately. -- You are

[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 --- Comment #7 from Mark Wielaard --- (In reply to Andreas Arnez from comment #5) > Created attachment 149025 [details] > Patch for adding a memmem intercept, version 2 > > This addresses Mark's comment and removes the 'hh' variable. Looks good to me

[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 Mark Wielaard changed: What|Removed |Added Attachment #149008|0 |1 is obsolete|

[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 Andreas Arnez changed: What|Removed |Added Attachment #148994|0 |1 is obsolete|

[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 --- Comment #4 from Andreas Arnez --- (In reply to Mark Wielaard from comment #2) > Looks good and fixes the issue for me. > I think the for loop could/should be from i = 1. needle being zero sized > (nlen == 0) and n[0] == h[0] (hh != n0) has already

[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 --- Comment #3 from Mark Wielaard --- Created attachment 149008 --> https://bugs.kde.org/attachment.cgi?id=149008=edit Add memcheck memmem vgtest I wrote a testcase that fails before the patch (on s390x) and succeeds afterwards. It would be nice to

[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 Mark Wielaard changed: What|Removed |Added CC||m...@klomp.org --- Comment #2 from Mark

[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 --- Comment #1 from Andreas Arnez --- Created attachment 148994 --> https://bugs.kde.org/attachment.cgi?id=148994=edit Add intercept for memmem on s390x Add an intercept for memmem on s390x platforms. This fixes the problem in my testing. -- You

[valgrind] [Bug 454040] s390x: False-positive memcheck:cond in memmem on arch13 systems

https://bugs.kde.org/show_bug.cgi?id=454040 Andreas Arnez changed: What|Removed |Added Status|REPORTED|ASSIGNED Assignee|jsew...@acm.org