https://bugs.kde.org/show_bug.cgi?id=398649
Andreas Arnez changed:
What|Removed |Added
CC||ar...@linux.ibm.com
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #73 from Andreas Arnez ---
Created attachment 115231
--> https://bugs.kde.org/attachment.cgi?id=115231=edit
Fixes based on Julian's comment #71
For reference, here's what I changed based on the comments above. I'll look
m
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #72 from Andreas Arnez ---
(In reply to Julian Seward from comment #71)
> Thank you for finishing this up. OK to land provided the stuff below
> is fixed (none of it is a big deal) and the test in the next para
> passe
https://bugs.kde.org/show_bug.cgi?id=385409
Andreas Arnez changed:
What|Removed |Added
Attachment #114206|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385409
Andreas Arnez changed:
What|Removed |Added
Attachment #114207|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=396839
Andreas Arnez changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution
https://bugs.kde.org/show_bug.cgi?id=396839
--- Comment #9 from Andreas Arnez ---
I've pushed this now as git commit 20976f432.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #66 from Andreas Arnez ---
(In reply to Mark Wielaard from comment #65)
> The answer to that is (it is actually 8 patches) and they should all be
> applied in order.
Correct.
> Should some of them be combined before being committed
https://bugs.kde.org/show_bug.cgi?id=396839
Andreas Arnez changed:
What|Removed |Added
Attachment #115146|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #63 from Andreas Arnez ---
(In reply to Julian Seward from comment #62)
> Yes. Good. That looks fine to me. Thank you for redoing it.
Great! Can the patches attached to this Bugzilla go upstream then?
--
You are receiving this m
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #61 from Andreas Arnez ---
Is this OK now?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=396839
--- Comment #4 from Andreas Arnez ---
Created attachment 115146
--> https://bugs.kde.org/attachment.cgi?id=115146=edit
Implement conditional trap instructions
This implements all conditional trap instructions, including the variants of
&q
https://bugs.kde.org/show_bug.cgi?id=385409
Andreas Arnez changed:
What|Removed |Added
Attachment #114932|0 |1
is obsolete
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #59 from Andreas Arnez ---
(In reply to Julian Seward from comment #58)
> * you use a construction "mkexpr(mktemp(type, expr))" which I am not
> sure what the purpose is. For expressions that will get used more
> th
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #57 from Andreas Arnez ---
Created attachment 114932
--> https://bugs.kde.org/attachment.cgi?id=114932=edit
Implement VLL with aligned loads
This fixes complaints from memcheck in cases where VLL is used for strlen,
strcpy,
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #56 from Andreas Arnez ---
(In reply to Julian Seward from comment #54)
> [...]
> Memcheck's "partial-loads-OK" heuristic, which is now enabled by default,
> should remove these complaints. So the question is,
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #51 from Andreas Arnez ---
Created attachment 114453
--> https://bugs.kde.org/attachment.cgi?id=114453=edit
Fix vector register move insns
This fixes the internal error I've mentioned in comment #50.
--
You are receiving this m
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #50 from Andreas Arnez ---
Vadim, thanks for the reworks of VLL and VFENE. These help quite considerably,
and the false positives we've seen before are gone. Now I'm debugging an
internal error that seems related to the z13 patches
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #24 from Andreas Arnez ---
In the meantime I did some more testing, and one thing I found is that VFENE
also marks bytes in the input vectors beyond the zero-terminator as read. This
leads to lots of false positives with real workloads
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #23 from Andreas Arnez ---
Julian, is this OK now?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #22 from Andreas Arnez ---
Created attachment 114230
--> https://bugs.kde.org/attachment.cgi?id=114230=edit
Fix strict aliasing violation
This fix applies to Vadim's new version. It also undoes the change from
UChar[6] to ULong, beca
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #21 from Andreas Arnez ---
(In reply to Julian Seward from comment #20)
> To tell the truth, we have built with -fno-strict-aliasing for about a
> decade now :-/ But I still would prefer not to have such casti
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #18 from Andreas Arnez ---
(In reply to Julian Seward from comment #14)
> More likely is that there's some violation of C "defined behaviour"
> that the compiler is exploiting whilst optimising. Or some type
> err
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #10 from Andreas Arnez ---
Created attachment 114152
--> https://bugs.kde.org/attachment.cgi?id=114152=edit
Fix vector register number calculation
Independent from the vtm issue above, I noticed another problem with the
current vec
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #9 from Andreas Arnez ---
Created attachment 114150
--> https://bugs.kde.org/attachment.cgi?id=114150=edit
Test case diff with vtm failure
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #8 from Andreas Arnez ---
(In reply to Vadim Barkov from comment #7)
> Andreas,
>
> I can't reproduce you test results so I added tests for every possible
> result of VTM instruction. Could you apply patch from attachment 11414
https://bugs.kde.org/show_bug.cgi?id=385409
--- Comment #5 from Andreas Arnez ---
(In reply to Vadim Barkov from comment #4)
> Now this patch can be applied on master (on
> d44563c49e55f47016e23591f708c7aa57f7a098 or later commit)
Good! Tried the patch, and it looks good, with one exc
https://bugs.kde.org/show_bug.cgi?id=385412
Andreas Arnez changed:
What|Removed |Added
Resolution|--- |FIXED
Status|ASSIGNED
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #26 from Andreas Arnez ---
(In reply to Julian Seward from comment #25)
> Landed, d44563c49e55f47016e23591f708c7aa57f7a098. Andreas, could
> you please checkout and test, when convenient?
Sure, checked out and tested. As far as
https://bugs.kde.org/show_bug.cgi?id=396839
Bug ID: 396839
Summary: s390x: Trap instructions not implemented
Product: valgrind
Version: 3.14 SVN
Platform: unspecified
OS: Linux
Status: UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #21 from Andreas Arnez ---
(In reply to Julian Seward from comment #20)
> So let's just land this as-is :-/
Sounds good to me. As long as there are no false positives, this should be OK
for now. And even that may not be too criti
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #12 from Andreas Arnez ---
> > Julian,
> > Could you review and merge it?
>
> Julian, can we merge this now?
Ping?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #11 from Andreas Arnez ---
(In reply to Vadim Barkov from comment #10)
> Andreas,
>
> I fixed the PPNO implementation so the tests are memcheck clean. I think
> it's ready to merge.
Thanks!
> Julian,
> Could yo
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #7 from Andreas Arnez <ar...@linux.ibm.com> ---
Julian, if you don't have any further comments, I think we can push this
(including my cleanup). I wouldn't hold up the item just because PPNO is
potentially not memcheck-clean. If nec
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #6 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
Created attachment 110849
--> https://bugs.kde.org/attachment.cgi?id=110849=edit
s390x tests: formatting fixes for z13.c
--
You are receiving this mail because:
You are wat
https://bugs.kde.org/show_bug.cgi?id=385412
--- Comment #5 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Vadim Barkov from comment #4)
> Created attachment 110203 [details]
> Non-vector z13 support
Looks mostly OK to me. One thing I noticed is that the "z13
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #26 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Vadim Barkov from comment #23)
> Is the current patch okay? Could you merge it or tell me what's wrong with
> it please?
For the record, I didn't find any furt
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #12 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Vadim Barkov from comment #10)
> Created attachment 108579 [details]
> Initial vector support (chapter 21) (remastered)
>
> Changes:
> - Removed ALL
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #9 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Julian Seward from comment #8)
> This patch will need some further work before it is reviewable.
> Right now it is so huge and difficult to follow that I have no
https://bugs.kde.org/show_bug.cgi?id=385408
--- Comment #5 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Vadim Barkov from comment #3)
> The adding of -march=z13 to CFLAGS isn't good aproach however it's the only
> way to compile condition code helpers
https://bugs.kde.org/show_bug.cgi?id=385408
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks|366413 |
Reference
https://bugs.kde.org/show_bug.cgi?id=385411
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks|366413 |
Reference
https://bugs.kde.org/show_bug.cgi?id=385412
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks|366413 |
Reference
https://bugs.kde.org/show_bug.cgi?id=385410
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks|366413 |
Reference
https://bugs.kde.org/show_bug.cgi?id=366413
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Depends on|385408, 385409,
https://bugs.kde.org/show_bug.cgi?id=385409
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks|366413 |
Reference
https://bugs.kde.org/show_bug.cgi?id=385412
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks||366413
Refe
https://bugs.kde.org/show_bug.cgi?id=385410
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks||366413
Refe
https://bugs.kde.org/show_bug.cgi?id=385408
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks||366413
Refe
https://bugs.kde.org/show_bug.cgi?id=385409
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks||366413
Refe
https://bugs.kde.org/show_bug.cgi?id=385411
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Blocks||366413
Refe
https://bugs.kde.org/show_bug.cgi?id=366413
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Depends on||385408,
https://bugs.kde.org/show_bug.cgi?id=385412
Bug ID: 385412
Summary: s390x: new non-vector z13 instructions not implemented
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=385411
Bug ID: 385411
Summary: s390x: z13 vector floating-point instructions not
implemented
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=385410
Bug ID: 385410
Summary: s390x: z13 vector string instructions not implemented
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=385409
Bug ID: 385409
Summary: s390x: z13 vector integer instructions not implemented
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
Status: UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=385408
Bug ID: 385408
Summary: s390x: z13 vector "support" instructions not
implemented
Product: valgrind
Version: unspecified
Platform: Other
OS: Linux
https://bugs.kde.org/show_bug.cgi?id=380397
--- Comment #3 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Ivo Raisr from comment #1)
> Seems like a simple wrapper for "__strcspn_c" would suffice in
> shared/vg_replace_strmem.c.
>
> Would you please t
https://bugs.kde.org/show_bug.cgi?id=380397
Bug ID: 380397
Summary: s390x: False-positive "invalid read" for strtok()
Product: valgrind
Version: 3.13 SVN
Platform: Other
OS: Linux
Status: UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=366413
--- Comment #8 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Ivo Raisr from comment #7)
> Andreas, what is the current status here?
I still haven't started working on this. And it seems that nobody has picked
it up either.
https://bugs.kde.org/show_bug.cgi?id=366413
--- Comment #6 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to neverscaired from comment #4)
> Is anyone work on this issue?
Currently I am *not* working on this issue, but I plan to start soon, if nobody
else picks it up.
https://bugs.kde.org/show_bug.cgi?id=369439
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Attachment #101320|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=369439
--- Comment #1 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
Created attachment 101320
--> https://bugs.kde.org/attachment.cgi?id=101320=edit
Support LDE/LDER, and RISBHG/RISBLG
This patch adds support for the missing instructions. In
https://bugs.kde.org/show_bug.cgi?id=369439
Bug ID: 369439
Summary: S390x: Unhandled insns RISBLG/RISBHG and LDE/LDER
Product: valgrind
Version: 3.12 SVN
Platform: Other
OS: Linux
Status: UNCONFIRMED
https://bugs.kde.org/show_bug.cgi?id=366413
--- Comment #2 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Zack Brdge from comment #1)
> Are there some specific KDE binaries, perhaps distributed with Debian s390x,
> that have the missing instructi
https://bugs.kde.org/show_bug.cgi?id=366413
Bug ID: 366413
Summary: s390x: New z13 instructions not implemented
Product: valgrind
Version: 3.12 SVN
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity:
https://bugs.kde.org/show_bug.cgi?id=361226
--- Comment #2 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Andreas Arnez from comment #1)
> Created attachment 98188 [details]
> Support RISBGN
Is this OK?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361226
--- Comment #1 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
Created attachment 98188
--> https://bugs.kde.org/attachment.cgi?id=98188=edit
Support RISBGN
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=303877
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
CC|
https://bugs.kde.org/show_bug.cgi?id=361226
Bug ID: 361226
Summary: s390x: risbgn (EC59) not implemented
Product: valgrind
Version: 3.12 SVN
Platform: Other
OS: Linux
Status: UNCONFIRMED
Severity: normal
https://bugs.kde.org/show_bug.cgi?id=359289
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
Attachment #97264|0 |1
is ob
https://bugs.kde.org/show_bug.cgi?id=359289
--- Comment #4 from Andreas Arnez <ar...@linux.vnet.ibm.com> ---
(In reply to Florian Krohm from comment #3)
> Thanks for the patch.
> As Mark said: none/tests/s390x/Makefile.am needs adjustment. Otherwise the
> popcnt test does not g
https://bugs.kde.org/show_bug.cgi?id=359289
Andreas Arnez <ar...@linux.vnet.ibm.com> changed:
What|Removed |Added
CC|
201 - 273 of 273 matches
Mail list logo
