[frameworks-kio] [Bug 375610] Dolphin doesn't correctly show directories on a ftp server
https://bugs.kde.org/show_bug.cgi?id=375610 --- Comment #3 from David Faure <fa...@kde.org> --- For reference: https://git.reviewboard.kde.org/r/129905/ (thanks!) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 375610] Dolphin doesn't correctly show directories on a ftp server
https://bugs.kde.org/show_bug.cgi?id=375610 David Faure <fa...@kde.org> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #2 from David Faure <fa...@kde.org> --- Nice, thanks for the patch. https://git.reviewboard.de.org is a better tool for getting patches reviewed though. I would like at least a comment that contains one of the lines that you show in this bug report, so someone can understand (and possibly modify) the parsing code even if the FTP site you mention no longer exists. (yes we should have done that for the other cases too...) The patch looks good otherwise (man we really should have some unittests for this parsing code, to make sure changes don't break anything...). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 375610] Dolphin doesn't correctly show directories on a ftp server
https://bugs.kde.org/show_bug.cgi?id=375610 David Faure <fa...@kde.org> changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kio ||/b158255bd590eb333e22526614 ||b1a72611402b6a Version Fixed In||5.31 Resolution|--- |FIXED --- Comment #4 from David Faure <fa...@kde.org> --- Git commit b158255bd590eb333e22526614b1a72611402b6a by David Faure, on behalf of Marco Scarpetta. Committed on 01/02/2017 at 11:25. Pushed by dfaure into branch 'master'. Fix parsing of directories listing on a specific ftp server Directories listing on ftp servers like ftp://ftp-dee.poliba.it/ are now parsed correctly. REVIEW: 129905 FIXED-IN: 5.31 M +13 -2src/ioslaves/ftp/ftp.cpp https://commits.kde.org/kio/b158255bd590eb333e22526614b1a72611402b6a -- You are receiving this mail because: You are watching all bug changes.
[kdepim] [Bug 358116] messageviewer leaks temporary files with mail parts in it
https://bugs.kde.org/show_bug.cgi?id=358116 David Faure <fa...@kde.org> changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 368999] Folders ending with a space in their name are not retrieved from Folder View
https://bugs.kde.org/show_bug.cgi?id=368999 --- Comment #3 from David Faure <fa...@kde.org> --- https://codereview.qt-project.org/186246 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 368999] Folders ending with a space in their name are not retrieved from Folder View
https://bugs.kde.org/show_bug.cgi?id=368999 David Faure <fa...@kde.org> changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |UPSTREAM --- Comment #4 from David Faure <fa...@kde.org> --- The fix is in (for Qt 5.8.1 if there's one, otherwise 5.9) -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 376589] Layout destroyed after clicking link with HiDPI
https://bugs.kde.org/show_bug.cgi?id=376589 David Faure <fa...@kde.org> changed: What|Removed |Added CC||fa...@kde.org Resolution|--- |UPSTREAM Status|UNCONFIRMED |RESOLVED --- Comment #3 from David Faure <fa...@kde.org> --- I was able to reproduce the same bug in webengine's demobrowser, so it's a Qt bug. https://bugreports.qt.io/browse/QTBUG-59017 -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 375956] Wrong mime type for the files with non-ascii characters
https://bugs.kde.org/show_bug.cgi?id=375956 David Faure <fa...@kde.org> changed: What|Removed |Added CC||fa...@kde.org --- Comment #5 from David Faure <fa...@kde.org> --- For the record, fixed in https://bugreports.qt.io/browse/QTBUG-58822 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kded] [Bug 371754] crash in qt_message_fatal
https://bugs.kde.org/show_bug.cgi?id=371754 --- Comment #3 from David Faure <fa...@kde.org> --- I saw the same error in https://bugs.kde.org/show_bug.cgi?id=358813, which said it happens after logout. Is it the case here as well? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 371721] slaveinterface.cpp do not compile under Centos 6.8
https://bugs.kde.org/show_bug.cgi?id=371721 --- Comment #3 from David Faure <fa...@kde.org> --- Would it be enough to #undef open in that header file? (and #undef stat in the test file) #defines are EVIL btw... -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 369276] KActionCollection, menu/action reuse and the native Mac menubar
https://bugs.kde.org/show_bug.cgi?id=369276 David Faure <fa...@kde.org> changed: What|Removed |Added Resolution|--- |UPSTREAM Status|UNCONFIRMED |RESOLVED CC||fa...@kde.org --- Comment #1 from David Faure <fa...@kde.org> --- The basic QAction concept is that you can add the same action to multiple widgets. If this doesn't work in some cases, it's a Qt bug, not a problem in KActionCollection (which is really just a container of qactions). => report this on the Qt bug tracker. Preferrably with an actual testcase. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kxmlgui] [Bug 369276] KActionCollection, menu/action reuse and the native Mac menubar
https://bugs.kde.org/show_bug.cgi?id=369276 --- Comment #3 from David Faure <fa...@kde.org> --- Amazing. So a QAction in both a toolbar and a menu in the native menubar is OK? Or as soon as a QAction is in a native menu (short for "menu in the native menubar") it can't be used anywhere else? This totally defeats the QAction concept, asking apps to create multiple QActions and keep them in sync. We're back to Qt 2 then... If you open a Qt bug report I can weigh in about how unacceptable this is ;) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 371721] slaveinterface.cpp do not compile under Centos 6.8
https://bugs.kde.org/show_bug.cgi?id=371721 David Faure <fa...@kde.org> changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 371721] slaveinterface.cpp do not compile under Centos 6.8
https://bugs.kde.org/show_bug.cgi?id=371721 --- Comment #14 from David Faure <fa...@kde.org> --- Wait. Something is really broken on CentOS 6.8 though, because according to http://ac-archive.sourceforge.net/largefile/glibc.html the #define open open64 should only happen when __REDIRECT is not set, and it should be set for gcc >= 2.x, see cdefs.h on that page. Can you check if your system headers match what that page says? I'm not pushing the #undef hacks after all, they shouldn't be needed. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 372005] [Patch] HTTP date format should be English and not follow user locale
https://bugs.kde.org/show_bug.cgi?id=372005 David Faure <fa...@kde.org> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED --- Comment #2 from David Faure <fa...@kde.org> --- Thanks for the patch. Indeed, I see the issue, and the fix works. For future patches you can use https://git.reviewboard.kde.org btw ;-) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 372005] [Patch] HTTP date format should be English and not follow user locale
https://bugs.kde.org/show_bug.cgi?id=372005 David Faure <fa...@kde.org> changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Latest Commit||http://commits.kde.org/kio/ ||64aff94b178b293f6695b16ffe0 ||0e6031700c15d Version Fixed In||5.28 --- Comment #3 from David Faure <fa...@kde.org> --- Git commit 64aff94b178b293f6695b16ffe00e6031700c15d by David Faure, on behalf of Daniel Aleksandersen. Committed on 05/11/2016 at 14:18. Pushed by dfaure into branch 'master'. Fix HTTP date format sent by kio_http to always use the C locale. * Must use English rather than the user’s locale. * Simplified implementation. FIXED-IN: 5.28 M +1-8src/ioslaves/http/http.cpp http://commits.kde.org/kio/64aff94b178b293f6695b16ffe00e6031700c15d -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kauth] [Bug 363200] [Kauth] - possibility to change the timeout of dbus.
https://bugs.kde.org/show_bug.cgi?id=363200 David Faure <fa...@kde.org> changed: What|Removed |Added CC||fa...@kde.org --- Comment #1 from David Faure <fa...@kde.org> --- https://git.reviewboard.kde.org/r/128902/ -- You are receiving this mail because: You are watching all bug changes.
[keditbookmarks] [Bug 372206] The split keditbookmarks repo doesn't contain a COPYING/LICENSE file
https://bugs.kde.org/show_bug.cgi?id=372206 --- Comment #2 from David Faure <fa...@kde.org> --- Sure, make it all consistent. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 371721] slaveinterface.cpp do not compile under Centos 6.8
https://bugs.kde.org/show_bug.cgi?id=371721 David Faure <fa...@kde.org> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED --- Comment #13 from David Faure <fa...@kde.org> --- The last two comments do no add any information :-) The #define comes from a system header, as I said, not from KIO's own sources. Actually, I can grep the internet instead... Yep: http://ac-archive.sourceforge.net/largefile/glibc.html https://git.busybox.net/uClibc/plain/include/fcntl.h both have "#define open open64", as I suspected. Horrible! But it's probably old news, since this hack was only for largefile support on 32 bit systems, so no "upstream" fix possible at this point. I'll push the #undef fix (into KF 5.28). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kded] [Bug 371754] crash in qt_message_fatal
https://bugs.kde.org/show_bug.cgi?id=371754 --- Comment #5 from David Faure <fa...@kde.org> --- It's a crash in colord-kded (some color daemon installed as a kded module), please find where that comes from, it's not a kded bug. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 354954] Shortcut Ctrl-Shift-S defined twice by default
https://bugs.kde.org/show_bug.cgi?id=354954 --- Comment #4 from David Faure <fa...@kde.org> --- OK never mind my comment (apart from the grep result ;). Achim is right, the conflict is probably with "Save As". Some actions already have a shortcut context. Otherwise Ctrl+Shift+O would conflict after splitting too, and it doesn't, so that's not it. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 354954] Shortcut Ctrl-Shift-S defined twice by default
https://bugs.kde.org/show_bug.cgi?id=354954 David Faure <fa...@kde.org> changed: What|Removed |Added CC||fa...@kde.org --- Comment #3 from David Faure <fa...@kde.org> --- The shortcut is defined here: src/ViewManager.cpp:158: collection->setDefaultShortcut(closeActiveAction, Qt::CTRL + Qt::SHIFT + Qt::Key_S); Probably the two views conflict, each one having such an action. The usual solution is to set the shortcut context of the actions, something like action->setShortcutContext(Qt::WidgetShortcut); -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 349789] Local Folders Disappear when Last Search Deleted
https://bugs.kde.org/show_bug.cgi?id=349789 --- Comment #5 from David Faure <fa...@kde.org> --- Git commit e58d4813b9eb6125bad83cc4fd576d5d75d31c4b by David Faure. Committed on 28/10/2016 at 09:11. Pushed by dfaure into branch 'KDE/4.14'. KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out rowsRemoved signal Backported from e2a6886 in kitemmodels. If the row being removed from the source model isn't shown by KRFPM, it's correct that we don't need to emit any signals, however we still need to tell our base class QSFPM so that it updates the mappings of the visible siblings below that removed row. Testcase: deleting the Last Search folder in kmail (full integration test for this testcase will be added to mailcommon). REVIEW: 128428 M +0-26 kdeui/itemviews/krecursivefilterproxymodel.cpp M +3-1kdeui/tests/krecursivefilterproxymodeltest.cpp http://commits.kde.org/kdelibs/e58d4813b9eb6125bad83cc4fd576d5d75d31c4b -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 371721] slaveinterface.cpp do not compile under Centos 6.8
https://bugs.kde.org/show_bug.cgi?id=371721 --- Comment #6 from David Faure <fa...@kde.org> --- Comment on attachment 101889 --> https://bugs.kde.org/attachment.cgi?id=101889 new patch based on #undef Thanks. Can you try something else? If you remove #include from slaveinterface.h, does that fix the error in slaveinterface.h ? This include isn't necessary and seems to bring in what is causing the problem. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 371721] slaveinterface.cpp do not compile under Centos 6.8
https://bugs.kde.org/show_bug.cgi?id=371721 --- Comment #7 from David Faure <fa...@kde.org> --- (which would explain why it only happens there -- mostly only KIO code uses qplatformdefs.h) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 371721] slaveinterface.cpp do not compile under Centos 6.8
https://bugs.kde.org/show_bug.cgi?id=371721 --- Comment #10 from David Faure <fa...@kde.org> --- Note that it wouldn't fix both instances, only the one in moc_slaveinterface.cpp. You must have a #define open open64 somewhere in a system header. Any chance you could use gcc -E or grep -r to find out where this happens? IMHO that's a bug in that system header. I'm not fully opposed to committing a workaround, but it's still good to find the heart of the issue as well. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kservice] [Bug 371885] kservice-5.27.0: fails to build with flex-2.6.2
https://bugs.kde.org/show_bug.cgi?id=371885 --- Comment #1 from David Faure <fa...@kde.org> --- So why not report this to the flex authors? ;-) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kded] [Bug 371890] kded5 always crashes when running screenfetch
https://bugs.kde.org/show_bug.cgi?id=371890 --- Comment #1 from David Faure <fa...@kde.org> --- `kded5 --version` crashes for you, in QtDBus, due to the early exit. I have seen this in the past, it was a bug in Qt, and I'm pretty sure it's fixed now. What's your Qt version? Can you try upgrading Qt? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kded] [Bug 371754] crash in qt_message_fatal
https://bugs.kde.org/show_bug.cgi?id=371754 David Faure <fa...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from David Faure <fa...@kde.org> --- *** This bug has been marked as a duplicate of bug 359677 *** -- You are receiving this mail because: You are watching all bug changes.
[colord-kde] [Bug 359677] colord causes crashes in kdeinit5 and kded5 in a Wayland session
https://bugs.kde.org/show_bug.cgi?id=359677 --- Comment #5 from David Faure <fa...@kde.org> --- *** Bug 371754 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kontact] [Bug 361714] Kontact/Korganizer crashes when changing email link
https://bugs.kde.org/show_bug.cgi?id=361714 David Faure <fa...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||fa...@kde.org Resolution|--- |DUPLICATE --- Comment #2 from David Faure <fa...@kde.org> --- *** This bug has been marked as a duplicate of bug 361664 *** -- You are receiving this mail because: You are watching all bug changes.
[kontact] [Bug 361664] Korganizer Crashes Kontact when refreshing Google Calendars
https://bugs.kde.org/show_bug.cgi?id=361664 --- Comment #1 from David Faure <fa...@kde.org> --- *** Bug 361714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kdelibs] [Bug 294005] Infinite loop in KSelectionProxyModel's _getRootListRow()
https://bugs.kde.org/show_bug.cgi?id=294005 David Faure <fa...@kde.org> changed: What|Removed |Added CC||fa...@kde.org Assignee|kdelibs-b...@kde.org|steve...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[kontact] [Bug 357299] kmail crashes during some curious activity done simultaneously in all folders above the one I moved a message into
https://bugs.kde.org/show_bug.cgi?id=357299 David Faure <fa...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||fa...@kde.org Resolution|--- |DUPLICATE --- Comment #1 from David Faure <fa...@kde.org> --- *** This bug has been marked as a duplicate of bug 344228 *** -- You are receiving this mail because: You are watching all bug changes.
[kontact] [Bug 344228] Kontact crashed when adding SMTP server
https://bugs.kde.org/show_bug.cgi?id=344228 David Faure <fa...@kde.org> changed: What|Removed |Added CC||michael.brach@uni-muenster. ||de --- Comment #1 from David Faure <fa...@kde.org> --- *** Bug 357299 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 350018] Can't launch position independent executables
https://bugs.kde.org/show_bug.cgi?id=350018 David Faure <fa...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |UPSTREAM --- Comment #2 from David Faure <fa...@kde.org> --- This is https://bugs.freedesktop.org/show_bug.cgi?id=97226 -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 346754] File association for *.asc files not working
https://bugs.kde.org/show_bug.cgi?id=346754 David Faure <fa...@kde.org> changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #9 from David Faure <fa...@kde.org> --- The Qt fix went in. -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 329983] Possibly wrong locale selected for testtrash
https://bugs.kde.org/show_bug.cgi?id=329983 David Faure <fa...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kio ||/459411055bb1236caf5d25d83f ||d4a62a58279fce Resolution|--- |FIXED --- Comment #1 from David Faure <fa...@kde.org> --- Git commit 459411055bb1236caf5d25d83fd4a62a58279fce by David Faure. Committed on 14/01/2017 at 12:59. Pushed by dfaure into branch 'master'. Use C rather than en_US so that the locale doesn't have to be installed M +1-1src/ioslaves/trash/tests/testtrash.cpp https://commits.kde.org/kio/459411055bb1236caf5d25d83fd4a62a58279fce -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 374224] KFileDialog Options drop-down menu grabs keyboard and mouse with QtCurve style
https://bugs.kde.org/show_bug.cgi?id=374224 --- Comment #5 from David Faure <fa...@kde.org> --- Over my dead body ;-) This needs debugging, and it sounds like the bug is in QtCurve itself, if it doesn't happen with other widget styles. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 360487] Changing "Points to" of a symlink leads to error
https://bugs.kde.org/show_bug.cgi?id=360487 --- Comment #2 from David Faure <fa...@kde.org> --- Git commit fd1c158cb829ede6beb0d7f37f40e2cdfbd6280f by David Faure. Committed on 01/01/2017 at 11:22. Pushed by dfaure into branch 'master'. Add unittests for KIO::symlink, including the case of Overwrite. All tests pass, with file:/// URLs. Clearly bug 360487 is related to desktop: URLs. M +62 -0autotests/jobtest.cpp M +1-0autotests/jobtest.h https://commits.kde.org/kio/fd1c158cb829ede6beb0d7f37f40e2cdfbd6280f -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 360487] Changing "Points to" of a symlink leads to error
https://bugs.kde.org/show_bug.cgi?id=360487 David Faure <fa...@kde.org> changed: What|Removed |Added Version Fixed In||5.30 Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kio ||/7f2abde5cb036b8b500aaff458 ||86368ca295e24f Resolution|--- |FIXED --- Comment #3 from David Faure <fa...@kde.org> --- Git commit 7f2abde5cb036b8b500aaff45886368ca295e24f by David Faure. Committed on 01/01/2017 at 12:16. Pushed by dfaure into branch 'master'. ForwardingSlaveBase: fix passing of Overwrite flag to kio_desktop Unittest will be committed to plasma-workspace/kioslave/desktop later. FIXED-IN: 5.30 M +1-1src/core/forwardingslavebase.cpp https://commits.kde.org/kio/7f2abde5cb036b8b500aaff45886368ca295e24f -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 360487] Changing "Points to" of a symlink leads to error
https://bugs.kde.org/show_bug.cgi?id=360487 --- Comment #4 from David Faure <fa...@kde.org> --- Git commit a4339386671b8dba0a8711e57a9398f98f44a147 by David Faure. Committed on 01/01/2017 at 12:37. Pushed by dfaure into branch 'master'. Add unittest for bug 360487 M +34 -0kioslave/desktop/tests/kio_desktop_test.cpp https://commits.kde.org/plasma-workspace/a4339386671b8dba0a8711e57a9398f98f44a147 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 342763] Crash In Task Manager Item Changed
https://bugs.kde.org/show_bug.cgi?id=342763 --- Comment #270 from David Faure <fa...@kde.org> --- We are fixing bugs in layoutChanged() of various proxymodels right now in Qt. Maybe this will fix this. Maybe not. I don't know how the QtQuick code enters the picture. But someone who compiles Qt 5.8 from git and who can easily reproduce this crash, could try to apply these commits to Qt and see if they help. https://codereview.qt-project.org/180249 https://codereview.qt-project.org/180389 https://codereview.qt-project.org/180390 In fact they are being staged right now for the first time, so with a bit of luck they'll be in qtbase.git in week or so :-) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kded] [Bug 372904] kded5 maxing one CPU core after search performed in Dolphin
https://bugs.kde.org/show_bug.cgi?id=372904 David Faure <fa...@kde.org> changed: What|Removed |Added Assignee|fa...@kde.org |bvb...@abv.bg --- Comment #4 from David Faure <fa...@kde.org> --- This is all known, see https://git.reviewboard.kde.org/r/129394/ -- You are receiving this mail because: You are watching all bug changes.
[konqueror] [Bug 373824] Konqueror 16.12 is missing the sidebar
https://bugs.kde.org/show_bug.cgi?id=373824 --- Comment #3 from David Faure <fa...@kde.org> --- The sidebar was still using Qt3Support (which doesn't exist in Qt5), and was full of cruft, I had to kill it. Dolphin is the file manager with a file-management sidebar. I mostly see konqueror as a universal browser now (web, pdf, etc.). This part isn't open to debate unless someone steps up to maintain the file-management parts of it, I won't. History is indeed missing, we'll have to find another way to visualize it. Bookmarks are in the menu and in keditbookmarks, is a third view useful? Firefox has pretty much the same two views, right? (popup menu and full tree). I won't work on a bookmarks sidebar in any case, I loved writing keditbookmarks but I don't actually use bookmarks myself - I memorize URLs instead ;-) On the other hand I want firefox-like completion in the location bar. PS: "the developers" (plural) is wishful thinking. Konqueror has 0.01 developer right now (me, with a very low priority for konqueror). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 374196] Build failure on compiling kio_trash
https://bugs.kde.org/show_bug.cgi?id=374196 --- Comment #8 from David Faure <fa...@kde.org> --- Oh I see, none of the "common" files are used on Windows. The var name is misnamed and confusing. I'll rename and revert. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 374196] Build failure on compiling kio_trash
https://bugs.kde.org/show_bug.cgi?id=374196 --- Comment #9 from David Faure <fa...@kde.org> --- Git commit ccb616e73292f97b3b22fea3c42fda24b5aff08e by David Faure. Committed on 28/12/2016 at 12:51. Pushed by dfaure into branch 'master'. Revert 76f89c4, and remove some confusion about what this var is for by renaming+moving it. M +10 -10 src/ioslaves/trash/CMakeLists.txt https://commits.kde.org/kio/ccb616e73292f97b3b22fea3c42fda24b5aff08e -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 374196] Build failure on compiling kio_trash
https://bugs.kde.org/show_bug.cgi?id=374196 --- Comment #6 from David Faure <fa...@kde.org> --- Try including -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 286041] Dolphin should keep time-stamps of file copies
https://bugs.kde.org/show_bug.cgi?id=286041 --- Comment #5 from David Faure <fa...@kde.org> --- So this problem is specific to NTFS mounts, right? Does `cp -a` preserve the modification time? Which Unix UID do the copied file get? If it's not the same as your UID then changing the mtime might not be possible. -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 286041] Dolphin should keep time-stamps of file copies onto NTFS partitions
https://bugs.kde.org/show_bug.cgi?id=286041 David Faure <fa...@kde.org> changed: What|Removed |Added Summary|Dolphin should keep |Dolphin should keep |time-stamps of file copies |time-stamps of file copies ||onto NTFS partitions -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 332461] Dragging file from trash to desktop leaves file with read-only permissions
https://bugs.kde.org/show_bug.cgi?id=332461 David Faure <fa...@kde.org> changed: What|Removed |Added Resolution|--- |WORKSFORME Status|CONFIRMED |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 346754] File association for *.asc files not working
https://bugs.kde.org/show_bug.cgi?id=346754 David Faure <fa...@kde.org> changed: What|Removed |Added Resolution|UPSTREAM|--- Ever confirmed|0 |1 Status|RESOLVED|REOPENED --- Comment #7 from David Faure <fa...@kde.org> --- I was wrong, the bug is in my QMimeDatabase code. Reopening. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 374196] Build failure on compiling kssld
https://bugs.kde.org/show_bug.cgi?id=374196 --- Comment #2 from David Faure <fa...@kde.org> --- Git commit 76f89c46d8645eec53795b26f1af7d669cea2c50 by David Faure. Committed on 27/12/2016 at 17:56. Pushed by dfaure into branch 'master'. Fix CMakeLists.txt for windows, blindly, since the windows guys report bugs instead of committing fixes ;-) M +1-1src/ioslaves/trash/CMakeLists.txt https://commits.kde.org/kio/76f89c46d8645eec53795b26f1af7d669cea2c50 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 374196] Build failure on compiling kssld
https://bugs.kde.org/show_bug.cgi?id=374196 --- Comment #1 from David Faure <fa...@kde.org> --- Is this with -j or something? kssld has nothing to do with kio_trash. As to the kio_trash_win.cpp error, isn't there a kiotrashdebug.h in the same source dir? Is -I. missing somehow? Hmm I do spot an error in the CMakeLists.txt though... -- You are receiving this mail because: You are watching all bug changes.
[konqueror] [Bug 373824] Konqueror 16.12 is missing the sidebar
https://bugs.kde.org/show_bug.cgi?id=373824 --- Comment #8 from David Faure <fa...@kde.org> --- The code is actually still there in the konqueror git repo. `git clone git://anongit.kde.org/konqueror` if you don't have a KDE identity account. I'm not convinced that the current sidebar is the best solution for the long term though, nor that there really are extensions/plugins available for it, what did you have in mind? -- You are receiving this mail because: You are watching all bug changes.
[KScreen] [Bug 374064] KDED keeps crashing when RDP into a fresh Ubuntu 14.05 installation with xrdp and kubuntu-desktop
https://bugs.kde.org/show_bug.cgi?id=374064 David Faure <fa...@kde.org> changed: What|Removed |Added Assignee|fa...@kde.org |se...@kde.org Version|5.27.0 |1.0.5 Component|general |libkscreen Product|frameworks-kded |KScreen --- Comment #1 from David Faure <fa...@kde.org> --- The "14" in Ubuntu 14 means 2014, it's not *that* fresh... Anyhow, reassigning to kscreen. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 373658] KDEInit could not launch 'konsole'
https://bugs.kde.org/show_bug.cgi?id=373658 --- Comment #14 from David Faure <fa...@kde.org> --- `konsole -qwindowtitle foo` actually works, and I suppose this feature is useful by showing in the konsole window title, which app it's running. The best fix might be to add support for -caption to konsole, if we want to support KDE4 and KF5 konsoles and to keep the feature. -- You are receiving this mail because: You are watching all bug changes.
[umbrello] [Bug 373932] Fix KF5 issues
https://bugs.kde.org/show_bug.cgi?id=373932 Bug 373932 depends on bug 374166, which changed state. Bug 374166 Summary: build failure on compiling kio_trash https://bugs.kde.org/show_bug.cgi?id=374166 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 374166] build failure on compiling kio_trash
https://bugs.kde.org/show_bug.cgi?id=374166 David Faure <fa...@kde.org> changed: What|Removed |Added Latest Commit||https://commits.kde.org/kio ||/bd9d605f5f4f6f41b9d1ba3b48 ||8bd706505e5dad Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #1 from David Faure <fa...@kde.org> --- Git commit bd9d605f5f4f6f41b9d1ba3b488bd706505e5dad by David Faure. Committed on 26/12/2016 at 17:41. Pushed by dfaure into branch 'master'. add missing include, to hopefully fix compilation on Windows M +1-1src/ioslaves/trash/kio_trash_win.cpp https://commits.kde.org/kio/bd9d605f5f4f6f41b9d1ba3b488bd706505e5dad -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 346754] File association for *.asc files not working
https://bugs.kde.org/show_bug.cgi?id=346754 --- Comment #8 from David Faure <fa...@kde.org> --- Qt fix written, now awaiting review at https://codereview.qt-project.org/180842 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 377686] Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation
https://bugs.kde.org/show_bug.cgi?id=377686 --- Comment #1 from David Faure <fa...@kde.org> --- "Platform: All" is incorrect because on Unix, with the different libexec dir, there is no conflict. Is there any chance to consider a libexec that is not bin, on Windows, or to decide that libexec==bin means co-installing is not supported? -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 344099] KMail composer changes HTML format when replying to HTML mail
https://bugs.kde.org/show_bug.cgi?id=344099 David Faure <fa...@kde.org> changed: What|Removed |Added CC||fa...@kde.org --- Comment #1 from David Faure <fa...@kde.org> --- "why are there so many line brakes in the text/plain version of the email" should finally be fixed with https://codereview.qt-project.org/191229 -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 377678] KMail header not showing attachment
https://bugs.kde.org/show_bug.cgi?id=377678 David Faure <fa...@kde.org> changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||17.04 Latest Commit||https://commits.kde.org/mes ||sagelib/37b992574c9c36e65fa ||38d241459b856900fe413 Status|UNCONFIRMED |RESOLVED --- Comment #2 from David Faure <fa...@kde.org> --- Git commit 37b992574c9c36e65fa38d241459b856900fe413 by David Faure. Committed on 09/04/2017 at 17:46. Pushed by dfaure into branch 'Applications/17.04'. Rework timing of script injection for showing attachments in message viewer. It was sometimes executed too early, before the script that defines qt.jQuery. FIXED-IN: 17.04 M +11 -8messageviewer/src/viewer/viewer_p.cpp M +17 -10 messageviewer/src/viewer/webengine/mailwebenginescript.cpp M +0-9messageviewer/src/viewer/webengine/mailwebengineview.cpp M +0-1messageviewer/src/viewer/webengine/mailwebengineview.h M +2-2 messageviewer/src/viewer/webengine/tests/testjquerysupportmailwebengine.js M +1-1webengineviewer/src/webenginepage.cpp M +1-3webengineviewer/src/webengineview.cpp https://commits.kde.org/messagelib/37b992574c9c36e65fa38d241459b856900fe413 -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 376589] Layout destroyed after clicking link with HiDPI
https://bugs.kde.org/show_bug.cgi?id=376589 --- Comment #4 from David Faure <fa...@kde.org> --- Note: if `kcmshell5 componentchooser` says the webbrowser is firefox, the bug doesn't happen. If OTOH it says "based on the contents of the URL" (i.e. KMail uses KIO), then the bug happens. That's a workaround for now, and an indication that something in KIO is triggering it. -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 183875] kmail keeps spawning "gpgsm --server" but never kills/reaps them
https://bugs.kde.org/show_bug.cgi?id=183875 David Faure <fa...@kde.org> changed: What|Removed |Added Status|REOPENED|ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 183875] kmail keeps spawning "gpgsm --server" but never kills/reaps them
https://bugs.kde.org/show_bug.cgi?id=183875 David Faure <fa...@kde.org> changed: What|Removed |Added Assignee|kdepim-b...@kde.org |fa...@kde.org CC||fa...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 183875] kmail keeps spawning "gpgsm --server" but never kills/reaps them
https://bugs.kde.org/show_bug.cgi?id=183875 David Faure <fa...@kde.org> changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Version Fixed In||17.04 Latest Commit||https://commits.kde.org/mes ||sagelib/14728b61a24f29afc2b ||3f8b86c26b410fdc27a0c --- Comment #8 from David Faure <fa...@kde.org> --- Git commit 14728b61a24f29afc2b3f8b86c26b410fdc27a0c by David Faure. Committed on 03/04/2017 at 07:00. Pushed by dfaure into branch 'Applications/17.04'. Fix gpgsm processes being leaked due to QGpgME::KeyListJob not being deleted FIXED-IN: 17.04 M +2-1mimetreeparser/src/viewer/messagepart.cpp https://commits.kde.org/messagelib/14728b61a24f29afc2b3f8b86c26b410fdc27a0c -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 376365] KFileWidget does not support : in filenames
https://bugs.kde.org/show_bug.cgi?id=376365 --- Comment #6 from David Faure <fa...@kde.org> --- Oh, indeed, I hadn't seen that. I completely agree, the same API with a QString can't be for relative paths and for URLs, "a:b" is both. How about we add a KFileWidget::setSelectedUrl(const QUrl& url)? Then we can get rid of this ugly .toString() (QUrl -> QString -> QUrl). -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 377165] Looks like KIO wasn't tested when samba is installed but not started and fills logs with error messages
https://bugs.kde.org/show_bug.cgi?id=377165 --- Comment #1 from David Faure <fa...@kde.org> --- What happens on your system when you run the command `net usershare info` in a terminal? What is printed? If you could redirect it to a file and attach it here that would be even better ;) Thanks. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 377144] Make folder dialog maximizes to dolphin window
https://bugs.kde.org/show_bug.cgi?id=377144 --- Comment #3 from David Faure <fa...@kde.org> --- Cannot reproduce this either, not even the dialog remembering its size. The code is a QDialog created in KNewFileMenu::createDirectory, and there is nothing there about saving/restoring size, it's supposed to come with the default size every time. Can you still reproduce the issue now that you resized the dialog? If so, can you test if it also happens in the english locale? (start `LANG=en_US.UTF-8 dolphin` in a terminal) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 376365] KFileWidget does not support : in filenames
https://bugs.kde.org/show_bug.cgi?id=376365 --- Comment #4 from David Faure <fa...@kde.org> --- Thanks for fixing the bug, it can be closed now, right? -- You are receiving this mail because: You are watching all bug changes.
[kio-extras] [Bug 376128] SMB://server/dir Timeout on Server server in Dolphin
https://bugs.kde.org/show_bug.cgi?id=376128 David Faure <fa...@kde.org> changed: What|Removed |Added Component|general |default Product|frameworks-kio |kio-extras Assignee|fa...@kde.org |plasma-de...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 377144] Make folder dialog maximizes to dolphin window
https://bugs.kde.org/show_bug.cgi?id=377144 --- Comment #5 from David Faure <fa...@kde.org> --- Comment on attachment 104365 --> https://bugs.kde.org/attachment.cgi?id=104365 Reproducing with enUS locale and closing Do you maybe have a KWin rule for Dolphin, which would unexpected apply to all its windows? Right click on Dolphin titlebar, More Actions, Special Application Settings... Have you ever seen this dialog before? Does it contain anything enabled? Check also "Special Window Settings" on both the dolphin mainwindow and the "create new folder" dialog. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 376365] KFileWidget does not support : in filenames
https://bugs.kde.org/show_bug.cgi?id=376365 --- Comment #9 from David Faure <fa...@kde.org> --- Git commit f49f34727ee68e8b86debc1e7bb24f113505f890 by David Faure. Committed on 08/03/2017 at 12:11. Pushed by dfaure into branch 'master'. Add KFileWidget::setSelectedUrl() Summary: It turns out that setSelection() cannot take both relative paths (filenames) and absolute URLs as input. "a:b" can be both, and URLs for files called "a#b" were handled wrongly. Reviewers: fvogt Reviewed By: fvogt Subscribers: fvogt, #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D4937 M +85 -6autotests/kfilewidgettest.cpp M +9-3src/filewidgets/kfilewidget.cpp M +23 -3src/filewidgets/kfilewidget.h https://commits.kde.org/kio/f49f34727ee68e8b86debc1e7bb24f113505f890 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 376365] KFileWidget does not support : in filenames
https://bugs.kde.org/show_bug.cgi?id=376365 --- Comment #8 from David Faure <fa...@kde.org> --- https://phabricator.kde.org/D4937 -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 238309] folder in recycle bin makes dolphin fill up /tmp dir
https://bugs.kde.org/show_bug.cgi?id=238309 David Faure <fa...@kde.org> changed: What|Removed |Added Resolution|BACKTRACE |--- Ever confirmed|0 |1 Status|NEEDSINFO |CONFIRMED --- Comment #9 from David Faure <fa...@kde.org> --- Changing status as requested. When you say "open trash: with dolphin", does the same problem happen if you just type "trash:" in the dolphin location bar, rather than clicking on a desktop icon? My hypothesis would be that the desktop icon is misconfigured (missing %u in the Exec line). -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 208625] Temporary files (for previewing files in the trash or remote files) aren't deleted
https://bugs.kde.org/show_bug.cgi?id=208625 David Faure <fa...@kde.org> changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED Resolution|WAITINGFORINFO |--- --- Comment #39 from David Faure <fa...@kde.org> --- Oops, no, it definitely doesn't. Well done, that's the issue. This code was written at the time where only files were getting previewed. Now it's getting triggered for entire directories too. I'm not sure we want that -at all- for non-local directories (trash is non local too, the way it's implemented). There's a choice between two possible fixes here: - properly removing temp dirs - skipping dirs for previews -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 238309] folder in recycle bin makes dolphin fill up /tmp dir
https://bugs.kde.org/show_bug.cgi?id=238309 David Faure <fa...@kde.org> changed: What|Removed |Added Resolution|--- |DUPLICATE Status|CONFIRMED |RESOLVED --- Comment #10 from David Faure <fa...@kde.org> --- OK this is about previews, not about the way to open trash. Same bug as bug 208625. *** This bug has been marked as a duplicate of bug 208625 *** -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 208625] Dolphins temporary files aren't deleted
https://bugs.kde.org/show_bug.cgi?id=208625 David Faure <fa...@kde.org> changed: What|Removed |Added CC||karl.r.er...@gmail.com --- Comment #35 from David Faure <fa...@kde.org> --- *** Bug 238309 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 208625] Temporary files (for previewing remote files) aren't deleted
https://bugs.kde.org/show_bug.cgi?id=208625 David Faure <fa...@kde.org> changed: What|Removed |Added Summary|Dolphins temporary files|Temporary files (for |aren't deleted |previewing remote files) ||aren't deleted -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 377144] Make folder dialog maximizes to dolphin window
https://bugs.kde.org/show_bug.cgi?id=377144 David Faure <fa...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #7 from David Faure <fa...@kde.org> --- Well there's no bug then. If you ask kwin to make all windows from dolphin very large, then all windows from dolphin become very large. If you want this to apply only to mainwindows (not dialogs), refine your KWin rules. -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 208625] Dolphins temporary files aren't deleted
https://bugs.kde.org/show_bug.cgi?id=208625 David Faure <fa...@kde.org> changed: What|Removed |Added Status|CONFIRMED |NEEDSINFO Resolution|--- |WAITINGFORINFO --- Comment #34 from David Faure <fa...@kde.org> --- OK, let's see. First, trying to reproduce Alvaro's initial steps (with the path in step 1 adjusted for Kf5) : 1. rm /tmp/dolphin* 2. open dolphin and split the window 3. go to a remote machine via SFTP 4. copy a file from the remote machine to the local one (using drag-n-drop) I copied a 102 MB file and a 3.7 MB file and no temp file was created, not even during the copy. Then Dmitry's comment says it might be about previews, I tried enabling previews in the toolbar, works locally, no effect on sftp. This is because Dolphin's preferences dialog says "Skip previews for remote files over 0MB". If I change that to 10 MB, then indeed I get a preview of the image I uploaded - but still no dolphin temp file left over in /tmp. Now trying the same with trash:/, preview works, no temp file left over. Now looking at the code: there is a QTemporaryFile in KIO::PreviewJob, obviously, for remote files where the thumbnail plugin doesn't support KIO. But the temp file is deleted in the next step. KIO::PreviewJobPrivate::getOrCreateThumbnail: Using temp file "/tmp/dolphin.B12772" KIO::PreviewJob::slotResult: Deleting temp file "/tmp/dolphin.B12772" (additional debug output I just added) So a temp file leak would only happen if the first step happens but not the second step. Reading the code, I don't see how this can ever happen. There is no code path where we wouldn't get to the second step. The only course of action I can suggest is that someone who can reproduce the bug applies the patch below to their kio build and reports the results. http://www.davidfaure.fr/2017/previewjob.cpp.diff -- You are receiving this mail because: You are watching all bug changes.
[dolphin] [Bug 352975] dolphin from git master pollutes /tmp/ with dolphin.***** files
https://bugs.kde.org/show_bug.cgi?id=352975 David Faure <fa...@kde.org> changed: What|Removed |Added Resolution|--- |DUPLICATE CC||fa...@kde.org Status|UNCONFIRMED |RESOLVED --- Comment #2 from David Faure <fa...@kde.org> --- *** This bug has been marked as a duplicate of bug 208625 *** -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 272249] Hard spamming in /tmp when browsing the trash directory.
https://bugs.kde.org/show_bug.cgi?id=272249 David Faure <fa...@kde.org> changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC||fa...@kde.org Resolution|--- |DUPLICATE --- Comment #7 from David Faure <fa...@kde.org> --- *** This bug has been marked as a duplicate of bug 208625 *** -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 208625] Temporary files (for previewing remote files) aren't deleted
https://bugs.kde.org/show_bug.cgi?id=208625 David Faure <fa...@kde.org> changed: What|Removed |Added CC||m...@hussam.eu.org --- Comment #36 from David Faure <fa...@kde.org> --- *** Bug 352975 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 208625] Temporary files (for previewing remote files) aren't deleted
https://bugs.kde.org/show_bug.cgi?id=208625 David Faure <fa...@kde.org> changed: What|Removed |Added CC||vo.z...@gmail.com --- Comment #37 from David Faure <fa...@kde.org> --- *** Bug 272249 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kio] [Bug 208625] Temporary files (for previewing files in the trash or remote files) aren't deleted
https://bugs.kde.org/show_bug.cgi?id=208625 David Faure <fa...@kde.org> changed: What|Removed |Added Summary|Temporary files (for|Temporary files (for |previewing remote files)|previewing files in the |aren't deleted |trash or remote files) ||aren't deleted -- You are receiving this mail because: You are watching all bug changes.
[kdelibs] [Bug 183458] Numpad (keypad) keys not mapped correctly when setting Global Shortcuts
https://bugs.kde.org/show_bug.cgi?id=183458 David Faure <fa...@kde.org> changed: What|Removed |Added Status|ASSIGNED|RESOLVED Latest Commit||https://commits.kde.org/kgl ||obalaccel/2c20ddff034e4958b ||f0536ca91ae9e444955305d Resolution|--- |FIXED --- Comment #86 from David Faure <fa...@kde.org> --- Git commit 2c20ddff034e4958bf0536ca91ae9e444955305d by David Faure. Committed on 06/08/2017 at 21:38. Pushed by dfaure into branch 'master'. KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys Test Plan: the following global shortcuts were successfully tested: Ctrl+1, Ctrl+Num+1, Ctrl+Num+/, Ctrl+F1, Ctrl+& (implicit shift) Differential Revision: https://phabricator.kde.org/D6234 M +7-45 src/runtime/plugins/xcb/kglobalaccel_x11.cpp https://commits.kde.org/kglobalaccel/2c20ddff034e4958bf0536ca91ae9e444955305d -- You are receiving this mail because: You are watching all bug changes.
[kdelibs] [Bug 183458] Numpad (keypad) keys not mapped correctly when setting Global Shortcuts
https://bugs.kde.org/show_bug.cgi?id=183458 --- Comment #85 from David Faure <fa...@kde.org> --- Git commit 32526718eae99ccb594360627586eebdf793372b by David Faure. Committed on 11/08/2017 at 06:26. Pushed by dfaure into branch 'master'. KKeyServer: fix handling of KeypadModifier. Summary: This required adding a new method symXModXToKeyQt since symXToKeyQt (without modifier as input) has no way to find out whether to use XK_KP_1 or XK_1. For this reason symXToKeyQt is now deprecated. Includes a unittest for keyQtToSymX, keyQtToModX and symXModXToKeyQt. Test Plan: After porting kglobalaccel to KKeyServer::xcbKeyPressEventToQt, the following global shortcuts were successfully tested: Ctrl+1, Ctrl+Num+1, Ctrl+Num+/, Ctrl+F1, Ctrl+& (implicit shift) Reviewers: graesslin Subscribers: graesslin, #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D6233 M +1-0autotests/CMakeLists.txt A +79 -0autotests/kkeyserver_x11_unittest.cpp [License: LGPL (v2/3+eV)] M +96 -52 src/platforms/xcb/kkeyserver.cpp M +13 -1src/platforms/xcb/kkeyserver_x11.h https://commits.kde.org/kwindowsystem/32526718eae99ccb594360627586eebdf793372b -- You are receiving this mail because: You are watching all bug changes.
[konqueror] [Bug 377084] WebEnginePart does not render kio output (kio_help, kio_man, ...)
https://bugs.kde.org/show_bug.cgi?id=377084 David Faure <fa...@kde.org> changed: What|Removed |Added Assignee|konq-b...@kde.org |fa...@kde.org Status|UNCONFIRMED |ASSIGNED Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[konqueror] [Bug 377084] WebEnginePart does not render kio output (kio_help, kio_man, ...)
https://bugs.kde.org/show_bug.cgi?id=377084 David Faure <fa...@kde.org> changed: What|Removed |Added CC||fa...@kde.org Resolution|FIXED |--- Latest Commit|https://commits.kde.org/kon | |queror/8a5ef4d042f45668cf03 | |64f341f6abca007a85c8| Status|RESOLVED|UNCONFIRMED --- Comment #3 from David Faure <fa...@kde.org> --- I have a fix, but the link to file:/// stylesheets fail to load due to security checks in WebEngine. I submitted https://bugreports.qt.io/browse/QTBUG-61937 to possibly fix that, the alternative would be to embed the stylesheet into the HTML (and use data URLs for icons). I pushed my current work into a branch (since it redesigns the support for the about: page too, which now suffers from the same security issue). See branch webengine_streaming in konqueror.git. -- You are receiving this mail because: You are watching all bug changes.
[konqueror] [Bug 377084] WebEnginePart does not render kio output (kio_help, kio_man, ...)
https://bugs.kde.org/show_bug.cgi?id=377084 David Faure <fa...@kde.org> changed: What|Removed |Added Latest Commit||https://commits.kde.org/kon ||queror/8a5ef4d042f45668cf03 ||64f341f6abca007a85c8 Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #2 from David Faure <fa...@kde.org> --- Git commit 8a5ef4d042f45668cf0364f341f6abca007a85c8 by David Faure. Committed on 14/07/2017 at 14:41. Pushed by dfaure into branch 'webengine_streaming'. Add support again for man:, info: and other slaves which output HTML. using the newly added support for streaming data into WebEnginePart. M +10 -0src/konqview.cpp M +8-3webenginepart/src/webenginepage.cpp M +5-2webenginepart/src/webenginepart.cpp https://commits.kde.org/konqueror/8a5ef4d042f45668cf0364f341f6abca007a85c8 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kcoreaddons] [Bug 381583] potential crash in KDirWatch::~KDirWatch()
https://bugs.kde.org/show_bug.cgi?id=381583 --- Comment #2 from David Faure <fa...@kde.org> --- This patch looks fine, please push it. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 359233] Improve usability of "Open with > Other" file dialog
https://bugs.kde.org/show_bug.cgi?id=359233 --- Comment #9 from David Faure <fa...@kde.org> --- Git commit 0296b89714ce96b247322d9be09b387573d79193 by David Faure, on behalf of Simone Gaiarin. Committed on 15/07/2017 at 12:53. Pushed by dfaure into branch 'master'. Make advanced options of "open with" dialog collabsible and hidden by default The current "open with" dialog implementation does not follow the KDE principle "Simple by default, powerful when needed" for the following reasons: - The "run in terminal" and "keep terminal open" options are advanced options and should not be exposed by default - The primary goal of the dialog should be to select an application from the app tree, running command is an advanced feature My patch changes the behavior as follow: * Put the two options in a KCollapsibleComboBox collapsed by default * The user can expand it only if he needs to use a command line command Implementation details: - When the KCollapsibleComboBox is clicked it is expanded upward keeping the dialog size fixed and compressing the treeview, I'm not sure this is the best approach, but to make it expand downwards we need to fix the size of the dialog with setSizeConstraint(QLayout::SetFixedSize); which may not be desiderable. Maybe there is a way to keep the dialog resizable and expand the combobox downwards, but I couldn't find it. - I've increased the vertical size of the dialog (which I think it was too small) also to accomodate the upward expansion which otherwise would make the app tree almost disappear Relevant discussions: https://forum.kde.org/viewtopic.php?f=285=131014 REVIEW: 130180 M +24 -11 src/widgets/kopenwithdialog.cpp https://commits.kde.org/kio/0296b89714ce96b247322d9be09b387573d79193 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 382341] Target Url not updated after renaming a desktop file in folder mode
https://bugs.kde.org/show_bug.cgi?id=382341 --- Comment #4 from David Faure <fa...@kde.org> --- Confirmed; thanks for the debugging. The thing is, shortly after KCoreDirLister::slotFileRenamed is called, desktopnotifier also triggers a full re-listing via KDirNotify::FilesAdded which calls KCoreDirLister::updateDirectory. That's when the dirlister should notice that the target URL of the item has changed. But it failed to do so because KFileItem::cmp() ignores UDS_LOCAL_PATH and UDS_TARGET_URL. Adding that fixes the bug. I'll work on a unittest and then commit that. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 382341] Target Url not updated after renaming a desktop file in folder mode
https://bugs.kde.org/show_bug.cgi?id=382341 David Faure <fa...@kde.org> changed: What|Removed |Added Latest Commit||https://commits.kde.org/kio ||/1449ecf136b5d170cb7c66e62a ||302bb9e9df164b Resolution|--- |FIXED Version Fixed In||5.37 Status|CONFIRMED |RESOLVED --- Comment #5 from David Faure <fa...@kde.org> --- Git commit 1449ecf136b5d170cb7c66e62a302bb9e9df164b by David Faure. Committed on 22/07/2017 at 06:52. Pushed by dfaure into branch 'master'. Ensure KDirLister updates items whose target URL has changed. This fixes the bug where renaming a desktop icon would not update its target URL, so clicking on it would try to open the old file. The tricky bit in all this is that first KCoreDirLister::slotFileRenamed is called, which updates the item's name (and local path), but then later on desktopnotifier also triggers a full re-listing via KDirNotify::FilesAdded which calls KCoreDirLister::updateDirectory. That's when the dirlister should notice that the target URL of the item has changed. For consistency, also compare local paths, although this commit doesn't actually require it. Unittest improved in plasma-workspace/kioslave/desktop/tests. FIXED-IN: 5.37 M +2-0src/core/kfileitem.cpp https://commits.kde.org/kio/1449ecf136b5d170cb7c66e62a302bb9e9df164b -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kservice] [Bug 348062] KBuildsycoca assert "hash != 0"
https://bugs.kde.org/show_bug.cgi?id=348062 --- Comment #3 from David Faure <fa...@kde.org> --- KBuildSycoca::calcResourceHash: File not found or not readable: "fsview_part.desktop" found: () -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kservice] [Bug 348062] KBuildsycoca assert "hash != 0"
https://bugs.kde.org/show_bug.cgi?id=348062 David Faure <fa...@kde.org> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #2 from David Faure <fa...@kde.org> --- I just hit this today when playing with "make uninstall". The desktop file gets removed, kbuildsycoca.cpp fails to open it, hash is 0, boom. I'll look into it ;) -- You are receiving this mail because: You are watching all bug changes.
[Ruqola] [Bug 382594] Remove http[s] prefix from hostname
https://bugs.kde.org/show_bug.cgi?id=382594 --- Comment #1 from David Faure <fa...@kde.org> --- Actually, the proper way is probably do it like Rocket.Chat+ does: asking the user for a URL, not for a hostname. This allows setups like the one we initially had at KDAB where the chat URL also had a path, e.g. https://server.kdab.com/chat/. If this was still the case, I guess I wouldn't have been able to log in with the current ruqola? -- You are receiving this mail because: You are watching all bug changes.
[Ruqola] [Bug 382597] Improve rendering of nicks in messages
https://bugs.kde.org/show_bug.cgi?id=382597 --- Comment #1 from David Faure <fa...@kde.org> --- Maybe for the full name it would be enough to have it in the nick list (which would have both full name and nick), like konversation does. Anyhow, sorry for mixing two issues, the primary issue here was the rendering of long nicks. -- You are receiving this mail because: You are watching all bug changes.
