[Akonadi] [Bug 480770] Regression: EWS Server might require HTTP 1.1
https://bugs.kde.org/show_bug.cgi?id=480770 --- Comment #5 from Igor Poboiko --- Happy to help! Proposed patches now fix both issues for me. -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 480770] Regression: EWS Server might require HTTP 1.1
https://bugs.kde.org/show_bug.cgi?id=480770 --- Comment #3 from Igor Poboiko --- Thanks for the quick response! I've applied both patches and tested it. Autodiscovery still doesn't work -- but now it fails with error "org.kde.pim.ews.client: Failed to process EWS request: Access denied to [URL]". (line 120 of ewspoxautodiscoverrequest.cpp: https://invent.kde.org/pim/kdepim-runtime/-/blob/master/resources/ews/ewsclient/ewspoxautodiscoverrequest.cpp?ref_type=heads#L120) However, the job error code is 115 (which is KIO::ERR_ACCESS_DENIED), instead of 401 Unauthorized, so it doesn't try authenticating with password (line 90 of ewsautodiscoveryjob.cpp: https://invent.kde.org/pim/kdepim-runtime/-/blob/master/resources/ews/ewsautodiscoveryjob.cpp?ref_type=heads#L90). Adding manual check for ERR_ACCESS_DENIED there solved this for me, and autodiscovery works. However, the resource still doesn't work because all other requests also fail with the same "HTTP/1.1 should be used" meassage. Adding the same line (set "HttpVersion" to "http1") to ewsrequest.cpp solved this for me as well, and resource now also works. -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 480770] New: Regression: EWS Server might require HTTP 1.1
https://bugs.kde.org/show_bug.cgi?id=480770 Bug ID: 480770 Summary: Regression: EWS Server might require HTTP 1.1 Classification: Frameworks and Libraries Product: Akonadi Version: 5.240.95 Platform: Gentoo Packages OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: EWS Resource Assignee: kdepim-b...@kde.org Reporter: igor.pobo...@gmail.com CC: c...@carlschwan.eu, kri...@op.pl Target Milestone: --- SUMMARY When testing 6th MegaRelease, and trying to configure Akonadi Microsoft Exchange Server (EWS) resource for my workplace, server autodiscovery fails with message "Failed to read POX response XML". Logs reveal suspicious message: > org.kde.pim.ews.client.proto: " xmlns=\"http://schemas.microsoft.com/exchange/autodiscover/outlook/requestschema/2006\;>[MAIL]http://schemas.microsoft.com/exchange/autodiscover/outlook/responseschema/2006a\n" > org.kde.pim.ews.client.request: Starting POX Autodiscovery request (url: > QUrl(https://[SERVER]/autodiscover/autodiscover.xml) , email: [MAIL] > qt.network.http2: stream 3 finished with error: "Server requires that > HTTP/1.1 be used instead of HTTP/2." > org.kde.pim.ews.client.proto: data KIO::TransferJob(0x564a2890da90) "" > org.kde.pim.ews.client.proto: response dumped to > "/tmp/akonadi-ews-XIiXnid/ews_xmldump_kVvvsjS.xml" > org.kde.pim.ews.client: Failed to read POX response XML Corresponding XML file it refers to it empty. According to https://doc.qt.io/qt-6/network-changes-qt6.html, it seems like Qt 6 enabled HTTP/2 by default, which might be the cause of this regression. Older KMail 23.08 at the same time with the same server works. Moreover, it provides with the URL via autodiscovery, which can then be entered manually in the newer 24.02 version. Nevertheless the newer version cannot connect with the message "Failed to read EWS request XML" and same "Server requires that HTTP/1.1 be used instead of HTTP/2." in logs. Operating System: Gentoo Linux 2.14 KDE Plasma Version: 5.93.0 KDE Frameworks Version: 5.249.0 KDE PIM Version: 5.240.95 rc2 (24.01.95) Qt Version: 6.6.1 Graphics Platform: Wayland -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 473043] Embedded Konsole crash on command execution
https://bugs.kde.org/show_bug.cgi?id=473043 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #15 from Igor Poboiko --- (In reply to Antonio Rojas from comment #14) > Probably 5bda57405e2f64e92a1142fb0898ff8ba5fafd3c, which wasn't backported > for some reason. I can confirm, I've rebuilt Konsole 23.08 with https://invent.kde.org/utilities/konsole/-/commit/5bda57405e2f64e92a1142fb0898ff8ba5fafd3c and can no longer reproduce this crash. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 353874] Baloo does not remove deleted files from index
https://bugs.kde.org/show_bug.cgi?id=353874 --- Comment #29 from Igor Poboiko --- (In reply to Oded Arbel from comment #28) >[...] > fanotify allows you to ignore that issue by setting up one watch on each of > the folders configured in Baloo's KCM and that's it - there are no more race > conditions between applications creating folders and Baloo putting inotify > watches on them. Sorry, I will add my 50 cents here. `man fanotify` claims that watches are not recursive, and should be set up for subdirectories separately, so such race condition is still there. Those could have been avoided if we could put a mark for the whole mount point / tree, but AFAIK that requires CAP_SYS_ADMIN. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kio] [Bug 457685] Local recent files in non-KDE apps are opened using kio-fuse mounted location instead of local path
https://bugs.kde.org/show_bug.cgi?id=457685 --- Comment #8 from Igor Poboiko --- I've rebuild the plasma-desktop with the patch applied, seems like it fixed the issue for me. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[kiofuse] [Bug 457685] New: Local recent files in non-KDE apps are opened using kio-fuse mounted location instead of local path
https://bugs.kde.org/show_bug.cgi?id=457685 Bug ID: 457685 Summary: Local recent files in non-KDE apps are opened using kio-fuse mounted location instead of local path Product: kiofuse Version: 5.0.1 Platform: Gentoo Packages OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: a.saout...@gmail.com Reporter: igor.pobo...@gmail.com CC: fab...@ritter-vogt.de, kio-bugs-n...@kde.org Target Milestone: --- SUMMARY & STEPS TO REPRODUCE I have a TeXStudio icon pinned to the taskbar. It has "Recent files" list available via right-mouse-click menu, with bunch of files, all inside local filesystem (e.g. inside my home directory). When I open one of those files via the menu, they are opened using the path "/run/user/UID/kio-fuse-XX/file/home/user/...", instead of simple "/home/user/...". I suppose it shouldn't happen. This issue also interferes with built-in "Recent files" feature available in some of the apps: two entries appear there, one of which pointing to the local path (/home/user/...), and other pointing to temporary kiofuse URL. The later also becomes unavailable after reboot. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Gentoo Linux 2.8 KDE Plasma Version: 5.25.3 KDE Frameworks Version: 5.96.0 Qt Version: 5.15.5 ADDITIONAL INFORMATION - The issue is not specific to TeXStudio: apparently, all non-KDE apps are affected: tested also with LyX and Wolfram Mathematica. KDE apps behave correctly (tested with Okular, Kate). - I suppose that "Recent files" are extracted from "~/.local/share/recently-used.xbel" file, which contains URLs both in format href="file:///home/user/..." and href="/home/user/...". Both types are however opened inside kio-fuse mounted path instead of local one. -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 453631] Can't open text documents: "The Akonadi personal information management service is not operational" (Kjots should not require the Akonadi PIM service)
https://bugs.kde.org/show_bug.cgi?id=453631 --- Comment #3 from Igor Poboiko --- (In reply to myndstream from comment #2) > [...] > Why does an app for writing/reading text require personal information > management tools? How is that relevant to notes-taking? For example, I > wouldn't want an app for notes to have access to my contacts and so on. It > seems to be unnecessary/badly designed and a privacy concern. Because it was originally created as a part of KDE PIM ecosystem. Integration with Akonadi would make sense because it could allow i.e. seamless integration with online services (Kolab, Evernote, NextCloud, Google Keep, whatever), as well as some more advanced features like tags/labels, being able to share notes with your contacts, and so on. Although unfortunately due to lack of manpower most of it is not yet implemented... :( > I don't understand why it can't open plain text files instead of only making > it an option to read/save as maildir. Well, one of the reasons is because it allows for rich text formatting (bold/underline/changing text color/links/inserting pictures/tables/etc), and so it internally uses html-like (Qt Rich Text) format anyways. As for maildir: it seems like historically it was the easiest solution, as maildir support was already implemented inside Akonadi and it fitted the needs. > Which? Anything better than Kate? I submitted this issue because of a major > issue with Kate for note-taking and am looking for a similar app: > https://unix.stackexchange.com/q/702033/233262 Kate is good as a pure plain-text editor, and apps like LibreOffice are better if you need a well-structured large documents (although it's obviously a bit heavy for note taking). For your particular use case I would suggest looking at note taking apps that support markdown format, which is a plain-text format which nevertheless allows for some structure and rich text. Such as QOwnNotes, Joplin, and others. You could find more as well as some articles with comparison of those by googling for "linux markdown note app". > Why would one need to install mysql server for a note-taking app? This is > just very wrong, especially if it's a dependency instead of optional. Indeed it would be an obvious overkill and not the best choice for you if the only application you use from the KDE PIM is KJots. But if you already use KMail / KOrganizer / Kalendar / KAddressBook / etc., and you already have Akonadi and MySQL installed and running, then such a dependency makes no difference. That's what I've started with - it was intended to be a part of KDE PIM ecosystem. -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 453631] Can't open text documents: "The Akonadi personal information management service is not operational" (Kjots should not require the Akonadi PIM service)
https://bugs.kde.org/show_bug.cgi?id=453631 Igor Poboiko changed: What|Removed |Added Resolution|--- |INTENTIONAL Status|REPORTED|RESOLVED --- Comment #1 from Igor Poboiko --- Hi, KJots is currently completely based on the KDE PIM stack, including Akonadi which is used to create/open/modify notes, even locally. There's not much can be done without rewriting a huge part of it. Please also note that KJots stores notes in a very specific maildir format, and is not intended to be used as a general purpose document/text editor (e.g. use it to modify ordinary plain text files, OpenDocument format files, etc.). There are better applications for that purpose. As for the issues you experience with the Akonadi: due to the "mysqld not found" line I would suggest installing mysql server and probably sending a bugreport to the distribution you use (Debian), which should have mysqld as a dependency for Akonadi. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 443719] Window thumbnails aren't displayed on Wayland
https://bugs.kde.org/show_bug.cgi?id=443719 --- Comment #7 from Igor Poboiko --- (In reply to pmargeti34 from comment #6) > What exactly does the screencast use flag entail on gentoo? I'm having this > issue on archlinux. Hey! For KWin: it adds a PipeWire dependency (so that KWin compiles with PipeWire support). For Plasma Workspace: it adds dependencies on QtGui (with EGL support), libglvnd, again PipeWire and libdrm. For xdg-desktop-portal: it adds dependency on PipeWire and enables "pipewire" flag for autotools. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 443719] Window thumbnails aren't displayed on Wayland
https://bugs.kde.org/show_bug.cgi?id=443719 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #4 from Igor Poboiko --- Hey, I had the same issue with Gentoo. Turned out I had to enable "screencast" USE-flag both for kde-plasma/kwin, kde-plasma/plasma-workspace and sys-apps/xdg-desktop-portal, and it fixed the issue for me. -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 437174] There's an automatic pop-up window that comes up for KJots letting me know that there are two ambiguous shortcuts.
https://bugs.kde.org/show_bug.cgi?id=437174 Igor Poboiko changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #1 from Igor Poboiko --- You have not specified the version of KJots you're using, but it should already be fixed in the most recent release (which is 5.1.0). Bookmarks currently use shortcut Ctrl+Shift+B to avoid this collision, see https://invent.kde.org/pim/kjots/-/blob/master/src/kjotswidget.cpp#L423. As a workaround, you can manually change the shortcut, it should be available via menu "Settings" - "Configure Keyboard Shortcuts...", look for "Add Bookmark". -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 199761] Kjots : "Search" icon or Ctrl+F doesn't continue after finding one criteria
https://bugs.kde.org/show_bug.cgi?id=199761 Igor Poboiko changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED CC||igor.pobo...@gmail.com --- Comment #3 from Igor Poboiko --- The inline Find feature is implemented in the most recent release (5.1.0). -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 332200] Kjots notebook displays list with incorrect indentation and numbering type
https://bugs.kde.org/show_bug.cgi?id=332200 Igor Poboiko changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED CC||igor.pobo...@gmail.com --- Comment #3 from Igor Poboiko --- This was a bug in upstream library Grantlee (which takes care of creating HTML previews), and it's now fixed, see https://github.com/steveire/grantlee/commit/c44bed61e68339f9904e18208617255aebe69e85 (need to wait for new release though) -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 424883] Shortcut for creating bulleted list doesn't work
https://bugs.kde.org/show_bug.cgi?id=424883 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #1 from Igor Poboiko --- The "Auto Bullet" action is used to automatically create bullet lists while typing. E.g. if you enter a new line starting with an asterisk "*", or minus "-", it will create a new bullet list element. Similarly, auto decimal is supposed to work when you type "1. [...]"; it will create a numbered list. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kiconthemes] [Bug 402172] Compiling against Qt 5.12 breaks QIcon::themeName with Plasma platform plugin
https://bugs.kde.org/show_bug.cgi?id=402172
--- Comment #18 from Igor Poboiko ---
Git commit 899c0f7fa457d77f4b53f8540e22290da862d57d by Igor Poboiko.
Committed on 04/06/2020 at 22:03.
Pushed by poboiko into branch 'master'.
[KMainWindow] Invoke QIcon::setFallbackThemeName (later)
Summary:
This is alternative approach to {D22488} and commit 4214045 to KIconThemes.
Okular (and most - if not all - KDE apps) inherit KMainWindow, so KDE apps
should have breeze icons). KMainWindow ctor should be early enough so no icons
are yet loaded, but late enough so QGuiApplication is already inited.
This should be followed by reverting commit 4214045 in KIconThemes.
Original problem description (by @mart):
invoking QIcon::setFallbackThemeName at QCoreApplication ctor
with Q_COREAPP_STARTUP_FUNCTION breaks the internal status of
QIconLoader as it instantiates it before the QPlatformTheme,
but QIconLoader depends from QPlatformTheme to be already instantiated
otherwise it won't load correctly, thus breaking icon loading
in QtQuickControls2 styles, such as Material and Fusion
see https://bugreports.qt.io/browse/QTBUG-74252
Test Plan:
Don't have GTK3 QPA plugin, so cannot test it yet.
I would appreciate if someone helped me with testing :)
Reviewers: aacid, mart, broulik
Subscribers: mart, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D29826
M +17 -0src/kmainwindow.cpp
https://invent.kde.org/frameworks/kxmlgui/commit/899c0f7fa457d77f4b53f8540e22290da862d57d
--
You are receiving this mail because:
You are watching all bug changes.
[kjots] [Bug 296242] kjots doesn't save when quitting via Ctrl+Q.
https://bugs.kde.org/show_bug.cgi?id=296242
Igor Poboiko changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/kjo
||ts/211395370166c1e538b020df
||ed4b236a7a7a334b
--- Comment #4 from Igor Poboiko ---
Git commit 211395370166c1e538b020dfed4b236a7a7a334b by Igor Poboiko.
Committed on 15/05/2020 at 10:32.
Pushed by poboiko into branch 'master'.
[KJots] Save on exit
Summary:
This is follow-up to {D29291}.
When quitting the application, perform a save using the synchronous
`ItemModifyJob` interface.
If the job has failed, show a dialog explaining what can be done to avoid data
loss (save it to file using Export menu).
Test Plan: Note is now always saved on Ctrl+Q.
Reviewers: dvratil
Reviewed By: dvratil
Subscribers: kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D29762
M +1-9src/KJotsMain.cpp
M +0-3src/KJotsMain.h
M +19 -15 src/kjotsmodel.cpp
M +4-0src/kjotsmodel.h
M +34 -2src/kjotswidget.cpp
https://commits.kde.org/kjots/211395370166c1e538b020dfed4b236a7a7a334b
--
You are receiving this mail because:
You are watching all bug changes.
[kjots] [Bug 255998] Provide visual indication of a page being saved
https://bugs.kde.org/show_bug.cgi?id=255998 Igor Poboiko changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kjo ||ts/ad0f09f7986b141da58f5f87 ||48d40daf448ba4d2 --- Comment #6 from Igor Poboiko --- Git commit ad0f09f7986b141da58f5f8748d40daf448ba4d2 by Igor Poboiko. Committed on 12/05/2020 at 10:58. Pushed by poboiko into branch 'master'. Provide visual indication whether the document is changed (via the asterisk in a window title). M +13 -4src/kjotsedit.cpp M +5-0src/kjotsedit.h M +1-1src/kjotsmodel.cpp M +5-1src/kjotswidget.cpp https://commits.kde.org/kjots/ad0f09f7986b141da58f5f8748d40daf448ba4d2 -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 420974] Kjots gives a warning about 2 conflicting shortcuts (Bold and Add Bookmark) on start.
https://bugs.kde.org/show_bug.cgi?id=420974 Igor Poboiko changed: What|Removed |Added Resolution|--- |DUPLICATE CC||igor.pobo...@gmail.com Status|REPORTED|RESOLVED --- Comment #2 from Igor Poboiko --- This is fixed in current master, expect the fix in the next release. *** This bug has been marked as a duplicate of bug 384000 *** -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 384000] There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B)
https://bugs.kde.org/show_bug.cgi?id=384000 Igor Poboiko changed: What|Removed |Added CC||gry...@protonmail.com --- Comment #8 from Igor Poboiko --- *** Bug 420974 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 230317] KJots: allow formatting of text with styles / templates
https://bugs.kde.org/show_bug.cgi?id=230317
--- Comment #2 from Igor Poboiko ---
Git commit cfee7c265b02f7b4d4e720c3c60744121c7b1608 by Igor Poboiko.
Committed on 09/05/2020 at 10:05.
Pushed by poboiko into branch 'master'.
[KJots] Add support for headings
Summary:
This patch adds support for headings, introduced for underlying `KRichTextEdit`
in {D28854}.
It adds relevant actions to toolbars & menu.
This also increases the required KF5 version to (not yet released) 5.70.
Slighly overlaps with {D29291} (which increases the version in .rc-file)
Test Plan: it compiles, actions are added (and functional)
Reviewers: dvratil, mlaurent
Subscribers: mlaurent, kde-pim
Differential Revision: https://phabricator.kde.org/D29300
M +1-1CMakeLists.txt
M +2-1src/kjotsedit.cpp
M +3-0src/kjotspartui.rc
M +3-0src/kjotsui.rc
https://commits.kde.org/kjots/cfee7c265b02f7b4d4e720c3c60744121c7b1608
--
You are receiving this mail because:
You are watching all bug changes.
[kjots] [Bug 255998] Provide visual indication of a page being saved
https://bugs.kde.org/show_bug.cgi?id=255998 --- Comment #5 from Igor Poboiko --- Git commit e520aa4b49a50da8d2b1f08e4b8676213baa5cde by Igor Poboiko. Committed on 05/05/2020 at 09:06. Pushed by poboiko into branch 'master'. [KJots] Provide explicit "Save" action, use standard actions where possible Summary: Use some standard actions for save, next page, previous page, rename. Add "Save" action to menu and toolbar, otherwise it's not even clear how to save the note. Don't use `QInputDialog` when renaming, just trigger inline rename. Also, perform save procedure on quit (inside `KJotsWidget::queryClose`). TODO: this is not yet functional, need to perform a synchronous job and wait for result. Related: bug 296242 Test Plan: All actions are functional Reviewers: dvratil Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D29291 M +1-1src/KJotsMain.cpp M +5-4src/kjotspartui.rc M +3-39 src/kjotstreeview.cpp M +3-1src/kjotstreeview.h M +6-4src/kjotsui.rc M +10 -21 src/kjotswidget.cpp https://commits.kde.org/kjots/e520aa4b49a50da8d2b1f08e4b8676213baa5cde -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 296242] kjots doesn't save when quitting via Ctrl+Q.
https://bugs.kde.org/show_bug.cgi?id=296242 --- Comment #3 from Igor Poboiko --- Git commit e520aa4b49a50da8d2b1f08e4b8676213baa5cde by Igor Poboiko. Committed on 05/05/2020 at 09:06. Pushed by poboiko into branch 'master'. [KJots] Provide explicit "Save" action, use standard actions where possible Summary: Use some standard actions for save, next page, previous page, rename. Add "Save" action to menu and toolbar, otherwise it's not even clear how to save the note. Don't use `QInputDialog` when renaming, just trigger inline rename. Also, perform save procedure on quit (inside `KJotsWidget::queryClose`). TODO: this is not yet functional, need to perform a synchronous job and wait for result. Related: bug 255998 Test Plan: All actions are functional Reviewers: dvratil Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D29291 M +1-1src/KJotsMain.cpp M +5-4src/kjotspartui.rc M +3-39 src/kjotstreeview.cpp M +3-1src/kjotstreeview.h M +6-4src/kjotsui.rc M +10 -21 src/kjotswidget.cpp https://commits.kde.org/kjots/e520aa4b49a50da8d2b1f08e4b8676213baa5cde -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 405094] Symbols in name break search
https://bugs.kde.org/show_bug.cgi?id=405094 --- Comment #3 from Igor Poboiko --- It's not my logic, it's the logic of Baloo and its original developer :) The logic is quite straightforward though. Most likely, user is searching for some particular document. If his search term is contained in "137K files", it wouldn't help at all - such term might as well be dropped. If those are only terms user looking for, he won't be able to find anything; if his query contains other terms, those will more likely to help Baloo identify the document user is looking for. I believe short terms are mostly there just to be able to search over filename extensions (like "filename.jpg") and e-mail/domains (like "john...@example.org"). In both cases, the "exact match" logic would suffice. > [...] Apparently A-Z characters are first class citizens, whereas the other > characters are estranged cousins. That's intentional. Remember that Baloo provides search over file contents too. And if you have it in mind, it doesn't sound that arbitrary: letters and words (not necessarily A-Z: also numbers and other languages) contain the most information to build index upon. What are the chances user is going to search for a document that has "." or " " or "_" somewhere inside? And what are the chances it will help to identify the document uniquely? Not to mention that by restricting itself to alphabet, it reduces the size of the index by a large factor. If you're looking for a file with a name you know precisely, and which mostly contains non-alphanumeric characters, then "find" / KFind or any other filesystem crawler will most likely do better. > Baloo = 5.55.0 I couldn't also help but notice that the version your distribution ships is a bit outdated. There were large number of improvements to Baloo somewhat around 5.60+ (unrelated to this particular issue, though). -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 415245] Create Maildir ressource on valid maildir could result in not showing mails
https://bugs.kde.org/show_bug.cgi?id=415245 --- Comment #1 from Igor Poboiko --- Git commit 4ab1f2068b53d3fabe3cf35c087f28bf10bca672 by Igor Poboiko. Committed on 03/05/2020 at 12:18. Pushed by poboiko into branch 'release/20.04'. [resources/maildir] Reload configuraton on configuration change Summary: When user adds new maildir, a new resource gets created, with the default directory `~/.local/share/local-mail`. Since it's a new resource, with no proper configuration, an `attemptConfigRestoring()` is called, which changes it to `~/.local/share/akonadi_maildir_resource#`. It's stored inside `mSettings->path()`. Then a dialog appears, where user can choose prefered directory. It gets written to the config file; then `configurationChanged` gets called. We call `mSettings->save()`, which overwrites the path provided by user with the default one (`~/.local/share/akonadi_maildir_resource#`), making it impossible to create a new maildir anywhere else. Just use `load()` instead, it makes more sense when configuration was changed. Related: bug 416287, bug 415922 Test Plan: 1) Create a new maildir resource pointing to `/tmp/dummy`. 2) The resource gets created, with the name `dummy`. `/tmp/dummy` gets created. 2) Drop some mails into it via KMail. Mails appear inside `/tmp/dummy` Reviewers: dvratil, mlaurent Reviewed By: dvratil Subscribers: wbauer, kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27905 M +2-1resources/maildir/maildirresource.cpp https://commits.kde.org/kdepim-runtime/4ab1f2068b53d3fabe3cf35c087f28bf10bca672 -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 415922] Changing/Setting maildir folder in settings is not working
https://bugs.kde.org/show_bug.cgi?id=415922 --- Comment #3 from Igor Poboiko --- Git commit 4ab1f2068b53d3fabe3cf35c087f28bf10bca672 by Igor Poboiko. Committed on 03/05/2020 at 12:18. Pushed by poboiko into branch 'release/20.04'. [resources/maildir] Reload configuraton on configuration change Summary: When user adds new maildir, a new resource gets created, with the default directory `~/.local/share/local-mail`. Since it's a new resource, with no proper configuration, an `attemptConfigRestoring()` is called, which changes it to `~/.local/share/akonadi_maildir_resource#`. It's stored inside `mSettings->path()`. Then a dialog appears, where user can choose prefered directory. It gets written to the config file; then `configurationChanged` gets called. We call `mSettings->save()`, which overwrites the path provided by user with the default one (`~/.local/share/akonadi_maildir_resource#`), making it impossible to create a new maildir anywhere else. Just use `load()` instead, it makes more sense when configuration was changed. Related: bug 416287, bug 415245 Test Plan: 1) Create a new maildir resource pointing to `/tmp/dummy`. 2) The resource gets created, with the name `dummy`. `/tmp/dummy` gets created. 2) Drop some mails into it via KMail. Mails appear inside `/tmp/dummy` Reviewers: dvratil, mlaurent Reviewed By: dvratil Subscribers: wbauer, kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27905 M +2-1resources/maildir/maildirresource.cpp https://commits.kde.org/kdepim-runtime/4ab1f2068b53d3fabe3cf35c087f28bf10bca672 -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 416287] It's not possible to add an existing maildir, the wrong path is used
https://bugs.kde.org/show_bug.cgi?id=416287 Igor Poboiko changed: What|Removed |Added Status|REPORTED|RESOLVED Latest Commit||https://commits.kde.org/kde ||pim-runtime/4ab1f2068b53d3f ||abe3cf35c087f28bf10bca672 Resolution|--- |FIXED --- Comment #5 from Igor Poboiko --- Git commit 4ab1f2068b53d3fabe3cf35c087f28bf10bca672 by Igor Poboiko. Committed on 03/05/2020 at 12:18. Pushed by poboiko into branch 'release/20.04'. [resources/maildir] Reload configuraton on configuration change Summary: When user adds new maildir, a new resource gets created, with the default directory `~/.local/share/local-mail`. Since it's a new resource, with no proper configuration, an `attemptConfigRestoring()` is called, which changes it to `~/.local/share/akonadi_maildir_resource#`. It's stored inside `mSettings->path()`. Then a dialog appears, where user can choose prefered directory. It gets written to the config file; then `configurationChanged` gets called. We call `mSettings->save()`, which overwrites the path provided by user with the default one (`~/.local/share/akonadi_maildir_resource#`), making it impossible to create a new maildir anywhere else. Just use `load()` instead, it makes more sense when configuration was changed. Related: bug 415245, bug 415922 Test Plan: 1) Create a new maildir resource pointing to `/tmp/dummy`. 2) The resource gets created, with the name `dummy`. `/tmp/dummy` gets created. 2) Drop some mails into it via KMail. Mails appear inside `/tmp/dummy` Reviewers: dvratil, mlaurent Reviewed By: dvratil Subscribers: wbauer, kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27905 M +2-1resources/maildir/maildirresource.cpp https://commits.kde.org/kdepim-runtime/4ab1f2068b53d3fabe3cf35c087f28bf10bca672 -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 345211] mails in ~/.local/share/local-mail don't show up any more
https://bugs.kde.org/show_bug.cgi?id=345211
--- Comment #7 from Igor Poboiko ---
Git commit 1a13474c9a53e8b4b485a27189ff26f309f7fccb by Igor Poboiko.
Committed on 27/04/2020 at 10:41.
Pushed by poboiko into branch 'release/20.04'.
Save configuration when creating resources for new user
Summary:
Akonadi calls `writeConfig` DBus method to save the configuration for newly
created resources, both via `firstrun` and `SpecialCollections` mechanisms.
This method is non-existent for all of the resources (it was deprecated in
KConfig, and apparently is not exported to DBus), method `save` should
be used instead.
This is related to issues raised in {D27905}: settings provided in firstrun did
not override default settings for the resource.
Related: bug 352502
Test Plan:
1) Check `qdbus org.freedesktop.Akonadi.Resource.akonadi_maildir_resource_0
/Settings`
2) There is no `writeConfig` method, but there is `save` method
Reviewers: dvratil
Reviewed By: dvratil
Subscribers: kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D28523
(cherry picked from commit 4447e8894d4f3b4c08849956f33aa7156caa30a4)
M +1-1src/core/firstrun.cpp
M +1-1src/core/jobs/specialcollectionshelperjobs.cpp
https://commits.kde.org/akonadi/1a13474c9a53e8b4b485a27189ff26f309f7fccb
--
You are receiving this mail because:
You are watching all bug changes.
[Akonadi] [Bug 352502] .local/share/local-mail has to be the top level of local folders!
https://bugs.kde.org/show_bug.cgi?id=352502
--- Comment #6 from Igor Poboiko ---
Git commit 1a13474c9a53e8b4b485a27189ff26f309f7fccb by Igor Poboiko.
Committed on 27/04/2020 at 10:41.
Pushed by poboiko into branch 'release/20.04'.
Save configuration when creating resources for new user
Summary:
Akonadi calls `writeConfig` DBus method to save the configuration for newly
created resources, both via `firstrun` and `SpecialCollections` mechanisms.
This method is non-existent for all of the resources (it was deprecated in
KConfig, and apparently is not exported to DBus), method `save` should
be used instead.
This is related to issues raised in {D27905}: settings provided in firstrun did
not override default settings for the resource.
Related: bug 345211
Test Plan:
1) Check `qdbus org.freedesktop.Akonadi.Resource.akonadi_maildir_resource_0
/Settings`
2) There is no `writeConfig` method, but there is `save` method
Reviewers: dvratil
Reviewed By: dvratil
Subscribers: kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D28523
(cherry picked from commit 4447e8894d4f3b4c08849956f33aa7156caa30a4)
M +1-1src/core/firstrun.cpp
M +1-1src/core/jobs/specialcollectionshelperjobs.cpp
https://commits.kde.org/akonadi/1a13474c9a53e8b4b485a27189ff26f309f7fccb
--
You are receiving this mail because:
You are watching all bug changes.
[Akonadi] [Bug 345211] mails in ~/.local/share/local-mail don't show up any more
https://bugs.kde.org/show_bug.cgi?id=345211
--- Comment #6 from Igor Poboiko ---
Git commit 4447e8894d4f3b4c08849956f33aa7156caa30a4 by Igor Poboiko.
Committed on 27/04/2020 at 10:38.
Pushed by poboiko into branch 'master'.
Save configuration when creating resources for new user
Summary:
Akonadi calls `writeConfig` DBus method to save the configuration for newly
created resources, both via `firstrun` and `SpecialCollections` mechanisms.
This method is non-existent for all of the resources (it was deprecated in
KConfig, and apparently is not exported to DBus), method `save` should
be used instead.
This is related to issues raised in {D27905}: settings provided in firstrun did
not override default settings for the resource.
Related: bug 352502
Test Plan:
1) Check `qdbus org.freedesktop.Akonadi.Resource.akonadi_maildir_resource_0
/Settings`
2) There is no `writeConfig` method, but there is `save` method
Reviewers: dvratil
Reviewed By: dvratil
Subscribers: kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D28523
M +1-1src/core/firstrun.cpp
M +1-1src/core/jobs/specialcollectionshelperjobs.cpp
https://commits.kde.org/akonadi/4447e8894d4f3b4c08849956f33aa7156caa30a4
--
You are receiving this mail because:
You are watching all bug changes.
[Akonadi] [Bug 352502] .local/share/local-mail has to be the top level of local folders!
https://bugs.kde.org/show_bug.cgi?id=352502
--- Comment #5 from Igor Poboiko ---
Git commit 4447e8894d4f3b4c08849956f33aa7156caa30a4 by Igor Poboiko.
Committed on 27/04/2020 at 10:38.
Pushed by poboiko into branch 'master'.
Save configuration when creating resources for new user
Summary:
Akonadi calls `writeConfig` DBus method to save the configuration for newly
created resources, both via `firstrun` and `SpecialCollections` mechanisms.
This method is non-existent for all of the resources (it was deprecated in
KConfig, and apparently is not exported to DBus), method `save` should
be used instead.
This is related to issues raised in {D27905}: settings provided in firstrun did
not override default settings for the resource.
Related: bug 345211
Test Plan:
1) Check `qdbus org.freedesktop.Akonadi.Resource.akonadi_maildir_resource_0
/Settings`
2) There is no `writeConfig` method, but there is `save` method
Reviewers: dvratil
Reviewed By: dvratil
Subscribers: kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D28523
M +1-1src/core/firstrun.cpp
M +1-1src/core/jobs/specialcollectionshelperjobs.cpp
https://commits.kde.org/akonadi/4447e8894d4f3b4c08849956f33aa7156caa30a4
--
You are receiving this mail because:
You are watching all bug changes.
[kjots] [Bug 302107] Line spacing doubled, if lines are pasted
https://bugs.kde.org/show_bug.cgi?id=302107
Igor Poboiko changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/kjo
||ts/4f861fa9211b31b1e810696b
||724d8459e2251a7c
Status|REPORTED|RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Igor Poboiko ---
Git commit 4f861fa9211b31b1e810696b724d8459e2251a7c by Igor Poboiko.
Committed on 26/04/2020 at 21:09.
Pushed by poboiko into branch 'master'.
[KJotsEdit] Don't mess with margins when pasting rich text
Summary:
Original code contained weird html parsing, removing `margin-*: *px;' style
properties from raw HTML.
However, when inserted, `QTextDocument` sees no margins and decides to set them
to the default 12px,
which breaks even copy-pasting of non-formatted text (see attached).
Instead just use standard `QTextDocument` manipulation methods to remove
margins. It fixes both pasting
formatted and non-formatted text.
Test Plan:
Before: {F8259687}
After: {F8259688}
Reviewers: dvratil, mlaurent
Reviewed By: mlaurent
Subscribers: kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D29177
M +15 -29 src/kjotsedit.cpp
https://commits.kde.org/kjots/4f861fa9211b31b1e810696b724d8459e2251a7c
--
You are receiving this mail because:
You are watching all bug changes.
[kjots] [Bug 384000] There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B)
https://bugs.kde.org/show_bug.cgi?id=384000 Igor Poboiko changed: What|Removed |Added CC||c_...@mail.com --- Comment #7 from Igor Poboiko --- *** Bug 401212 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 401212] Two actions have the same shortcut key assigned by default.
https://bugs.kde.org/show_bug.cgi?id=401212 Igor Poboiko changed: What|Removed |Added Resolution|--- |DUPLICATE CC||igor.pobo...@gmail.com Status|REPORTED|RESOLVED --- Comment #1 from Igor Poboiko --- *** This bug has been marked as a duplicate of bug 384000 *** -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 215543] KJots: After ctrl-clicking a link, mouse cursor stays in text shape
https://bugs.kde.org/show_bug.cgi?id=215543 Igor Poboiko changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kjo ||ts/bd0ea6d00f5c73bfe9c58c92 ||9db863a67b6aedb5 --- Comment #3 from Igor Poboiko --- Git commit bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5 by Igor Poboiko. Committed on 24/04/2020 at 10:52. Pushed by poboiko into branch 'master'. [KJotsEdit] Fix links handling in editing mode Summary: When user Ctrl+Clicks on the link in the editing mode, emit the linkClicked signal (which is forwarded to corresponding slot inside `KJotsWidget`). We use `mousePressEvent` instead of `mouseReleaseEvent` to be able not to move the cursor when user ctrl+clicks on the link (so we override default `mousePressEvent`, which moves it) Add visual feedback when hovering the mouse over a link with ctrl pressed (change the cursor to pointing hand) Add visual feedback when simply hovering the mouse over a link (a tooltip) Related: bug 218522, bug 244846 Test Plan: 1. Add Link, Ctrl+Click on it: mouse cursor changes, link opens 2. Right-click on link: there is "Link" entry, which can be used to edit link 3. Hover mouse over link: a useful tooltip appears telling user how to open it Reviewers: dvratil Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D29094 M +70 -15 src/kjotsedit.cpp M +12 -2src/kjotsedit.h M +1-0src/kjotswidget.cpp https://commits.kde.org/kjots/bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5 -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 244846] links in the book page aren't working
https://bugs.kde.org/show_bug.cgi?id=244846 Igor Poboiko changed: What|Removed |Added Latest Commit||https://commits.kde.org/kjo ||ts/bd0ea6d00f5c73bfe9c58c92 ||9db863a67b6aedb5 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #3 from Igor Poboiko --- Git commit bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5 by Igor Poboiko. Committed on 24/04/2020 at 10:52. Pushed by poboiko into branch 'master'. [KJotsEdit] Fix links handling in editing mode Summary: When user Ctrl+Clicks on the link in the editing mode, emit the linkClicked signal (which is forwarded to corresponding slot inside `KJotsWidget`). We use `mousePressEvent` instead of `mouseReleaseEvent` to be able not to move the cursor when user ctrl+clicks on the link (so we override default `mousePressEvent`, which moves it) Add visual feedback when hovering the mouse over a link with ctrl pressed (change the cursor to pointing hand) Add visual feedback when simply hovering the mouse over a link (a tooltip) Related: bug 215543, bug 218522 Test Plan: 1. Add Link, Ctrl+Click on it: mouse cursor changes, link opens 2. Right-click on link: there is "Link" entry, which can be used to edit link 3. Hover mouse over link: a useful tooltip appears telling user how to open it Reviewers: dvratil Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D29094 M +70 -15 src/kjotsedit.cpp M +12 -2src/kjotsedit.h M +1-0src/kjotswidget.cpp https://commits.kde.org/kjots/bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5 -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 218522] Links in KJots are not clickable/executable
https://bugs.kde.org/show_bug.cgi?id=218522 Igor Poboiko changed: What|Removed |Added Latest Commit||https://commits.kde.org/kjo ||ts/bd0ea6d00f5c73bfe9c58c92 ||9db863a67b6aedb5 Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #9 from Igor Poboiko --- Git commit bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5 by Igor Poboiko. Committed on 24/04/2020 at 10:52. Pushed by poboiko into branch 'master'. [KJotsEdit] Fix links handling in editing mode Summary: When user Ctrl+Clicks on the link in the editing mode, emit the linkClicked signal (which is forwarded to corresponding slot inside `KJotsWidget`). We use `mousePressEvent` instead of `mouseReleaseEvent` to be able not to move the cursor when user ctrl+clicks on the link (so we override default `mousePressEvent`, which moves it) Add visual feedback when hovering the mouse over a link with ctrl pressed (change the cursor to pointing hand) Add visual feedback when simply hovering the mouse over a link (a tooltip) Related: bug 215543, bug 244846 Test Plan: 1. Add Link, Ctrl+Click on it: mouse cursor changes, link opens 2. Right-click on link: there is "Link" entry, which can be used to edit link 3. Hover mouse over link: a useful tooltip appears telling user how to open it Reviewers: dvratil Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D29094 M +70 -15 src/kjotsedit.cpp M +12 -2src/kjotsedit.h M +1-0src/kjotswidget.cpp https://commits.kde.org/kjots/bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5 -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 420228] kjots crashes upon start
https://bugs.kde.org/show_bug.cgi?id=420228 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #1 from Igor Poboiko --- This is fixed, see revision https://phabricator.kde.org/D28775 and commit https://phabricator.kde.org/R573:ca6f4b963e83ed91cc7314e1b60fe6607b61b53e. -- You are receiving this mail because: You are watching all bug changes.
[kjots] [Bug 195828] KJots when inserting rule line scrollbar returns to startup position
https://bugs.kde.org/show_bug.cgi?id=195828
Igor Poboiko changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Latest Commit||https://commits.kde.org/kte
||xtwidgets/0e14353610fa7f121
||659fbe28dd764b6c2d6dc77
Resolution|--- |FIXED
--- Comment #5 from Igor Poboiko ---
Git commit 0e14353610fa7f121659fbe28dd764b6c2d6dc77 by Igor Poboiko.
Committed on 19/04/2020 at 09:23.
Pushed by poboiko into branch 'master'.
[KRichTextEdit] Fix scroll jumping around when horizontal rule is added
Summary:
Due to Qt bug 83605, it's not a good idea to `setTextCursor` while the cursor
is inside `beginEditBlock / endEditBlock` (scrollbar might jump to the top),
see KDE bug 195828. It's sufficient to move `setTextCursor` outside to fix it.
(it's never too late... :)
This patch also adds a test for this case (which currently fails due to
regression, see {D28819} and {D28964} for the fix).
Test Plan:
1) Apply {D28964}
2) `ctest`
Reviewers: #frameworks, dfaure
Reviewed By: dfaure
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D28966
M +19 -0autotests/krichtextedittest.cpp
M +1-0autotests/krichtextedittest.h
M +1-1src/widgets/krichtextedit.cpp
https://commits.kde.org/ktextwidgets/0e14353610fa7f121659fbe28dd764b6c2d6dc77
--
You are receiving this mail because:
You are watching all bug changes.
[kjots] [Bug 384000] There are two actions (Bold, Add Bookmark) that want to use the same shortcut (Ctrl+B)
https://bugs.kde.org/show_bug.cgi?id=384000
Igor Poboiko changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REPORTED|RESOLVED
Latest Commit||https://commits.kde.org/kjo
||ts/ca6f4b963e83ed91cc7314e1
||b60fe6607b61b53e
--- Comment #6 from Igor Poboiko ---
Git commit ca6f4b963e83ed91cc7314e1b60fe6607b61b53e by Igor Poboiko.
Committed on 18/04/2020 at 22:06.
Pushed by poboiko into branch 'master'.
[KJots] Fix bookmarks actions
Summary:
This patch ports KJots from deprecated `KBookmarksMenu` API (see {D25660}).
On my machine, it also fixes a crash (`bm_action` was null for some reason,
I did not investigate it though).
It also fixes the shortcuts collision (`action->setShortcut` was not enough,
one also needs to run `actionCollection->setDefaultShortcut`).
Test Plan:
1) Start KJots
2) It don't crash, and `Ambiguous shortcuts` dialog does not appear)
3) Open `Bookmarks` menu, the shortcut is `Ctrl+Shift+B`.
Reviewers: dvratil
Reviewed By: dvratil
Subscribers: winterz, kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D28775
M +8-5src/kjotswidget.cpp
https://commits.kde.org/kjots/ca6f4b963e83ed91cc7314e1b60fe6607b61b53e
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-ktextwidgets] [Bug 256001] Undo in lists is broken
https://bugs.kde.org/show_bug.cgi?id=256001 Igor Poboiko changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kte ||xtwidgets/1d1eb6feb7f85d5e0 ||9e00f75114f671eceff1598 Resolution|--- |FIXED --- Comment #2 from Igor Poboiko --- Git commit 1d1eb6feb7f85d5e09e00f75114f671eceff1598 by Igor Poboiko. Committed on 14/04/2020 at 22:38. Pushed by poboiko into branch 'master'. [KRichTextEdit] Always treat key press as single modification in undo stack Summary: If my cursor is on a bullet list, and I press Enter to create a new element, it registers as 5-7 actions in an undo stack, mostly margins adjustments. So to rewind it, user has to press `Ctrl+Z` 5+ times, which is quite frustrating. Instead this patch suggests to treat _any_ change that is a result of a single key press as a single event, so user has to press `Ctrl+Z` just once to undo it Test Plan: 1) Open KMail -> New Mail, enable Rich Text mode (or, say, open KJots) 2) Create a bullet list with couple of elements 3) Put cursor on the last element, press Enter to create a new element 4) Try to undo this action with Ctrl+Z 5) (without patch) One has to press Ctrl+Z 5-7 times to undo it. 6) (with patch) A single Ctrl+Z is enough Reviewers: #frameworks, mlaurent, dfaure Reviewed By: dfaure Subscribers: ahmadsamir, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D28819 M +2-0src/widgets/krichtextedit.cpp https://commits.kde.org/ktextwidgets/1d1eb6feb7f85d5e09e00f75114f671eceff1598 -- You are receiving this mail because: You are watching all bug changes.
[kdepim] [Bug 413078] Can't change name of akonadi EWS resource (sort of)
https://bugs.kde.org/show_bug.cgi?id=413078 Igor Poboiko changed: What|Removed |Added Latest Commit||https://commits.kde.org/kde ||pim-runtime/4484df3d6f0c449 ||ec2cfd4956175eab507f4cc55 Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #5 from Igor Poboiko --- Git commit 4484df3d6f0c449ec2cfd4956175eab507f4cc55 by Igor Poboiko. Committed on 21/03/2020 at 13:14. Pushed by poboiko into branch 'master'. [resources/ews] Adjust name of root collection to the name of the resource Summary: The name of root collection inside the Akonadi DB (and thus, i.e. inside KMail) is always `akonadi_ews_resource#`, even if the resource itself was renamed. Even though we call `mRootCollection->setName(name())`, the name get's overriden after we fetch it from DB. The settings UI changes the name of the resource, but not root collection. This patch runs `CollectionModifyJob` to rename the root collection in both scenarios: either when we fetch root collection or change the resource name. Related: bug 416663 Test Plan: 1) Open KMail -> Settings -> Accounts -> Receiving -> EWS account 2) Change "Account Name", save 3) The change gets applied to Mailbox View inside KMail UI immediately Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27817 M +13 -0resources/ews/ewsresource.cpp M +1-0resources/ews/ewsresource.h https://commits.kde.org/kdepim-runtime/4484df3d6f0c449ec2cfd4956175eab507f4cc55 -- You are receiving this mail because: You are watching all bug changes.
[kontact] [Bug 416663] Office 365/EWS Incorrect account folder name
https://bugs.kde.org/show_bug.cgi?id=416663 Igor Poboiko changed: What|Removed |Added Status|REPORTED|RESOLVED Latest Commit||https://commits.kde.org/kde ||pim-runtime/4484df3d6f0c449 ||ec2cfd4956175eab507f4cc55 Resolution|--- |FIXED --- Comment #1 from Igor Poboiko --- Git commit 4484df3d6f0c449ec2cfd4956175eab507f4cc55 by Igor Poboiko. Committed on 21/03/2020 at 13:14. Pushed by poboiko into branch 'master'. [resources/ews] Adjust name of root collection to the name of the resource Summary: The name of root collection inside the Akonadi DB (and thus, i.e. inside KMail) is always `akonadi_ews_resource#`, even if the resource itself was renamed. Even though we call `mRootCollection->setName(name())`, the name get's overriden after we fetch it from DB. The settings UI changes the name of the resource, but not root collection. This patch runs `CollectionModifyJob` to rename the root collection in both scenarios: either when we fetch root collection or change the resource name. Related: bug 413078 Test Plan: 1) Open KMail -> Settings -> Accounts -> Receiving -> EWS account 2) Change "Account Name", save 3) The change gets applied to Mailbox View inside KMail UI immediately Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27817 M +13 -0resources/ews/ewsresource.cpp M +1-0resources/ews/ewsresource.h https://commits.kde.org/kdepim-runtime/4484df3d6f0c449ec2cfd4956175eab507f4cc55 -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 393002] Akonadi-ews does not save password in kwallet
https://bugs.kde.org/show_bug.cgi?id=393002 Igor Poboiko changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|https://commits.kde.org/kde |https://commits.kde.org/kde |pim-runtime/b5ee6ff11cd3a7e |pim-runtime/7afd99abbfa141f |0c28305b351d28c5f244f101e |6e6dfbe69b01827af8f16ba27 Status|REOPENED|RESOLVED --- Comment #18 from Igor Poboiko --- Git commit 7afd99abbfa141f6e6dfbe69b01827af8f16ba27 by Igor Poboiko. Committed on 20/03/2020 at 16:10. Pushed by poboiko into branch 'master'. [resources/ews] Save password to wallet Summary: Seems like the password entered via the UI actually never gets saved anywhere. Just do it explicitly. Related: bug 390798, bug 402780, bug 414789 Test Plan: 1) Try to setup EWS account using autodiscovery, using Username/Password auth 2) Set Username, Password, hit "Try connect" -> it works fine 3) Hit "OK" -> observe "Authentication failure" resource error 4) Browse `akonadi-ews` via `KWalletManager` -> it's empty 5) Apply the patch, repeat 1-4 - authentication succeeds, password entry inside wallet appears Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27813 M +1-0resources/ews/ewsconfigdialog.cpp https://commits.kde.org/kdepim-runtime/7afd99abbfa141f6e6dfbe69b01827af8f16ba27 -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 414789] Authentication failed even though server replies Auth is ok
https://bugs.kde.org/show_bug.cgi?id=414789 --- Comment #1 from Igor Poboiko --- Git commit 7afd99abbfa141f6e6dfbe69b01827af8f16ba27 by Igor Poboiko. Committed on 20/03/2020 at 16:10. Pushed by poboiko into branch 'master'. [resources/ews] Save password to wallet Summary: Seems like the password entered via the UI actually never gets saved anywhere. Just do it explicitly. Related: bug 393002, bug 390798, bug 402780 Test Plan: 1) Try to setup EWS account using autodiscovery, using Username/Password auth 2) Set Username, Password, hit "Try connect" -> it works fine 3) Hit "OK" -> observe "Authentication failure" resource error 4) Browse `akonadi-ews` via `KWalletManager` -> it's empty 5) Apply the patch, repeat 1-4 - authentication succeeds, password entry inside wallet appears Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27813 M +1-0resources/ews/ewsconfigdialog.cpp https://commits.kde.org/kdepim-runtime/7afd99abbfa141f6e6dfbe69b01827af8f16ba27 -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 390798] Akonadi EWS failed to authenticate with Exchange Server
https://bugs.kde.org/show_bug.cgi?id=390798 --- Comment #22 from Igor Poboiko --- Git commit 7afd99abbfa141f6e6dfbe69b01827af8f16ba27 by Igor Poboiko. Committed on 20/03/2020 at 16:10. Pushed by poboiko into branch 'master'. [resources/ews] Save password to wallet Summary: Seems like the password entered via the UI actually never gets saved anywhere. Just do it explicitly. Related: bug 393002, bug 402780, bug 414789 Test Plan: 1) Try to setup EWS account using autodiscovery, using Username/Password auth 2) Set Username, Password, hit "Try connect" -> it works fine 3) Hit "OK" -> observe "Authentication failure" resource error 4) Browse `akonadi-ews` via `KWalletManager` -> it's empty 5) Apply the patch, repeat 1-4 - authentication succeeds, password entry inside wallet appears Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27813 M +1-0resources/ews/ewsconfigdialog.cpp https://commits.kde.org/kdepim-runtime/7afd99abbfa141f6e6dfbe69b01827af8f16ba27 -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 402780] Akonadi doesn't work with Exchange again
https://bugs.kde.org/show_bug.cgi?id=402780 --- Comment #20 from Igor Poboiko --- Git commit 7afd99abbfa141f6e6dfbe69b01827af8f16ba27 by Igor Poboiko. Committed on 20/03/2020 at 16:10. Pushed by poboiko into branch 'master'. [resources/ews] Save password to wallet Summary: Seems like the password entered via the UI actually never gets saved anywhere. Just do it explicitly. Related: bug 393002, bug 390798, bug 414789 Test Plan: 1) Try to setup EWS account using autodiscovery, using Username/Password auth 2) Set Username, Password, hit "Try connect" -> it works fine 3) Hit "OK" -> observe "Authentication failure" resource error 4) Browse `akonadi-ews` via `KWalletManager` -> it's empty 5) Apply the patch, repeat 1-4 - authentication succeeds, password entry inside wallet appears Reviewers: dvratil, nowicki Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27813 M +1-0resources/ews/ewsconfigdialog.cpp https://commits.kde.org/kdepim-runtime/7afd99abbfa141f6e6dfbe69b01827af8f16ba27 -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 415922] Changing/Setting maildir folder in settings is not working
https://bugs.kde.org/show_bug.cgi?id=415922 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #1 from Igor Poboiko --- This is probably related to bug 408354 - the path was misinterpreted as ~/file:/data/user/mail, which is obviously not the right place to look at. Do such folder get created in your case? -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 408354] If default maildir folder is changed a new set of folders are stored under "/home/$user/file:"
https://bugs.kde.org/show_bug.cgi?id=408354 Igor Poboiko changed: What|Removed |Added CC||mathias.hom...@opensuse.org --- Comment #12 from Igor Poboiko --- *** Bug 411307 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 411307] Akonadi agents can't properly handle file:/ urls
https://bugs.kde.org/show_bug.cgi?id=411307 Igor Poboiko changed: What|Removed |Added Resolution|--- |DUPLICATE CC||igor.pobo...@gmail.com Status|REPORTED|RESOLVED --- Comment #1 from Igor Poboiko --- Notes are maildir under the hood, so it's the same bug. Should be fixed by now. *** This bug has been marked as a duplicate of bug 408354 *** -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 411269] maildir ressource creates a folder named "file:" in my home
https://bugs.kde.org/show_bug.cgi?id=411269 Igor Poboiko changed: What|Removed |Added Latest Commit||https://commits.kde.org/kde ||pim-runtime/93ecfacfb9f21ee ||027dbcfc7d5d47ddbbb253ba1 Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #1 from Igor Poboiko --- Git commit 93ecfacfb9f21ee027dbcfc7d5d47ddbbb253ba1 by Igor Poboiko. Committed on 01/03/2020 at 18:44. Pushed by poboiko into branch 'master'. [resources/maildir] Don't save "file:" schema to the config Summary: `ConfigWidget` uses `KConfig` underneath, and utilizes `KUrlRequester` custom widget. The `USER` property of this widget (which is used by `KConfig`) is of type `QUrl`, and thus when dialog is accepted, the `path` config property gets overriden with `QUrl::toString()` value, which prepends `file:` schema (this is basically because `KCoreConfigSkeleton::ItemPath` is inherited from `ItemString`, and when someone calls `ItemString::setProperty`, it gets casted as `QVariant::toString`). Inside the `ConfigWidget::save` the code calls `setPath` method on `url.toLocalFile`, which drops the scheme. Because of that, the `pathItem` and `path` property of `mSettings` have different values, first has schema and the second hasn't. Eventually, the value stored by `pathItem` wins, and `mSettings->path()` returns URL with schema. However, `Maildir` doesn't expect it and misinterprets it as the relative path to current WORKDIR (which is home directory), thus creating `/home/user/file:/home/user/...` file structure. The proposed solution is to simply call `mSettings->save()`, which overrides `pathItem` value and drops schema from it. It also fixes the `AkoNotes` resource, which uses the same `ConfigWidget`. Funny enough, `Contacts` resource, which is somewhat similar, is not affected as it has the same `Settings->save()` call. Alternative approaches include: 1) Teach `Maildir` to drop the schema (if it's there). 2) Teach `KCoreConfigSkeleton::ItemPath` to work with `QUrl` and don't append schema (it makes sense, because `ItemPath` corresponds to local file. Although it's not documented that it shouldn't have schema, it seems from the tests that it was the original intent). This could save the headache of having such issue in the future, but it could mess up with other programs in funny ways (as currently `file:` sometimes gets prepended, and some code might implicitly rely on it) Additional note: There are `ui.kcfg_Path->url().isLocalFile()` checks around, which doesn't make sense to me, as `KUrlRequester` is used for local files and it seems like it always returns `QUrl` pointing to local file (i.e. have the `file:` schema). Related: bug 408354, bug 413588 Test Plan: 1) Open `akonadiconsole -> Local Folders` properties, change the folder, save 2) `cat ~/.config/akonadi_maildir_resource_0rc`. `file:` schema gets prepended 2.1) `akonadictl restart`. `file:` folder gets created inside homedir 3) Apply patch, repeat (1)-(2.1). `file:` schema is dropped. Reviewers: dvratil, mlaurent Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27722 M +1-0resources/maildir/configwidget.cpp https://commits.kde.org/kdepim-runtime/93ecfacfb9f21ee027dbcfc7d5d47ddbbb253ba1 -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 413588] always inserts file:// into path
https://bugs.kde.org/show_bug.cgi?id=413588 Igor Poboiko changed: What|Removed |Added Latest Commit||https://commits.kde.org/kde ||pim-runtime/93ecfacfb9f21ee ||027dbcfc7d5d47ddbbb253ba1 Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #2 from Igor Poboiko --- Git commit 93ecfacfb9f21ee027dbcfc7d5d47ddbbb253ba1 by Igor Poboiko. Committed on 01/03/2020 at 18:44. Pushed by poboiko into branch 'master'. [resources/maildir] Don't save "file:" schema to the config Summary: `ConfigWidget` uses `KConfig` underneath, and utilizes `KUrlRequester` custom widget. The `USER` property of this widget (which is used by `KConfig`) is of type `QUrl`, and thus when dialog is accepted, the `path` config property gets overriden with `QUrl::toString()` value, which prepends `file:` schema (this is basically because `KCoreConfigSkeleton::ItemPath` is inherited from `ItemString`, and when someone calls `ItemString::setProperty`, it gets casted as `QVariant::toString`). Inside the `ConfigWidget::save` the code calls `setPath` method on `url.toLocalFile`, which drops the scheme. Because of that, the `pathItem` and `path` property of `mSettings` have different values, first has schema and the second hasn't. Eventually, the value stored by `pathItem` wins, and `mSettings->path()` returns URL with schema. However, `Maildir` doesn't expect it and misinterprets it as the relative path to current WORKDIR (which is home directory), thus creating `/home/user/file:/home/user/...` file structure. The proposed solution is to simply call `mSettings->save()`, which overrides `pathItem` value and drops schema from it. It also fixes the `AkoNotes` resource, which uses the same `ConfigWidget`. Funny enough, `Contacts` resource, which is somewhat similar, is not affected as it has the same `Settings->save()` call. Alternative approaches include: 1) Teach `Maildir` to drop the schema (if it's there). 2) Teach `KCoreConfigSkeleton::ItemPath` to work with `QUrl` and don't append schema (it makes sense, because `ItemPath` corresponds to local file. Although it's not documented that it shouldn't have schema, it seems from the tests that it was the original intent). This could save the headache of having such issue in the future, but it could mess up with other programs in funny ways (as currently `file:` sometimes gets prepended, and some code might implicitly rely on it) Additional note: There are `ui.kcfg_Path->url().isLocalFile()` checks around, which doesn't make sense to me, as `KUrlRequester` is used for local files and it seems like it always returns `QUrl` pointing to local file (i.e. have the `file:` schema). Related: bug 408354, bug 411269 Test Plan: 1) Open `akonadiconsole -> Local Folders` properties, change the folder, save 2) `cat ~/.config/akonadi_maildir_resource_0rc`. `file:` schema gets prepended 2.1) `akonadictl restart`. `file:` folder gets created inside homedir 3) Apply patch, repeat (1)-(2.1). `file:` schema is dropped. Reviewers: dvratil, mlaurent Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27722 M +1-0resources/maildir/configwidget.cpp https://commits.kde.org/kdepim-runtime/93ecfacfb9f21ee027dbcfc7d5d47ddbbb253ba1 -- You are receiving this mail because: You are watching all bug changes.
[kmail2] [Bug 408354] If default maildir folder is changed a new set of folders are stored under "/home/$user/file:"
https://bugs.kde.org/show_bug.cgi?id=408354 Igor Poboiko changed: What|Removed |Added Status|REPORTED|RESOLVED Latest Commit||https://commits.kde.org/kde ||pim-runtime/93ecfacfb9f21ee ||027dbcfc7d5d47ddbbb253ba1 Resolution|--- |FIXED --- Comment #11 from Igor Poboiko --- Git commit 93ecfacfb9f21ee027dbcfc7d5d47ddbbb253ba1 by Igor Poboiko. Committed on 01/03/2020 at 18:44. Pushed by poboiko into branch 'master'. [resources/maildir] Don't save "file:" schema to the config Summary: `ConfigWidget` uses `KConfig` underneath, and utilizes `KUrlRequester` custom widget. The `USER` property of this widget (which is used by `KConfig`) is of type `QUrl`, and thus when dialog is accepted, the `path` config property gets overriden with `QUrl::toString()` value, which prepends `file:` schema (this is basically because `KCoreConfigSkeleton::ItemPath` is inherited from `ItemString`, and when someone calls `ItemString::setProperty`, it gets casted as `QVariant::toString`). Inside the `ConfigWidget::save` the code calls `setPath` method on `url.toLocalFile`, which drops the scheme. Because of that, the `pathItem` and `path` property of `mSettings` have different values, first has schema and the second hasn't. Eventually, the value stored by `pathItem` wins, and `mSettings->path()` returns URL with schema. However, `Maildir` doesn't expect it and misinterprets it as the relative path to current WORKDIR (which is home directory), thus creating `/home/user/file:/home/user/...` file structure. The proposed solution is to simply call `mSettings->save()`, which overrides `pathItem` value and drops schema from it. It also fixes the `AkoNotes` resource, which uses the same `ConfigWidget`. Funny enough, `Contacts` resource, which is somewhat similar, is not affected as it has the same `Settings->save()` call. Alternative approaches include: 1) Teach `Maildir` to drop the schema (if it's there). 2) Teach `KCoreConfigSkeleton::ItemPath` to work with `QUrl` and don't append schema (it makes sense, because `ItemPath` corresponds to local file. Although it's not documented that it shouldn't have schema, it seems from the tests that it was the original intent). This could save the headache of having such issue in the future, but it could mess up with other programs in funny ways (as currently `file:` sometimes gets prepended, and some code might implicitly rely on it) Additional note: There are `ui.kcfg_Path->url().isLocalFile()` checks around, which doesn't make sense to me, as `KUrlRequester` is used for local files and it seems like it always returns `QUrl` pointing to local file (i.e. have the `file:` schema). Related: bug 411269, bug 413588 Test Plan: 1) Open `akonadiconsole -> Local Folders` properties, change the folder, save 2) `cat ~/.config/akonadi_maildir_resource_0rc`. `file:` schema gets prepended 2.1) `akonadictl restart`. `file:` folder gets created inside homedir 3) Apply patch, repeat (1)-(2.1). `file:` schema is dropped. Reviewers: dvratil, mlaurent Reviewed By: dvratil Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D27722 M +1-0resources/maildir/configwidget.cpp https://commits.kde.org/kdepim-runtime/93ecfacfb9f21ee027dbcfc7d5d47ddbbb253ba1 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 394750] baloo_file fills RAM and disk for hours with no visible progress
https://bugs.kde.org/show_bug.cgi?id=394750 --- Comment #11 from Igor Poboiko --- (In reply to p from comment #10) > same issue here on a fresh install of opensuse 15.1. It kills my system > completely. Makes baloo unusable. Sad. Considering that the report was open > one and half years ago I assume we don't can hope for a fix. Sad. So, which files does it choke on? What does `balooctl status` / `balooctl monitor` report? -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 409499] Krunner returns empty item
https://bugs.kde.org/show_bug.cgi?id=409499 --- Comment #5 from Igor Poboiko --- Whoops, sorry. KF 5.60 is the most recent version for now. Have you tried clearing your index with 5.60? It should be fine. -- You are receiving this mail because: You are watching all bug changes.
[krunner] [Bug 409499] Krunner returns empty item
https://bugs.kde.org/show_bug.cgi?id=409499 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #3 from Igor Poboiko --- This can be related to bug 409257, which should be fixed in KF 5.60. Can you try the most recent version? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 409257] Baloo index gets corrupted, no results
https://bugs.kde.org/show_bug.cgi?id=409257 Igor Poboiko changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 409257] Baloo index gets corrupted, no results
https://bugs.kde.org/show_bug.cgi?id=409257 --- Comment #30 from Igor Poboiko --- (In reply to S from comment #29) > Over here: > https://bugzilla.suse.com/show_bug.cgi?id=1141028 > (Stefan Brüns) > > A fix is already included in KF5.60. He probably refers to the following commit (which I kind of missed here - sorry about it) - https://cgit.kde.org/baloo.git/commit/?id=8e7b54c54764f3e6eae7d79f0e0ce3079d56a3a0. It should also work (and if it does, please drop a comment here so we can close this issue) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 409257] Baloo index gets corrupted, no results
https://bugs.kde.org/show_bug.cgi?id=409257 --- Comment #24 from Igor Poboiko --- (In reply to Gerson from comment #21) > since the upload limit is 4MB, I'll attach the file with an online system: > > https://ufile.io/60gkivz8 > > The file (index.tgz) will be available for 30 days starting now. OK, I've looked at it. Baloo stores internally filesystem tree inside index in order to be able to reconstruct full path of particular document id. The root of this tree should correspond to root directory "/" (id = 0). In your case, it is not so, the tree corresponds to your home directory instead (this can be deduced from non-corrupted index), which is why Baloo is not happy - it cannot resolve paths. This patch might help: https://phabricator.kde.org/D21427. Can anyone confirm? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 409257] Baloo index gets corrupted, no results
https://bugs.kde.org/show_bug.cgi?id=409257 --- Comment #23 from Igor Poboiko --- (In reply to Gerson from comment #21) > since the upload limit is 4MB, I'll attach the file with an online system: > > https://ufile.io/60gkivz8 > > The file (index.tgz) will be available for 30 days starting now. Your help is very much appreciated! I will investigate it. > In my case, actually, it seems that the db only corrupts after I restart the > computer. Does it happen after each restart, or only sometimes? Is it enough to just restart baloo to corrupt index? (i.e. run in the terminal "balooctl stop" and then "balooctl start") -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 409257] Baloo index gets corrupted, no results
https://bugs.kde.org/show_bug.cgi?id=409257 --- Comment #18 from Igor Poboiko --- We would really appreciate if someone who experiences this could send us a corrupted "~/.local/share/baloo/index" entry. Just be aware that it will most likely contain a lot of personal information. If you don't want it to be exposed, make sure to add folders which you don't want to be indexed to "Do not search in these locations", inside "SystemSettings -> Search -> File Search". Alternatively, you can create a new user (with no personal information at all), and try to reproduce it. Thanks! > Even after I clear all folders, the file size won't change. > The command 'balooctl indexSize' shows that the used space is much smaller. > But it seems that it remains something broken within the index file. It's one of the peculiarities of the underlying database, LMDB. It uses Copy-on-Write, and database actually doesn't shrink. But it can reuse memory pages that became free later on (so after clear, db size might actually not change at all). > Another curious thing. I'm indexing only the file names, and not the content. > Nonetheless, the process feels a bit too fast. Disabling and re-enabling > baloo, the re-indexing process is almost instantaneous. > Is it actually running the file name indexing from scratch? > Or using some backup of the index file stored in a cache somewhere? Filename indexing should be quite fast (don't know how fast is "too fast" though - but I think it takes less than a second in my case, which is ~13.5k documents inside index). Baloo don't have any backups / caches for it, it only can redo it from scratch. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 409257] Baloo index gets corrupted, no results
https://bugs.kde.org/show_bug.cgi?id=409257 --- Comment #13 from Igor Poboiko --- (In reply to S from comment #9) > I would assume directory. :-) Here's what happened: > > [...] It doesn't really matter, file or directory. Your problem looks like corruption of IdTreeDB, when for some reason Baloo "forgets" about some of the top-level directories, and then just cannot resolve path of particular documents. Reindexing of a single file might restore this information. (and it will also help us to know whether it is the problem) > > Then I tried the suggestion from above: > > > balooctl disable && balooctl enable > > Disabling the File Indexer > > Enabling the File Indexer These commands will totally wipe your database and then rebuild it from scratch. Although it will most likely help, it's also a pretty time consuming operation. > > Then I get a large number of errors like this from a directory I have full > of .rtf files: >[...] Those are non-critical errors, it's more like debug-messages, reporting different problems when extracting metadata from various files on your computer. Logging them would not be much useful. I don't even know why they are written to the terminal (it might depend on some of your distro default settings, probably?) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 405094] Symbols in name break search
https://bugs.kde.org/show_bug.cgi?id=405094 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #1 from Igor Poboiko --- The problem here is that short terms (of length < 3) are only matched *exactly*. This is intentional: because if we match them by prefix (like we do with longer terms) there will most likely be just too many matches. So in your case 'AB 1' doesn't match files #1 and #3 because they don't contain "1" exactly. But all of them do contain "AB" exactly. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 379391] balooctl monitor command does not appear in help output
https://bugs.kde.org/show_bug.cgi?id=379391 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com Resolution|--- |FIXED Status|REPORTED|RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 378726] baloosearch doesn't find certain substrings
https://bugs.kde.org/show_bug.cgi?id=378726 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #9 from Igor Poboiko --- When expanding search query, terms which are connected with underscore (i.e query [nategraham_notnategraham]) are expanded as phrase query (equivalent to query ["nategraham notnategraham"]), meaning that these two words should match *exactly* and to be in this particular order. Phrase searches by prefix (when the second term is not written completely, but just its prefix - like ["nategraham notnate"]) are unfortunately not yet implemented. As a workaround I suggest replacing underscore with AND (i.e. just [nategraham AND notnate]) - in that case your document will match. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 409257] Baloo index gets corrupted, no results
https://bugs.kde.org/show_bug.cgi?id=409257 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #7 from Igor Poboiko --- Instead rebuilding the whole index, try performing `balooctl clear ~/somefile && balooctl index ~/somefile` (on some existing file inside your home folder) -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 387500] Switching layout with Alt+Shift negates shortcuts with Ctrl+Alt+Shift
https://bugs.kde.org/show_bug.cgi?id=387500 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #8 from Igor Poboiko --- See bug 383113. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 375518] global shortcuts show some oddities with foreign keyboard layouts
https://bugs.kde.org/show_bug.cgi?id=375518 Igor Poboiko changed: What|Removed |Added CC||zvova7...@gmail.com --- Comment #9 from Igor Poboiko --- *** Bug 407703 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kwindowsystem] [Bug 407703] [Wayland] Shortcut Alt + ~ for switch same class window is not working with non US layout
https://bugs.kde.org/show_bug.cgi?id=407703 Igor Poboiko changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |DUPLICATE CC||igor.pobo...@gmail.com --- Comment #1 from Igor Poboiko --- *** This bug has been marked as a duplicate of bug 375518 *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 375518] global shortcuts show some oddities with foreign keyboard layouts
https://bugs.kde.org/show_bug.cgi?id=375518 --- Comment #8 from Igor Poboiko --- Related link to the same bug in Qt: https://bugreports.qt.io/browse/QTBUG-66497 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 397242] Baloo gets confused when a file is renamed over existing one
https://bugs.kde.org/show_bug.cgi?id=397242 --- Comment #10 from Igor Poboiko --- It might be intentional: IIRC, Baloo doesn't want to reindex the same file too often (so it won't kill your machine when it finds i.e. logs being continuously written) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 397242] Baloo gets confused when a file is renamed over existing one
https://bugs.kde.org/show_bug.cgi?id=397242 --- Comment #8 from Igor Poboiko --- It is indeed weird. What filesystem do you use? How does "balooctl monitor" react to those files? -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 373430] No immediate effect of adding currently indexed dir to excludes.
https://bugs.kde.org/show_bug.cgi?id=373430
Igor Poboiko changed:
What|Removed |Added
Latest Commit||https://commits.kde.org/bal
||oo/e58804bf9eb8d507d3ef4aa8
||faf12d6854f5a8bc
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #9 from Igor Poboiko ---
Git commit e58804bf9eb8d507d3ef4aa8faf12d6854f5a8bc by Igor Poboiko.
Committed on 20/03/2019 at 09:01.
Pushed by poboiko into branch 'master'.
React to config updates inside indexer
Summary:
In case a config was changed, we need to:
1. Stop the ContentIndexer (bug 373430)
2. Remove all scheduled indexing of files that should not be indexed
3. Check for stale index entries. Those includes documents marked for
indexing, that should be removed
(because of that we need to do it inside `scheduleIndexing` before content
indexing)
4. Finally, check for unindexed files (if new files were added)
(based on {D15939}). Also note that `IndexCleaner` should clean all files, not
just those inside `includeFolders`
Test Plan:
Seems to be working. But it would be nice to test it more.
1. Add large folder to config. `baloo_file` start indexing it.
2. Add it to exclude list. `baloo_file` stops indexing it, and removes entries
from DB.
3. Remove it from exclude list. `baloo_file` starts indexing it again.
Reviewers: #baloo, #frameworks, bruns, ngraham
Reviewed By: #baloo, ngraham
Subscribers: kde-frameworks-devel, bruns
Tags: #frameworks, #baloo
Differential Revision: https://phabricator.kde.org/D15983
M +38 -10 src/file/fileindexscheduler.cpp
M +1-0src/file/fileindexscheduler.h
M +7-0src/file/indexcleaner.cpp
M +1-2src/file/mainhub.cpp
https://commits.kde.org/baloo/e58804bf9eb8d507d3ef4aa8faf12d6854f5a8bc
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-baloo] [Bug 397242] Baloo gets confused when a file is renamed over existing one
https://bugs.kde.org/show_bug.cgi?id=397242 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #5 from Igor Poboiko --- That was supposed to be caused by the same issue. Sorry, I cannot reproduce it anymore. Your script (with NAME="testfile" and CONTENT="testtesttest", since I don't have pwgen) yields: ``` /home/eol/testfile_1.txt /home/eol/testfile_2.txt /home/eol/test.sh Elapsed: 0.299802 msecs renamed 'testfile_1.txt' -> 'testfile_2.txt' /home/eol/testfile_2.txt /home/eol/test.sh Elapsed: 0.277733 msecs ``` while monitor yields: ``` Indexing new files Indexing file content Indexing: /home/eol/testfile_1.txt: Ok Indexing: /home/eol/testfile_2.txt: Ok Idle Indexing modified files Indexing file content Indexing: /home/eol/testfile_2.txt: Ok ``` so everythings seems to be running smooth... -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 353874] Baloo does not remove deleted files from index
https://bugs.kde.org/show_bug.cgi?id=353874 Igor Poboiko changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC||igor.pobo...@gmail.com Resolution|--- |FIXED --- Comment #10 from Igor Poboiko --- This should have been fixed by https://phabricator.kde.org/D15939 and commit https://phabricator.kde.org/R293:f8897a2511c4652c203bf25f6d788d0a698e4203 Feel free to reopen if this bug still affects you. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 342224] Indexing inside a diretory fails if the directory was created in a blacklisted symlinked place then moved to a symlinked directory
https://bugs.kde.org/show_bug.cgi?id=342224 Igor Poboiko changed: What|Removed |Added Status|REPORTED|RESOLVED Latest Commit||https://commits.kde.org/bal ||oo/5e1add922ab2a1d6b4a2131b ||846c5a9d964c43a2 Resolution|--- |FIXED --- Comment #3 from Igor Poboiko --- Git commit 5e1add922ab2a1d6b4a2131b846c5a9d964c43a2 by Igor Poboiko. Committed on 15/02/2019 at 15:41. Pushed by poboiko into branch 'master'. [baloo/KInotify] Notify if folder was moved from unwatched place Summary: If a folder was moved from an unwatched place, `KInotify` will receive an `EventMoveTo` event, which doesn't have an `EventMoveFrom` counterpart, and thus it will emit only `created` signal for the moved directory, but not its contents. It also won't install watches for the directory (as it does in `EventCreate`). Instead use FilteredDirIterator to emit created() signal for all the contents as well, and add inotify watches. It should also now handle the race condition if a directory was created and files were moved inside it before an inotify watch for this directory was installed. Note that it's not really realted to symbolic links, one just has to move a folder from excluded place to included. Test Plan: Added a test case for `KInotifyTest`, similar to one described in Bug 342224. It passes now. Reviewers: #baloo, #frameworks, ngraham, bruns Reviewed By: #baloo, ngraham, bruns Subscribers: bruns, ngraham, kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D18698 M +37 -0autotests/unit/file/kinotifytest.cpp M +24 -4src/file/kinotify.cpp M +8-0src/file/kinotify.h https://commits.kde.org/baloo/5e1add922ab2a1d6b4a2131b846c5a9d964c43a2 -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kfilemetadata] [Bug 361259] baloo crashes
https://bugs.kde.org/show_bug.cgi?id=361259 Igor Poboiko changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kfi ||lemetadata/5eee9ac75b7d6bb1 ||9795c2d3b964fe05fd8fc47c Status|REPORTED|RESOLVED --- Comment #1 from Igor Poboiko --- Git commit 5eee9ac75b7d6bb19795c2d3b964fe05fd8fc47c by Igor Poboiko. Committed on 16/10/2018 at 13:56. Pushed by poboiko into branch 'master'. Don't crash on invalid exiv2 data Summary: The file from bug 375131 crashes `baloo_file_extractor`. The problem is that its EXIF data contains a key `Exif.Photo.FocalLength`, whose type is `Exiv2::unsignedRational`, and whose value is empty. On the other hand, the `Exiv2::Value::toFloat()` call relies on at least single component of a value, causing undefined behavior (i.e. crash) if there is none. This is simple workaround: if we got a property with no value, just return an empty QVariant(). (unfortunately, didn't manage to reproduce the hang reported in the bug originally) Related: bug 352856, bug 353848, bug 375131 Test Plan: `baloo_file_extractor` no longer crashes on the file, it processes the file and extracts all the necessary data Reviewers: #baloo, #frameworks, astippich Reviewed By: astippich Subscribers: bruns, astippich, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D16165 M +3-0src/extractors/exiv2extractor.cpp https://commits.kde.org/kfilemetadata/5eee9ac75b7d6bb19795c2d3b964fe05fd8fc47c -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 375131] baloo hangs up forever when it reachs a corrupted file.
https://bugs.kde.org/show_bug.cgi?id=375131 --- Comment #6 from Igor Poboiko --- Git commit 5eee9ac75b7d6bb19795c2d3b964fe05fd8fc47c by Igor Poboiko. Committed on 16/10/2018 at 13:56. Pushed by poboiko into branch 'master'. Don't crash on invalid exiv2 data Summary: The file from bug 375131 crashes `baloo_file_extractor`. The problem is that its EXIF data contains a key `Exif.Photo.FocalLength`, whose type is `Exiv2::unsignedRational`, and whose value is empty. On the other hand, the `Exiv2::Value::toFloat()` call relies on at least single component of a value, causing undefined behavior (i.e. crash) if there is none. This is simple workaround: if we got a property with no value, just return an empty QVariant(). (unfortunately, didn't manage to reproduce the hang reported in the bug originally) Related: bug 352856, bug 353848, bug 361259 Test Plan: `baloo_file_extractor` no longer crashes on the file, it processes the file and extracts all the necessary data Reviewers: #baloo, #frameworks, astippich Reviewed By: astippich Subscribers: bruns, astippich, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D16165 M +3-0src/extractors/exiv2extractor.cpp https://commits.kde.org/kfilemetadata/5eee9ac75b7d6bb19795c2d3b964fe05fd8fc47c -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kfilemetadata] [Bug 353848] Baloo File Extractor crashes after startup
https://bugs.kde.org/show_bug.cgi?id=353848 Igor Poboiko changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kfi ||lemetadata/5eee9ac75b7d6bb1 ||9795c2d3b964fe05fd8fc47c --- Comment #1 from Igor Poboiko --- Git commit 5eee9ac75b7d6bb19795c2d3b964fe05fd8fc47c by Igor Poboiko. Committed on 16/10/2018 at 13:56. Pushed by poboiko into branch 'master'. Don't crash on invalid exiv2 data Summary: The file from bug 375131 crashes `baloo_file_extractor`. The problem is that its EXIF data contains a key `Exif.Photo.FocalLength`, whose type is `Exiv2::unsignedRational`, and whose value is empty. On the other hand, the `Exiv2::Value::toFloat()` call relies on at least single component of a value, causing undefined behavior (i.e. crash) if there is none. This is simple workaround: if we got a property with no value, just return an empty QVariant(). (unfortunately, didn't manage to reproduce the hang reported in the bug originally) Related: bug 352856, bug 361259, bug 375131 Test Plan: `baloo_file_extractor` no longer crashes on the file, it processes the file and extracts all the necessary data Reviewers: #baloo, #frameworks, astippich Reviewed By: astippich Subscribers: bruns, astippich, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D16165 M +3-0src/extractors/exiv2extractor.cpp https://commits.kde.org/kfilemetadata/5eee9ac75b7d6bb19795c2d3b964fe05fd8fc47c -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kfilemetadata] [Bug 352856] Baloo file extractor crashes in libexiv2 at login
https://bugs.kde.org/show_bug.cgi?id=352856 Igor Poboiko changed: What|Removed |Added Latest Commit||https://commits.kde.org/kfi ||lemetadata/5eee9ac75b7d6bb1 ||9795c2d3b964fe05fd8fc47c Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #1 from Igor Poboiko --- Git commit 5eee9ac75b7d6bb19795c2d3b964fe05fd8fc47c by Igor Poboiko. Committed on 16/10/2018 at 13:56. Pushed by poboiko into branch 'master'. Don't crash on invalid exiv2 data Summary: The file from bug 375131 crashes `baloo_file_extractor`. The problem is that its EXIF data contains a key `Exif.Photo.FocalLength`, whose type is `Exiv2::unsignedRational`, and whose value is empty. On the other hand, the `Exiv2::Value::toFloat()` call relies on at least single component of a value, causing undefined behavior (i.e. crash) if there is none. This is simple workaround: if we got a property with no value, just return an empty QVariant(). (unfortunately, didn't manage to reproduce the hang reported in the bug originally) Related: bug 353848, bug 361259, bug 375131 Test Plan: `baloo_file_extractor` no longer crashes on the file, it processes the file and extracts all the necessary data Reviewers: #baloo, #frameworks, astippich Reviewed By: astippich Subscribers: bruns, astippich, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D16165 M +3-0src/extractors/exiv2extractor.cpp https://commits.kde.org/kfilemetadata/5eee9ac75b7d6bb19795c2d3b964fe05fd8fc47c -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 394750] baloo_file fills RAM and disk for hours with no visible progress
https://bugs.kde.org/show_bug.cgi?id=394750 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #4 from Igor Poboiko --- Could you(In reply to Thaddee Tyl from comment #0) > If that large folder and the iso are the files that baloo_file chokes on, > could we make Baloo give up if it spends more than 10 seconds on a single > file or folder? (An `ls` on the Go games folder takes 11 minutes.) I guess in that case Baloo does can choke on this directory. And, I guess, this setup is indeed somewhat unusual. I suggest adding this folder to "exclude" list (it's available inside "systemsettings", in "Workspace -> Search -> File Search" category. Does this Go game files have a special mime-type? We have a list of blacklisted mimetypes inside Baloo (which currently includes mostly source-code files), we can blacklist it by default (as it hardly contains useful information for indexing, right?) > Philosophically, it makes more sense to whitelist files by type than to > index files that are unlikely to be properly read. Looking through the > configuration parameters, it looks like files are blacklisted by type. It > would make more sense to whitelist them: there are more file types that are > unreadable than there are supported ones. Most users only care about > indexing of .pdf, .docx and .jpg files, maybe a handful of others. I don't > see a use-case for indexing an .iso file. Yet it is neither in > excludeFilters nor in excludeMimetypes by default. Baloo relies on KFileMetaData framework to index files: if we can extract data from file, we do it. But it only supports use-cases relevant for users (documents, pictures, audio files, etc.). I'm not really sure iso-files are being indexed at all, as KFileMetaData does not support them (well, because there is not much to be extracted that is relevant for user...). > Aside. Is Baloo indexing file paths themselves? It would be both pretty > inefficient and a duplication of effort, since mlocate does it stellarly and > yet unnoticeably. /var/lib/mlocate is 98 MiB and `locate *.pdf` takes about > a second to run. It does. Also, Baloo is supposed to be self-sufficient, it's not supposed to be used together with mlocate, it's a separate indexing system. > Finally, when Baloo does pointless busywork, it would be welcome to have > more debugging tools. > balooctl could have a command to debug what baloo_file is currently indexing. "balooctl monitor" does that. (well, unfortunately it was not possible to print _current_ file being indexed, but this will be fixed in 5.52 release, see https://cgit.kde.org/baloo.git/commit/?id=a9696978322c08d19ece0a67f430aee391e3918d) -- You are receiving this mail because: You are watching all bug changes.
[frameworks-baloo] [Bug 364858] Regression: Re-add a decent way of displaying what files baloo is indexing / extracting
https://bugs.kde.org/show_bug.cgi?id=364858
Igor Poboiko changed:
What|Removed |Added
Status|REPORTED|RESOLVED
Version Fixed In||5.52
Resolution|--- |FIXED
Latest Commit||https://commits.kde.org/bal
||oo/a9696978322c08d19ece0a67
||f430aee391e3918d
--- Comment #1 from Igor Poboiko ---
Git commit a9696978322c08d19ece0a67f430aee391e3918d by Igor Poboiko.
Committed on 08/10/2018 at 22:16.
Pushed by poboiko into branch 'master'.
[balooctl] Print current state & indexing file when monitor starts
Summary:
This is based on {D15943}.
Simply print current state & file when monitor starts.
FIXED-IN: 5.52
Test Plan:
`balooctl monitor` now prints
```
Press ctrl+c to stop monitoring
File indexer is running
Idle
```
Reviewers: #baloo, #frameworks, bruns, ngraham
Reviewed By: #baloo, bruns, ngraham
Subscribers: ngraham, bruns
Differential Revision: https://phabricator.kde.org/D15985
M +5-0src/tools/balooctl/monitorcommand.cpp
https://commits.kde.org/baloo/a9696978322c08d19ece0a67f430aee391e3918d
--
You are receiving this mail because:
You are watching all bug changes.
[frameworks-baloo] [Bug 397242] Baloo gets confused when a file is renamed over existing one
https://bugs.kde.org/show_bug.cgi?id=397242 Igor Poboiko changed: What|Removed |Added Latest Commit||https://commits.kde.org/bal ||oo/7e5c005e6a3b563013e2ba8c ||b9c8f1b282e6f7b2 Resolution|--- |FIXED Version Fixed In||5.52 Status|CONFIRMED |RESOLVED --- Comment #3 from Igor Poboiko --- Git commit 7e5c005e6a3b563013e2ba8cb9c8f1b282e6f7b2 by Igor Poboiko. Committed on 08/10/2018 at 22:10. Pushed by poboiko into branch 'master'. [balooctl] Fix "index" command with already indexed, but moved file Summary: If I move a file (while baloo was not running) and perform `balooctl index` on new file (so that document Id is not changed), it won't update the path of the file, keeping the invalid entry in index. Explicitly tell Baloo that we want to update everything concerning this file. FIXED-IN: 5.52 Test Plan: 1) `echo "hello world" >~/file1` 2) `balooctl stop` 3) `mv ~/file1 ~/file2` 4) `balooctl start && balooctl index ~/file2` 5) `balooshow file2` and `balooshow -x ` The first command should show the right path, and the second command shouldn't complain about bug in Baloo (invalid index entry) Reviewers: #baloo, #frameworks, ngraham Reviewed By: #baloo, ngraham Subscribers: ngraham, kde-frameworks-devel Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D15944 M +1-1src/tools/balooctl/indexer.cpp https://commits.kde.org/baloo/7e5c005e6a3b563013e2ba8cb9c8f1b282e6f7b2 -- You are receiving this mail because: You are watching all bug changes.
[systemsettings] [Bug 387941] "Enable file search" checkbox work at the contrary
https://bugs.kde.org/show_bug.cgi?id=387941 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #2 from Igor Poboiko --- My guess is the following: what you disable by this checkbox is the indexer, and not file search itself. Files that are already indexed are still shown. However, when you re-enable the checkbox, baloo wipes its index entirely and starts building it from scratch. And that leads to no results (immediately after enabling). However, after some time they should appear. Is that the case? -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 390366] Cube Slide does not work on wayland
https://bugs.kde.org/show_bug.cgi?id=390366
Igor Poboiko changed:
What|Removed |Added
Version Fixed In||5.15.0
Latest Commit||https://commits.kde.org/kwi
||n/1115ca84902ad75f44a75df44
||9f134795e3f0f47
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Igor Poboiko ---
Git commit 1115ca84902ad75f44a75df449f134795e3f0f47 by Igor Poboiko.
Committed on 17/09/2018 at 19:27.
Pushed by poboiko into branch 'master'.
[effects/cubeslide] Fix "sticky" windows detection on Wayland
Summary: This is second part of {D15175}, and aimed at fixing Bug 390366.
The problem was that effect relied on isManaged() to detect OSDs and
notifications, that should be painted on top of the cube. On Wayland, the
desktop window itself is not managed, which made it "sticky".
Instead we use isSpecialWindow() check to explicitly make notifications and
OSDs sticky.
It still requires fixing Plasma::Dialog, since it does not set
isSpecialWindow() flag correctly.
Reviewers: #kwin, davidedmundson
Reviewed By: #kwin, davidedmundson
Subscribers: kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D15496
FIXED-IN: 5.15.0
M +1-1effects/cube/cubeslide.cpp
https://commits.kde.org/kwin/1115ca84902ad75f44a75df449f134795e3f0f47
--
You are receiving this mail because:
You are watching all bug changes.
[kwin] [Bug 362360] When switching virtual desktops with the Desktop Cube Animation effect, the Blur and Background Contrast effect cause visual artifacts in the upper right quarter of the screen
https://bugs.kde.org/show_bug.cgi?id=362360 Igor Poboiko changed: What|Removed |Added Latest Commit||https://commits.kde.org/kwi ||n/ca1b5ea1070ccd23dd742f35d ||449e4a531ff7951 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Version Fixed In||5.15.0 --- Comment #14 from Igor Poboiko --- Git commit ca1b5ea1070ccd23dd742f35d449e4a531ff7951 by Igor Poboiko. Committed on 14/09/2018 at 09:36. Pushed by poboiko into branch 'master'. [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect Summary: Bugs occurred because KWin was not very happy when windows were painted during CubeSlideEffect::paintScreen(). Another issue is that blur, although it was supposed to, did not work at all (haven't found appropriate bug on bugzilla). As well as background contrast effect. This patch does the following thing: - Adopted WindowForceBlur / WindowForceBackgroundContrast logic from SlideEffect, instead of panels/stickyWindows QSets (those become useless anyway) - Added shouldAnimate code, which determines whether a window should be animated with the cube (i.e. ordinary windows) or should stick (i.e. panels or pinned windows, if corresponding options are checked in the settings) - It paints an additional non-transformed screen, on which it paints only "sticky" windows. This is done because otherwise KWin would apply blur not behind the OSD, but on the same place on moving cube face. - (in addition) switched to new Qt5 connect syntax. Reviewers: #kwin, zzag Differential Revision: https://phabricator.kde.org/D15175 Related: bug 361516 FIXED-IN: 5.15.0 M +87 -54 effects/cube/cubeslide.cpp M +10 -3effects/cube/cubeslide.h https://commits.kde.org/kwin/ca1b5ea1070ccd23dd742f35d449e4a531ff7951 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 361516] Panel on top/left cause a black window in cube animation
https://bugs.kde.org/show_bug.cgi?id=361516 Igor Poboiko changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In||5.15.0 Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kwi ||n/ca1b5ea1070ccd23dd742f35d ||449e4a531ff7951 --- Comment #18 from Igor Poboiko --- Git commit ca1b5ea1070ccd23dd742f35d449e4a531ff7951 by Igor Poboiko. Committed on 14/09/2018 at 09:36. Pushed by poboiko into branch 'master'. [effects/cubeslide] Fix visual glitches with Blur / BackgroundContrast effect Summary: Bugs occurred because KWin was not very happy when windows were painted during CubeSlideEffect::paintScreen(). Another issue is that blur, although it was supposed to, did not work at all (haven't found appropriate bug on bugzilla). As well as background contrast effect. This patch does the following thing: - Adopted WindowForceBlur / WindowForceBackgroundContrast logic from SlideEffect, instead of panels/stickyWindows QSets (those become useless anyway) - Added shouldAnimate code, which determines whether a window should be animated with the cube (i.e. ordinary windows) or should stick (i.e. panels or pinned windows, if corresponding options are checked in the settings) - It paints an additional non-transformed screen, on which it paints only "sticky" windows. This is done because otherwise KWin would apply blur not behind the OSD, but on the same place on moving cube face. - (in addition) switched to new Qt5 connect syntax. Reviewers: #kwin, zzag Differential Revision: https://phabricator.kde.org/D15175 Related: bug 362360 FIXED-IN: 5.15.0 M +87 -54 effects/cube/cubeslide.cpp M +10 -3effects/cube/cubeslide.h https://commits.kde.org/kwin/ca1b5ea1070ccd23dd742f35d449e4a531ff7951 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 392677] "Pointer motion confined to the current window. To release pointer hold Escape for 3 seconds." notification upon trying to move XWayland app window
https://bugs.kde.org/show_bug.cgi?id=392677 Igor Poboiko changed: What|Removed |Added CC||igor.pobo...@gmail.com --- Comment #5 from Igor Poboiko --- (In reply to Martin Flöser from comment #1) > That is correct: the apps grab the mouse and KWin reacts accordingly. Could you please elaborate on that? I still can move my pointer wherever I want, and as far as I can see it isn't confined to the current window at all. And why does it affect only XWayland windows if it is correct behavior? In this particular case this notification seems to be at least misleading. -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 213599] Desktop cube reflection incorrect after doing a 90° down rotation - (Desktop cube animation 0.1.0)
https://bugs.kde.org/show_bug.cgi?id=213599 Igor Poboiko changed: What|Removed |Added Latest Commit||https://commits.kde.org/kwi ||n/6408e0ba6045d03b8872eab71 ||060ac8d6f13ee9f Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #7 from Igor Poboiko --- Git commit 6408e0ba6045d03b8872eab71060ac8d6f13ee9f by Igor Poboiko. Committed on 01/06/2018 at 15:32. Pushed by poboiko into branch 'master'. [effects/cube] Fix animation and reflection issues The main problem was that inside the effect there was manualVerticalAngle, which did not represent the actual rotation angle of the cube during the animation, but used to calculate the position of the reflection. The actual angle was calculated on-the-fly and was not exposed outside. Brief description of what the code does: - variables currentAngle and verticalCurrentAngle now always represent the current position of the cube. They are updated when one uses the mouse and inside the rotateCube() method, which is called in prePaintScreen(). - two queues, animations (used for Start / Stop / Left / Right) and verticalAnimations (used for Up / Down) are used for scheduling the animations if i.e. user presses several keys in a row. The code checks whether the last animation has finished (and thus we need to start a new one) inside prePaintScreen() and postPaintScreen() - when the animation starts, code saves the starting position of the cube inside startAngle, startFrontDesktop and verticalStartAngle variables, which are used to calculate the actual cube position during the animation later. This is done by startAnimation() and startVerticalAnimation(), which also calculates the QTimeLine curves needed for animation Related: bug 373101 Differential Revision: https://phabricator.kde.org/D9860 M +256 -441 effects/cube/cube.cpp M +26 -19 effects/cube/cube.h https://commits.kde.org/kwin/6408e0ba6045d03b8872eab71060ac8d6f13ee9f -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 373101] Incorrect reflection for cylinder animation (it uses cube reflection causing it to separate at edge)
https://bugs.kde.org/show_bug.cgi?id=373101 Igor Poboiko changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kwi ||n/6408e0ba6045d03b8872eab71 ||060ac8d6f13ee9f Resolution|--- |FIXED --- Comment #5 from Igor Poboiko --- Git commit 6408e0ba6045d03b8872eab71060ac8d6f13ee9f by Igor Poboiko. Committed on 01/06/2018 at 15:32. Pushed by poboiko into branch 'master'. [effects/cube] Fix animation and reflection issues The main problem was that inside the effect there was manualVerticalAngle, which did not represent the actual rotation angle of the cube during the animation, but used to calculate the position of the reflection. The actual angle was calculated on-the-fly and was not exposed outside. Brief description of what the code does: - variables currentAngle and verticalCurrentAngle now always represent the current position of the cube. They are updated when one uses the mouse and inside the rotateCube() method, which is called in prePaintScreen(). - two queues, animations (used for Start / Stop / Left / Right) and verticalAnimations (used for Up / Down) are used for scheduling the animations if i.e. user presses several keys in a row. The code checks whether the last animation has finished (and thus we need to start a new one) inside prePaintScreen() and postPaintScreen() - when the animation starts, code saves the starting position of the cube inside startAngle, startFrontDesktop and verticalStartAngle variables, which are used to calculate the actual cube position during the animation later. This is done by startAnimation() and startVerticalAnimation(), which also calculates the QTimeLine curves needed for animation Related: bug 213599 Differential Revision: https://phabricator.kde.org/D9860 M +256 -441 effects/cube/cube.cpp M +26 -19 effects/cube/cube.h https://commits.kde.org/kwin/6408e0ba6045d03b8872eab71060ac8d6f13ee9f -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 378688] Broken reflections in coverswitch on multi screen
https://bugs.kde.org/show_bug.cgi?id=378688 Igor Poboiko <igor.pobo...@gmail.com> changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://commits.kde.org/kwi ||n/e3f0b537b6b4684ef2ed013c6 ||1fdf6801f879db9 Status|UNCONFIRMED |RESOLVED --- Comment #4 from Igor Poboiko <igor.pobo...@gmail.com> --- Git commit e3f0b537b6b4684ef2ed013c61fdf6801f879db9 by Igor Poboiko. Committed on 25/03/2018 at 10:26. Pushed by poboiko into branch 'master'. [effects/coverswitch] Fix broken reflection on multi-monitor setup ModelViewMatrix used to paint windows (which is aware about multi-monitor configuration) was overriden by reflectionMatrix when painting reflections, leading to wrong placement of reflections. Now we just multiply old matrix and reflection matrix. Differential Revision: https://phabricator.kde.org/D10465 M +1-2effects/coverswitch/coverswitch.cpp https://commits.kde.org/kwin/e3f0b537b6b4684ef2ed013c61fdf6801f879db9 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 361516] Panel on top/left cause a black window in cube animation
https://bugs.kde.org/show_bug.cgi?id=361516 Igor Poboiko <igor.pobo...@gmail.com> changed: What|Removed |Added CC||zh...@outlook.com --- Comment #16 from Igor Poboiko <igor.pobo...@gmail.com> --- *** Bug 368144 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 368144] Black area in top-right screen when switch between pagers
https://bugs.kde.org/show_bug.cgi?id=368144 Igor Poboiko <igor.pobo...@gmail.com> changed: What|Removed |Added CC||igor.pobo...@gmail.com Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #2 from Igor Poboiko <igor.pobo...@gmail.com> --- *** This bug has been marked as a duplicate of bug 361516 *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 361516] Panel on top/left cause a black window in cube animation
https://bugs.kde.org/show_bug.cgi?id=361516 Igor Poboiko <igor.pobo...@gmail.com> changed: What|Removed |Added CC||skpl1...@gmail.com --- Comment #15 from Igor Poboiko <igor.pobo...@gmail.com> --- *** Bug 374854 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 374854] black square appears in right hand corner when using desktop cube workspace switching effect
https://bugs.kde.org/show_bug.cgi?id=374854 Igor Poboiko <igor.pobo...@gmail.com> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||igor.pobo...@gmail.com --- Comment #4 from Igor Poboiko <igor.pobo...@gmail.com> --- *** This bug has been marked as a duplicate of bug 361516 *** -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 383113] New: Ctrl+Shift+letter shortcuts don't work if Ctrl+Shift is used for layout switching in wayland
https://bugs.kde.org/show_bug.cgi?id=383113 Bug ID: 383113 Summary: Ctrl+Shift+letter shortcuts don't work if Ctrl+Shift is used for layout switching in wayland Product: kwin Version: 5.10.4 Platform: Gentoo Packages OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: wayland-generic Assignee: kwin-bugs-n...@kde.org Reporter: igor.pobo...@gmail.com Target Milestone: --- This is a long-standing bug for X.org (see https://bugs.freedesktop.org/show_bug.cgi?id=865, 13 years already; although it has a proposed patch, which is not accepted to upstream yet), and there is even an old bug in KDE bugzilla (Bug 114326). In wayland, apparently, things are quite different as the compositor - KWin - now handles everything including shortcuts, which brings a hope to resolve this issue once and for all. The current behavior is following: 1) I have two keyboard layouts, russian and english, and I use ctrl+shift for layout switching. 2) I open Konsole and press Ctrl+Shift+N in order to open new window 3) Right after I pressed Ctrl+Shift, the layout immediately switches. After I press "N", Konsole thinks I've pressed just Ctrl+N and thus ignores the shortcut (this I've checked via the KWin Debug Console), writing the "n" letter in the terminal. Clearly, switching the layout is not something I intended to do and this behavior is wrong. The original idea proposed in bugs.fd.o 865 is to trigger the shortcut (e.g. ctrl+shift) on key release instead of key press. Actually, there is a lot of discussion there, which might be useful. -- You are receiving this mail because: You are watching all bug changes.
[kdeplasma-addons] [Bug 358940] Fifteen puzzle unsolvable
https://bugs.kde.org/show_bug.cgi?id=358940 Igor Poboiko <igor.pobo...@gmail.com> changed: What|Removed |Added Latest Commit||https://commits.kde.org/kde ||plasma-addons/3516eda8107bd ||a0c91fa8fa5ef7e6da34d995f6b Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #5 from Igor Poboiko <igor.pobo...@gmail.com> --- Git commit 3516eda8107bda0c91fa8fa5ef7e6da34d995f6b by Igor Poboiko. Committed on 22/05/2017 at 15:51. Pushed by poboiko into branch 'master'. Fix fifteen puzzle solveability Differential Revision: https://phabricator.kde.org/D5913 M +2-2applets/fifteenPuzzle/package/contents/ui/FifteenPuzzle.qml https://commits.kde.org/kdeplasma-addons/3516eda8107bda0c91fa8fa5ef7e6da34d995f6b -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 374867] Impossible to reach screen edge if mouse cursor is moving fast
https://bugs.kde.org/show_bug.cgi?id=374867 --- Comment #6 from Igor Poboiko <igor.pobo...@gmail.com> --- I rebuilt KWin with that patch. Unfortunately, it didn't help that much: it's still reproducible. -- You are receiving this mail because: You are watching all bug changes.
[Baloo] [Bug 333678] Cannot index and search files in soft link path using Baloo Desktop Search.
https://bugs.kde.org/show_bug.cgi?id=333678 --- Comment #11 from Igor Poboiko <igor.pobo...@gmail.com> --- Git commit eea16e6cd9ecdba9c26b870472cacb32b34187e2 by Igor Poboiko. Committed on 19/03/2017 at 21:13. Pushed by poboiko into branch 'master'. Search also in symlinked directories M +2-1src/lib/searchstore.cpp https://commits.kde.org/baloo/eea16e6cd9ecdba9c26b870472cacb32b34187e2 -- You are receiving this mail because: You are watching all bug changes.
[kwin] [Bug 375518] global shortcuts show some oddities with foreign keyboard layouts
https://bugs.kde.org/show_bug.cgi?id=375518
Igor Poboiko <igor.pobo...@gmail.com> changed:
What|Removed |Added
CC||igor.pobo...@gmail.com
--- Comment #2 from Igor Poboiko <igor.pobo...@gmail.com> ---
Same here with russian layout (which is obviously completely different from
english).
(In reply to Martin Gräßlin from comment #1)
> Now the problem is tricky. Do you know whether there is a key in the layout
> which renders a "k"? Or whether the k key actually generates multiple
> keysyms? If it generated kappa and k, we could change the code to support
> all syms.
I suppose Greek layout just doesn't have a "k" symbol at all. Does such layouts
even exist (where the same symbol is placed on the some place in one layout and
on another place on second layout)?
Can we just bind it not to the symbol but to key ("scan code") instead?
(however, it might break if user attaches another keyboard...)
Or just map everything to English layout? (it might be weird if user isn't
familiar with latin alphabet)
Or maybe iterate over all configured layouts and check if pressed key code
corresponds to a shortcut on any of it?
--
You are receiving this mail because:
You are watching all bug changes.
