[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-06-14 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #42 from Lubos Lunak  ---
> It looks almost correct. I would just remove the following debug (TD3) part
> from get_debug_addr_entry_common:

Updated.

> It is a little tricky to know how to interpret endianness for these "3-byte"
> values.
> But what I mean is that I believe others interpret this as a 4-byte value
> where the 4th byte is zero.
> Which doesn't matter for little endian, but does for big endian.
> With the assumption of the 4th byte is zero the code would look like:
> 
>c1 = ML_(img_get_UChar)(c->sli.img, c->sli_next);
>c2 = ML_(img_get_UChar)(c->sli.img, c->sli_next+1);
>c3 = ML_(img_get_UChar)(c->sli.img, c->sli_next+2);
>c4 = 0;
>c->sli_next += 3;
> #if defined(VG_BIGENDIAN)
>return c1 << 24 | c2 << 16 | c3 << 8 | c4;
> #else
>return c1 | c2 << 8 | c3 << 16 | c4 << 24;
> #endif

I don't see the dwarf spec being specific on how to interpret this, but then I
think my way is the only logical one. This code would be weird/broken, for the
following reasons:
- It's inconsistent between little and big endian. On LE this would encode
offsets 0-16777215, on BE it would encode offsets in multiples of 256 in the
range 0-4278190080.
- It's inconsistent with the 1,2,4 variants. Those encode 1,2,4 lowest bytes
(e.g. str2 doesn't mean 3rd and 4th byte being zero).
- It doesn't make much sense to encode multiples of 256. Although it's not
spelled out, I think it's clear that it's meant to be a binary representation
of a value using the minimal number of bytes needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-06-14 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #149672|0   |1
is obsolete||

--- Comment #41 from Lubos Lunak  ---
Created attachment 149692
  --> https://bugs.kde.org/attachment.cgi?id=149692=edit
implement support for missing DW_LLE_* and DW_RLE_*  values

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-06-14 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #38 from Lubos Lunak  ---
> But the error handling in get_debug_addr_entry looks off.
> The second argument is DW_FORM form. But it is given either a DW_FORM,
> DW_LLE or DW_LRE.
> I think it would be better if the second argument would be a const HChar*.

You're right, too much copy Updated (but not using const HChar*, as I
find it inefficient to go through a large switch for every call even though it
normally wouldn't be used).

> imho to use #if defined(VG_BIGENDIAN) instead of doing a runtime trick.

Updated.

> Is the big endian variant correct?

I don't have actual big endian HW, but I think it is. The input is 3-byte
bigendian that needs byte-by-byte handling, not the output.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-06-14 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #148380|0   |1
is obsolete||

--- Comment #37 from Lubos Lunak  ---
Created attachment 149673
  --> https://bugs.kde.org/attachment.cgi?id=149673=edit
support DW_FORM_addrx3 and DW_FORM_strx3

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-06-14 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #148368|0   |1
is obsolete||

--- Comment #36 from Lubos Lunak  ---
Created attachment 149672
  --> https://bugs.kde.org/attachment.cgi?id=149672=edit
implement support for missing DW_LLE_* and DW_RLE_*  values

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-06-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #31 from Lubos Lunak  ---
> So I reviewed, tested and applied the first four numbered ones. What would
> be correct order for the next three patches/attachements?

In the order they are listed in the attachment list here. If you managed to
apply those 4 ones without conflicts, then apparently they can all be applied
independently.

> Just to make sure that whenever we skip an attribute we always do it the
> same way.
> So skip_Form_contents would basically be:

I see. I did not find any need to do that while writing the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-06-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #28 from Lubos Lunak  ---
> But this also handles DW_FORM_rnglistx and DW_FORM_loclistx.
> Shouldn't setup_cu_bases also handle these?

The 2nd patch does that. The 7 patches should be applied in the order they are
attached. You appear to be applying them based on their subject line, but those
got meaningless as I was adding and updating the patches and I didn't realize
somebody might look at those (I don't know if I'd ever submitted several
patches as actual patches before).

> And if so, should we have an skip_Form_contents function that can be used in 
> both places?

I don't know what you mean, I see no need for such a function.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-27 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #20 from Lubos Lunak  ---
They affect compilations does using Clang when it generates DWARF5. So
presumably they also affect older versions if explicitly asked to generate
DWARF5, but otherwise no.

BTW, since you're not going to actually handle this, maybe you shouldn't be the
assignee for the bugreport?

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-26 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #18 from Lubos Lunak  ---
Created attachment 148380
  --> https://bugs.kde.org/attachment.cgi?id=148380=edit
support DW_FORM_addrx3 and DW_FORM_strx3

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-26 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #17 from Lubos Lunak  ---
Created attachment 148376
  --> https://bugs.kde.org/attachment.cgi?id=148376=edit
treat DW_TAG_skeleton_unit like DW_TAG_compile_unit

Ok, I've figured out the split-dwarf debug line problem too, this fixes it for
both GCC and Clang.

So these patches should be all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-26 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #148240|0   |1
is obsolete||

--- Comment #16 from Lubos Lunak  ---
Created attachment 148375
  --> https://bugs.kde.org/attachment.cgi?id=148375=edit
avoid warning about missing DW_AT_*_base in skip_DIE()

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-26 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #148233|0   |1
is obsolete||

--- Comment #15 from Lubos Lunak  ---
Created attachment 148374
  --> https://bugs.kde.org/attachment.cgi?id=148374=edit
read properly unit headers depending on dwarf5 unit_type

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-25 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #148243|0   |1
is obsolete||

--- Comment #14 from Lubos Lunak  ---
Created attachment 148368
  --> https://bugs.kde.org/attachment.cgi?id=148368=edit
implement support for missing DW_LLE_* and DW_RLE_*  values

Removed forgotten todo comment in 5th patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-25 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #148242|0   |1
is obsolete||

--- Comment #13 from Lubos Lunak  ---
Created attachment 148367
  --> https://bugs.kde.org/attachment.cgi?id=148367=edit
read dwarf5 DW_FORM_rnglistx and DW_FORM_loclistx

Added one forgotten switch case in 4th patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-25 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #148234|0   |1
is obsolete||

--- Comment #12 from Lubos Lunak  ---
Created attachment 148366
  --> https://bugs.kde.org/attachment.cgi?id=148366=edit
read dwarf5 DW_FORM_addrx* and DW_FORM_strx* as generated  by Clang14

Removed forgotten todo note in 2nd patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-20 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #10 from Lubos Lunak  ---
The only remaining issue I can see is that DWARF5 + -gsplit-dwarf does not
output source locations in backtraces. So far I have not been able to find out
which part of Valgrind code is responsible, the furthest I know so far is that
search_one_loctab() does not find the location, possibly because
di->loctab_used is slightly smaller than in non-split case. I also don't see
any difference in DWARF info when compared to split DWARF4 or non-split DWARF5
that would seem relevant (llvm-dwarfdump claims .debug_line are the same in
both cases when generated by GCC 11).

Testcase:
$ cat a.cpp 
static int func(int a, int* b)
{
if(*b)
return a + 2;
else
return a - 2;
}

int main()
{
int v;
return func(4, );
}

$ g++-11 -g -gdwarf-5 a.cpp -gsplit-dwarf
$ valgrind ./a.out
...
==22491== Conditional jump or move depends on uninitialised value(s)
==22491==at 0x400559: func(int, int*) (in /home/seli/tmp/a.out)
==22491==by 0x400583: main (in /home/seli/tmp/a.out)

$ g++-11 -g -gdwarf-5 a.cpp
$ valgrind ./a.out
...
==22512== Conditional jump or move depends on uninitialised value(s)
==22512==at 0x400559: func(int, int*) (a.cpp:3)
==22512==by 0x400583: main (a.cpp:12)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-19 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #7 from Lubos Lunak  ---
Created attachment 148243
  --> https://bugs.kde.org/attachment.cgi?id=148243=edit
implement support for missing DW_LLE_* and DW_RLE_*  values

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-19 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #148239|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-19 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #6 from Lubos Lunak  ---
Created attachment 148242
  --> https://bugs.kde.org/attachment.cgi?id=148242=edit
read dwarf5 DW_FORM_rnglistx and DW_FORM_loclistx

Removed left-over debug statement.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-19 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #5 from Lubos Lunak  ---
Created attachment 148240
  --> https://bugs.kde.org/attachment.cgi?id=148240=edit
avoid warning about missing DW_AT_*_base in skip_DIE()

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-19 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Lubos Lunak  changed:

   What|Removed |Added

 Attachment #148235|0   |1
is obsolete||

--- Comment #4 from Lubos Lunak  ---
Created attachment 148239
  --> https://bugs.kde.org/attachment.cgi?id=148239=edit
read dwarf5 DW_FORM_rnglistx and DW_FORM_loclistx

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-19 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #3 from Lubos Lunak  ---
Created attachment 148235
  --> https://bugs.kde.org/attachment.cgi?id=148235=edit
valgrind patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-19 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #2 from Lubos Lunak  ---
Created attachment 148234
  --> https://bugs.kde.org/attachment.cgi?id=148234=edit
valgrind patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-19 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

--- Comment #1 from Lubos Lunak  ---
Created attachment 148233
  --> https://bugs.kde.org/attachment.cgi?id=148233=edit
valgrind patch

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 452758] New: Valgrind does not read properly DWARF5 as generated by Clang14

2022-04-19 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=452758

Bug ID: 452758
   Summary: Valgrind does not read properly DWARF5 as generated by
Clang14
   Product: valgrind
   Version: 3.19 GIT
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: jsew...@acm.org
  Reporter: l.lu...@kde.org
  Target Milestone: ---

Trying to use Valgrind with a binary compiled by Clang14 with DWARF5 enabled
results in Valgrind complaing about possibly corrupted debuginfo and aborting.

Attached are 3 patches that improve the situation. I'm not very familiar with
Valgrind internals or DWARF, but with these patches Valgrind is now able to run
Clang14-compiled programs without complaining and generally seems to work. The
one thing I've noticed that still does not work is backtraces with split-dwarf,
they report the binary name instead of source file location, I don't know if
the 3rd patch is incorrect in the assumption that rnglistx/loclistx may be
ignored, or if it's something else missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 395682] Reading debug info of binaries with readonly PT_LOAD segments

2018-07-15 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=395682

Lubos Lunak  changed:

   What|Removed |Added

 CC||l.lu...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 384727] [PATCH]valgrind does not support debug info for read only segments (generated by LLD)

2018-07-14 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=384727

--- Comment #5 from Lubos Lunak  ---
(In reply to Ivo Raisr from comment #3)
> Please could you try one of the patches from bug
> https://bugs.kde.org/show_bug.cgi?id=395682
> These two bugs seem to be very similar.

Yes, the patch from bug #395682 seems to work for me too (again tested with
LibreOffice debug build with with clang6 and lld6). The bugreports look like
duplicates to me and that patch seems better than mine (no idea why I got
confused into thinking that .rodata could be encountered twice in one binary).

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 384727] [PATCH]valgrind does not support debug info for read only segments (generated by LLD)

2018-07-04 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=384727

Lubos Lunak  changed:

   What|Removed |Added

Summary|valgrind does not support   |[PATCH]valgrind does not
   |debug info for read only|support debug info for read
   |segments (generated by LLD) |only segments (generated by
   ||LLD)

-- 
You are receiving this mail because:
You are watching all bug changes.

[valgrind] [Bug 384727] valgrind does not support debug info for read only segments (generated by LLD)

2018-07-04 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=384727

Lubos Lunak  changed:

   What|Removed |Added

 CC||l.lu...@kde.org

--- Comment #2 from Lubos Lunak  ---
Created attachment 113765
  --> https://bugs.kde.org/attachment.cgi?id=113765=edit
valgrind patch

I think this patch completes the fix (i.e. it's meant to be added on top of the
above-mentioned
https://github.com/orivej/valgrind/commit/c59bf5c215f85fb08605708b51f88777227885ae.patch
).

With these two patches, valgrind works for me fine with lld-generated binaries
(and my testcase is LibreOffice, so if it works there, it must work for
everything else too :) ).

The only place I'm somewhat unsure of is the "FIND(rodata, rw)", i.e. the last
snippet, but I assume that doesn't actually matter. As noted in "JRS
2013-Jun-01" a couple of lines above, all the code related to the second
argument to FIND(), variables like rx_dsvma_limit and all that are actually
unused.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 384392] konsole (always), kwrite (sometimes) doesn't restore "Application menu" in title bar after restore session

2017-12-06 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=384392

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 CC||l.lu...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 382764] Save and restore environment variables per application

2017-07-27 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=382764

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from Lubos Lunak <l.lu...@kde.org> ---
Ksmserver has no reasonable way to find out environment variables of
applications. What is possible that applications tell ksmserver which variables
to set again, so it would be up to each application to do this. But even than
this is very problematic, as applications actually have no good way to known
which variables should be restored - how is Thunderbind to know that your
LC_TIME is special enough to be kept?

If you launch apps in special ways manually, I'm afraid you'll need to do that
manually too. I don't see a reasonable way to do this programatically, sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 379254] ksmserver errors after updating to Plasma 5.9.5

2017-05-03 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=379254

--- Comment #19 from Lubos Lunak <l.lu...@kde.org> ---
As this bugreport shows, throwing such errors to stderr means that nobody will
notice them, and then distros will happily ship broken apps (that said, I've
noticed that kcm_autostart does not one let do anything with global autostart
files, not even show them, so if a distro manages to do this, the user won't
have an easy way to handle the problem).

KRun does a number of things that KProcess-based code doesn't
(KDesktopExecParser, KAuthorized, CWD, DiscreteGPU). If they wouldn't be needed
for launching .desktop files, then there would be no point in having them in
KRun either. And it seems lame to require every place that wants to run a
.desktop file to do this manually.

I guess it'll be better to move this discussion to kde-core-devel.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 365042] kwin doesnt place winecfg's window centered

2017-05-02 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=365042

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 CC||l.lu...@kde.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #11 from Lubos Lunak <l.lu...@kde.org> ---
I don't think the rule set up this way actually matches the winecfg window
(window class is not set, nor anything else in the first screenshot).

And this works perfectly fine here, when the winecfg window is open, using
Alt+F3/Advanced/Special window settings (or whatever it's exactly in English)
and then following comment #9.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 379367] Trying to end plasma wayland session results in ksm-logout-greeter crashing

2017-05-02 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=379367

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Component|general |ui

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 379254] ksmserver errors after updating to Plasma 5.9.5

2017-05-02 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=379254

--- Comment #17 from Lubos Lunak <l.lu...@kde.org> ---
So I've intentionally broken one of my local autostart .desktop files and that
does cause the problem, and it's indeed somewhat annoying that the whole
startup is blocked by it. And, looking at KRun, this is caused by a dialog
blocking the whole ksmserver in the autostart code.

So I see basically 3 viable possibilities:
- Leave master as it is. And I don't think this is such a bad choice, there are
not supposed to be broken .desktop files after all.
- Add some kind of "QString* error" argument to the KRun call, which would
prevent KRun from showing the dialog itself and let ksmserver show it in a
non-blocking way.
- Make ksmserver have klauncher do the actual launching, like it was before
(i.e. a DBus call to "start_service" or somesuch). But I don't know what was
the exact idea with moving the autostart code to ksmserver.

I intentionally didn't list "revert my commits in master". The code in KRun (or
klauncher) does way more than just get the executable path from the .desktop
file and launch it. I don't find it a good idea to either copy a lof of
code to ksmserver, or to trade a blatantly obvious problem (that's not even our
problem) for a possible bunch of non-obvious problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 379254] ksmserver errors after updating to Plasma 5.9.5

2017-04-27 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=379254

--- Comment #14 from Lubos Lunak <l.lu...@kde.org> ---
Given comments above, I find it rather clear that the actual problem is with
the broken .desktop files (in one distro, possibly, kdeconnectd doesn't have
such a problem on openSUSE). So it could be argued that there indeed should be
a dialog about the error (although I'm not strictly opposed to reverting it in
the branches).

-- 
You are receiving this mail because:
You are watching all bug changes.


[ksmserver] [Bug 379254] ksmserver errors after updating to Plasma 5.9.5

2017-04-27 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=379254

--- Comment #7 from Lubos Lunak <l.lu...@kde.org> ---
I cannot reproduce (openSUSE42.2 + 5.9.5 packages), nor I can quite see why
this should break (apparently KRun::runApplication() works elsewhere, so why
not here).

What exactly do the error dialogs say?

"‎They're blocking, and it's a new window so kwin will ask ksmserver for
restoration details." - This doesn't look like the cause of the problem, nor it
looks like something that would be much of a problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 348390] Klipper does not copy selected things

2017-04-26 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=348390

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/f78b0869f01d2 |sma-workspace/921f89cb62e2f
   |55d0e17a0a246e5a9456f2bba4e |a118ba16ea87bcec0ba41751a82

--- Comment #14 from Lubos Lunak <l.lu...@kde.org> ---
Git commit 921f89cb62e2fa118ba16ea87bcec0ba41751a82 by Luboš Luňák.
Committed on 26/04/2017 at 09:07.
Pushed by lunakl into branch 'Plasma/5.9'.

selecting the topmost klipper item should always set it as clipboard contents

Without this, that wasn't always the case if the top item was only the mouse
selection. This was presumably broken by 2e47d84772.
Also explicitly check the popup item, since it's now owned by Klipper.
Related: bug 251222

M  +11   -0klipper/history.cpp
M  +1-0klipper/history.h
M  +1-0klipper/klipper.cpp
M  +7-0klipper/klipperpopup.cpp
M  +1-0klipper/klipperpopup.h

https://commits.kde.org/plasma-workspace/921f89cb62e2fa118ba16ea87bcec0ba41751a82

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 251222] First entry is not checked when something is copied by CTRL-C or mouse selection, even after choosing it in klipper window after copy

2017-04-26 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=251222

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/f78b0869f01d2 |sma-workspace/921f89cb62e2f
   |55d0e17a0a246e5a9456f2bba4e |a118ba16ea87bcec0ba41751a82

--- Comment #22 from Lubos Lunak <l.lu...@kde.org> ---
Git commit 921f89cb62e2fa118ba16ea87bcec0ba41751a82 by Luboš Luňák.
Committed on 26/04/2017 at 09:07.
Pushed by lunakl into branch 'Plasma/5.9'.

selecting the topmost klipper item should always set it as clipboard contents

Without this, that wasn't always the case if the top item was only the mouse
selection. This was presumably broken by 2e47d84772.
Also explicitly check the popup item, since it's now owned by Klipper.
Related: bug 348390

M  +11   -0klipper/history.cpp
M  +1-0klipper/history.h
M  +1-0klipper/klipper.cpp
M  +7-0klipper/klipperpopup.cpp
M  +1-0klipper/klipperpopup.h

https://commits.kde.org/plasma-workspace/921f89cb62e2fa118ba16ea87bcec0ba41751a82

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 348390] Klipper does not copy selected things

2017-04-26 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=348390

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/37014e643cec4 |sma-workspace/f78b0869f01d2
   |ee9aed54421f66c675e1bc91b70 |55d0e17a0a246e5a9456f2bba4e

--- Comment #13 from Lubos Lunak <l.lu...@kde.org> ---
Git commit f78b0869f01d255d0e17a0a246e5a9456f2bba4e by Luboš Luňák.
Committed on 26/04/2017 at 09:06.
Pushed by lunakl into branch 'Plasma/5.8'.

selecting the topmost klipper item should always set it as clipboard contents

Without this, that wasn't always the case if the top item was only the mouse
selection. This was presumably broken by 2e47d84772.
Also explicitly check the popup item, since it's now owned by Klipper.
Related: bug 251222

M  +11   -0klipper/history.cpp
M  +1-0klipper/history.h
M  +1-0klipper/klipper.cpp
M  +7-0klipper/klipperpopup.cpp
M  +1-0klipper/klipperpopup.h

https://commits.kde.org/plasma-workspace/f78b0869f01d255d0e17a0a246e5a9456f2bba4e

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 251222] First entry is not checked when something is copied by CTRL-C or mouse selection, even after choosing it in klipper window after copy

2017-04-26 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=251222

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/37014e643cec4 |sma-workspace/f78b0869f01d2
   |ee9aed54421f66c675e1bc91b70 |55d0e17a0a246e5a9456f2bba4e

--- Comment #21 from Lubos Lunak <l.lu...@kde.org> ---
Git commit f78b0869f01d255d0e17a0a246e5a9456f2bba4e by Luboš Luňák.
Committed on 26/04/2017 at 09:06.
Pushed by lunakl into branch 'Plasma/5.8'.

selecting the topmost klipper item should always set it as clipboard contents

Without this, that wasn't always the case if the top item was only the mouse
selection. This was presumably broken by 2e47d84772.
Also explicitly check the popup item, since it's now owned by Klipper.
Related: bug 348390

M  +11   -0klipper/history.cpp
M  +1-0klipper/history.h
M  +1-0klipper/klipper.cpp
M  +7-0klipper/klipperpopup.cpp
M  +1-0klipper/klipperpopup.h

https://commits.kde.org/plasma-workspace/f78b0869f01d255d0e17a0a246e5a9456f2bba4e

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 369391] ksmserver captures and discards standard output/error - debug information lost

2017-04-21 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=369391

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/0f19e92f3e85d |sma-workspace/da44dd6eae8b9
   |064de9cebf280fa8e085485c2e0 |ef4161680efcb9319a7267fe77e
   |https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/da44dd6eae8b9 |sma-workspace/0f19e92f3e85d
   |ef4161680efcb9319a7267fe77e |064de9cebf280fa8e085485c2e0

--- Comment #5 from Lubos Lunak <l.lu...@kde.org> ---
Git commit da44dd6eae8b9ef4161680efcb9319a7267fe77e by Luboš Luňák.
Committed on 21/04/2017 at 12:00.
Pushed by lunakl into branch 'Plasma/5.9'.

launch autostart apps in ksmserver using KRun, not QProcess

The "move" (copy in fact) of the autostart code from klauncher simply
switched to QProcess. This resulted in a number of problems, as the incorrect
handling of .desktop file command if it had placeholders (worked around
already), kdeinit is no longer used (not sure how much that matters nowadays)
and finally QProcess simply eats all stdout/stderr of all such processes
(which, when daemonized, can lead even to the processes getting SIGPIPE'd).
If the application to start is a KService, simply launch it as such.
Related: bug 370528

M  +3-13   ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/da44dd6eae8b9ef4161680efcb9319a7267fe77e

--- Comment #6 from Lubos Lunak <l.lu...@kde.org> ---
Git commit c7d21ae2b834bd101d8dba1edaea05edcdb6e8f5 by Luboš Luňák.
Committed on 21/04/2017 at 12:00.
Pushed by lunakl into branch 'Plasma/5.9'.

use KProcess instead of QProcess to launch apps in ksmserver

Follow-up to the previous commit. KProcess has saner defaults for simply
launching an app and being done with it, no lost stdout/stderr or even SIGPIPE.
Related: bug 370528

M  +3-2ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/c7d21ae2b834bd101d8dba1edaea05edcdb6e8f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 370528] Autostart, stderr is closed if daemonized (conky)

2017-04-21 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=370528

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/0f19e92f3e85d |sma-workspace/da44dd6eae8b9
   |064de9cebf280fa8e085485c2e0 |ef4161680efcb9319a7267fe77e

--- Comment #3 from Lubos Lunak <l.lu...@kde.org> ---
Git commit da44dd6eae8b9ef4161680efcb9319a7267fe77e by Luboš Luňák.
Committed on 21/04/2017 at 12:00.
Pushed by lunakl into branch 'Plasma/5.9'.

launch autostart apps in ksmserver using KRun, not QProcess

The "move" (copy in fact) of the autostart code from klauncher simply
switched to QProcess. This resulted in a number of problems, as the incorrect
handling of .desktop file command if it had placeholders (worked around
already), kdeinit is no longer used (not sure how much that matters nowadays)
and finally QProcess simply eats all stdout/stderr of all such processes
(which, when daemonized, can lead even to the processes getting SIGPIPE'd).
If the application to start is a KService, simply launch it as such.
Related: bug 369391

M  +3-13   ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/da44dd6eae8b9ef4161680efcb9319a7267fe77e

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 369391] ksmserver captures and discards standard output/error - debug information lost

2017-04-21 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=369391

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/0f19e92f3e85d |sma-workspace/da44dd6eae8b9
   |064de9cebf280fa8e085485c2e0 |ef4161680efcb9319a7267fe77e
   |https://commits.kde.org/pla |https://commits.kde.org/pla
   |sma-workspace/da44dd6eae8b9 |sma-workspace/0f19e92f3e85d
   |ef4161680efcb9319a7267fe77e |064de9cebf280fa8e085485c2e0

--- Comment #5 from Lubos Lunak <l.lu...@kde.org> ---
Git commit da44dd6eae8b9ef4161680efcb9319a7267fe77e by Luboš Luňák.
Committed on 21/04/2017 at 12:00.
Pushed by lunakl into branch 'Plasma/5.9'.

launch autostart apps in ksmserver using KRun, not QProcess

The "move" (copy in fact) of the autostart code from klauncher simply
switched to QProcess. This resulted in a number of problems, as the incorrect
handling of .desktop file command if it had placeholders (worked around
already), kdeinit is no longer used (not sure how much that matters nowadays)
and finally QProcess simply eats all stdout/stderr of all such processes
(which, when daemonized, can lead even to the processes getting SIGPIPE'd).
If the application to start is a KService, simply launch it as such.
Related: bug 370528

M  +3-13   ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/da44dd6eae8b9ef4161680efcb9319a7267fe77e

--- Comment #6 from Lubos Lunak <l.lu...@kde.org> ---
Git commit c7d21ae2b834bd101d8dba1edaea05edcdb6e8f5 by Luboš Luňák.
Committed on 21/04/2017 at 12:00.
Pushed by lunakl into branch 'Plasma/5.9'.

use KProcess instead of QProcess to launch apps in ksmserver

Follow-up to the previous commit. KProcess has saner defaults for simply
launching an app and being done with it, no lost stdout/stderr or even SIGPIPE.
Related: bug 370528

M  +3-2ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/c7d21ae2b834bd101d8dba1edaea05edcdb6e8f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 370528] Autostart, stderr is closed if daemonized (conky)

2017-04-21 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=370528

--- Comment #4 from Lubos Lunak <l.lu...@kde.org> ---
Git commit c7d21ae2b834bd101d8dba1edaea05edcdb6e8f5 by Luboš Luňák.
Committed on 21/04/2017 at 12:00.
Pushed by lunakl into branch 'Plasma/5.9'.

use KProcess instead of QProcess to launch apps in ksmserver

Follow-up to the previous commit. KProcess has saner defaults for simply
launching an app and being done with it, no lost stdout/stderr or even SIGPIPE.
Related: bug 369391

M  +3-2ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/c7d21ae2b834bd101d8dba1edaea05edcdb6e8f5

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 377756] Restore windows to correct position and activity

2017-04-21 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=377756

--- Comment #2 from Lubos Lunak <l.lu...@kde.org> ---
Git commit 71908e79626b240d1c32ee88d726c227fa7d6a2d by Luboš Luňák.
Committed on 21/04/2017 at 12:00.
Pushed by lunakl into branch 'Plasma/5.9'.

recognize the WM even if given with a full path

Normally kWin is launched simply as "kwin" ("kwin_x11", whatever), but
in some cases it's restart command may be "/usr/bin/kwin", most notably
when KWin restarts itself after a crash. Failing to recognize this client
as the WM leads to KWin starting without any session management restoring.

M  +1-1ksmserver/legacy.cpp
M  +5-2ksmserver/server.cpp
M  +1-1ksmserver/server.h
M  +2-2ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/71908e79626b240d1c32ee88d726c227fa7d6a2d

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 370528] Autostart, stderr is closed if daemonized (conky)

2017-04-21 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=370528

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/0f19e92f3e85d
   ||064de9cebf280fa8e085485c2e0

--- Comment #2 from Lubos Lunak <l.lu...@kde.org> ---
Git commit 0f19e92f3e85d064de9cebf280fa8e085485c2e0 by Luboš Luňák.
Committed on 21/04/2017 at 11:59.
Pushed by lunakl into branch 'Plasma/5.8'.

launch autostart apps in ksmserver using KRun, not QProcess

The "move" (copy in fact) of the autostart code from klauncher simply
switched to QProcess. This resulted in a number of problems, as the incorrect
handling of .desktop file command if it had placeholders (worked around
already), kdeinit is no longer used (not sure how much that matters nowadays)
and finally QProcess simply eats all stdout/stderr of all such processes
(which, when daemonized, can lead even to the processes getting SIGPIPE'd).
If the application to start is a KService, simply launch it as such.
Related: bug 369391

M  +3-13   ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/0f19e92f3e85d064de9cebf280fa8e085485c2e0

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 369391] ksmserver captures and discards standard output/error - debug information lost

2017-04-21 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=369391

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/0f19e92f3e85d
   ||064de9cebf280fa8e085485c2e0

--- Comment #3 from Lubos Lunak <l.lu...@kde.org> ---
Git commit 17eeb58ae42596195d6a841c06d17721b7af2c14 by Luboš Luňák.
Committed on 21/04/2017 at 12:00.
Pushed by lunakl into branch 'Plasma/5.8'.

use KProcess instead of QProcess to launch apps in ksmserver

Follow-up to the previous commit. KProcess has saner defaults for simply
launching an app and being done with it, no lost stdout/stderr or even SIGPIPE.
Related: bug 370528

M  +3-2ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/17eeb58ae42596195d6a841c06d17721b7af2c14

--- Comment #4 from Lubos Lunak <l.lu...@kde.org> ---
Git commit 0f19e92f3e85d064de9cebf280fa8e085485c2e0 by Luboš Luňák.
Committed on 21/04/2017 at 11:59.
Pushed by lunakl into branch 'Plasma/5.8'.

launch autostart apps in ksmserver using KRun, not QProcess

The "move" (copy in fact) of the autostart code from klauncher simply
switched to QProcess. This resulted in a number of problems, as the incorrect
handling of .desktop file command if it had placeholders (worked around
already), kdeinit is no longer used (not sure how much that matters nowadays)
and finally QProcess simply eats all stdout/stderr of all such processes
(which, when daemonized, can lead even to the processes getting SIGPIPE'd).
If the application to start is a KService, simply launch it as such.
Related: bug 370528

M  +3-13   ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/0f19e92f3e85d064de9cebf280fa8e085485c2e0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 377756] Restore windows to correct position and activity

2017-04-21 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=377756

--- Comment #1 from Lubos Lunak <l.lu...@kde.org> ---
Git commit 7fca524e0846fd16558a4ac085afa551a9f22c99 by Luboš Luňák.
Committed on 21/04/2017 at 11:59.
Pushed by lunakl into branch 'Plasma/5.8'.

recognize the WM even if given with a full path

Normally kWin is launched simply as "kwin" ("kwin_x11", whatever), but
in some cases it's restart command may be "/usr/bin/kwin", most notably
when KWin restarts itself after a crash. Failing to recognize this client
as the WM leads to KWin starting without any session management restoring.

M  +1-1ksmserver/legacy.cpp
M  +5-2ksmserver/server.cpp
M  +1-1ksmserver/server.h
M  +2-2ksmserver/startup.cpp

https://commits.kde.org/plasma-workspace/7fca524e0846fd16558a4ac085afa551a9f22c99

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 251222] First entry is not checked when something is copied by CTRL-C or mouse selection, even after choosing it in klipper window after copy

2017-04-17 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=251222

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/37014e643cec4
   ||ee9aed54421f66c675e1bc91b70
 Resolution|--- |FIXED

--- Comment #19 from Lubos Lunak <l.lu...@kde.org> ---
Git commit 37014e643cec4ee9aed54421f66c675e1bc91b70 by Luboš Luňák.
Committed on 17/04/2017 at 11:13.
Pushed by lunakl into branch 'master'.

selecting the topmost klipper item should always set it as clipboard contents

Without this, that wasn't always the case if the top item was only the mouse
selection. This was presumably broken by 2e47d84772.
Also explicitly check the popup item, since it's now owned by Klipper.
Related: bug 348390

M  +11   -0klipper/history.cpp
M  +1-0klipper/history.h
M  +1-0klipper/klipper.cpp
M  +7-0klipper/klipperpopup.cpp
M  +1-0klipper/klipperpopup.h

https://commits.kde.org/plasma-workspace/37014e643cec4ee9aed54421f66c675e1bc91b70

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 348390] Klipper does not copy selected things

2017-04-17 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=348390

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/pla
   ||sma-workspace/37014e643cec4
   ||ee9aed54421f66c675e1bc91b70

--- Comment #11 from Lubos Lunak <l.lu...@kde.org> ---
Git commit 37014e643cec4ee9aed54421f66c675e1bc91b70 by Luboš Luňák.
Committed on 17/04/2017 at 11:13.
Pushed by lunakl into branch 'master'.

selecting the topmost klipper item should always set it as clipboard contents

Without this, that wasn't always the case if the top item was only the mouse
selection. This was presumably broken by 2e47d84772.
Also explicitly check the popup item, since it's now owned by Klipper.
Related: bug 251222

M  +11   -0klipper/history.cpp
M  +1-0klipper/history.h
M  +1-0klipper/klipper.cpp
M  +7-0klipper/klipperpopup.cpp
M  +1-0klipper/klipperpopup.h

https://commits.kde.org/plasma-workspace/37014e643cec4ee9aed54421f66c675e1bc91b70

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 221206] Klipper does not allow to select (and thus to make it ready for pasting) most recently added (sic!) clipboard entry

2017-04-17 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=221206

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 CC||l.lu...@kde.org
 Status|ASSIGNED|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #21 from Lubos Lunak <l.lu...@kde.org> ---
As per comment #16, the original problem can no longer be reproduced. The other
problems appear to be unrelated and are e.g. bug #348390.

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 221206] Klipper does not allow to select (and thus to make it ready for pasting) most recently added (sic!) clipboard entry

2017-04-17 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=221206

--- Comment #20 from Lubos Lunak <l.lu...@kde.org> ---
As per comment #16, the original problem. The other problems appear to be
unrelated and are e.g. bug #348390.

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 376590] Unable to paste but entry into klipper

2017-04-17 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=376590

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from Lubos Lunak <l.lu...@kde.org> ---
Your option needs to be this:
[X] Prevent empty clipboard

Otherwise clipboard contents are lost when the owning application closes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 376561] An option to copy an entry to the clipboard to paste

2017-04-17 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=376561

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |REMIND
 Status|UNCONFIRMED |RESOLVED
 CC||l.lu...@kde.org

--- Comment #2 from Lubos Lunak <l.lu...@kde.org> ---
Either trivially resolved as per comment #1, or is pending more information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[klipper] [Bug 222764] Unable to paste content

2017-04-17 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=222764

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |REMIND
 Status|UNCONFIRMED |RESOLVED

--- Comment #8 from Lubos Lunak <l.lu...@kde.org> ---
Closing, question in comment #4 has not been answered for ages.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 365237] session not saved/restored upon logout/login

2017-04-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=365237

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |REMIND

--- Comment #2 from Lubos Lunak <l.lu...@kde.org> ---
No response, presumably fixed, closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 361229] Firefox recalled session at system start has no internet connection.

2017-04-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=361229

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #3 from Lubos Lunak <l.lu...@kde.org> ---
I seriously doubt this is our problem. First of all, this normally works for
me, and second, Firefox on session restore is simply launched using the command
it gave when saving the session. Either there's a problem with your system, or
with your Firefox.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 351801] With restore session enabled, kde also launches scripts that have been autostarted

2017-04-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=351801

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #3 from Lubos Lunak <l.lu...@kde.org> ---
As already said, there's no good way to solve this from our side. Either
autostart it, or doesn't store it in the session (in the session configuration
module it's possible to specify a list of apps to exclude from session).

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 369391] ksmserver captures and discards standard output/error - debug information lost

2017-04-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=369391

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Lubos Lunak <l.lu...@kde.org> ---
https://commits.kde.org/plasma-workspace/eadaf1cd6f55e6092deb2114c5477559ebf063e0
https://commits.kde.org/plasma-workspace/0377d6a992725e0b0b469b87d17343fa3730b829

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 370528] Autostart, stderr is closed if daemonized (conky)

2017-04-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=370528

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Lubos Lunak <l.lu...@kde.org> ---
https://commits.kde.org/plasma-workspace/eadaf1cd6f55e6092deb2114c5477559ebf063e0
https://commits.kde.org/plasma-workspace/0377d6a992725e0b0b469b87d17343fa3730b829

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 361236] Aurorae crashes in QQmlBinding::write on creation - Qt 5.6

2017-04-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=361236

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 CC||l.lu...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 374408] kwin crashes at various times for unknown reasons

2017-04-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=374408

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Lubos Lunak <l.lu...@kde.org> ---


*** This bug has been marked as a duplicate of bug 361236 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 361236] Aurorae crashes in QQmlBinding::write on creation - Qt 5.6

2017-04-13 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=361236

--- Comment #115 from Lubos Lunak <l.lu...@kde.org> ---
*** Bug 374408 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 361236] Aurorae crashes in QQmlBinding::write on creation - Qt 5.6

2017-04-11 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=361236

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #113 from Lubos Lunak <l.lu...@kde.org> ---
This is a Qt bug and has already been fixed by
http://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=4d375f3f2b95bfcb322402df3525db6cc7a723ce
.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 338578] On login, all applications open in the same virtual desktop, not where they were before logout

2017-03-22 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=338578

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[ksmserver] [Bug 327695] Do not resume the application Calibre [maybe other java based applications]

2017-03-22 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=327695

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Lubos Lunak <l.lu...@kde.org> ---
This is Calibre's problem, it claims to ksmserver that the command to restart
it is 'calibre-gui', but there's no such binary.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 377756] Restore windows to correct position and activity

2017-03-22 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=377756

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 CC||l.lu...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 377756] Restore windows to correct position and activity

2017-03-18 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=377756

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

  Component|general |general
Product|ksmserver   |kwin
   Assignee|l.lu...@kde.org |kwin-bugs-n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 363224] Kwin crashes from time to time (this time using Virtual Machine Manager)

2017-03-17 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=363224

--- Comment #59 from Lubos Lunak <l.lu...@kde.org> ---
Created attachment 104621
  --> https://bugs.kde.org/attachment.cgi?id=104621=edit
proposed fix

As seen in the Valgrind log, this is basically bug #347490. The supposed fix
30e6ae34d7 for that one only moved the problem, so instead of delayed slots
crashing because of deleted Client objects, it now crashes because of deleted
EffectWindow objects.

This patch reverts that commit and also the delayed signals, based on the
following:
- 30e6ae34d7 only papers over the problem
- the commit introducing the delaying of the signal doesn't explain it (*sigh*)
and so the only reasoning for it is a comment in #347490 with a supposition
about it, and I cannot see any glitches with this patch attached (although
admitedly I didn't try too hard, given that I don't know what to look for)
- the logic of delaying of just this one signal seems wrong to me, if it would
be needed, surely other signals would need similar delaying as well
- if it turns out any delaying is actually necessary, it should be done
properly where needed (such as triggering a delayed repaint in the appropriate
place)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 363224] Kwin crashes from time to time (this time using Virtual Machine Manager)

2017-03-17 Thread Lubos Lunak
https://bugs.kde.org/show_bug.cgi?id=363224

Lubos Lunak <l.lu...@kde.org> changed:

   What|Removed |Added

 CC||l.lu...@kde.org

--- Comment #58 from Lubos Lunak <l.lu...@kde.org> ---
Created attachment 104620
  --> https://bugs.kde.org/attachment.cgi?id=104620=edit
valgrind trace of the crash

-- 
You are receiving this mail because:
You are watching all bug changes.