[kdevelop] [Bug 463802] Crash while loading Python code
https://bugs.kde.org/show_bug.cgi?id=463802 Pino Toscano changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|--- |DOWNSTREAM --- Comment #12 from Pino Toscano --- The problem has been fixed in Debian unstable few days ago, and now it migrated to testing too. Hence, closing. -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 463802] Crash while loading Python code
https://bugs.kde.org/show_bug.cgi?id=463802 --- Comment #10 from Pino Toscano --- (In reply to Sven Brauch from comment #9) > Hi, I think ideally in this case you would have notified me that you needed > Python 3.11 support in Gear 22.12. I would have backported it there. While that is true, I think it would not be unreasonable to expect that, once a new Python version is released, it will start to flow into distros, and distro packagers will need to make sure all the Python-using packages (modules, plugins like kdev-python, etc) are compatible with it. > Still, I dunno. I made an explicit, conscious decision to not include the > patch in our tagged release because I knew it was risky, and it was just > shipped to users regardless, without me even knowing. That's odd to me. What I can tell you from my POV (not even with a DD hat, as non-kdevelop contributor) is that I don't find it easy to determine what you can "conscious decision": sometimes maintainer do not backport patches at all in stable branches, sometimes they do when requested, sometimes they do aggressively... and you don't know what's the actual case here, unless you really know each person involved. So please bear with people that are not part of the "kdevelop development group". Back to the actual situation here: 1) should I drop the extra bits of Python 3.10 support, even if there will be (hopefully soon) a fix for that coming? 2) should I drop the support for Python 3.11, since it is not in 22.12.x as "conscious decision"? -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 463802] Crash while loading Python code
https://bugs.kde.org/show_bug.cgi?id=463802 --- Comment #8 from Pino Toscano --- (In reply to Sven Brauch from comment #6) > The maintainers of the respective applications have the best judgement of > which feature is ready to be included in a release and which isn't, and > these decisions should not be overruled by packagers. The change was also > made long after feature freeze for Gear 22.12. Sorry if I seem negative: I cannot get this paragraph as exactly cooperative. Also, the support for Python 3.11 was added only in master (currently towards 23.04) and it is not in 22.12.x; according to your logic, I should not backport it either, because it would be a "maintainer decision that should not be overruled by packagers"? Debian unstable recently switched to Python 3.11 as default (other distros did it already), so I see a bit of contradicting logic... -- You are receiving this mail because: You are watching all bug changes.
[kdevelop] [Bug 463802] Crash while loading Python code
https://bugs.kde.org/show_bug.cgi?id=463802 Pino Toscano changed: What|Removed |Added CC||p...@kde.org --- Comment #5 from Pino Toscano --- Hello, Debian packager here. (In reply to Sven Brauch from comment #4) > Including c4ec40a9cac is odd though, it is the commit that introduced the > crash and it's also completely unrelated to any build or even python 3.11 > topic, it just adds support for some random python 3.10 feature. I backported it because, as you wrote, it adds the basic support for some Python 3.10 feature, which I thought may be useful for users. > It should just be removed from the patch set. While I can do that (sigh), it would simply be delaying the problem, wouldn't it? I mean, if you said that that commit introduces a crash, that means kdev-python in master (for the future Gear 23.04) is currently buggy. Wouldn't it be better to fix the problem instead? -- You are receiving this mail because: You are watching all bug changes.
[kphotoalbum] [Bug 458727] New: kphotoalbum 5.9.0 release tarball does not ship translations
https://bugs.kde.org/show_bug.cgi?id=458727 Bug ID: 458727 Summary: kphotoalbum 5.9.0 release tarball does not ship translations Product: kphotoalbum Version: 5.9.0 Platform: Compiled Sources URL: https://download.kde.org/stable/kphotoalbum/5.9.0/kpho toalbum-5.9.0.tar.xz OS: All Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: kpab...@willden.org Reporter: p...@kde.org Target Milestone: --- The tarball of the new 5.9.0 release does not contain any translation (i.e. .po files under a "po" top-level subdirectory), and also the po-related CMake machinery in top-level CMakeLists.txt. I think this might be due to the new release being created manually from the git repository, rather than using the KDE release scripts that do this. This is a regression compared to previous versions. -- You are receiving this mail because: You are watching all bug changes.
[plasma-pass] [Bug 433112] New: plasma-pass assumes the gnupg version by the executable name
https://bugs.kde.org/show_bug.cgi?id=433112
Bug ID: 433112
Summary: plasma-pass assumes the gnupg version by the
executable name
Product: plasma-pass
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: General
Assignee: dvra...@kde.org
Reporter: p...@kde.org
Target Milestone: ---
Looking at plugin/providerbase.cpp in plasma-pass 1.2.0, I see the following:
bool isGpg2 = true;
auto gpgExe = QStandardPaths::findExecutable(QStringLiteral("gpg2"));
if (gpgExe.isEmpty()) {
gpgExe = QStandardPaths::findExecutable(QStringLiteral("gpg"));
isGpg2 = false;
}
This is semi-incorrect, as newer distributions (at least Debian since few
years) tend to ship GnuPG 2.x as "gpg", with the old GnuPG 1.x as "gpg1". IMHO
there ought to be a proper version check based on the executable itself, i.e.
parsing the output of `$gpgExe --version`.
--
You are receiving this mail because:
You are watching all bug changes.
[amarok] [Bug 423598] Preset editor shows Match tag:(I18N_ARGUMENT_MISSING) for all values in the constraint tree
https://bugs.kde.org/show_bug.cgi?id=423598 Pino Toscano changed: What|Removed |Added Status|REPORTED|RESOLVED Latest Commit||https://invent.kde.org/mult ||imedia/amarok/commit/a0433c ||bec23ce9d1ec85323c6b7ffcf19 ||3f9aae3 Resolution|--- |FIXED --- Comment #2 from Pino Toscano --- Git commit a0433cbec23ce9d1ec85323c6b7ffcf193f9aae3 by Pino Toscano. Committed on 13/02/2021 at 08:06. Pushed by pino into branch 'master'. Properly use KLocalizedString for dynamic placeholder replacement M +9-9src/playlistgenerator/constraints/Checkpoint.cpp M +13 -10 src/playlistgenerator/constraints/TagMatch.cpp https://invent.kde.org/multimedia/amarok/commit/a0433cbec23ce9d1ec85323c6b7ffcf193f9aae3 -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 431507] New: qt6-header-fixes fails when Qt5 is build using OpenGL ES
https://bugs.kde.org/show_bug.cgi?id=431507 Bug ID: 431507 Summary: qt6-header-fixes fails when Qt5 is build using OpenGL ES Product: clazy Version: unspecified Platform: Debian unstable OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: unassigned-b...@kde.org Reporter: p...@kde.org CC: smart...@kde.org Target Milestone: --- SUMMARY When testing clazy 1.9 on current Debian unstable, the qt6-header-fixes test fails when run on architectures (armel and armhf, i.e. 32bit ARM) where Qt is built using OpenGL ES instead of "desktop" OpenGL. STEPS TO REPRODUCE 1. build clazy against Qt built using OpenGL ES 2. run the test suite, either from the build directory, or after installation OBSERVED RESULT This is the output on armhf (it is the same on armel, only the library & include directories change): Qt version: 51502 Qt headers: /usr/include/arm-linux-gnueabihf/qt5 clazy-standalone qstring-varargs/main.cpp -checks=qstring-varargs -- -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/arm-linux-gnueabihf/qt5 -fPIC -L /usr/lib/arm-linux-gnueabihf -Wno-non-pod-varargs Running: clang -Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/arm-linux-gnueabihf/qt5 -fPIC -L /usr/lib/arm-linux-gnueabihf -c -Xclang -plugin-arg-clazy -Xclang qt6-header-fixes -Xclang -plugin-arg-clazy -Xclang export-fixes qt6-header-fixes/main.cpp output_file=qt6-header-fixes/main.cpp.out [FAIL] qt6-header-fixes (plugin) diff -Naur --strip-trailing-cr qt6-header-fixes/main.cpp.expected qt6-header-fixes/main.cpp.result --- qt6-header-fixes/main.cpp.expected 2021-01-10 17:43:52.0 + +++ qt6-header-fixes/main.cpp.result2021-01-11 01:08:38.665301734 + @@ -46,6 +46,7 @@ qt6-header-fixes/main.cpp:47:10: warning: including QtGui/QOpenGLFunctions_4_5_Compatibility [-Wclazy-qt6-header-fixes] qt6-header-fixes/main.cpp:48:10: warning: including QtGui/QOpenGLFunctions_4_5_Core [-Wclazy-qt6-header-fixes] qt6-header-fixes/main.cpp:49:10: warning: including QtGui/QOpenGLFunctions_ES2 [-Wclazy-qt6-header-fixes] +/usr/include/arm-linux-gnueabihf/qt5/QtGui/qopenglfunctions_es2.h:47:10: warning: including QtGui/QOpenGLVersionFunctions [-Wclazy-qt6-header-fixes] qt6-header-fixes/main.cpp:50:10: warning: including QtGui/QOpenGLPaintDevice [-Wclazy-qt6-header-fixes] qt6-header-fixes/main.cpp:51:10: warning: including QtGui/QOpenGLPixelTransferOptions [-Wclazy-qt6-header-fixes] qt6-header-fixes/main.cpp:52:10: warning: including QtGui/QOpenGLShader [-Wclazy-qt6-header-fixes] Full logs: https://buildd.debian.org/status/fetch.php?pkg=clazy=armel=1.9-1=1610334563=1 https://buildd.debian.org/status/fetch.php?pkg=clazy=armhf=1.9-1=1610327402=1 EXPECTED RESULT qt6-header-fixes passes on any architecture. SOFTWARE/OS VERSIONS Qt Version: 5.15.2 -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 429552] qt6-deprecated-api-fixes & qt6-qlatin1stringchar-to-u fail
https://bugs.kde.org/show_bug.cgi?id=429552 --- Comment #5 from Pino Toscano --- Thanks for the quick fixes! I can indeed confirm they work on both LLVM 9 and 11. PS: the clazy 1.8 tar.gz does not have the content inside a top-level directory like clazy-1.8, unlike previous versions (and generally released Linux software). -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 429552] qt6-deprecated-api-fixes & qt6-qlatin1stringchar-to-u fail
https://bugs.kde.org/show_bug.cgi?id=429552 --- Comment #2 from Pino Toscano --- I just tried with LLVM 11, and these two tests pass. -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 429552] qt6-deprecated-api-fixes & qt6-qlatin1stringchar-to-u fail
https://bugs.kde.org/show_bug.cgi?id=429552 --- Comment #1 from Pino Toscano --- Sorry, I typo'ed the Qt version, which is 5.15.1 (as also visible in the snippets). -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 429552] New: qt6-deprecated-api-fixes & qt6-qlatin1stringchar-to-u fail
https://bugs.kde.org/show_bug.cgi?id=429552 Bug ID: 429552 Summary: qt6-deprecated-api-fixes & qt6-qlatin1stringchar-to-u fail Product: clazy Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: unassigned-b...@kde.org Reporter: p...@kde.org CC: smart...@kde.org Target Milestone: --- SUMMARY When testing clazy 1.8 on current Debian unstable using LLVM 9, the qt6-deprecated-api-fixes & qt6-qlatin1stringchar-to-u tests fail when run on Linux architectures (at least on x86_64 and i386). STEPS TO REPRODUCE 1. build clazy on a Linux architecture using LLVM 9 2. run the test suite, either from the build directory, or after installation OBSERVED RESULT Qt version: 51501 Qt headers: /usr/include/i386-linux-gnu/qt5 clang -Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/i386-linux-gnu/qt5 -fPIC -L /usr/lib/i386-linux-gnu -c -Xclang -plugin-arg-clazy -Xclang isempty-vs-count isempty-vs-count/main.cpp Running: clang -Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/i386-linux-gnu/qt5 -fPIC -L /usr/lib/i386-linux-gnu -c -Xclang -plugin-arg-clazy -Xclang qt6-deprecated-api-fixes -Xclang -plugin-arg-clazy -Xclang export-fixes qt6-deprecated-api-fixes/main.cpp output_file=qt6-deprecated-api-fixes/main.cpp.out [FAIL] qt6-deprecated-api-fixes (plugin) diff -Naur --strip-trailing-cr qt6-deprecated-api-fixes/main.cpp.expected qt6-deprecated-api-fixes/main.cpp.result --- qt6-deprecated-api-fixes/main.cpp.expected 2020-11-22 14:30:50.0 + +++ qt6-deprecated-api-fixes/main.cpp.result2020-11-23 13:55:44.805401909 + @@ -1,5 +1,5 @@ qt6-deprecated-api-fixes/main.cpp:38:22: warning: ISO C++11 does not allow conversion from string literal to 'char *' [-Wwritable-strings] -qt6-deprecated-api-fixes/main.cpp:167:35: warning: non-void function does not return a value [-Wreturn-type] +qt6-deprecated-api-fixes/main.cpp:167:35: warning: control reaches end of non-void function [-Wreturn-type] qt6-deprecated-api-fixes/main.cpp:29:9: warning: function setPath() has to be used in Qt6 [-Wclazy-qt6-deprecated-api-fixes] qt6-deprecated-api-fixes/main.cpp:32:10: warning: function setPath() has to be used in Qt6 [-Wclazy-qt6-deprecated-api-fixes] qt6-deprecated-api-fixes/main.cpp:35:10: warning: function setPath() has to be used in Qt6 [-Wclazy-qt6-deprecated-api-fixes] Qt version: 51501 Qt headers: /usr/include/i386-linux-gnu/qt5 clang -Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/i386-linux-gnu/qt5 -fPIC -L /usr/lib/i386-linux-gnu -c -Xclang -plugin-arg-clazy -Xclang qstring-allocations,foreach clazy/suppressionsWholeFile.cpp Running: clang -Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/i386-linux-gnu/qt5 -fPIC -L /usr/lib/i386-linux-gnu -c -Xclang -plugin-arg-clazy -Xclang qt6-qlatin1stringchar-to-u -Xclang -plugin-arg-clazy -Xclang export-fixes qt6-qlatin1stringchar-to-u/main.cpp output_file=qt6-qlatin1stringchar-to-u/main.cpp.out [FAIL] qt6-qlatin1stringchar-to-u (plugin) diff -Naur --strip-trailing-cr qt6-qlatin1stringchar-to-u/main.cpp.expected qt6-qlatin1stringchar-to-u/main.cpp.result --- qt6-qlatin1stringchar-to-u/main.cpp.expected2020-11-22 14:30:50.0 + +++ qt6-qlatin1stringchar-to-u/main.cpp.result 2020-11-23 13:57:11.841399837 + @@ -6,6 +6,8 @@ qt6-qlatin1stringchar-to-u/main.cpp:27:20: warning: QLatin1Char or QLatin1String is being called [-Wclazy-qt6-qlatin1stringchar-to-u] qt6-qlatin1stringchar-to-u/main.cpp:30:24: warning: QLatin1Char or QLatin1String is being called [-Wclazy-qt6-qlatin1stringchar-to-u] qt6-qlatin1stringchar-to-u/main.cpp:30:42: warning: QLatin1Char or QLatin1String is being called [-Wclazy-qt6-qlatin1stringchar-to-u] +qt6-qlatin1stringchar-to-u/main.cpp:30:24: warning: QLatin1Char or QLatin1String is being called [-Wclazy-qt6-qlatin1stringchar-to-u] +qt6-qlatin1stringchar-to-u/main.cpp:30:42: warning: QLatin1Char or QLatin1String is being called [-Wclazy-qt6-qlatin1stringchar-to-u] qt6-qlatin1stringchar-to-u/main.cpp:31:16: warning: QLatin1Char or QLatin1String is being called [-Wclazy-qt6-qlatin1stringchar-to-u] qt6-qlatin1stringchar-to-u/main.cpp:34:16: warning: QLatin1Char or QLatin1String is being called [-Wclazy-qt6-qlatin1stringchar-to-u] qt6-qlatin1stringchar-to-u/main.cpp:36:27: warning: QLatin1Char or QLatin1String is being called [-Wclazy-qt6-qlatin1stringchar-to-u] EXPECTED RESULT qt6-deprecated-api-fixes &
[libksane] [Bug 370940] DPI field shows: 300 DPI (I18N_EXCESS_ARGUMENTS_SUPPLIED)
https://bugs.kde.org/show_bug.cgi?id=370940 Pino Toscano changed: What|Removed |Added Status|REOPENED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/libksane/commit/f88f84 ||3d5e143b4b5b89119189d720d61 ||6c01cbe Resolution|--- |FIXED Version Fixed In||20.07.80 --- Comment #7 from Pino Toscano --- Git commit f88f843d5e143b4b5b89119189d720d616c01cbe by Pino Toscano. Committed on 06/07/2020 at 22:04. Pushed by pino into branch 'master'. i18n: use plural forms for KSaneOption::unitString() strings The resulting string is set as suffix for KPluralHandlingSpinBox. KPluralHandlingSpinBox tries to substitute the value, so the KLocalizedString set must be either a plural form. Hence, make all the strings returned by KSaneOption::unitString() as plural forms. FIXED-IN: 20.07.80 M +4-4src/options/ksaneoption.cpp https://invent.kde.org/graphics/libksane/commit/f88f843d5e143b4b5b89119189d720d616c01cbe -- You are receiving this mail because: You are watching all bug changes.
[libksane] [Bug 370940] DPI field shows: 300 DPI (I18N_EXCESS_ARGUMENTS_SUPPLIED)
https://bugs.kde.org/show_bug.cgi?id=370940 Pino Toscano changed: What|Removed |Added CC|kdelibs-b...@kde.org| -- You are receiving this mail because: You are watching all bug changes.
[libksane] [Bug 370940] DPI field shows: 300 DPI (I18N_EXCESS_ARGUMENTS_SUPPLIED)
https://bugs.kde.org/show_bug.cgi?id=370940 Pino Toscano changed: What|Removed |Added Product|frameworks-ktextwidgets |libksane Component|general |general --- Comment #6 from Pino Toscano --- Actually I take it back: the issue is in libkscan: the KLocalizedString object for KPluralHandlingSpinBox::setSuffix() must be a plural string. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ki18n] [Bug 386053] i18ncp() incorrectly appends I18N_EXCESS_ARGUMENTS_SUPPLIED when singular and plural format strings use different variables
https://bugs.kde.org/show_bug.cgi?id=386053 Pino Toscano changed: What|Removed |Added See Also|https://bugs.kde.org/show_b | |ug.cgi?id=370940| -- You are receiving this mail because: You are watching all bug changes.
[frameworks-ktextwidgets] [Bug 370940] DPI field shows: 300 DPI (I18N_EXCESS_ARGUMENTS_SUPPLIED)
https://bugs.kde.org/show_bug.cgi?id=370940 Pino Toscano changed: What|Removed |Added Version Fixed In|20.07.80| CC||kdelibs-b...@kde.org Product|libksane|frameworks-ktextwidgets Latest Commit|https://invent.kde.org/grap | |hics/libksane/commit/dd39e1 | |fb2f2da6d4f2d8b70366441dc00 | |44117fb | See Also|https://bugs.kde.org/show_b | |ug.cgi?id=386053| Status|RESOLVED|REOPENED Assignee|kare.s...@iki.fi|p...@kde.org Resolution|FIXED |--- Component|general |general --- Comment #5 from Pino Toscano --- Sorry, I just realized the change in libksane is wrong: the result is that the value will be shown twice, once by the spin box itself and the other as its suffix. Instead, I will fix KPluralHandlingSpinBox to not attempt to substitute the value in the suffix KLocalizedString. -- You are receiving this mail because: You are watching all bug changes.
[libksane] [Bug 370940] DPI field shows: 300 DPI (I18N_EXCESS_ARGUMENTS_SUPPLIED)
https://bugs.kde.org/show_bug.cgi?id=370940 Pino Toscano changed: What|Removed |Added Component|general |general Product|Skanlite|libksane -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 370940] DPI field shows: 300 DPI (I18N_EXCESS_ARGUMENTS_SUPPLIED)
https://bugs.kde.org/show_bug.cgi?id=370940 Pino Toscano changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[Skanlite] [Bug 370940] DPI field shows: 300 DPI (I18N_EXCESS_ARGUMENTS_SUPPLIED)
https://bugs.kde.org/show_bug.cgi?id=370940 Pino Toscano changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/libksane/commit/dd39e1 ||fb2f2da6d4f2d8b70366441dc00 ||44117fb Version Fixed In||20.07.80 --- Comment #4 from Pino Toscano --- Git commit dd39e1fb2f2da6d4f2d8b70366441dc0044117fb by Pino Toscano. Committed on 06/07/2020 at 17:10. Pushed by pino into branch 'master'. i18n: add placeholder to KSaneOption::unitString() strings The resulting string is set as suffix for KPluralHandlingSpinBox. KPluralHandlingSpinBox updates its text on value change replacing the value as placeholder/argument in the suffix string; if the KLocalizedString suffix does not have a placeholder, there will be a command line warning about the extra placeholder. FIXED-IN: 20.07.80 M +6-6src/options/ksaneoption.cpp https://invent.kde.org/graphics/libksane/commit/dd39e1fb2f2da6d4f2d8b70366441dc0044117fb -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 423728] inefficient-qlist fails on 32bit architectures
https://bugs.kde.org/show_bug.cgi?id=423728 --- Comment #5 from Pino Toscano --- Thanks, it is skipped now. -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 423728] inefficient-qlist fails on 32bit architectures
https://bugs.kde.org/show_bug.cgi?id=423728 --- Comment #2 from Pino Toscano --- Note I'm just a humble packager in this context, so I don't have any opinion in one way or another. My concern is making sure that the test suite works on all the architectures in Debian where LLVM is available. -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 401494] inefficient-qlist & inefficient-qlist-soft fail on 32bit Linux architectures
https://bugs.kde.org/show_bug.cgi?id=401494 Pino Toscano changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=423728 -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 423728] New: inefficient-qlist fails on 32bit architectures
https://bugs.kde.org/show_bug.cgi?id=423728 Bug ID: 423728 Summary: inefficient-qlist fails on 32bit architectures Product: clazy Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: unassigned-b...@kde.org Reporter: p...@kde.org CC: smart...@kde.org Target Milestone: --- SUMMARY When testing clazy 1.7, the inefficient-qlist test fails when run on 32bit Linux architectures; this is similar/related to the old bug 401494 and bug 413169. Because of the changes done for bug 413169, it does not fail on x86, however it still fails on other 32bit architectures (e.g. arm, mips, powerpc). STEPS TO REPRODUCE 1. build clazy on a 32bit Linux architecture different than x86 2. run the test suite, either from the build directory, or after installation OBSERVED RESULT These are the outputs on armhf, and (sort of different name in library directory) they are the same also on the other affected architectures: Qt version: 51402 Qt headers: /usr/include/arm-linux-gnueabihf/qt5 clazy-standalone connect-non-signal/392441.cpp -checks=connect-non-signal -- -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/arm-linux-gnueabihf/qt5 -fPIC -L /usr/lib/arm-linux-gnueabihf Running: clang -Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/arm-linux-gnueabihf/qt5 -fPIC -L /usr/lib/arm-linux-gnueabihf -c -Xclang -plugin-arg-clazy -Xclang inefficient-qlist inefficient-qlist/main.cpp output_file=inefficient-qlist/main.cpp.out [FAIL] inefficient-qlist (plugin) diff -Naur --strip-trailing-cr inefficient-qlist/main.cpp.expected.x86 inefficient-qlist/main.cpp.result --- inefficient-qlist/main.cpp.expected.x86 2020-06-28 23:30:42.0 + +++ inefficient-qlist/main.cpp.result 2020-07-01 06:29:31.920309898 + @@ -1,4 +1,4 @@ inefficient-qlist/main.cpp:24:5: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist] inefficient-qlist/main.cpp:38:11: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist] inefficient-qlist/main.cpp:40:5: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist] -inefficient-qlist/main.cpp:53:5: warning: Use QVector instead of QList for type with size 12 bytes [-Wclazy-inefficient-qlist] +inefficient-qlist/main.cpp:53:5: warning: Use QVector instead of QList for type with size 16 bytes [-Wclazy-inefficient-qlist] Logs: https://buildd.debian.org/status/fetch.php?pkg=clazy=armel=1.7-1=1593585667=1 https://buildd.debian.org/status/fetch.php?pkg=clazy=armhf=1.7-1=1593585009=1 https://buildd.debian.org/status/fetch.php?pkg=clazy=mipsel=1.7-1=1593588667=1 EXPECTED RESULT inefficient-qlist & inefficient-qlist-soft pass on any architecture. ADDITIONAL INFORMATION IMHO the change done for bug 413169 was more a workaround than a real fix; ideally the test output should be adapted to whatever is the actual size of QVariant. -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 413169] inefficient-qlist fails on Linux x86 (32bit)
https://bugs.kde.org/show_bug.cgi?id=413169 Pino Toscano changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=423728 -- You are receiving this mail because: You are watching all bug changes.
[KAccounts] [Bug 422191] [ABI break] KAccountsDPlugin changes its API without bumping the libkaccount SONAME
https://bugs.kde.org/show_bug.cgi?id=422191 Pino Toscano changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED --- Comment #2 from Pino Toscano --- @Nicolas: ping? -- You are receiving this mail because: You are watching all bug changes.
[kwalletmanager] [Bug 421178] kwalletmanager cannot be started by systemsettings/account details/launch
https://bugs.kde.org/show_bug.cgi?id=421178 --- Comment #6 from Pino Toscano --- > this bug is still there in plasma 5.19.1 Note that this is in kwalletmanager, which is released as part of the quarterly release service. Hence, any update of Plasma will not change the status. You need kwalletmanager 20.04.3 (or greater), will be released in 3 weeks. -- You are receiving this mail because: You are watching all bug changes.
[kwalletmanager] [Bug 421178] kwalletmanager cannot be started by systemsettings/account details/launch
https://bugs.kde.org/show_bug.cgi?id=421178 Pino Toscano changed: What|Removed |Added Assignee|va...@kde.org |p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kwalletmanager] [Bug 421178] kwalletmanager cannot be started by systemsettings/account details/launch
https://bugs.kde.org/show_bug.cgi?id=421178 Pino Toscano changed: What|Removed |Added Version|5.18.5 |20.04 Assignee|k...@davidedmundson.co.uk|va...@kde.org Target Milestone|1.0 |--- Product|plasmashell |kwalletmanager Component|general |general -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 421178] kwalletmanager cannot be started by systemsettings/account details/launch
https://bugs.kde.org/show_bug.cgi?id=421178 Pino Toscano changed: What|Removed |Added CC||p...@kde.org Version Fixed In||20.04.3 Status|REPORTED|RESOLVED Latest Commit||https://commits.kde.org/kwa ||lletmanager/9cf4ab73cd9b6eb ||38ddf8f55dca797510de513f0 Resolution|--- |FIXED --- Comment #5 from Pino Toscano --- I fixed it few days ago with commit https://commits.kde.org/kwalletmanager/9cf4ab73cd9b6eb38ddf8f55dca797510de513f0 which will be in kwalletmanager >= 20.04.3. Sorry for noticing this bug earlier. -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 402017] Cannot save PDF when loaded file has been deleted
https://bugs.kde.org/show_bug.cgi?id=402017 --- Comment #28 from Pino Toscano --- (In reply to Nate Graham from comment #27) > If Firefox isn't interested in playing ball, then our only realistic option > is work around it in Okular. This isn't ideal, but seems preferable to > letting user data be destroyed for the sake of a principle (making the fix > in the right place). The "principle" here is one of the factors, and not one of bigger ones. This behaviour (i.e. remove the temporary files when closing tabs or exiting) affects _any_ application launched by Firefox: okular, kwrite/kate, gwenview, you name it. Adding the same workarounds in any application potentially launched by Firefox and used by users means adding more complexity to those applications (like proven by the discussion in this bug, and my attempt 12 years ago, bug 163363), and even more so when each application usually handles file reading in its own way, making even harder to "share" a potential workaround. Also, what if you try to talk with Mozilla people about this, for example? -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 402017] Cannot save PDF when loaded file has been deleted
https://bugs.kde.org/show_bug.cgi?id=402017 --- Comment #26 from Pino Toscano --- (In reply to Nate Graham from comment #25) > Is there a technically feasible way for Firefox to do something better? In the same way XDG desktop environment do it: by handling the XDG base directory and XDG desktop files specifications to detect which applications can handle a certain content type and/or a certain remote protocol. See also https://bugzilla.mozilla.org/show_bug.cgi?id=415441#c12 -- maybe there is a better non-closed bug asking this, and if not it would be good to open it. However, in general Mozilla does not care that much about integrating properly Firefox/etc in Unix desktops, as their main share of users is on Windows... -- You are receiving this mail because: You are watching all bug changes.
[KAccounts] [Bug 422191] [ABI break] KAccountsDPlugin changes its API without bumping the libkaccount SONAME
https://bugs.kde.org/show_bug.cgi?id=422191 Pino Toscano changed: What|Removed |Added Summary|[ABI break] 20.04 and |[ABI break] |20.04.1 have renamed|KAccountsDPlugin changes |symbols and needs and ABI |its API without bumping the |bump|libkaccount SONAME CC||nicolas.fe...@gmx.de, ||p...@kde.org --- Comment #1 from Pino Toscano --- Note that the actual ABI change is not what Nicholas mention, but rather this: diff --git a/src/lib/kaccountsdplugin.h b/src/lib/kaccountsdplugin.h index 1f1f82f..178a3d3 100644 --- a/src/lib/kaccountsdplugin.h +++ b/src/lib/kaccountsdplugin.h @@ -54,7 +54,7 @@ class KACCOUNTS_EXPORT KAccountsDPlugin : public QObject Q_OBJECT public: -KAccountsDPlugin(QObject *parent = nullptr); +KAccountsDPlugin(QObject *parent, const QVariantList& args); virtual ~KAccountsDPlugin(); public Q_SLOTS: @@ -90,6 +90,4 @@ public Q_SLOTS: virtual void onServiceDisabled(const Accounts::AccountId accountId, const Accounts::Service ) = 0; }; -Q_DECLARE_INTERFACE(KAccountsDPlugin, "org.kde.kaccounts.DPlugin") - #endif // KACCOUNTSDPLUGIN_H Ie done as part of https://phabricator.kde.org/D27633, commit: https://invent.kde.org/network/kaccounts-integration/-/commit/27487ab9276ca3a9b6ef4e8145b2279b5e38cd25 -- You are receiving this mail because: You are watching all bug changes.
[okular] [Bug 402017] Cannot save PDF when loaded file has been deleted
https://bugs.kde.org/show_bug.cgi?id=402017 --- Comment #16 from Pino Toscano --- (In reply to David Hurka from comment #13) > @Pino: Can you tell more about the problem? Can it be fixed, or do we need > another approach than creating a file handle? See bug 163363. Holding an open descriptor on the document fixes the case that the document disappears (hello firefox, and apparently hello kmail too...) while it is opened in okular. The big downside, which is also what I mentioned, is that file watching breaks, and reading the commit should give an hint on why: the handle is kept for the _old_ file, so when some PDF producer (latex, etc) creates a new file by rename()ing the new temporary file on the old name (which is an atomic operation), you don't notice that. At least, I remember there were problems in the results you get from file watching because of this. While fixing firefox to not remove files under applications' feet is not an easy task (12 years and still no change on that), why don't we fix at least our own products (kmail)? Enabling FileKeeper again will not fix this situation, as you will trade one issue with another. (In reply to Nate Graham from comment #14) > Temporarily wasting some memory or disk space is a far better alternative > than data loss. :) This won't behave nicely in editing sessions e.g. in kile or in other document producers, where you edit the sources and save+recompile to PDF often, resulting in a big churn of file creations/removals, and in slowdown due to the blocking file saving. -- You are receiving this mail because: You are watching all bug changes.
[kig] [Bug 419237] kig's FindBoostPython.cmake does not find the py3 version of python-boost
https://bugs.kde.org/show_bug.cgi?id=419237 Pino Toscano changed: What|Removed |Added Latest Commit||https://commits.kde.org/kig ||/1fdeff25f5f113f4567ab100da ||9df3f0f24c3ce8 Resolution|--- |FIXED Status|REPORTED|RESOLVED Version Fixed In||20.07.80 --- Comment #2 from Pino Toscano --- Git commit 1fdeff25f5f113f4567ab100da9df3f0f24c3ce8 by Pino Toscano. Committed on 03/05/2020 at 08:08. Pushed by pino into branch 'master'. cmake: switch python & boost-python search to py3 Python 2 is EOL now, and Python 3 has been available in distros for years already, so it is time to switch exclusively to Python 3. The actual changes to the BoostPython module are: - look for the python3 boost component (instead of python): while boost upstream does not provide it, most of the distros do; the alternative would be to look for the pythonXY components, which is not ideal... - look for the python libraries >= 3, setting as additional versions for the cmake module all the non-EOL Python 3 versions - set as Python versions for pkg-config all the non-EOL ones, using the embed version starting from Python 3.8 [1] [1] https://bugs.python.org/issue36721 FIXED-IN: 20.07.80 M +11 -9cmake/modules/FindBoostPython.cmake https://commits.kde.org/kig/1fdeff25f5f113f4567ab100da9df3f0f24c3ce8 -- You are receiving this mail because: You are watching all bug changes.
[kig] [Bug 419237] kig's FindBoostPython.cmake does not find the py3 version of python-boost
https://bugs.kde.org/show_bug.cgi?id=419237 Pino Toscano changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kig] [Bug 388241] Cannot use python scripting when compiling from source
https://bugs.kde.org/show_bug.cgi?id=388241 Pino Toscano changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[tellico] [Bug 420451] iso5426test fails (and maybe Iso5426Converter is broken) when char is unsigned
https://bugs.kde.org/show_bug.cgi?id=420451 --- Comment #7 from Pino Toscano --- Thanks, it worked perfectly now: https://buildd.debian.org/status/logs.php?pkg=tellico=3.3-2=sid -- You are receiving this mail because: You are watching all bug changes.
[tellico] [Bug 420451] iso5426test fails (and maybe Iso5426Converter is broken) when char is unsigned
https://bugs.kde.org/show_bug.cgi?id=420451 --- Comment #3 from Pino Toscano --- (In reply to Robby Stephenson from comment #1) > Created attachment 127900 [details] > Try to account for uchar from QByteArray I tested this patch on s390x Debian unstable porterbox, and it worked -- iso5426test passed. Thanks! -- You are receiving this mail because: You are watching all bug changes.
[tellico] [Bug 420451] New: iso5426test fails (and maybe Iso5426Converter is broken) when char is unsigned
https://bugs.kde.org/show_bug.cgi?id=420451 Bug ID: 420451 Summary: iso5426test fails (and maybe Iso5426Converter is broken) when char is unsigned Product: tellico Version: 3.3 Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: ro...@periapsis.org Reporter: p...@kde.org Target Milestone: --- SUMMARY The iso5426test test fails on architectures where char is signed (for example ARM, POWER, RISC-V, IBM Z). This is its output as executed when building tellico 3.3 on Debian unstable on s390x (IBM Z): * Start testing of Iso5426Test * Config: Using QtTest library 5.12.5, Qt 5.12.5 (s390x-big_endian-lp64 shared (dynamic) release build; by GCC 9.3.0) PASS : Iso5426Test::initTestCase() PASS : Iso5426Test::testStrings(lowercase) PASS : Iso5426Test::testStrings(uppercase) PASS : Iso5426Test::testStrings(numbers) PASS : Iso5426Test::testStrings(symbols) PASS : Iso5426Test::testCharacters(0020) PASS : Iso5426Test::testCharacters(0021) PASS : Iso5426Test::testCharacters(0022) PASS : Iso5426Test::testCharacters(0023) PASS : Iso5426Test::testCharacters(0025) PASS : Iso5426Test::testCharacters(0026) PASS : Iso5426Test::testCharacters(0027) PASS : Iso5426Test::testCharacters(0028) PASS : Iso5426Test::testCharacters(0029) PASS : Iso5426Test::testCharacters(002a) PASS : Iso5426Test::testCharacters(002b) PASS : Iso5426Test::testCharacters(002c) PASS : Iso5426Test::testCharacters(002d) PASS : Iso5426Test::testCharacters(002e) PASS : Iso5426Test::testCharacters(002f) PASS : Iso5426Test::testCharacters(0030) PASS : Iso5426Test::testCharacters(0031) PASS : Iso5426Test::testCharacters(0032) PASS : Iso5426Test::testCharacters(0033) PASS : Iso5426Test::testCharacters(0034) PASS : Iso5426Test::testCharacters(0035) PASS : Iso5426Test::testCharacters(0036) PASS : Iso5426Test::testCharacters(0037) PASS : Iso5426Test::testCharacters(0038) PASS : Iso5426Test::testCharacters(0039) PASS : Iso5426Test::testCharacters(003a) PASS : Iso5426Test::testCharacters(003b) PASS : Iso5426Test::testCharacters(003c) PASS : Iso5426Test::testCharacters(003d) PASS : Iso5426Test::testCharacters(003e) PASS : Iso5426Test::testCharacters(003f) PASS : Iso5426Test::testCharacters(0040) PASS : Iso5426Test::testCharacters(0041) PASS : Iso5426Test::testCharacters(0042) PASS : Iso5426Test::testCharacters(0043) PASS : Iso5426Test::testCharacters(0044) PASS : Iso5426Test::testCharacters(0045) PASS : Iso5426Test::testCharacters(0046) PASS : Iso5426Test::testCharacters(0047) PASS : Iso5426Test::testCharacters(0048) PASS : Iso5426Test::testCharacters(0049) PASS : Iso5426Test::testCharacters(004a) PASS : Iso5426Test::testCharacters(004b) PASS : Iso5426Test::testCharacters(004c) PASS : Iso5426Test::testCharacters(004d) PASS : Iso5426Test::testCharacters(004e) PASS : Iso5426Test::testCharacters(004f) PASS : Iso5426Test::testCharacters(0050) PASS : Iso5426Test::testCharacters(0051) PASS : Iso5426Test::testCharacters(0052) PASS : Iso5426Test::testCharacters(0053) PASS : Iso5426Test::testCharacters(0054) PASS : Iso5426Test::testCharacters(0055) PASS : Iso5426Test::testCharacters(0056) PASS : Iso5426Test::testCharacters(0057) PASS : Iso5426Test::testCharacters(0058) PASS : Iso5426Test::testCharacters(0059) PASS : Iso5426Test::testCharacters(005a) PASS : Iso5426Test::testCharacters(005b) PASS : Iso5426Test::testCharacters(005c) PASS : Iso5426Test::testCharacters(005d) PASS : Iso5426Test::testCharacters(005e) PASS : Iso5426Test::testCharacters(005f) PASS : Iso5426Test::testCharacters(0060) PASS : Iso5426Test::testCharacters(0061) PASS : Iso5426Test::testCharacters(0062) PASS : Iso5426Test::testCharacters(0063) PASS : Iso5426Test::testCharacters(0064) PASS : Iso5426Test::testCharacters(0065) PASS : Iso5426Test::testCharacters(0066) PASS : Iso5426Test::testCharacters(0067) PASS : Iso5426Test::testCharacters(0068) PASS : Iso5426Test::testCharacters(0069) PASS : Iso5426Test::testCharacters(006a) PASS : Iso5426Test::testCharacters(006b) PASS : Iso5426Test::testCharacters(006c) PASS : Iso5426Test::testCharacters(006d) PASS : Iso5426Test::testCharacters(006e) PASS : Iso5426Test::testCharacters(006f) PASS : Iso5426Test::testCharacters(0070) PASS : Iso5426Test::testCharacters(0071) PASS : Iso5426Test::testCharacters(0072) PASS : Iso5426Test::testCharacters(0073) PASS : Iso5426Test::testCharacters(0074) PASS : Iso5426Test::testCharacters(0075) PASS : Iso5426Test::testCharacters(0076) PASS : Iso5426Test::testCharacters(0077) PASS : Iso5426Test::testCharacters(0078) PASS : Iso5426Test::testCharacters(0079) PASS : Iso5426Test::testCharacters(007a) PASS :
[clazy] [Bug 413169] New: inefficient-qlist fails on Linux x86 (32bit)
https://bugs.kde.org/show_bug.cgi?id=413169 Bug ID: 413169 Summary: inefficient-qlist fails on Linux x86 (32bit) Product: clazy Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: unassigned-b...@kde.org Reporter: p...@kde.org CC: smart...@kde.org Target Milestone: --- SUMMARY When testing clazy 1.6, the inefficient-qlist test fails when run on x86 32bit Linux architectures (i.e. i386 in Debian). STEPS TO REPRODUCE 1. build clazy on Linux x86 2. run the test suite, either from the build directory, or after installation OBSERVED RESULT Qt version: 51103 Qt headers: /usr/include/i386-linux-gnu/qt5 clazy-standalone old-style-connect/port_qsignalspy.cpp -export-fixes=old-style-connect/port_qsignalspy.cpp.clazy-standalone.yaml -checks=old-style-connect -- -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/i386-linux-gnu/qt5 -fPIC -L /usr/lib/i386-linux-gnu Running: clang -Xclang -load -Xclang ClazyPlugin.so -Xclang -add-plugin -Xclang clazy -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/i386-linux-gnu/qt5 -fPIC -L /usr/lib/i386-linux-gnu -c -Xclang -plugin-arg-clazy -Xclang inefficient-qlist inefficient-qlist/main.cpp output_file=inefficient-qlist/main.cpp.out [FAIL] inefficient-qlist (plugin) diff -Naur --strip-trailing-cr inefficient-qlist/main.cpp.expected inefficient-qlist/main.cpp.result --- inefficient-qlist/main.cpp.expected 2019-10-12 08:39:47.0 + +++ inefficient-qlist/main.cpp.result 2019-10-18 14:14:56.093460474 + @@ -1,4 +1,4 @@ inefficient-qlist/main.cpp:24:5: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist] inefficient-qlist/main.cpp:38:11: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist] inefficient-qlist/main.cpp:40:5: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist] -inefficient-qlist/main.cpp:53:5: warning: Use QVector instead of QList for type with size 16 bytes [-Wclazy-inefficient-qlist] +inefficient-qlist/main.cpp:53:5: warning: Use QVector instead of QList for type with size 12 bytes [-Wclazy-inefficient-qlist] Log: https://buildd.debian.org/status/fetch.php?pkg=clazy=i386=1.6-1=1571408147=1 EXPECTED RESULT inefficient-qlist passes on any architecture. SOFTWARE/OS VERSIONS clazy 1.6 ADDITIONAL INFORMATION Basically the test properly detects QList as inefficient, just that the error message does not match the baseline due to the different size of QVariant. This was introduced with commit 948a23ae1b1553cf67dc8b523236cc0e7dc74994. -- You are receiving this mail because: You are watching all bug changes.
[lokalize] [Bug 305677] "default" window title string for default project not translateable
https://bugs.kde.org/show_bug.cgi?id=305677 Pino Toscano changed: What|Removed |Added CC||p...@kde.org --- Comment #5 from Pino Toscano --- Note that: 1) the default project ID/name is "default", not translatable; at most the initial value for it can be translated 2) the name is set by the user anyway, so if they choose "default" as project name, then lokalize must show that - unchanged - everywhere (1) should be easy to do (it needs to be checked though); regarding existing project names, then lokalize must definitely _not_ touch them in any way. -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 393708] Copy to clipboard doesn't seem to work with default Klipper settings
https://bugs.kde.org/show_bug.cgi?id=393708 Pino Toscano changed: What|Removed |Added Version Fixed In|Applications 19.04.0 on |Applications 19.08.0 on |Plasma 5.15.4 or later |Plasma 5.15.4 or later -- You are receiving this mail because: You are watching all bug changes.
[Spectacle] [Bug 385559] "Copy to Clipboard" CLI option for spectacle
https://bugs.kde.org/show_bug.cgi?id=385559 Pino Toscano changed: What|Removed |Added Version Fixed In|19.04.0 |19.08.0 -- You are receiving this mail because: You are watching all bug changes.
[i18n] [Bug 405102] (Lubuntu 19.10) Japanese translation of discover
https://bugs.kde.org/show_bug.cgi?id=405102 Pino Toscano changed: What|Removed |Added Assignee|lei...@leinir.dk|tk...@pa3.so-net.ne.jp Component|discover|ja Version|5.15.1 |unspecified Product|Discover|i18n -- You are receiving this mail because: You are watching all bug changes.
[clazy] [Bug 401494] New: inefficient-qlist & inefficient-qlist-soft fail on 32bit Linux architectures
https://bugs.kde.org/show_bug.cgi?id=401494 Bug ID: 401494 Summary: inefficient-qlist & inefficient-qlist-soft fail on 32bit Linux architectures Product: clazy Version: unspecified Platform: Debian unstable OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: unassigned-b...@kde.org Reporter: p...@kde.org CC: smart...@kde.org Target Milestone: --- SUMMARY The inefficient-qlist, and tests fail when run on 32bit Linux architectures (e.g. armhf, i386, mips, and powerpc, in Debian). STEPS TO REPRODUCE 1. build clazy on one of the aforementioned 32it Linux architectures 2. run the test suite, either from the build directory, or after installation OBSERVED RESULT These are the outputs on i386, and (sort of different name in library directory) they are the same also on the other affected architectures: Qt version: 51102 Qt headers: /usr/include/i386-linux-gnu/qt5 Running: clang -Xclang -load -Xclang ClangLazy.so -Xclang -add-plugin -Xclang clang-lazy -Xclang -plugin-arg-clang-lazy -Xclang no-inplace-fixits -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/i386-linux-gnu/qt5 -fPIC -L /usr/lib/i386-linux-gnu -c -Xclang -plugin-arg-clang-lazy -Xclang inefficient-qlist -Xclang -plugin-arg-clang-lazy -Xclang enable-all-fixits inefficient-qlist/main.cpp output_file=inefficient-qlist/main.cpp.out [FAIL] inefficient-qlist --- inefficient-qlist/main.cpp.expected 2018-09-23 16:22:24.0 + +++ inefficient-qlist/main.cpp.result 2018-11-27 08:00:50.257341202 + @@ -1,3 +1,4 @@ inefficient-qlist/main.cpp:24:5: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist] +inefficient-qlist/main.cpp:25:5: warning: Use QVector instead of QList for type with size 8 bytes [-Wclazy-inefficient-qlist] inefficient-qlist/main.cpp:38:11: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist] inefficient-qlist/main.cpp:40:5: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist] Qt version: 51102 Qt headers: /usr/include/i386-linux-gnu/qt5 Running: clang -Xclang -load -Xclang ClangLazy.so -Xclang -add-plugin -Xclang clang-lazy -Xclang -plugin-arg-clang-lazy -Xclang no-inplace-fixits -Wno-unused-value -Qunused-arguments -std=c++14 -isystem /usr/include/i386-linux-gnu/qt5 -fPIC -L /usr/lib/i386-linux-gnu -c -Xclang -plugin-arg-clang-lazy -Xclang inefficient-qlist-soft -Xclang -plugin-arg-clang-lazy -Xclang enable-all-fixits inefficient-qlist-soft/main.cpp output_file=inefficient-qlist-soft/main.cpp.out [FAIL] inefficient-qlist-soft --- inefficient-qlist-soft/main.cpp.expected2018-09-23 16:22:24.0 + +++ inefficient-qlist-soft/main.cpp.result 2018-11-27 08:00:46.469387068 + @@ -1,3 +1,4 @@ inefficient-qlist-soft/main.cpp:24:5: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist-soft] +inefficient-qlist-soft/main.cpp:25:5: warning: Use QVector instead of QList for type with size 8 bytes [-Wclazy-inefficient-qlist-soft] inefficient-qlist-soft/main.cpp:64:5: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist-soft] inefficient-qlist-soft/main.cpp:68:5: warning: Use QVector instead of QList for type with size 9 bytes [-Wclazy-inefficient-qlist-soft] Logs: https://buildd.debian.org/status/fetch.php?pkg=clazy=armhf=1.4-2=1543305282=1 https://buildd.debian.org/status/fetch.php?pkg=clazy=i386=1.4-2=1543305671=1 https://buildd.debian.org/status/fetch.php?pkg=clazy=mips=1.4-2=1543387556=1 https://buildd.debian.org/status/fetch.php?pkg=clazy=powerpc=1.4-2=1543305940=1 EXPECTED RESULT inefficient-qlist & inefficient-qlist-soft pass on any architecture. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 396121] Build failure with libraw-0.19
https://bugs.kde.org/show_bug.cgi?id=396121 Pino Toscano changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 396121] Build failure with libraw-0.19
https://bugs.kde.org/show_bug.cgi?id=396121 Pino Toscano changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Pino Toscano --- This was fixed recently in master (future krita 4.2) by: https://commits.kde.org/krita/3b7d0f2cbf66b06e12c57be26b262b71d8030d1a I guess a backport to 4.1 would be a good idea too, unless krita people plan to release 4.2.0 soon. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 397040] crash when save a QImage to the eps format file
https://bugs.kde.org/show_bug.cgi?id=397040 Pino Toscano changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[frameworks-kimageformats] [Bug 397040] crash when save a QImage to the eps format file
https://bugs.kde.org/show_bug.cgi?id=397040 --- Comment #4 from Pino Toscano --- (In reply to zccrs from comment #3) > Created attachment 114347 [details] > This is a stack list This shows that the issue is not in the EPS handler, which is called for some reasons during the application destruction. The problem is the deepin stuff, including its usage of an internal part of Qt (the Qt5XcbQpa library). Try the test case of comment 2 without any deepin stuff installed. -- You are receiving this mail because: You are watching all bug changes.
[kopete] [Bug 395287] Disable yahoo messenger plugin
https://bugs.kde.org/show_bug.cgi?id=395287 Pino Toscano changed: What|Removed |Added Version Fixed In||18.08.0 --- Comment #3 from Pino Toscano --- Note for packagers (and whoever builds kopete on their own): for older versions, you can disable the Yahoo protocol when building by passing -DWITH_yahoo=OFF to cmake. -- You are receiving this mail because: You are watching all bug changes.
[kopete] [Bug 395287] Disable yahoo messenger plugin
https://bugs.kde.org/show_bug.cgi?id=395287 Pino Toscano changed: What|Removed |Added Latest Commit||https://commits.kde.org/kop ||ete/da33bbfb24e3c026ee7eadb ||5f37085df80bfe481 Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #2 from Pino Toscano --- Git commit da33bbfb24e3c026ee7eadb5f37085df80bfe481 by Pino Toscano. Committed on 19/07/2018 at 03:56. Pushed by pino into branch 'Applications/18.08'. Remove the Yahoo protocol Yahoo discontinued the Yahoo Messenger on July 17, 2018, so this protocol is effectively dead. As a result: - remove the code of the protocol itself - remove all the supporting cmake stuff - remove one notification specific to it - remove the kconf_update scripts - slightly update the documentation to not mention Yahoo anymore - stop mentioning it in the appdata file This way, developers/downstreams will not try to accidentally build/ship this anymore. Fixed-In: 18.08.0 [1] https://help.yahoo.com/kb/SLN28776.html M +0-3CMakeLists.txt M +1-6doc/index.docbook M +2-2kopete/kconf_update/CMakeLists.txt D +0-20 kopete/kconf_update/kopete-update_yahoo_server.pl D +0-4kopete/kconf_update/kopete-update_yahoo_server.upd M +0-137 kopete/kopete.notifyrc M +1-1kopete/org.kde.kopete.appdata.xml M +0-8libkopete/kopete_export.h M +0-4protocols/CMakeLists.txt D +0-70 protocols/yahoo/CMakeLists.txt D +0-9protocols/yahoo/icons/CMakeLists.txt D +---protocols/yahoo/icons/cr16-action-yahoo_connecting.mng D +---protocols/yahoo/icons/ox128-app-yahoo_protocol.png D +---protocols/yahoo/icons/ox16-action-yahoo_away.png D +---protocols/yahoo/icons/ox16-action-yahoo_busy.png D +---protocols/yahoo/icons/ox16-action-yahoo_idle.png D +---protocols/yahoo/icons/ox16-action-yahoo_invisible.png D +---protocols/yahoo/icons/ox16-action-yahoo_mobile.png D +---protocols/yahoo/icons/ox16-action-yahoo_stealthed.png D +---protocols/yahoo/icons/ox16-action-yahoo_tea.png D +---protocols/yahoo/icons/ox16-app-yahoo_protocol.png D +---protocols/yahoo/icons/ox22-action-yahoo_stealthed.png D +---protocols/yahoo/icons/ox32-action-yahoo_stealthed.png D +---protocols/yahoo/icons/ox32-app-yahoo_protocol.png D +---protocols/yahoo/icons/ox48-app-yahoo_protocol.png D +---protocols/yahoo/icons/ox64-app-yahoo_protocol.png D +0-149 protocols/yahoo/kopete_yahoo.desktop D +0-91 protocols/yahoo/libkyahoo/CMakeLists.txt D +0-46 protocols/yahoo/libkyahoo/alivetask.cpp D +0-36 protocols/yahoo/libkyahoo/alivetask.h D +0-277 protocols/yahoo/libkyahoo/bytestream.cpp D +0-76 protocols/yahoo/libkyahoo/bytestream.h D +0-85 protocols/yahoo/libkyahoo/changestatustask.cpp D +0-49 protocols/yahoo/libkyahoo/changestatustask.h D +0-63 protocols/yahoo/libkyahoo/chatsessiontask.cpp D +0-45 protocols/yahoo/libkyahoo/chatsessiontask.h D +0-1015 protocols/yahoo/libkyahoo/client.cpp D +0-755 protocols/yahoo/libkyahoo/client.h D +0-274 protocols/yahoo/libkyahoo/conferencetask.cpp D +0-57 protocols/yahoo/libkyahoo/conferencetask.h D +0-60 protocols/yahoo/libkyahoo/connector.cpp D +0-58 protocols/yahoo/libkyahoo/connector.h D +0-214 protocols/yahoo/libkyahoo/coreprotocol.cpp D +0-106 protocols/yahoo/libkyahoo/coreprotocol.h D +0-202 protocols/yahoo/libkyahoo/crypt.c D +0-158 protocols/yahoo/libkyahoo/filetransfernotifiertask.cpp D +0-50 protocols/yahoo/libkyahoo/filetransfernotifiertask.h D +0-97 protocols/yahoo/libkyahoo/inputprotocolbase.cpp D +0-76 protocols/yahoo/libkyahoo/inputprotocolbase.h D +0-20 protocols/yahoo/libkyahoo/libkyahoo_export.h D +0-529 protocols/yahoo/libkyahoo/libyahoo.c D +0-60 protocols/yahoo/libkyahoo/libyahoo.h D +0-108 protocols/yahoo/libkyahoo/listtask.cpp D +0-46 protocols/yahoo/libkyahoo/listtask.h D +0-441 protocols/yahoo/libkyahoo/logintask.cpp D +0-95 protocols/yahoo/libkyahoo/logintask.h D +0-43 protocols/yahoo/libkyahoo/logofftask.cpp D +0-34 protocols/yahoo/libkyahoo/logofftask.h D +0-78 protocols/yahoo/libkyahoo/mailnotifiertask.cpp D +0-44 protocols/yahoo/libkyahoo/mailnotifiertask.h D +0-391 protocols/yahoo/libkyahoo/md5.c D +0-93 protocols/yahoo/libkyahoo/md5.h D +0-196 protocols/yahoo/libkyahoo/messagereceivertask.cpp D +0-50 protocols/yahoo/libkyahoo/messagereceivertask.h D +0-165 protocols/yahoo/libkyahoo/modifybuddytask.cpp D +0
[kio-gdrive] [Bug 396262] [PATCH] Provide screenshot in Appstream metadata
https://bugs.kde.org/show_bug.cgi?id=396262 --- Comment #6 from Pino Toscano --- (In reply to Nate Graham from comment #5) > Can you paste the link to the patch here? I'm @ngraham on Phabricator. https://phabricator.kde.org/D14119 -- You are receiving this mail because: You are watching all bug changes.
[kmldonkey] [Bug 376499] KMldonkey crashes on startup
https://bugs.kde.org/show_bug.cgi?id=376499 Pino Toscano changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kmldonkey] [Bug 386331] Kmldonkey crash
https://bugs.kde.org/show_bug.cgi?id=386331 Pino Toscano changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Pino Toscano --- *** This bug has been marked as a duplicate of bug 376499 *** -- You are receiving this mail because: You are watching all bug changes.
[kmldonkey] [Bug 376499] KMldonkey crashes on startup
https://bugs.kde.org/show_bug.cgi?id=376499 Pino Toscano changed: What|Removed |Added CC||ranmaru.hibik...@gmail.com --- Comment #2 from Pino Toscano --- *** Bug 386331 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #62 from Pino Toscano --- Forgot to ask: @Tyson: which version of Qt do you have? Also, are you sure you have the Qt translations installed (they are a different Qt module). What about the [OK], [Cancel], etc buttons on other Qt/KF5 applications, e.g. kate, kwrite, dolphin, okular, etc? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #61 from Pino Toscano --- OK, so if I set zh_CN as language in krita (Settings -> Switch Application Language), I can see the following: - the standard buttons eg [OK], [Cancel], [Apply], [Reset] are properly translated -- in particular, these you showed in screenshots 001C, 014, 006A, 008C1, 010C1, 010D1 - in 006A, only the "Pick Screen Color" string is untranslated - in 001C, I can confirm the untranslated [Create] button, and the size text - 004A is still untranslated as before; this involves the system of resources, and also other kind of resources (e.g. the shipped brushes/patterns/etc) are untranslated as well, so a separate discussion about these is needed - in 008C1 the [Print] button is translated, but the categories not; I have a prototype of fix for this, still needs more work - in 011D1 the strings come from SVG files themselves @Boud: just to be sure: I guess translations for 4.1.0 were picked from /branches/stable/l10n-kf5, right? Where are the scripts used to create the release tarballs? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #60 from Pino Toscano --- (In reply to Tyson Tan from comment #53) > Created attachment 113640 [details] > 008C1 Configure Krita-Keyboard Shortcut > > In "Configure Krita" dialogue, "Keyboard Shortcut" page. > The categories and one item are untranslatable. It looks like that your "Tools" category includes way more elements than what mine (krita 4.1.0 built as Debian package) includes, and "Artistic Text Tool" is one of these extras. Do you build krita from sources, and install it somewhere locally? If so, it might be an old plugin still lying around... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #59 from Pino Toscano --- (In reply to Tyson Tan from comment #50) > Created attachment 113636 [details] > 014_Configure Krita dialogue > > Krita 4.1.0, still untranslated: > 1) [Restore Default] This string is actually translatable -- I enabled its translation few days ago, and indeed it is still not translated in zh_CN. -- You are receiving this mail because: You are watching all bug changes.
[kopete] [Bug 395287] Disable yahoo messenger plugin
https://bugs.kde.org/show_bug.cgi?id=395287 Pino Toscano changed: What|Removed |Added Component|general |Yahoo Plugin OS|Linux |All --- Comment #1 from Pino Toscano --- I will propose a removal after that time, then. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #48 from Pino Toscano --- @Tyson Tan: now that Krita 4.1.0 is released, can you please check again the status of all the issues you reported as images? If so, please mark the images of all the fixed cases as "obsolete" attachments in this bug, so it is easier to see what you still notice as untranslated. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #44 from Pino Toscano --- (In reply to Tyson Tan from comment #42) > Thank you Boud and Pino. And today all new strings have been translated. Remember to make sure the updated translations are pushed in the KDE SVN; right now I see in stable/l10n-kf5 for zh_CN: $ LANG=C msgfmt --statistics -c -o /dev/null extragear-graphics/krita.po 5433 translated messages, 394 fuzzy translations, 180 untranslated messages. stable/l10n-kf5 follows the krita/4.1 branch of krita, and it is what will be used when releasing krita 4.1.x. trunk/l10n-kf5 currently follows the master branch of krita, and will be used for future 4.2.x. > kf5-trunk/messages/extragear-graphics/desktop_extragear-graphics_krita.pot This is for strings in .desktop files, and they are written back to the .desktop files themselves; most of the strings here are used in krita. > kf5-trunk/messages/extragear-graphics/org.kde.krita.appdata.pot This is for strings in the .appdata.xml files, and they are written back to the .appdata.xml files themselves; the .appdata.xml files are not used by the applications themselves, but by consumers of the AppStream format (e.g. Plasma Discover, GNOME Software, etc). Note both the file above are available also in stable/l10n-kf5. > Plus, I don't know how to deal with [OK] [Cancel] buttons yet. For some > reason, some of them are translated in some dialogues, but not all of them. At this point I'd say: - @Tyson: make sure that krita.po in stable/l10n-kf5 for zh_CN is 100% translated - if Boud does not beat me to it, I will try to fix the i18n() SIP binding in pykrita once an alpha/beta of 4.1.0 with translations is available - let's re-check the status again once the final 4.1.0 is released -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #43 from Pino Toscano --- Git commit 77a5df289ff30f2d4a740521b571e978c13e58d3 by Pino Toscano. Committed on 19/06/2018 at 03:54. Pushed by pino into branch 'krita/4.1'. pykrita: use KDesktopFile to read desktop files of plugins This way translations are automatically used. (the case 008F is fixed) (cherry picked from commit cc25aeddb2ea2054d5e435cfeb1b5ad65dd98710) M +9-8plugins/extensions/pykrita/plugin/PythonPluginManager.cpp https://commits.kde.org/krita/77a5df289ff30f2d4a740521b571e978c13e58d3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #41 from Pino Toscano --- OK, I marked more strings in Python plugins for translations, fixing their style while doing so. I backported the fixes in the krita/4.1 branch -- it is not a problem for the string freeze, since those strings were never extracted, so it does not change anything for translators. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338
--- Comment #38 from Pino Toscano ---
(In reply to Pino Toscano from comment #32)
> Most probably that will require binding i18n()
> to the Python API, or using the Python binding of KI18n (which are not used
> much, though).
This seems to exists already, as there is a binding for i18n() here:
plugins/extensions/pykrita/plugin/krita/__init__.py
OTOH ...
(In reply to Pino Toscano from comment #35)
> Now the task is checking whether the translations actually work, and in case
> mark for translations also the strings of the other Python plugins.
... that binding is not useful, since:
a) it uses QCoreApplication::translate(), instead of i18n() from KI18n
b) the context ("PyKrita") is wrong, as all the strings are matched against the
"krita" domain (see -DTRANSLATION_DOMAIN=\"krita\" in the top-level
CMakeLists.txt)
@krita developers: pykrita needs a proper binding for i18n(), calling the
actual i18n() from KI18n, so translations are properly searched in the same
krita MO catalog as the strings in C++ files. If you have already familiarity
with SIP, a faster patch that what I could do is welcome :-)
(Also, while doing this, adding a binding for i18nc() would be nice too.)
--
You are receiving this mail because:
You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #37 from Pino Toscano --- (In reply to Tyson Tan from comment #36) > 1) Do you know where I can contribute translations for qtbase? https://wiki.qt.io/Qt_Localization is a good starting point. > 2) Do you know which KDE Frameworks components are holding those non-krita > strings? Hard to say; OTOH, https://l10n.kde.org/stats/gui/trunk-kf5/team/zh_CN/frameworks/ shows 100% completion for Frameworks now, that is why I suggested to also wait for the next version (5.48.0). -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #35 from Pino Toscano --- Regarding the "OK", "Cancel", "Apply", "Restore Defaults", etc labels of standard buttons in dialogs: the majority of them (if not all) should come from Qt5 itself, so I'd check the status of the qtbase translations for zh_CN. Same reason for the "Pick Screen Color" string of screenshot 006. Regarding translations from Frameworks: I see that until few days ago they were not 100% complete, so maybe some of the strings were missing -- let's wait for 5.48.0 (3 away from tagging, 4 from release). Regarding the Python plugins: most probably there is already the way to use i18n(), and the Comic plugin had translatable strings already. OTOH, no strings from .py files were extracted, so I committed this: https://commits.kde.org/krita/5d4c275a1dd3e5f45e109e976774019ba981d2c4 Now the task is checking whether the translations actually work, and in case mark for translations also the strings of the other Python plugins. Also, I did not find some of the strings mentioned in the current git master (future 4.1.0), e.g. 008D. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #32 from Pino Toscano --- Also, regarding the screenshot 003: basically all of the strings in Python plugins are not translatable. Most probably that will require binding i18n() to the Python API, or using the Python binding of KI18n (which are not used much, though). -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #31 from Pino Toscano --- Hi Tyson Tan, what is the code of the language you are using? How did you install the KDE Frameworks libraries? Did you build them on your own, or are you using them as available in a Linux distribution (which one)? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 --- Comment #30 from Pino Toscano --- Git commit cc25aeddb2ea2054d5e435cfeb1b5ad65dd98710 by Pino Toscano. Committed on 14/06/2018 at 06:52. Pushed by pino into branch 'master'. pykrita: use KDesktopFile to read desktop files of plugins This way translations are automatically used. (the case 008F is fixed) M +9-8plugins/extensions/pykrita/plugin/PythonPluginManager.cpp https://commits.kde.org/krita/cc25aeddb2ea2054d5e435cfeb1b5ad65dd98710 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 395338] Missing some button strings in krita.pot, some translated strings not reflected
https://bugs.kde.org/show_bug.cgi?id=395338 Pino Toscano changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 393307] Krita is looking for the unversioned libpython3.so instead of the versioned one
https://bugs.kde.org/show_bug.cgi?id=393307 Pino Toscano changed: What|Removed |Added Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri |ta/1553c12637e15d77168e6dda |ta/8b59bf27b4af54203dd4e0ca |d287ccbf0c53075b|aec9d81c9957d8a9 --- Comment #4 from Pino Toscano --- Git commit 8b59bf27b4af54203dd4e0caaec9d81c9957d8a9 by Pino Toscano. Committed on 29/05/2018 at 09:35. Pushed by pino into branch 'krita/4.0'. Fix loading of the Python library Summary: Instead of assuming the unversioned .so symlink will exist also at runtime (which is not the case for binary distros), use the QLibrary features: the SONAME of the Python library is "1.0", so use the unsuffixed filename of Python library with it. Additionally, this extends the loading also to Unices platforms different than macOS (since Boud excluded it in a previous commit), and destroy the QLibrary in case of loading failure. Fixed-In: 4.0.4 Reviewers: rempt Reviewed By: rempt Subscribers: rempt Differential Revision: https://phabricator.kde.org/D13144 (cherry picked from commit 1553c12637e15d77168e6ddad287ccbf0c53075b) M +7-31 plugins/extensions/pykrita/plugin/utilities.cpp https://commits.kde.org/krita/8b59bf27b4af54203dd4e0caaec9d81c9957d8a9 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 393307] Krita is looking for the unversioned libpython3.so instead of the versioned one
https://bugs.kde.org/show_bug.cgi?id=393307 Pino Toscano changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://commits.kde.org/kri ||ta/1553c12637e15d77168e6dda ||d287ccbf0c53075b --- Comment #3 from Pino Toscano --- Git commit 1553c12637e15d77168e6ddad287ccbf0c53075b by Pino Toscano. Committed on 29/05/2018 at 08:45. Pushed by pino into branch 'master'. Fix loading of the Python library Summary: Instead of assuming the unversioned .so symlink will exist also at runtime (which is not the case for binary distros), use the QLibrary features: the SONAME of the Python library is "1.0", so use the unsuffixed filename of Python library with it. Additionally, this extends the loading also to Unices platforms different than macOS (since Boud excluded it in a previous commit), and destroy the QLibrary in case of loading failure. Fixed-In: 4.0.4 Reviewers: rempt Reviewed By: rempt Subscribers: rempt Differential Revision: https://phabricator.kde.org/D13144 M +7-31 plugins/extensions/pykrita/plugin/utilities.cpp https://commits.kde.org/krita/1553c12637e15d77168e6ddad287ccbf0c53075b -- You are receiving this mail because: You are watching all bug changes.
[amarok] [Bug 390432] Add Amarok contextual menus to Dolphin
https://bugs.kde.org/show_bug.cgi?id=390432 Pino Toscano changed: What|Removed |Added CC||p...@kde.org --- Comment #2 from Pino Toscano --- Most probably this happens because the latest releases of Amarok are still based on Qt 4 / kdelibs 4.x, and thus the service menus are installed in a location specific for kdelibs 4.x. This will be fixed "automatically" once Amarok is released as Qt 5 / Frameworks. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 393307] Krita is looking for the unversioned libpython3.so instead of the versioned one
https://bugs.kde.org/show_bug.cgi?id=393307 Pino Toscano <p...@kde.org> changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 393307] Krita is looking for the unversioned libpython3.so instead of the versioned one
https://bugs.kde.org/show_bug.cgi?id=393307 Pino Toscano <p...@kde.org> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED --- Comment #2 from Pino Toscano <p...@kde.org> --- Opened a review with a potential fix: https://phabricator.kde.org/D13144 -- You are receiving this mail because: You are watching all bug changes.
[kopete] [Bug 393372] kopete-18.04.0: build error: invalid use of incomplete type ‘class Buffer’
https://bugs.kde.org/show_bug.cgi?id=393372 Pino Toscano <p...@kde.org> changed: What|Removed |Added Attachment #11|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes.
[kopete] [Bug 393372] kopete-18.04.0: build error: invalid use of incomplete type ‘class Buffer’
https://bugs.kde.org/show_bug.cgi?id=393372 --- Comment #8 from Pino Toscano <p...@kde.org> --- https://phabricator.kde.org/D12530 removes the WLM prootocol in >= 18.04.2. -- You are receiving this mail because: You are watching all bug changes.
[kopete] [Bug 393372] kopete-18.04.0: build error: invalid use of incomplete type ‘class Buffer’
https://bugs.kde.org/show_bug.cgi?id=393372 Pino Toscano <p...@kde.org> changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #7 from Pino Toscano <p...@kde.org> --- This specific issue, i.e. the build failure in the oscar protocol, was fixed -- hence closing. As Rex said, wlm is dead for a long time already, and even libmsn is not useful anymore now. Just stop building wlm in kopete, and drop libmsn from slackware. -- You are receiving this mail because: You are watching all bug changes.
[kopete] [Bug 393372] kopete-18.04.0: build error: invalid use of incomplete type ‘class Buffer’
https://bugs.kde.org/show_bug.cgi?id=393372 Pino Toscano <p...@kde.org> changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[kopete] [Bug 393372] kopete-18.04.0: build error: invalid use of incomplete type ‘class Buffer’
https://bugs.kde.org/show_bug.cgi?id=393372 Pino Toscano <p...@kde.org> changed: What|Removed |Added Latest Commit||https://commits.kde.org/kop ||ete/b1f4fa1401cba2e359e5a4b ||3ea2bafd119fca62b Resolution|--- |FIXED Version Fixed In||18.04.1 Status|CONFIRMED |RESOLVED --- Comment #3 from Pino Toscano <p...@kde.org> --- Git commit b1f4fa1401cba2e359e5a4b3ea2bafd119fca62b by Pino Toscano. Committed on 24/04/2018 at 04:30. Pushed by pino into branch 'Applications/18.04'. oscar: include buffer.h This header uses Buffer as by-value parameter, so make sure it knows about it. FIXED-IN: 18.04.1 M +1-0protocols/oscar/liboscar/tasks/messagereceivertask.h https://commits.kde.org/kopete/b1f4fa1401cba2e359e5a4b3ea2bafd119fca62b -- You are receiving this mail because: You are watching all bug changes.
[KReport] [Bug 390199] New: Please make sdc.py work also with (or switch it to) Python 3
https://bugs.kde.org/show_bug.cgi?id=390199 Bug ID: 390199 Summary: Please make sdc.py work also with (or switch it to) Python 3 Product: KReport Version: 3.0.0 Platform: unspecified OS: All Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: stan...@kde.org Reporter: p...@kde.org Target Milestone: --- Right now tools/sdc.py seems to be a Python2-only script, and the build system (cmake/modules/KDbCreateSharedDataClasses.cmake) indeed requires Python2 to be installed to build kreport. Since Python2 will become EOL soon (https://pythonclock.org/), please make sdc.py work with Python3 as well (or switch it to Python3 exclusively), so Python2 will not be required to build kreport. Distributions are switching to Python3 as default, and at the same time working on reducing the need for Python2. -- You are receiving this mail because: You are watching all bug changes.
[KDb] [Bug 390198] New: Please make sdc.py work also with (or switch it to) Python 3
https://bugs.kde.org/show_bug.cgi?id=390198 Bug ID: 390198 Summary: Please make sdc.py work also with (or switch it to) Python 3 Product: KDb Version: 3.0.0 Platform: unspecified OS: All Status: UNCONFIRMED Severity: normal Priority: NOR Component: General Assignee: stan...@kde.org Reporter: p...@kde.org Target Milestone: --- Right now tools/sdc.py seems to be a Python2-only script, and the build system (cmake/modules/KDbCreateSharedDataClasses.cmake) indeed requires Python2 to be installed to build kdb. Since Python2 will become EOL soon (https://pythonclock.org/), please make sdc.py work with Python3 as well (or switch it to Python3 exclusively), so Python2 will not be required to build kdb. Distributions are switching to Python3 as default, and at the same time working on reducing the need for Python2. -- You are receiving this mail because: You are watching all bug changes.
[Akonadi] [Bug 369203] CollectionFetchJob::exec() hangs forever
https://bugs.kde.org/show_bug.cgi?id=369203 Pino Toscano <p...@kde.org> changed: What|Removed |Added CC||p...@kde.org --- Comment #1 from Pino Toscano <p...@kde.org> --- (In reply to Patrick Ohly from comment #0) > SyncEvolution uses the blocking API to execute jobs. That used to work fine > with older Akonadi, but on Debian Stretch (= 4.14.10-5) it just hangs. Debian packager here: note that the "akonadi" bits provided in Stretch, that use Qt4/kdelibs 4.x, are just the client libraries without the actual server; this was done to allow to keep in Debian kdepimlibs, and few applications using it. The server you are running is the Qt5/Frameworks 5.x version of Akonadi (see e.g. the "search paths" lines in the akonadictl output). Hence, I would not be surprised that stuff using akonadi 4.x would not work at all. As unfortunate as it sounds, the solution I see in this case is to port the Akonadi integration in SyncEvolution to Akonadi 5.x (Qt5/Frameworks 5.x): - the KDE project stopped releasing sources part of Applications releases that use kdelibs 4.x with Application 17.08.x (there are none since Applications 17.12.x) - distributions are looking into reducing more and more anything based on Qt4/kdelibs 4.x (see for example https://bugs.debian.org/875215) With my Debian hat: SyncEvolution is one of the very few sources in Debian testing (the future stable Buster) that uses akonadi 4.x/kdepimlibs 4.x, and for which I see no porting to Frameworks (or other solutions) in sight. I am not sure whether we want/can carry them on in Buster, so consider this as a not-so-subtle hint to port SyncEvolution :-) -- You are receiving this mail because: You are watching all bug changes.
[zanshin] [Bug 368728] Please ship translations
https://bugs.kde.org/show_bug.cgi?id=368728 --- Comment #4 from Pino Toscano <p...@kde.org> --- Yay, thanks for this! -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382775] Settings window has no "cancel" button
https://bugs.kde.org/show_bug.cgi?id=382775 Pino Toscano <p...@kde.org> changed: What|Removed |Added Version Fixed In||17.11.80 -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 382775] Settings window has no "cancel" button
https://bugs.kde.org/show_bug.cgi?id=382775 Pino Toscano <p...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Pino Toscano <p...@kde.org> --- It is fixed in k3b >= 17.11.80. -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side
https://bugs.kde.org/show_bug.cgi?id=375125 Pino Toscano <p...@kde.org> changed: What|Removed |Added CC||p...@kde.org -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 375125] Settings dialog resizes itself when I select "CDDB" in left side
https://bugs.kde.org/show_bug.cgi?id=375125 Pino Toscano <p...@kde.org> changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #5 from Pino Toscano <p...@kde.org> --- I do not think this is a correct fix. Now the config dialog has a fixed size, and cannot be resized at all: this is bad for usability, since it truncates labels of checkboxes, texts in list views, and so on. I reverted it, and thus reopened this bug. -- You are receiving this mail because: You are watching all bug changes.
[kmymoney] [Bug 341663] Dialog requesting password for online update doesn't say for which account
https://bugs.kde.org/show_bug.cgi?id=341663 Pino Toscano <p...@kde.org> changed: What|Removed |Added CC||p...@kde.org --- Comment #2 from Pino Toscano <p...@kde.org> --- This fix is wrong: arguments to i18n*() functions are passed directly to the functions themselves, not using arg(); this will produce runtime warnings. What was the issue with the previous code? -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 387298] Crash when I try to burn audio cd or mixed mode cd using wma files
https://bugs.kde.org/show_bug.cgi?id=387298 --- Comment #14 from Pino Toscano <p...@kde.org> --- (In reply to Leslie Zhai from comment #13) > I respect you the pioneer of KDE developer, please code review firstly, when > LGTM, then git push to the K3B repository, thanks a lot! Pioneer of what? Your sentences make no sense to me, sorry. Again, just because I did the last two commits to that code, that does not make me its maintainer. -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 387298] Crash when I try to burn audio cd or mixed mode cd using wma files
https://bugs.kde.org/show_bug.cgi?id=387298 Pino Toscano <p...@kde.org> changed: What|Removed |Added CC|p...@kde.org| --- Comment #12 from Pino Toscano <p...@kde.org> --- (In reply to Leslie Zhai from comment #9) > But my sincere thanks goes to you for maintaining ffmpeg plugin > https://github.com/KDE/k3b/commits/master/plugins/decoder/ffmpeg/ > k3bffmpegwrapper.cpp I am *not* the maintainer of that code. Or in general, I am *not* the maintainer of k3b, who is Leslie Zhai. -- You are receiving this mail because: You are watching all bug changes.
[k3b] [Bug 387298] Crash when I try to burn audio cd or mixed mode cd using wma files
https://bugs.kde.org/show_bug.cgi?id=387298 Pino Toscano <p...@kde.org> changed: What|Removed |Added CC|p...@kde.org| --- Comment #8 from Pino Toscano <p...@kde.org> --- @Leslie Zhai: when CCing people to a bug, you ought to tell them why you are CCing them. -- You are receiving this mail because: You are watching all bug changes.
[frameworks-khtml] [Bug 377490] build failure with qt-5.9
https://bugs.kde.org/show_bug.cgi?id=377490 --- Comment #6 from Pino Toscano <p...@kde.org> --- Git commit 3def65075c09af4961cd399e8e78ed78cca72e65 by Pino Toscano, on behalf of Wolfgang Bauer. Committed on 11/10/2017 at 20:17. Pushed by pino into branch '0.12'. Fix build with Qt 5.9 Summary: moc 5.9 errors out when building: Error: Plugin Metadata file "" could not be opened: file to open is a directory Same issue and fix as https://phabricator.kde.org/D5392 for khtml. Test Plan: builds fine now with Qt 5.9.0rc and also earlier versions. Reviewers: vriezen, pino Reviewed By: pino Subscribers: pino Differential Revision: https://phabricator.kde.org/D5985 M +1-1src/kmplayer_part.h https://commits.kde.org/kmplayer/3def65075c09af4961cd399e8e78ed78cca72e65 -- You are receiving this mail because: You are watching all bug changes.
[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client
https://bugs.kde.org/show_bug.cgi?id=370448 Pino Toscano <p...@kde.org> changed: What|Removed |Added CC||howl@gmail.com --- Comment #2 from Pino Toscano <p...@kde.org> --- *** Bug 383149 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[ktorrent] [Bug 370448] Ktorrent stable tarballs have VERSION_TYPE = bt::DEVEL in ktversion.h, and thus identified as development client
https://bugs.kde.org/show_bug.cgi?id=370448 Pino Toscano <p...@kde.org> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |CONFIRMED Summary|Ktorrent 5.0 and 5.0.1 |Ktorrent stable tarballs |stable tarballs has |have VERSION_TYPE = |VERSION_TYPE = bt::DEVEL in |bt::DEVEL in ktversion.h, |ktversion.h |and thus identified as ||development client --- Comment #1 from Pino Toscano <p...@kde.org> --- Happens with 5.1 as well. Also, the kt::MINOR and kt::RELEASE variables are outdated. -- You are receiving this mail because: You are watching all bug changes.
[ktorrent] [Bug 383149] KTorrent 5.0.1 identify as KTorrent 5.0dev
https://bugs.kde.org/show_bug.cgi?id=383149 Pino Toscano <p...@kde.org> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Pino Toscano <p...@kde.org> --- *** This bug has been marked as a duplicate of bug 370448 *** -- You are receiving this mail because: You are watching all bug changes.
[zanshin] [Bug 368728] Please ship translations
https://bugs.kde.org/show_bug.cgi?id=368728 --- Comment #2 from Pino Toscano <p...@kde.org> --- (In reply to Kevin Ottens from comment #1) > Guidance would be welcome on the process to do that properly. Been hunting > for documentation tonight but can't seem to find proper direction in our > wikis. Been looking at our releaseme scripts but they badly break for me. >From what I know, releaseme is more for gettext translations (.po files), rather than Qt translations. Unfortunately I have no experience with that, so I'd suggest to ask to kde-core-devel/kde-frameworks/etc. -- You are receiving this mail because: You are watching all bug changes.
[zanshin] [Bug 368728] New: Please ship translations
https://bugs.kde.org/show_bug.cgi?id=368728 Bug ID: 368728 Summary: Please ship translations Product: zanshin Version: unspecified Platform: Compiled Sources OS: All Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: er...@kde.org Reporter: p...@kde.org CC: mbe...@ipsquad.net Since the first zanshin releases (more than 5 years ago), the zanshin translations in KDE's SVN are not used at all. This means that, even though zanshin has always been translatable and translators have been working on it, building a zanshin release tarball provides an English-only zanshin. This is valid also for newly released 0.4.1. -- You are receiving this mail because: You are watching all bug changes.
