[kgpg] [Bug 368462] Add support for ECC keys (primary and subkeys)

2016-10-01 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368462 --- Comment #10 from Steven Noonan --- Something like this would work though: diff --git a/core/convert.cpp b/core/convert.cpp index 1f30739..2939767 100644 --- a/core/convert.cpp +++ b/core/convert.cpp @@ -28,10 +28,10 @@

[kgpg] [Bug 368462] Add support for ECC keys (primary and subkeys)

2016-10-01 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368462 --- Comment #9 from Steven Noonan --- Andrius, that commit isn't right. You can't use #ifdef on an enum value. It would only be guaranteed to work properly with preprocessor macros. -- You are receiving this mail because: You

[kgpg] [Bug 369274] "expert" button on key generation dialog doesn't bring up Konsole

2016-10-01 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369274 --- Comment #3 from Steven Noonan --- $ konsole --version konsole 16.08.1 Example of how kgpg currently invokes konsole: $ konsole -e gpg --gen-key --expert Unknown options: gen-key, expert. How it should be quoting: $ konsole

[kgpg] [Bug 369274] "expert" button on key generation dialog doesn't bring up Konsole

2016-09-23 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369274 --- Comment #1 from Steven Noonan --- Created attachment 101253 --> https://bugs.kde.org/attachment.cgi?id=101253=edit patch My copy/pasted diff had a missing include. Also the formatting was ugly. Attaching a patch instead.

[kgpg] [Bug 369274] New: "expert" button on key generation dialog doesn't bring up Konsole

2016-09-23 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369274 Bug ID: 369274 Summary: "expert" button on key generation dialog doesn't bring up Konsole Product: kgpg Version: unspecified Platform: Other OS: Linux

[kgpg] [Bug 368462] Add support for ECC keys (primary and subkeys)

2016-09-17 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368462 --- Comment #7 from Steven Noonan --- Squashed patch up for review here until I find out how to make ReviewBoard cooperate: https://git.reviewboard.kde.org/r/128931/ -- You are receiving this mail because: You are watching all

[kgpg] [Bug 368462] Add support for ECC keys (primary and subkeys)

2016-09-17 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368462 --- Comment #6 from Steven Noonan --- I submitted the first patch to review board. It didn't like the second one because it depends on files that were changed in the first one: The specified diff file could not be parsed. Line

[kgpg] [Bug 368462] Add support for ECC keys (primary and subkeys)

2016-09-17 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368462 --- Comment #3 from Steven Noonan --- Created attachment 101139 --> https://bugs.kde.org/attachment.cgi?id=101139=edit implement display of "strength" instead of "size" Along with the previous patch, this implements a display

[kgpg] [Bug 368462] Add support for ECC keys (primary and subkeys)

2016-09-17 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368462 --- Comment #2 from Steven Noonan --- Oh, I forgot to mention. Another place where my patch is useless is showing which curve is being used. I've seen some other GPG frontends replace the "size" column with a more descriptive

[kgpg] [Bug 368462] Add support for ECC keys (primary and subkeys)

2016-09-17 Thread Steven Noonan via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=368462 Steven Noonan changed: What|Removed |Added CC||ste...@uplinklabs.net