[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added Resolution|--- |FIXED Latest

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #37 from caulier.gil...@gmail.com --- Maik, any reason to not close this file since patch is applied to 6.0.0 ? Gilles -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #36 from Maik Qualmann --- (In reply to Thanh Trung Dinh from comment #34) > Besides, it seemed to me that map works much slower with QWebEngineView than > with QWebView, didn't it? I can not say that the Google map

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #35 from Maik Qualmann --- Git commit 101b1170ef8484df732ccbff235dc28fc91f1a26 by Maik Qualmann. Committed on 28/03/2018 at 20:13. Pushed by mqualmann into branch 'master'. add possibility to use QWebEngine instead

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #34 from Thanh Trung Dinh --- Created attachment 87 --> https://bugs.kde.org/attachment.cgi?id=87=edit portWebEngine_patch Hi Maik, I have created a new patch by shrinking the previous one. In this

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #33 from Maik Qualmann --- Thanh, Yes, that's right, that I did not consider. Of course we keep the class. Maik -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #32 from Thanh Trung Dinh --- Maik, About your first point that WelcomePageViewPage class should be deleted, that was right since we can access by QWebEngineView::page(). However, I found that the class was

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #31 from Maik Qualmann --- Thanh, At the moment I have no real idea to solve it "elegantly". It could be a function that collects the results and then allocates the return values ​​to the functions. Waiting is just a

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #30 from Thanh Trung Dinh --- Maik, I saw the lines that used QEventLoop to wait for return from JavaScript functions. But as you said that " we should implement it more elegantly ", I don't really understand

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Thanh Trung Dinh changed: What|Removed |Added CC|

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #29 from Maik Qualmann --- For some JavaScript operations we need a return value. QWebEngine uses an asynchronous FunctorOrLambda function for it. We are currently using a QEventLoop to wait for the result. It works,

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added Attachment #106207|0 |1 is obsolete|

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #27 from caulier.gil...@gmail.com --- Some details about the problem seen with QtWebEngine port : 1/ The DK bundles explode. It's increased to 100Mb. QWebEngine need to be optimized at compilation time. There are a lots of possibilities due

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added Resolution|FIXED |---

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added Version Fixed In||5.7.0

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #25 from caulier.gil...@gmail.com --- Maik, I just tested. It work better now. Please commit the patch, we will continue to finalize and hack with git/master until 5.7.0. We have plenty of time while this summer... Gilles -- You are

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added Attachment #106199|0 |1 is obsolete|

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #23 from Maik Qualmann --- I just compile again because of a big update of my distribution. But the region selection tool works very well. I will take a look at it. Maik -- You are receiving this mail because: You

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #22 from caulier.gil...@gmail.com --- MAik, I can confirm that QWebEngine+Mapsearch tool is broken is selection mode. I reverted to QWebKit, and it work fine. Gilles -- You are receiving this mail because: You are watching all bug

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #21 from caulier.gil...@gmail.com --- The graphic card is a Virtual Box one. Nothing special here, just a basic one. I tried and to problem is difficult to reproduce in fact. It happen when the coordinates are located to north pole on an

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #20 from Maik Qualmann --- I can reproduce something, it is possible to move the map down out. Then it is no longer visible. Maik -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #19 from Maik Qualmann --- Gilles, Can you make a screencast? Which graphic driver do you use? I can not reproduce it. Maik -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #18 from caulier.gil...@gmail.com --- Maik, I tried the GoogleMaps view with your patch. I found a dysfunction (i don't tested all possibilities yet). It's simple : GoogleMaps work everywhere, excepted on central view when you switch from

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #17 from caulier.gil...@gmail.com --- Ok thanks i test this evening and i give you a feedback Gilles -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added Attachment #105493|0 |1 is obsolete|

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #15 from caulier.gil...@gmail.com --- Maik, Can you update the patch with last current changes from git/master about GeoIface namespace which have been dropped from digiKam core ? No need to have QWebKit and QWebEngine support. The last

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #14 from Maik Qualmann --- The backend-googlemaps-js.js is loaded by the backend-googlemaps.html. We need a second backend-googlemaps.html and load into backendgooglemaps.cpp the right file. Maik -- You are

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #13 from Maik Qualmann --- Yes, we need 2 files. Maik -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 caulier.gil...@gmail.com changed: What|Removed |Added Attachment #105300|0 |1 is obsolete|

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #11 from caulier.gil...@gmail.com --- So you mean that we need 2 javascript files, one for QWebView, one for QWebEngine ? If yes, the googlemaps backend from geolocation code need to load right file depending of cmake configuration.

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #10 from Maik Qualmann --- No, the file only works after the patch with QWebEngine. QWebEngine does not support read status bar messages anymore. Everything now runs over Javascript messages. Maik -- You are

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #9 from caulier.gil...@gmail.com --- Maik, The patch version 4 include minimal changes in backend-googlemaps-js Javascript file, which sound like to be compatible with QWebView and QWebEngine. Do you confirm that file can be patched as well

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #8 from caulier.gil...@gmail.com --- Maik, I will include this patch in git /master with a dedicated compilation flag in cmake. Like this we will able to deploy an experimental version as AppImage soon... Gilles -- You are receiving this

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added Attachment #102076|0 |1 is obsolete|

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #6 from caulier.gil...@gmail.com --- MAik, Qt 5.8 have new Chrome engine version included. Perhaps the port will be better with this new release of Qt WebEngine. See release announcement for details :

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #5 from Maik Qualmann --- I do not know. KMail with Nouveau driver crashes here as well. It could be due to hardware acceleration. I currently use the NVidia driver. You can enabled for test the line 127 in

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #4 from caulier.gil...@gmail.com --- As i use NVIDIA card GeForce 750 with Nouveau driver, i can check if problem is reproducible here. Q : This problem remain if Qt5 with OpenGL effect is compiled ? Or it's only a dysfunction from

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added Attachment #100912|0 |1 is obsolete|

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added Attachment #99331|0 |1 is obsolete|

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 Maik Qualmann changed: What|Removed |Added CC||metzping...@gmail.com

[digikam] [Bug 363859] digiKam core port from QWebKit to QWebEngine [patch]

https://bugs.kde.org/show_bug.cgi?id=363859 --- Comment #1 from caulier.gil...@gmail.com --- Created attachment 99331 --> https://bugs.kde.org/attachment.cgi?id=99331=edit patch version 1 first version of patch -- You are receiving this mail because: You are watching all bug changes.