[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Nate Graham changed: What|Removed |Added Version Fixed In||5.24 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Nate Graham changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-desktop/commit/b6 |ma/plasma-desktop/commit/ec |3a6c9b16f261ecac99e5d1abbd7 |2d3d56a7eb0ac7bd6eb2a3fb860 |2c52349cb95 |38fad0f000e --- Comment #38 from Nate Graham --- Git commit ec2d3d56a7eb0ac7bd6eb2a3fb86038fad0f000e by Nate Graham, on behalf of Fushan Wen. Committed on 16/11/2021 at 01:33. Pushed by ngraham into branch 'master'. taskmanager: Port PlasmaExtras.ScrollArea to PC3.ScrollView in GroupDialog 1. Port `PlasmaExtras.ScrollArea` to `PC3.ScrollView`, and port `Repeater` to `ListView` so only visible tasks are loaded. 2. Rework activeTask mechanism to fit `ListView`, so the highlight can be restored after opening the same textual list (`findActiveTaskIndex()`). 3. Drop `updateSize()` function because it's more distinct to use size bindings, and the text width is updated by `updateMaxTextWidth()`. 4. Drop `attachModel()` function and set model property directly in `ListView`. 5. Add `isGroupDialog` bool property to `MouseHandler` because `ListView` uses `itemAt` instead of `childAt` to get the item at the cursor position, so drag and drop still works. 6. Several hacks to prevent warning messages, including "Binding loop detected" and "trying to show an empty dialog". 7. Add `iconMargin` and `labelMargin`, so those properties can be shared between `Task` and `GroupDialog`. M +61 -219 applets/taskmanager/package/contents/ui/GroupDialog.qml M +7-1applets/taskmanager/package/contents/ui/MouseHandler.qml M +6-6applets/taskmanager/package/contents/ui/Task.qml M +2-0applets/taskmanager/package/contents/ui/code/layout.js https://invent.kde.org/plasma/plasma-desktop/commit/ec2d3d56a7eb0ac7bd6eb2a3fb86038fad0f000e -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Bug Janitor Service changed: What|Removed |Added Status|REOPENED|ASSIGNED --- Comment #37 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/689 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #36 from Nate Graham --- Git commit 3d552a2bfcc7b0f5e03bdeef8fcacdbeea9cf5d6 by Nate Graham, on behalf of Fushan Wen. Committed on 29/10/2021 at 17:08. Pushed by ngraham into branch 'master'. taskmanager: Disable tooltips completely when groupDialog is visible Setting active property to false only makes the tooltip invisible, but setting enabled property to false can completely disable the tooltip from rendering. This will bring some performance improvement for the textual list, because when hovering on items in the textual list, the tooltip will be still rendered without enabled: false. M +1-2applets/taskmanager/package/contents/ui/Task.qml https://invent.kde.org/plasma/plasma-desktop/commit/3d552a2bfcc7b0f5e03bdeef8fcacdbeea9cf5d6 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #35 from Nate Graham --- *** Bug 429502 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Nate Graham changed: What|Removed |Added Version Fixed In|5.24| -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #34 from qydwhotm...@gmail.com --- To really fix the bug, the Repeater in GroupDialog.qml must be replaced with a ListView. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #33 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/652 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 qydwhotm...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- --- Comment #32 from qydwhotm...@gmail.com --- After carefully re-reading the description of this bug, I found the bug is about textual list, but not the tooltip, so it's a mistake that I added "BUG: 433907" in the merge request. Mark it as REOPENED so future work is needed. -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Nate Graham changed: What|Removed |Added Version Fixed In||5.24 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Nate Graham changed: What|Removed |Added Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas |ma/plasma-desktop/commit/ea |ma/plasma-desktop/commit/b6 |84e5c1600dde7207a85dc228eae |3a6c9b16f261ecac99e5d1abbd7 |6cc05d4b319 |2c52349cb95 Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #31 from Nate Graham --- Git commit b63a6c9b16f261ecac99e5d1abbd72c52349cb95 by Nate Graham, on behalf of Fushan Wen. Committed on 26/10/2021 at 19:15. Pushed by ngraham into branch 'master'. taskmanager: Replace Repeater with ListView for task group list Unlike Repeater ListView loads only visible items. This behaviour leads to huge performance improvement. Related: bug 444001 M +2-14 applets/taskmanager/package/contents/ui/Task.qml M +30 -33 applets/taskmanager/package/contents/ui/ToolTipDelegate.qml https://invent.kde.org/plasma/plasma-desktop/commit/b63a6c9b16f261ecac99e5d1abbd72c52349cb95 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #30 from Nate Graham --- Git commit 238a076c8d9d80f874f3cbef7ba857db7efda7ac by Nate Graham, on behalf of Fushan Wen. Committed on 26/10/2021 at 17:49. Pushed by ngraham into branch 'master'. taskmanager: Move x11Thumbnail, pipeWireThumbnail, iconItem to the same Loader As PipeWireThumbnail is available, there is no need to use a separate Loader anymore. This is expected to slightly improve the loading speed and the memory consumption of ToolTipInstance. D +0-20 applets/taskmanager/package/contents/ui/PipeWireThumbnail.qml M +41 -29 applets/taskmanager/package/contents/ui/ToolTipInstance.qml https://invent.kde.org/plasma/plasma-desktop/commit/238a076c8d9d80f874f3cbef7ba857db7efda7ac -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #29 from Nate Graham --- Git commit bb18ba6a83ca7abe34aa0018bc5630f4e077ca19 by Nate Graham, on behalf of Fushan Wen. Committed on 26/10/2021 at 16:51. Pushed by ngraham into branch 'master'. taskmanager: Make the player controller load on demand This is expected to slightly improve the loading speed and the memory consumption of ToolTipInstance. M +75 -70 applets/taskmanager/package/contents/ui/ToolTipInstance.qml https://invent.kde.org/plasma/plasma-desktop/commit/bb18ba6a83ca7abe34aa0018bc5630f4e077ca19 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #28 from Nate Graham --- Git commit d74bdc66117cf85d34eaa5ca24b1954ab0df0ac6 by Nate Graham, on behalf of Fushan Wen. Committed on 25/10/2021 at 18:46. Pushed by ngraham into branch 'master'. taskmanager: Make albumArtBackground in the tooltip load on demand This is expected to slightly improve the loading speed and the memory consumption of ToolTipInstance. M +19 -26 applets/taskmanager/package/contents/ui/ToolTipInstance.qml https://invent.kde.org/plasma/plasma-desktop/commit/d74bdc66117cf85d34eaa5ca24b1954ab0df0ac6 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #27 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/638 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #26 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/637 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #25 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/636 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #24 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/635 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Bug Janitor Service changed: What|Removed |Added Status|CONFIRMED |ASSIGNED --- Comment #23 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/631 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #22 from Nate Graham --- Git commit 9e1a0670721093b508f1c6722c8c82beb95078b1 by Nate Graham, on behalf of Fushan Wen. Committed on 21/10/2021 at 17:46. Pushed by ngraham into branch 'Plasma/5.23'. taskmanager: Show highlight before ToolTipInstance starts loading for grouped tooltips For grouped tooltips, if there are many windows in a group, it could take a long time before all ToolTipInstances are loaded. Show highlight before ToolTipInstance starts loading to make user feel less unresponsive. Note: Will not work when a tooltip is already visible (move directly from a task to a grouped task) (cherry picked from commit 818b1b29bc64ccd656a5da2f82fe1aa893d7f8d9) M +4-0applets/taskmanager/package/contents/ui/Task.qml M +7-2applets/taskmanager/package/contents/ui/ToolTipDelegate.qml https://invent.kde.org/plasma/plasma-desktop/commit/9e1a0670721093b508f1c6722c8c82beb95078b1 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #21 from Nate Graham --- Git commit 818b1b29bc64ccd656a5da2f82fe1aa893d7f8d9 by Nate Graham, on behalf of Fushan Wen. Committed on 21/10/2021 at 17:44. Pushed by ngraham into branch 'master'. taskmanager: Show highlight before ToolTipInstance starts loading for grouped tooltips For grouped tooltips, if there are many windows in a group, it could take a long time before all ToolTipInstances are loaded. Show highlight before ToolTipInstance starts loading to make user feel less unresponsive. Note: Will not work when a tooltip is already visible (move directly from a task to a grouped task) M +4-0applets/taskmanager/package/contents/ui/Task.qml M +7-2applets/taskmanager/package/contents/ui/ToolTipDelegate.qml https://invent.kde.org/plasma/plasma-desktop/commit/818b1b29bc64ccd656a5da2f82fe1aa893d7f8d9 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #20 from Nate Graham --- Git commit 2f27fc9f05462076a77254c0df17fa07ee8228a8 by Nate Graham, on behalf of Fushan Wen. Committed on 21/10/2021 at 15:47. Pushed by ngraham into branch 'Plasma/5.23'. taskmanager: Prevent useless component creation/destruction for grouped tooltips The binding of "model" property of DelegateModel in ToolTipDelegate.qml will trigger useless component creation/destruction when "rootIndex" is changed but is not undefined. Make the ternary operator depend on "hasRootIndex" bool property to avoid that. In Task.qml, only assign different values to "parentTask" and "rootIndex" to avoid unnecessary component creation/destruction for the second time hovering on the same task. Related: bug 444001 (cherry picked from commit 12373d31a0400bf5d4b7d6abdb29268c360156bf) M +10 -2applets/taskmanager/package/contents/ui/Task.qml M +4-1applets/taskmanager/package/contents/ui/ToolTipDelegate.qml https://invent.kde.org/plasma/plasma-desktop/commit/2f27fc9f05462076a77254c0df17fa07ee8228a8 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #19 from qydwhotm...@gmail.com --- Git commit 12373d31a0400bf5d4b7d6abdb29268c360156bf by Fushan Wen. Committed on 21/10/2021 at 09:10. Pushed by ngraham into branch 'master'. taskmanager: Prevent useless component creation/destruction for grouped tooltips The binding of "model" property of DelegateModel in ToolTipDelegate.qml will trigger useless component creation/destruction when "rootIndex" is changed but is not undefined. Make the ternary operator depend on "hasRootIndex" bool property to avoid that. In Task.qml, only assign different values to "parentTask" and "rootIndex" to avoid unnecessary component creation/destruction for the second time hovering on the same task. Related: bug 444001 M +10 -2applets/taskmanager/package/contents/ui/Task.qml M +4-1applets/taskmanager/package/contents/ui/ToolTipDelegate.qml https://invent.kde.org/plasma/plasma-desktop/commit/12373d31a0400bf5d4b7d6abdb29268c360156bf -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #18 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/623 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #17 from Bug Janitor Service --- A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/622 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 qydwhotm...@gmail.com changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=444001 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Paul changed: What|Removed |Added CC||holle...@cs.dal.ca -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 qydwhotm...@gmail.com changed: What|Removed |Added Version|5.21.90 |5.22.2 CC||qydwhotm...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Matthias Dahl changed: What|Removed |Added CC||ua_bugz_kde@binary-island.e ||u -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Patrick Silva changed: What|Removed |Added CC||asca...@q.com --- Comment #16 from Patrick Silva --- *** Bug 428351 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Nate Graham changed: What|Removed |Added Version Fixed In|5.22| Status|REOPENED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #15 from Nate Graham --- Git commit 152674a5fdf69f8e33ceef09b71e8d67d1595926 by Nate Graham. Committed on 17/05/2021 at 14:09. Pushed by ngraham into branch 'Plasma/5.22'. Revert "Replace Repeater with ListView for task group list" This reverts commit ea84e5c1600dde7207a85dc228eae6cc05d4b319. This commit was supposed to fix 433907 but apparently did not do so. Additionally, it introduced an unpleasant visual flicker for grouped task tooltips. Let's try again another way. (cherry picked from commit 4342e6f7eb7d2eb7eb789554a8be2e5d1a8b618d) M +14 -10 applets/taskmanager/package/contents/ui/ToolTipDelegate.qml https://invent.kde.org/plasma/plasma-desktop/commit/152674a5fdf69f8e33ceef09b71e8d67d1595926 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 --- Comment #14 from Nate Graham --- Git commit 34b978243147cbafd62d9965338b236deb519826 by Nate Graham. Committed on 17/05/2021 at 14:08. Pushed by ngraham into branch 'master'. Revert "Replace Repeater with ListView for task group list" This reverts commit ea84e5c1600dde7207a85dc228eae6cc05d4b319. This commit was supposed to fix 433907 but apparently did not do so. Additionally, it introduced an unpleasant visual flicker for grouped task tooltips. Let's try again another way. M +14 -10 applets/taskmanager/package/contents/ui/ToolTipDelegate.qml https://invent.kde.org/plasma/plasma-desktop/commit/34b978243147cbafd62d9965338b236deb519826 -- You are receiving this mail because: You are watching all bug changes.
[plasmashell] [Bug 433907] plasmashell works slow when displaying textual list of grouped tasks for big group
https://bugs.kde.org/show_bug.cgi?id=433907 Nate Graham changed: What|Removed |Added Assignee|notm...@gmail.com |h...@kde.org Version|5.79.0 |5.21.90 Target Milestone|--- |1.0 Product|frameworks-plasma |plasmashell Component|libplasmaquick |Task Manager and Icons-Only ||Task Manager -- You are receiving this mail because: You are watching all bug changes.
