[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=326289

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pri |https://invent.kde.org/util
   |nt-manager/c93f2f16c30d10fb |ities/print-manager/commit/
   |d0f4bfb4c0bf0cec07a4c93b|33a1a1dced51ab8d21bf766db45
   ||f45e14c448b99

--- Comment #66 from Albert Astals Cid  ---
Git commit 33a1a1dced51ab8d21bf766db45f45e14c448b99 by Albert Astals Cid.
Committed on 02/12/2019 at 22:04.
Pushed by aacid into branch 'arcpatch-D25623'.

Fix crash when cups returns jobs with duplicate id

Summary:
For some reason my cups was giving me two withheld jobs with id 33 and two with
id 40

That made the JobModel code crash, because it went like this

 * First job with id 33 found
 * insertRow with 0 called
 * Row 0 inserted
 * Job at row 0 updated (from inside insertRow)
 * Second job with id 33 found
 * The "oh i already have this job code triggers", updates the job, then
takesRow 0 and inserts at row 1. QStandardItemModel doesn't like getting a row
add at 1 inserted when empty
 * First job with id 40 found
 * insertRow with 2 called
 * Row 2 inserted, it fails, QStandardItemModel doesn't like getting a row add
at 2 when empty
 * Job at row 2 updated (from iniside insertRow)
 * Crash because there's no row 2 in the model

Test Plan: Doesn't crash anymore with my weird cups list of pending jobs

Reviewers: dantti

Reviewed By: dantti

Subscribers: ngraham, marcelm, fvogt, broulik, nicolasfella, kmaterka,
kde-utils-devel

Differential Revision: https://phabricator.kde.org/D25623

M  +21   -2libkcups/JobModel.cpp

https://invent.kde.org/utilities/print-manager/commit/33a1a1dced51ab8d21bf766db45f45e14c448b99

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=326289

Nate Graham  changed:

   What|Removed |Added

 CC||kde.for...@develdog.com

--- Comment #65 from Nate Graham  ---
*** Bug 412639 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||ruiz.math...@protonmail.com

--- Comment #64 from Christoph Feck  ---
*** Bug 424849 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||gesb...@gmail.com

--- Comment #63 from Christoph Feck  ---
*** Bug 420576 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Yvan Broccard]

https://bugs.kde.org/show_bug.cgi?id=326289

Yvan Broccard  changed:

   What|Removed |Added

 CC||yvan.brocc...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Yvan Broccard]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #62 from Yvan Broccard  ---
Created attachment 127232
  --> https://bugs.kde.org/attachment.cgi?id=127232=edit
New crash information added by DrKonqi

plasmashell (5.17.5) using Qt 5.13.2

- What I was doing when the application crashed:

I added a new HP printer earlier this day. Now, Plasma crashes at every login.
I created a new user with a brand new /home and Plasma crashes with that user
as well.

-- Backtrace (Reduced):
#6  0x7f809d42436a in JobModel::updateJob(int, KCupsJob const&) () from
/lib64/libkcupslib.so
#7  0x7f809d426418 in JobModel::insertJob(int, KCupsJob const&) () from
/lib64/libkcupslib.so
#8  0x7f809d4268d9 in JobModel::getJobFinished(KCupsRequest*) () from
/lib64/libkcupslib.so
#9  0x7f80c94b279a in QObject::event(QEvent*) () from
/lib64/libQt5Core.so.5
#10 0x7f80c9f88ab6 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /lib64/libQt5Widgets.so.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=326289

Nate Graham  changed:

   What|Removed |Added

 CC||ssl...@hotmail.com

--- Comment #61 from Nate Graham  ---
*** Bug 418717 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||ben.sim...@uts.edu.au

--- Comment #60 from Christoph Feck  ---
*** Bug 417537 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=326289

Nate Graham  changed:

   What|Removed |Added

 CC||scooter.c...@gmail.com

--- Comment #59 from Nate Graham  ---
*** Bug 417462 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Gordon Lack]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #58 from Gordon Lack  ---
A workaround is to cancel all jobs, or at least the duplicates(?).

See:

https://bugs.launchpad.net/ubuntu/+source/plasma-workspace/+bug/1770044/comments/82

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Matheus]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #57 from Matheus  ---
Is there any workaround? I'm on 5.18.9? I was trying to use a wifi printer

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||matheusfillip...@gmail.com

--- Comment #56 from Christoph Feck  ---
*** Bug 417601 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=326289

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||agoli...@gmail.com

--- Comment #55 from Kai Uwe Broulik  ---
*** Bug 416985 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||k...@box.kilmann.net

--- Comment #54 from Christoph Feck  ---
*** Bug 416215 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||p.stol...@gmail.com

--- Comment #53 from Christoph Feck  ---
*** Bug 415014 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #52 from Christoph Feck  ---
*** Bug 415239 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #51 from Albert Astals Cid  ---
(In reply to Konrad Materka from comment #49)
> Maybe this should also be reported to Cups team?

Unless someone knows how to reproduce the duplicate ids issue i'm not sure it
makes much sense, but feel free :) maybe they can think of a way this would
happen

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Gordon Lack]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #50 from Gordon Lack  ---
>>> Anyone knows what exactly happened on Cups side?

I was wondering a similar thing. But rather what the "cups database" of past
jobs looked like when it has multiple jobs with teh same id.
When I went looking the info was only in /var/spool/cups and the job number was
taken from the filename, so what does this look like when there are multiple
ids?

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Konrad Materka]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #49 from Konrad Materka  ---
Anyone knows what exactly happened on Cups side? Why there were jobs with
duplicated Id? Maybe this should also be reported to Cups team?

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=326289

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/pri |https://commits.kde.org/pri
   |nt-manager/5d3c5f7bc4174695 |nt-manager/c93f2f16c30d10fb
   |af57cf5032a3d4117bd7577c|d0f4bfb4c0bf0cec07a4c93b
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #48 from Albert Astals Cid  ---
Git commit c93f2f16c30d10fbd0f4bfb4c0bf0cec07a4c93b by Albert Astals Cid.
Committed on 02/12/2019 at 22:05.
Pushed by aacid into branch 'release/19.12'.

Fix crash when cups returns jobs with duplicate id

Summary:
For some reason my cups was giving me two withheld jobs with id 33 and two with
id 40

That made the JobModel code crash, because it went like this

 * First job with id 33 found
 * insertRow with 0 called
 * Row 0 inserted
 * Job at row 0 updated (from inside insertRow)
 * Second job with id 33 found
 * The "oh i already have this job code triggers", updates the job, then
takesRow 0 and inserts at row 1. QStandardItemModel doesn't like getting a row
add at 1 inserted when empty
 * First job with id 40 found
 * insertRow with 2 called
 * Row 2 inserted, it fails, QStandardItemModel doesn't like getting a row add
at 2 when empty
 * Job at row 2 updated (from iniside insertRow)
 * Crash because there's no row 2 in the model

Test Plan: Doesn't crash anymore with my weird cups list of pending jobs

Reviewers: dantti

Reviewed By: dantti

Subscribers: ngraham, marcelm, fvogt, broulik, nicolasfella, kmaterka,
kde-utils-devel

Differential Revision: https://phabricator.kde.org/D25623

M  +21   -2libkcups/JobModel.cpp

https://commits.kde.org/print-manager/c93f2f16c30d10fbd0f4bfb4c0bf0cec07a4c93b

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=326289

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=326289

Nate Graham  changed:

   What|Removed |Added

 CC||filippo.berna...@gmail.com

--- Comment #47 from Nate Graham  ---
*** Bug 414652 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Meinhard Ritscher]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #46 from Meinhard Ritscher  ---
(In reply to Albert Astals Cid from comment #44)
> Right, you have 3 print jobs with id 97, which is why this is crashing.
> 
> Do you remember what you did to end up with 3 print jobs with the same id?
> Was your printer off or on or it failed during printing or something?
Not really, no. I would assume the (network connected) printer was switched
off. But I'm not certain.

Meanwhile I managed to remove the print jobs via lprm -U user x (iterating x
from 0 to 2)

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=326289

vor...@z-ray.de changed:

   What|Removed |Added

 CC||vor...@z-ray.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #45 from vor...@z-ray.de ---
Created attachment 124272
  --> https://bugs.kde.org/attachment.cgi?id=124272=edit
New crash information added by DrKonqi

plasmashell (5.17.3) using Qt 5.13.1

- What I was doing when the application crashed:
Logged in into KDE
- Unusual behavior I noticed:
Desktop appeard and went straight to a black screen and after a few seconds Dr.
Konqi appeared.

-- Backtrace (Reduced):
#6  0x7f0945c0b556 in JobModel::updateJob(int, KCupsJob const&) () at
/usr/lib64/libkcupslib.so
#7  0x7f0945c0d5f8 in JobModel::insertJob(int, KCupsJob const&) () at
/usr/lib64/libkcupslib.so
#8  0x7f0945c0dab9 in JobModel::getJobFinished(KCupsRequest*) () at
/usr/lib64/libkcupslib.so
#9  0x7f097747deea in QObject::event(QEvent*) () at
/usr/lib64/libQt5Core.so.5
#10 0x7f097800fc62 in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() at /usr/lib64/libQt5Widgets.so.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Konrad Materka]

https://bugs.kde.org/show_bug.cgi?id=326289

Konrad Materka  changed:

   What|Removed |Added

 CC||mate...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #44 from Albert Astals Cid  ---
(In reply to Meinhard Ritscher from comment #43)
> I do experience the crash and 
> 
> $> lpstat -R
>   0 printer-97user  316416 Sun Sep 15 22:00:36 2019
>   1 printer-97user  316416 Sun Sep 15 22:00:36 2019
>   2 printer-97user  316416 Sun Sep 15 22:00:36 2019
> 
> Running on openSuse Thumbleweed on the latests updates. Experience this
> crash since a few days

Right, you have 3 print jobs with id 97, which is why this is crashing.

Do you remember what you did to end up with 3 print jobs with the same id? Was
your printer off or on or it failed during printing or something?

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Meinhard Ritscher]

https://bugs.kde.org/show_bug.cgi?id=326289

Meinhard Ritscher  changed:

   What|Removed |Added

 CC||mr203010s...@gmx.net

--- Comment #43 from Meinhard Ritscher  ---
I do experience the crash and 

$> lpstat -R
  0 printer-97user  316416 Sun Sep 15 22:00:36 2019
  1 printer-97user  316416 Sun Sep 15 22:00:36 2019
  2 printer-97user  316416 Sun Sep 15 22:00:36 2019

Running on openSuse Thumbleweed on the latests updates. Experience this crash
since a few days

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=326289

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #42 from Albert Astals Cid  ---
People that still have this crash. Can you please run 
lpstat -R

People that still have this crash and have the technical ability to test a
patch, please test https://phabricator.kde.org/D25623

If we're quick enough we can get it into the 19.12 release of print-manager

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||ajiv...@gmail.com

--- Comment #41 from Christoph Feck  ---
*** Bug 414083 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Bennet]

https://bugs.kde.org/show_bug.cgi?id=326289

Bennet  changed:

   What|Removed |Added

 CC||alex7an...@gmail.com

--- Comment #40 from Bennet  ---
*** Bug 414058 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||mahea...@nic.fi

--- Comment #38 from Christoph Feck  ---
*** Bug 411870 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||wasch...@gmx.de

--- Comment #39 from Christoph Feck  ---
*** Bug 412269 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Carlos]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #37 from Carlos  ---
Created attachment 123034
  --> https://bugs.kde.org/attachment.cgi?id=123034=edit
New crash information added by DrKonqi

plasmashell (5.16.5) using Qt 5.12.3

- What I was doing when the application crashed:
Usually after printing Plasma would crash but restarting from terminal using
killall plasmashell followed by kstart plasmashell would work, now it just
keeps on crashing, so it becomes unusable.
- Unusual behavior I noticed:
Whenever printing succeeded, plasma would crash but resume. If printing failed
and job stayed in printing queue, plasma would crash and never resume. Manual
restart of plasma would be necessary. This is no longer working.

-- Backtrace (Reduced):
#6  0x7f6ae18e9c80 in JobModel::updateJob(int, KCupsJob const&) () at
/usr/lib/x86_64-linux-gnu/libkcupslib.so
#7  0x7f6ae18ebe68 in JobModel::insertJob(int, KCupsJob const&) () at
/usr/lib/x86_64-linux-gnu/libkcupslib.so
#8  0x7f6ae18ec46b in JobModel::getJobFinished(KCupsRequest*) () at
/usr/lib/x86_64-linux-gnu/libkcupslib.so
#9  0x7f6b32e203e2 in QObject::event(QEvent*) () at
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
#10 0x7f6b3474d65c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() at /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Carlos]

https://bugs.kde.org/show_bug.cgi?id=326289

Carlos  changed:

   What|Removed |Added

 CC||cromua...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||salvi.lo...@bsi.sm

--- Comment #36 from Christoph Feck  ---
*** Bug 411153 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Gordon Lack]

https://bugs.kde.org/show_bug.cgi?id=326289

Gordon Lack  changed:

   What|Removed |Added

 CC||gordon.l...@dsl.pipex.com

--- Comment #35 from Gordon Lack  ---
FWIW.
That comment about that multiple jobs with the same id shouldn't exist.
I just decided to use the taskbar print-queue viewer (kde-print-queue) and
selected "All Jobs".
At that point it crashed (but only it - plasma was OK).

But "lpstat -W completed" shows this - several multiple entries...

[parent]: lpstat -W completed
MFCJ4410DW-52   gml44108081408   Sun 01 Sep 2019 22:31:09 BST
MFCJ4410DW-51   gml44103419136   Sun 01 Sep 2019 22:28:35 BST
MFCJ4410DW-49   gml4410 667648   Sun 01 Sep 2019 22:20:14 BST
MFCJ4410DW-48   gml4410   12908544   Sun 01 Sep 2019 22:18:02 BST
MFCJ4410DW-47   gml4410 522240   Sun 01 Sep 2019 22:16:27 BST
MFCJ4410DW-46   gml4410 667648   Sun 01 Sep 2019 22:15:51 BST
MFCJ4410DW-45   gml4410 633856   Sun 01 Sep 2019 22:15:19 BST
MFCJ4410DW-44   gml44103618816   Sun 01 Sep 2019 22:13:56 BST
MFCJ4410DW-43   gml44103674112   Sun 01 Sep 2019 22:13:06 BST
MFCJ4410DW-40   gml44101386496   Sun 01 Sep 2019 21:48:04 BST
MFCJ4410DW-39   gml44101386496   Sun 01 Sep 2019 21:47:16 BST
MFCJ4410DW-38   gml44101199104   Sun 01 Sep 2019 21:44:59 BST
MFCJ4410DW-37   gml44101199104   Sun 01 Sep 2019 21:44:16 BST
MFCJ4410DW-36   gml44101832960   Sun 01 Sep 2019 21:42:29 BST
MFCJ4410DW-35   gml44105528576   Sun 01 Sep 2019 21:37:53 BST
MFCJ4410DW-33   gml44101867776   Sun 01 Sep 2019 21:32:38 BST
MFCJ4410DW-33   gml44101867776   Sun 01 Sep 2019 21:32:38 BST
MFCJ4410DW-31   gml4410 104448   Tue 13 Aug 2019 12:52:43 BST
MFCJ4410DW-31   gml4410 104448   Tue 13 Aug 2019 12:52:43 BST
MFCJ4410DW-30   gml4410 256000   Tue 06 Aug 2019 08:09:15 BST
MFCJ4410DW-30   gml4410 256000   Tue 06 Aug 2019 08:09:15 BST
MFCJ4410DW-29   gml44105049344   Tue 06 Aug 2019 08:08:49 BST
MFCJ4410DW-29   gml44105049344   Tue 06 Aug 2019 08:08:49 BST
MFCJ4410DW-28   gml4410 131072   Mon 05 Aug 2019 03:10:27 BST
MFCJ4410DW-28   gml4410 131072   Mon 05 Aug 2019 03:10:27 BST
MFCJ4410DW-27   gml4410 437248   Sat 03 Aug 2019 05:52:51 BST
MFCJ4410DW-27   gml4410 437248   Sat 03 Aug 2019 05:52:51 BST
MFCJ4410DW-26   gml4410 178176   Fri 02 Aug 2019 00:24:39 BST
MFCJ4410DW-26   gml4410 178176   Fri 02 Aug 2019 00:24:39 BST
MFCJ4410DW-25   gml4410 312320   Sat 15 Jun 2019 08:55:55 BST
MFCJ4410DW-25   gml4410 312320   Sat 15 Jun 2019 08:55:55 BST
MFCJ4410DW-24   gml44101629184   Sun 09 Jun 2019 18:51:18 BST
MFCJ4410DW-24   gml44101629184   Sun 09 Jun 2019 18:51:18 BST
MFCJ4410DW-23   gml4410 211968   Sun 02 Jun 2019 11:11:43 BST
MFCJ4410DW-23   gml4410 211968   Sun 02 Jun 2019 11:11:43 BST
MFCJ4410DW-22   gml4410 521216   Sun 02 Jun 2019 11:05:51 BST
MFCJ4410DW-22   gml4410 521216   Sun 02 Jun 2019 11:05:51 BST
MFCJ4410DW-21   gml4410  32768   Wed 15 May 2019 12:17:19 BST
MFCJ4410DW-21   gml4410  32768   Wed 15 May 2019 12:17:19 BST
MFCJ4410DW-20   gml4410 294912   Wed 15 May 2019 10:58:47 BST
MFCJ4410DW-20   gml4410 294912   Wed 15 May 2019 10:58:47 BST
MFCJ4410DW-19   gml4410 250880   Wed 15 May 2019 10:58:16 BST
MFCJ4410DW-19   gml4410 250880   Wed 15 May 2019 10:58:16 BST
MFCJ4410DW-18   gml4410  81920   Tue 14 May 2019 10:25:39 BST
MFCJ4410DW-18   gml4410  81920   Tue 14 May 2019 10:25:39 BST
MFCJ4410DW-14   gml4410 245760   Mon 13 May 2019 11:10:57 BST
MFCJ4410DW-14   gml4410 245760   Mon 13 May 2019 11:10:57 BST
MFCJ4410DW-14   gml4410 245760   Mon 13 May 2019 11:10:57 BST
MFCJ4410DW-13   gml4410 300032   Sat 11 May 2019 15:43:22 BST
MFCJ4410DW-13   gml4410 300032   Sat 11 May 2019 15:43:22 BST
MFCJ4410DW-13   gml4410 300032   Sat 11 May 2019 15:43:22 BST
MFCJ4410DW-12   gml44107809024   Sun 05 May 2019 01:04:45 BST
MFCJ4410DW-12   gml44107809024   Sun 05 May 2019 01:04:45 BST
MFCJ4410DW-12   gml44107809024   Sun 05 May 2019 01:04:45 BST
MFCJ4410DW-11   gml4410 137216   Wed 24 Apr 2019 18:56:44 BST
MFCJ4410DW-11   gml4410 137216   Wed 24 Apr 2019 

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||newslett...@dedanann.de

--- Comment #34 from Christoph Feck  ---
*** Bug 410509 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=326289

David Edmundson  changed:

   What|Removed |Added

 CC||hoheneg...@web.de

--- Comment #33 from David Edmundson  ---
*** Bug 410570 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Rik Mills]

https://bugs.kde.org/show_bug.cgi?id=326289

Rik Mills  changed:

   What|Removed |Added

 CC||geneloca...@yandex.com

--- Comment #32 from Rik Mills  ---
*** Bug 410124 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=326289

Fabian Vogt  changed:

   What|Removed |Added

 CC||maggu2...@web.de

--- Comment #31 from Fabian Vogt  ---
*** Bug 409439 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Fabian Vogt]

https://bugs.kde.org/show_bug.cgi?id=326289

Fabian Vogt  changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

--- Comment #30 from Fabian Vogt  ---
> Perhaps insertRow() has undefined behavior when the given row index is 
> greater than rowCount()?

The behaviour is actually well defined: It does nothing.

As the assumption that at each iteration of the loop there are at least "i"
rows is wrong, it crashes.

Maybe the best option is to just skip jobs with duplicate ids?

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=409439

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #29 from saif1...@gmail.com ---
(In reply to Marcel Martin from comment #28)
> > Interesting, so you're saying that my boot problem was because
> > there were jobs in the print queue?
> 
> To be precise: The problem occurs whenever there are at least two jobs in
> your print queue with identical job ids. This should normally not happen,
> but it apparently does sometimes. 
> 
> When Plasma starts up, it loads various apps, including the one responsible
> for the printer status icon in the system tray. When that one is loaded, it
> goes through the jobs in the print queue and tries to gather information
> about them. When it does so and encounters two jobs with the same id, it
> crashes, taking Plasma with it. At least that is my theory so far.
> 
> Did you try 'cancel -a'? It would be interesting to know whether that fixes
> the problem.

Interesting!. The consequences are super nasty though. My KDE desktop wouldn't
boot at all. No wallpaper, no menus, nothing. Obvious debugging or first
counter-measures won't work either (such as wiping out ~/.config/).

I haven't tried cancel -a now since the first thing I went through is
re-installing cups completely which fixed the problem. Not sure how to
reproduce it now.

Still, I was seconds away of installing other distro or something... This one
should get fixed. I didn't do any weird stuff just user my printer a few times
last night (and it worked fine)

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Marcel Martin]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #28 from Marcel Martin  ---
> Interesting, so you're saying that my boot problem was because
> there were jobs in the print queue?

To be precise: The problem occurs whenever there are at least two jobs in your
print queue with identical job ids. This should normally not happen, but it
apparently does sometimes. 

When Plasma starts up, it loads various apps, including the one responsible for
the printer status icon in the system tray. When that one is loaded, it goes
through the jobs in the print queue and tries to gather information about them.
When it does so and encounters two jobs with the same id, it crashes, taking
Plasma with it. At least that is my theory so far.

Did you try 'cancel -a'? It would be interesting to know whether that fixes the
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #27 from saif1...@gmail.com ---
(In reply to Marcel Martin from comment #26)
> A temporary fix should be to delete all queued print jobs because the
> problem occurs when there are multiple print jobs with the same id. Then you
> don’t have to uninstall cups and will still be able to print.
> 
> On the commandline, you should be able to delete all jobs by running "cancel
> -a". Or read .
> 
> I have not tested this on my machine as I want to be able to reproduce the
> crash when necessary.

Interesting, so you're saying that my boot problem was because there were jobs
in the print queue?

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Marcel Martin]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #26 from Marcel Martin  ---
A temporary fix should be to delete all queued print jobs because the problem
occurs when there are multiple print jobs with the same id. Then you don’t have
to uninstall cups and will still be able to print.

On the commandline, you should be able to delete all jobs by running "cancel
-a". Or read .

I have not tested this on my machine as I want to be able to reproduce the
crash when necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #25 from saif1...@gmail.com ---
(In reply to saif1988 from comment #24)
> Hi.
> 
> Today my KDE Plasma stopped booting normally. Got this libkcups.so core
> dumped error. Works fine after uninstalling cups package. Fedora 29

Full stacktrace I got is here:
https://ask.fedoraproject.org/en/question/130338/kde-broken-after-fedora-upgrade/

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=326289

saif1...@gmail.com changed:

   What|Removed |Added

 CC||saif1...@gmail.com

--- Comment #24 from saif1...@gmail.com ---
Hi.

Today my KDE Plasma stopped booting normally. Got this libkcups.so core dumped
error. Works fine after uninstalling cups package. Fedora 29

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[David Pyke]

https://bugs.kde.org/show_bug.cgi?id=326289

David Pyke  changed:

   What|Removed |Added

 CC||kdeb...@loftwyr.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||a...@mattenet.com

--- Comment #23 from Christoph Feck  ---
*** Bug 399400 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Tobias Roeser]

https://bugs.kde.org/show_bug.cgi?id=326289

Tobias Roeser  changed:

   What|Removed |Added

 CC||le.petit@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Marcel Martin]

https://bugs.kde.org/show_bug.cgi?id=326289

Marcel Martin  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #22 from Marcel Martin  ---
Thanks so much for looking into this! Unfortunately, the crash is still there.

(Sorry for the late reply, but for some reason I wasn’t notified that this
report had been updated.)

However, your changes made it a bit easier for me to continue debugging this.
As it turns out, the problem appears to be that I have two jobs that have the
same id. That is, within getJobFinished(), the 'jobs' variable (KCupsJobs)
contains four jobs, and the first two have the same .id(). (They also have the 
same .name().) I have four jobs in total.

Here is what happens inside the for loop over the KCupsJobs (the JobModel is
initially empty, i.e. rowCount() == 0 at the start)

- Iteration/job 0: jobRow() for this KCupsJob returns -1, which means that the
job isn’t in the model. The job is inserted at index 0.

- Iteration/job 1: jobRow() for this KCupsJob returns 0 because this KCupsJob
has the same id as the one that was just inserted. updateJob() is called for
row 0. Then the condition in "if (job_row != i)" is true ("found at wrong
position") and the code tries to take row 0 and insert it at index 2. This
fails for some reason so that there are actually no rows in the model anymore
(rowCount() == 0). Perhaps insertRow() has undefined behavior when the given
row index is greater than rowCount()?

- Iteration/job 2: jobRow() for this KCupsJob returns -1 as it is a different
job. The code tries to insert it at index 2. insertJob() calls updateJob() with
pos = 2, which crashes at some point because rowCount() is actually 0.

I have no idea why the duplicate jobs exist, but they are also visible on
, so they’re real.

I’ve attempted to fix the problem in getJobFinished() by just inserting all
jobs when the model is empty:

if (rowCount() == 0) {
for (int i = 0; i < jobs.size(); ++i) {
insertJob(i, jobs.at(i));
}
} else {
// (previous loop here)

For me, this avoids the crash during startup. (I’m not suggesting this is a
proper fix.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Daniel Nicoletti]

https://bugs.kde.org/show_bug.cgi?id=326289

Daniel Nicoletti  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pri
   ||nt-manager/5d3c5f7bc4174695
   ||af57cf5032a3d4117bd7577c

--- Comment #20 from Daniel Nicoletti  ---
Git commit 5d3c5f7bc4174695af57cf5032a3d4117bd7577c by Daniel Nicoletti.
Committed on 06/06/2018 at 20:22.
Pushed by dantti into branch 'master'.

Possibly fix a crash by updating a row before moving it

This optimizes row updates and will update a row
before putting it in another position in order to
try to avoid a crash.

M  +63   -55   libkcups/JobModel.cpp

https://commits.kde.org/print-manager/5d3c5f7bc4174695af57cf5032a3d4117bd7577c

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Daniel Nicoletti]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #21 from Daniel Nicoletti  ---
I'm not sure if this fixes the issue so please try...

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Daniel Nicoletti]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #19 from Daniel Nicoletti  ---
This is really odd, and sadly I could never reproduce it.

The code removes a row, inserts at another position and then crashes when
updating it at the new position, it feels like the insert failed somehow...

I could add a check but that doesn't seem right :/

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=326289

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=326289

Christoph Feck  changed:

   What|Removed |Added

 CC||cf...@kde.org

--- Comment #18 from Christoph Feck  ---
Random idea:

If the job is not found, it first does a takeRow(), then an insertRow(). If the
row to be removed is preceeding the row where to insert later, then the insert
index "i" probably needs to be updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Marcel Martin]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #17 from Marcel Martin  ---
I can reliably reproduce this crash on Kubuntu 18.04. I tried to debug it using
the Git version of print-manager. I’m not familiar with the code, so I don’t
think I can submit a patch, but I think I can pinpoint the problem.

The crash occurs in line 328 in JobModel.cpp (in JobModel::updateJob()):


The line is:

if (item(pos, ColStatus)->data(RoleJobState).toInt() != jobState) {

The expression item(pos, ColStatus) evaluates to NULL, hence the crash.

In my case, updateJob() is called from JobModel::getJobFinished() at line 202
within a branch described as "found at wrong position, take it and insert on
the right position", see


Perhaps this is already enough for one of the developers to come up with a
solution. I’d be happy to help as much as I can.

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Andrew Travneff]

https://bugs.kde.org/show_bug.cgi?id=326289

--- Comment #16 from Andrew Travneff  ---
Created attachment 112216
  --> https://bugs.kde.org/attachment.cgi?id=112216=edit
New crash information added by DrKonqi

plasmashell (5.12.4) using Qt 5.9.4

What I was doing when the application crashed: restarted cups service with one
print job in the queue.
System experienced smth like kernel bug 12309 while that (copying data from sd
card to ssd, everything was very slow).

-- Backtrace (Reduced):
#6  0x7f25d75973c6 in JobModel::updateJob(int, KCupsJob const&) () at
/lib64/libkcupslib.so
#7  0x7f25d759bd0f in JobModel::getJobFinished() () at
/lib64/libkcupslib.so
#9  0x7f26a03c826a in QObject::event(QEvent*) () at /lib64/libQt5Core.so.5
#10 0x7f26a14d192c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() at /lib64/libQt5Widgets.so.5
#11 0x7f26a14d9174 in QApplication::notify(QObject*, QEvent*) () at
/lib64/libQt5Widgets.so.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Andrew Travneff]

https://bugs.kde.org/show_bug.cgi?id=326289

Andrew Travneff  changed:

   What|Removed |Added

 CC||travn...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Marcel Martin]

https://bugs.kde.org/show_bug.cgi?id=326289

Marcel Martin  changed:

   What|Removed |Added

 CC||m...@freenet.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[print-manager] [Bug 326289] plasma-desktop crashed after configuring printer applet [JobModel::updateJob]

[Kevin Funk]

https://bugs.kde.org/show_bug.cgi?id=326289

Kevin Funk  changed:

   What|Removed |Added

 CC||kf...@kde.org
Summary|plasma-desktop crashed  |plasma-desktop crashed
   |after configuring printer   |after configuring printer
   |applet  |applet
   ||[JobModel::updateJob]

-- 
You are receiving this mail because:
You are watching all bug changes.