[dolphin] [Bug 183429] open externally called folder in new tab

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=183429

Bug Janitor Service  changed:

   What|Removed |Added

   Priority|NOR |HI

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Feng Lengshun]

https://bugs.kde.org/show_bug.cgi?id=183429

Feng Lengshun <7erxk5...@mozmail.com> changed:

   What|Removed |Added

 CC||7erxk5...@mozmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=183429

--- Comment #36 from andydecle...@gmail.com ---
Created attachment 129556
  --> https://bugs.kde.org/attachment.cgi?id=129556=edit
One folder, two ways

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=183429

--- Comment #35 from andydecle...@gmail.com ---
In addition to my already stated reason for believing this is not yet resolved,
it seems the is-already-open detection is too picky in some way:

1. I launch dolphin with a hotkey, configured so that I can get access to this
feature as it's currently implemented, which runs the command:

dolphin ~/Downloads

2. I navigate to ~/Videos by editing the location bar

3. I launch vokoscreen-ng and click the "Folder" button

This opens another tab open to ~/Videos, adjacent to the first tab open to that
same folder. Further clicks of the button re-focus that second tab.

I notice that each tab uses a different icon; I'll attach a screenshot.

This doesn't happen if I choose the folder from the dropdown, left of the
location bar, nor if I go Up and click into the Videos folder. In those cases,
no second tab is opened; the first and only is focused.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=183429

--- Comment #34 from andydecle...@gmail.com ---
Alright, I still think this should be re-opened until it works with the Global
Shortcuts item for Dolphin, but I've given up and set a custom shortcut via the
khotkeys kcm, specifying the (now doubly-configured) launch path in the command
as a workaround.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=183429

--- Comment #33 from andydecle...@gmail.com ---
Can we get this to work when no paths are provided to dolphin, such as when
launching via a menu, dock, panel, krunner, or global shortcut? The implicit
path is whatever dolphin's open-at-launch path is. 

I was looking forward to this feature but had no idea it was implemented,
because its activation conditions overlap with my usage either very little or
not at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=183429

neg...@negora.com changed:

   What|Removed |Added

 CC||neg...@negora.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=183429

Elvis Angelaccio  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||19.08.0
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/dol
   ||phin/27e3907a3daf9a63d05c00
   ||a0ff746de6cfdf2bdf

--- Comment #32 from Elvis Angelaccio  ---
Git commit 27e3907a3daf9a63d05c00a0ff746de6cfdf2bdf by Elvis Angelaccio, on
behalf of Alexander Saoutkin.
Committed on 30/05/2019 at 20:40.
Pushed by elvisangelaccio into branch 'master'.

Open externally called files/directories in new tabs

Summary:
FIXED-IN: 19.08.0
GUI: new cli argument --new-window

Externally called files/directories are opened in a a new tab of an instance of
Dolphin that already exists. If any of the given URIs are already open in a
tab, then those tabs are activated instead of a new tab being opened.  If there
is no instance then the files/directories are opened in a new window. The newly
opened file/directory has its tab activated, and consequently, the window is
also activated.

When the user clicks "Open In New Window" or "Detach Tab", the
files/directories are opened in a new window.

Test Plan:
[Manual]
Before testing, set the default file manager in system settings as the newly
built Dolphin executable.
One must also include the new dolphin executable in the $PATH, otherwise some
functions will attempt to open the system dolphin instead of the new one.

Furthermore, running two different versions of Dolphin (in particular, where
one does not have this patch included) can result in bugs appearing, in
particular, new tabs not opening as old instances will not recognise the DBus
commands sent to it. However, I see no reason why a user will have two
different versions of Dolphin (apart from people like us :D).

Open directories with the help of auxillary programs (i.e. a browser). The
files/directories should appear in a new window if an instance does not exist.
If an existence already exists, then a new tab should be opened and activated
in that instance and the window activated.
Use QDBusViewer to open folders/items by calling the ShowFolders/ShowItems
methods in org.freedesktop.FileManager1 of the Dolphin instance.
When a user chooses to "Open In New Window"/"Detach Tab" then the
files/directories should be opened in a new window.

Reviewers: #dolphin, elvisangelaccio

Subscribers: zzag, dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin,
ngraham, elvisangelaccio, anthonyfieroni, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D16648

M  +1-0CMakeLists.txt
M  +1-0src/CMakeLists.txt
M  +11   -2src/dbusinterface.cpp
M  +27   -0src/dolphinmainwindow.cpp
M  +33   -0src/dolphinmainwindow.h
M  +22   -2src/dolphintabwidget.cpp
M  +6-0src/dolphintabwidget.h
M  +82   -2src/global.cpp
M  +6-0src/global.h
M  +18   -5src/main.cpp

https://commits.kde.org/dolphin/27e3907a3daf9a63d05c00a0ff746de6cfdf2bdf

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Störm Poorun]

https://bugs.kde.org/show_bug.cgi?id=183429

Störm Poorun  changed:

   What|Removed |Added

 CC||s...@olan.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Henrique Sant'Anna]

https://bugs.kde.org/show_bug.cgi?id=183429

Henrique Sant'Anna  changed:

   What|Removed |Added

 CC||hsanta...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=183429

Nate Graham  changed:

   What|Removed |Added

   Keywords|junior-jobs |

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=183429

--- Comment #31 from Nate Graham  ---
This appears to be a popular feature, because no fewer than three people have
now submitted patches to implement it!

- https://phabricator.kde.org/D16648
- https://phabricator.kde.org/D19150
- https://phabricator.kde.org/D19883

We don't need any more for now. :) The Dolphin maintainer will sort out this
situation and hopefully get one of them merged! Thanks everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=183429

matheus4...@hotmail.com changed:

   What|Removed |Added

 CC||matheus4...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Nathaniel Beaver]

https://bugs.kde.org/show_bug.cgi?id=183429

Nathaniel Beaver  changed:

   What|Removed |Added

 CC||nathanielmbea...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[James Turnbull]

https://bugs.kde.org/show_bug.cgi?id=183429

James Turnbull  changed:

   What|Removed |Added

 CC||ja...@lovedthanlost.net

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[King Kang Kong]

https://bugs.kde.org/show_bug.cgi?id=183429

King Kang Kong  changed:

   What|Removed |Added

 CC||r2b2x3+kde...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=183429

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[intika]

https://bugs.kde.org/show_bug.cgi?id=183429

intika  changed:

   What|Removed |Added

 CC||boite.a.me...@hotmail.com

--- Comment #30 from intika  ---
Based on 
https://github.com/FadySGhatas/kde-dolphin-single-instance and 
https://git.reviewboard.kde.org/r/129043/

i implemented this feature & more... 
https://github.com/intika/kde-dolphin-single-instance

Feel free to pull request, edit etc... the solution is good and work as
expected but its not perfect so i am not submitting a patch feel free to do so.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Marcelo FOrnet]

https://bugs.kde.org/show_bug.cgi?id=183429

Marcelo FOrnet  changed:

   What|Removed |Added

 CC||mfornet94+bugs...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=183429

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=183429

Nate Graham  changed:

   What|Removed |Added

   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=183429

Nate Graham  changed:

   What|Removed |Added

 CC||correcho...@hotmail.com

--- Comment #29 from Nate Graham  ---
*** Bug 391254 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=183429

Christoph Feck  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=388016

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Mark Constable]

https://bugs.kde.org/show_bug.cgi?id=183429

Mark Constable  changed:

   What|Removed |Added

 CC||ma...@renta.net

--- Comment #28 from Mark Constable  ---
No one has posted this link so here it is for the record. I have no idea if
it's suitable for this particular use case solution but it's probably close and
could be the foundation of a real solution...

https://github.com/FadySGhatas/kde-dolphin-single-instance

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[zeta]

https://bugs.kde.org/show_bug.cgi?id=183429

zeta  changed:

   What|Removed |Added

 CC||franciscodezuvi...@gmail.co
   ||m

--- Comment #27 from zeta  ---
Whoever implements this please make it so the dolphin instance to be used is:
 - one binded to current activity
 - if not found, one binded to all activities
 - if not found, new instance belonging to current activity
I would really really really like having a single dolphin instance per
activity.

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=183429

andydecle...@gmail.com changed:

   What|Removed |Added

 CC||andydecle...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=183429

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 183429] open externally called folder in new tab

[Sebastian Ernst]

https://bugs.kde.org/show_bug.cgi?id=183429

Sebastian Ernst  changed:

   What|Removed |Added

 CC||er...@pleiszenburg.de

-- 
You are receiving this mail because:
You are watching all bug changes.