[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #70 from Felix Ernst  ---
(In reply to funkybomber from comment #69)
> I have verified the patch working in the latest KDE Neon Unstable edition
> and I think it's only fair to release the bounty regardless of the whole
> Bountysource situation. I have made a 50€ payment (the initial bounty was
> for $50 but potato-potahto) so you should receive it (minus the Liberapay
> processing fees) soon. Thanks for your good work!

It makes me happy to see my work being appreciated. I received the 50€. Thank
you!

>(minus the Liberapay processing fees)

LiberaPay actually has zero fees (https://en.liberapay.com/about/faq) so I
received the full amount.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #69 from funkybom...@gmail.com ---
(In reply to Felix Ernst from comment #67)
> (In reply to funkybomber from comment #58)
> > I have just posted a bounty for this bug. I'd like to see this fixed when
> > the Oxygen Icon Theme is in use. 
> > Please note that I will need to see it solved in the KDE Neon Developer
> > edition before I am ok with releasing the reward!
> > Happy coding! :)
> > 
> > https://www.bountysource.com/issues/54393195-full-and-empty-stars-are-
> > indistinguishable-when-using-an-icon-theme-including-oxygen-that-lacks-the-
> > rating-unrated-icon
> 
> I just looked into claiming the bounty but unfortunately the people running
> the bountysource page are now committing fraud, embezzling the money, and
> are no longer paying out bounties:
> https://github.com/bountysource/core/issues/1586
> 
> I originally found this bug through bounty source, and while 50€ isn't that
> much, hearing of one more fraud is still upsetting.
> 
> If you want to, you could still pay out the bounty to me directly, but after
> all these years and after the money you originally allocated being
> embezzled, I totally understand if you don't.
> 
> Here is my Paypal
> https://www.paypal.com/donate/?hosted_button_id=WTHAYDL59U9FL and my
> Liberapay https://liberapay.com/felixernst/donate .
> 
> In any case this should be fully fixed now for KDE frameworks 6. You can
> test it like this:
> 
> Test plan:
> 
> 1. Either find a theme that only provides a "rating" icon but no
> "rating-unrated" icon, or temporarily rename all "rating-unrated" icons in
> your current theme:
> sudo find /usr/share/icons/$THEMENAME/ -type f -regex '.*atin.*' -exec
> rename 's/rating-unrated/\(renamed\)rating-unrated/' {} \;
> (You can later change it back using this command: sudo find
> /usr/share/icons/$THEMENAME/ -type f -regex '.*atin.*' -exec rename
> 's/\(renamed\)rating-unrated/rating-unrated/' {} \;)
> 2. Notice that the "rating" field in Dolphin in the information panel or in
> the "rating" column in details view now all show a five-star rating.
> 3. Do the same with a Dolphin using a KWidgetsAddons framework containing my
> fix. Notice everything is fine now.
> 
> Cheers!

I have verified the patch working in the latest KDE Neon Unstable edition and I
think it's only fair to release the bounty regardless of the whole Bountysource
situation. I have made a 50€ payment (the initial bounty was for $50 but
potato-potahto) so you should receive it (minus the Liberapay processing fees)
soon. Thanks for your good work!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=339863

Felix Ernst  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
   |eworks/kwidgetsaddons/-/com |eworks/kwidgetsaddons/-/com
   |mit/e5ef8184db0733b944cb7a3 |mit/2273405379815ce9a4c6561
   |c9ee1cf239035921b   |9511849c3aa3b5a84

--- Comment #68 from Felix Ernst  ---
Git commit 2273405379815ce9a4c65619511849c3aa3b5a84 by Felix Ernst, on behalf
of Felix Ernst.
Committed on 11/09/2023 at 09:25.
Pushed by felixernst into branch 'kf5'.

Fix file rating being unreadable in certain themes

Typically, a rating on a file is represented by five stars in a
row. If the first 3 stars are filled and the other 2 aren't, that
represents a 3/5 star rating.

When a theme only provides the filled stars (i.e. "rating") icon
but no unfilled stars (i.e. "rating-unrated") icon, KRatingPainter
would always paint all five stars as filled no matter if the actual
rating was 1/5 or 5/5 because the automatic fallback of the
"rating-unrated" icon is the "rating" icon as stated by the icon
theme spec.

This commit fixes this by having KRatingPainter use a generated
replacement "rating-unrated" icon (a de-saturated and grey-scaled
"rating" icon), if the theme does not provide a "rating-unrated"
icon already.


(cherry picked from commit e5ef8184db0733b944cb7a3c9ee1cf239035921b)

M  +10   -6src/kratingpainter.cpp

https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/2273405379815ce9a4c65619511849c3aa3b5a84

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=339863

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In|5.5.0   |6.0

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=339863

Felix Ernst  changed:

   What|Removed |Added

 CC||felixer...@kde.org

--- Comment #67 from Felix Ernst  ---
(In reply to funkybomber from comment #58)
> I have just posted a bounty for this bug. I'd like to see this fixed when
> the Oxygen Icon Theme is in use. 
> Please note that I will need to see it solved in the KDE Neon Developer
> edition before I am ok with releasing the reward!
> Happy coding! :)
> 
> https://www.bountysource.com/issues/54393195-full-and-empty-stars-are-
> indistinguishable-when-using-an-icon-theme-including-oxygen-that-lacks-the-
> rating-unrated-icon

I just looked into claiming the bounty but unfortunately the people running the
bountysource page are now committing fraud, embezzling the money, and are no
longer paying out bounties: https://github.com/bountysource/core/issues/1586

I originally found this bug through bounty source, and while 50€ isn't that
much, hearing of one more fraud is still upsetting.

If you want to, you could still pay out the bounty to me directly, but after
all these years and after the money you originally allocated being embezzled, I
totally understand if you don't.

Here is my Paypal https://www.paypal.com/donate/?hosted_button_id=WTHAYDL59U9FL
and my Liberapay https://liberapay.com/felixernst/donate .

In any case this should be fully fixed now for KDE frameworks 6. You can test
it like this:

Test plan:

1. Either find a theme that only provides a "rating" icon but no
"rating-unrated" icon, or temporarily rename all "rating-unrated" icons in your
current theme:
sudo find /usr/share/icons/$THEMENAME/ -type f -regex '.*atin.*' -exec rename
's/rating-unrated/\(renamed\)rating-unrated/' {} \;
(You can later change it back using this command: sudo find
/usr/share/icons/$THEMENAME/ -type f -regex '.*atin.*' -exec rename
's/\(renamed\)rating-unrated/rating-unrated/' {} \;)
2. Notice that the "rating" field in Dolphin in the information panel or in the
"rating" column in details view now all show a five-star rating.
3. Do the same with a Dolphin using a KWidgetsAddons framework containing my
fix. Notice everything is fine now.

Cheers!

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Felix Ernst]

https://bugs.kde.org/show_bug.cgi?id=339863

Felix Ernst  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|https://commits.kde.org/oxy |https://invent.kde.org/fram
   |gen-icons5/221951952d22ae8d |eworks/kwidgetsaddons/-/com
   |4b8b9d8dc90af53cf8401a92|mit/e5ef8184db0733b944cb7a3
   ||c9ee1cf239035921b
 Status|ASSIGNED|RESOLVED

--- Comment #66 from Felix Ernst  ---
Git commit e5ef8184db0733b944cb7a3c9ee1cf239035921b by Felix Ernst, on behalf
of Felix Ernst.
Committed on 07/09/2023 at 13:35.
Pushed by felixernst into branch 'master'.

Fix file rating being unreadable in certain themes

Typically, a rating on a file is represented by five stars in a
row. If the first 3 stars are filled and the other 2 aren't, that
represents a 3/5 star rating.

When a theme only provides the filled stars (i.e. "rating") icon
but no unfilled stars (i.e. "rating-unrated") icon, KRatingPainter
would always paint all five stars as filled no matter if the actual
rating was 1/5 or 5/5 because the automatic fallback of the
"rating-unrated" icon is the "rating" icon as stated by the icon
theme spec.

This commit fixes this by having KRatingPainter use a generated
replacement "rating-unrated" icon (a de-saturated and grey-scaled
"rating" icon), if the theme does not provide a "rating-unrated"
icon already.

M  +10   -6src/kratingpainter.cpp

https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/e5ef8184db0733b944cb7a3c9ee1cf239035921b

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=339863

Bug Janitor Service  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

--- Comment #65 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/kwidgetsaddons/-/merge_requests/190

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #64 from Christoph Feck  ---
It probably is the correct solution for the Oxygen theme (providing separate
images is always better than faking them by reducing colors).

But I reopened this ticket, because it should also work for any other icon
theme that does not provide separate images. It also needs to be tested to work
with Qt's icon loader as well as KIconLoader.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #63 from funkybom...@gmail.com ---
There is also this co-related phabricator task which has been marked as
"resolved" due to this latest commit from "andreask".

https://phabricator.kde.org/T7094

Is this commit not a proper solution for the Oxygen theme?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=339863

Christoph Feck  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #62 from Christoph Feck  ---
The commit only added more Oxygen icons.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #61 from funkybom...@gmail.com ---
The changes have not yet appeared in my KDE Neon Developer installation.
Perhaps I need to follow some manual steps in order to get the changes on my
system?

Also, which KDE package/release is the one that is supposed to include the fix?
I would expect it to be Dolphin 18.04.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Wolfgang Bauer]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #60 from Wolfgang Bauer  ---
I still think it would be good to fix the underlying issue in the icon loader
though.

And maybe add default icons to kwidgetaddons, Oxygen is no longer used as
fallback since a while (and breeze neither)...

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Jayesh Bhoot]

https://bugs.kde.org/show_bug.cgi?id=339863

Jayesh Bhoot  changed:

   What|Removed |Added

 CC|jay...@bhoot.sh |

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[andreas]

https://bugs.kde.org/show_bug.cgi?id=339863

andreas  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
  Latest Commit|http://commits.kde.org/kwid |https://commits.kde.org/oxy
   |getsaddons/9f618d0d45d5b9b2 |gen-icons5/221951952d22ae8d
   |eb6f980f8956bbafc26eff04|4b8b9d8dc90af53cf8401a92
 Resolution|--- |FIXED

--- Comment #59 from andreas  ---
Git commit 221951952d22ae8d4b8b9d8dc90af53cf8401a92 by andreas kainz.
Committed on 07/02/2018 at 00:57.
Pushed by andreask into branch 'master'.

Add rating-unrated icon

A  +---16x16/actions/rating-unrated.png
A  +---22x22/actions/rating-unrated.png
A  +---32x32/actions/rating-unrated.png
A  +---48x48/actions/rating-unrated.png

https://commits.kde.org/oxygen-icons5/221951952d22ae8d4b8b9d8dc90af53cf8401a92

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] Full and empty stars are indistinguishable when using an icon theme (including Oxygen) that lacks the "rating-unrated" icon

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=339863

Nate Graham  changed:

   What|Removed |Added

Summary|full and empty stars are|Full and empty stars are
   |indistinguishable   |indistinguishable when
   ||using an icon theme
   ||(including Oxygen) that
   ||lacks the "rating-unrated"
   ||icon

--- Comment #57 from Nate Graham  ---
Is this actually still a bug with kwidgetsaddons? At this point shouldn't we
just fix the icon themes?

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=339863

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=339863

Nate Graham  changed:

   What|Removed |Added

 CC||funkybom...@gmail.com

--- Comment #56 from Nate Graham  ---
*** Bug 385682 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable

[Elvis Angelaccio]

https://bugs.kde.org/show_bug.cgi?id=339863

Elvis Angelaccio  changed:

   What|Removed |Added

 CC||elvis.angelac...@kde.org

--- Comment #55 from Elvis Angelaccio  ---
Created attachment 105374
  --> https://bugs.kde.org/attachment.cgi?id=105374=edit
Indistinguishable empty stars in Dolphin tooltips

Not sure if related or a different issue, but the empty stars in KRatingWidget
are invisible in the Dolphin's tooltips (with the default breeze theme).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #54 from Wolfgang Bauer  ---
(In reply to Christoph Feck from comment #53)
> What is the status of this bug with frameworks from master?
> QIcon::hasThemeIcon() might again got fixed with yesterdays commit.

Unfortunately this commit didn't change anything regarding the rating widget.
In other words, this is still broken with oxygen (or any other theme that
doesn't have rating-unrated).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #52 from Wolfgang Bauer  ---
PS, somehow related:
I think it would also be a good idea if kwidgetsaddons would actually ship with
fallback icons for "rating" and "rating-unrated" (e.g. in an embedded .qrc).
Currently the rating stars do not show up at all here when running dolphin
outside of Plasma (i.e. when KDE's icon loader is not used), because the
"rating" icon is only present in breeze and oxygen (not hicolor).

This would also fix the problem with full and empty stars being
undistinguishable if "rating-unrated" is missing in the theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339863

--- Comment #51 from Wolfgang Bauer  ---
(In reply to Wolfgang Bauer from comment #50)
> But what about the most obvious and probably easiest "solution"?
> Just add a "rating-unrated" icon to the oxygen theme.
> That should fix the problem also for other themes, as oxygen is still used
> as fallback for missing icons in the currently configured icon theme.

Forgot to mention that I tested this locally, it works great and fixes the
problem.

Another option would probably be to revert
https://quickgit.kde.org/?p=kwidgetsaddons.git=commit=9f618d0d45d5b9b2eb6f980f8956bbafc26eff04
and drop "rating-unrated", as breeze's rating icon is not monochrome any more.
That might of course cause problems with other themes that do contain a
monochrome rating icon, but that was the state in KDE4 too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable

[Wolfgang Bauer via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339863

Wolfgang Bauer  changed:

   What|Removed |Added

 CC||wba...@tmo.at

--- Comment #50 from Wolfgang Bauer  ---
(In reply to David M from comment #49)
> I'm happy to report that with the Breeze theme, KDE Applications 16.04
> finally it appears for whatever reason that this bug is fixed and all star
> ratings now appear as they should. 

Actually, with breeze this is fixed since months. If it didn't work for you,
you probably experienced a different problem, maybe this one:
https://bugzilla.opensuse.org/show_bug.cgi?id=970896, which is indeed fixed in
dolphin 16.04.

But the rating display is still completely broken with other themes (including
oxygen) that don't provide a "rating-unrated" icon.

The reason is as suggested in comment#20:
(In reply to Christoph Feck from comment #20)
> I guess this has something to do with the KDE icon loader
> stating that "rating-unrated" icon exists, but actually only found the
> fallback icon "rating". The Qt icon loader seems to handle this correctly.

But, this is not a bug in the icon loader I think, that's how the behaviour is
defined in the freedesktop icon name specification
(https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#guidelines):
The dash “-” character is used to separate levels of specificity in icon names,
for all contexts other than MimeTypes. For instance, we use “input-mouse” as
the generic item for all mouse devices, and we use “input-mouse-usb” for a USB
mouse device. However, if the more specific item does not exist in the current
theme, and does exist in a parent theme, the generic icon from the current
theme is preferred, in order to keep consistent style.

That implies that if "rating-unrated" doesn't exist in the current theme,
"rating" (from the current theme) should be used instead.
So "rating-unrated" was actually a bad choice to begin with I think, and can't
really work as intended IMHO.

But what about the most obvious and probably easiest "solution"?
Just add a "rating-unrated" icon to the oxygen theme.
That should fix the problem also for other themes, as oxygen is still used as
fallback for missing icons in the currently configured icon theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 339863] full and empty stars are indistinguishable

[Michael D via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=339863

Michael D  changed:

   What|Removed |Added

 CC||nortex...@gmail.com

--- Comment #47 from Michael D  ---
Any status on this? It happens with a number of different icon themes (e.g.
Papirus included) in a number of different apps. I consider the rating feature
to be quite an important one!

-- 
You are receiving this mail because:
You are watching all bug changes.