[frameworks-qqc2-desktop-style] [Bug 467390] Use of checkboxes for mutually exclusive menu items is very misleading

2023-03-31 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=467390

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.105

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 467390] Use of checkboxes for mutually exclusive menu items is very misleading

2023-03-31 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=467390

ratijas  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
   |eworks/qqc2-desktop-style/c |eworks/qqc2-desktop-style/c
   |ommit/9dadd05de66a135ea0c3c |ommit/7bff5123264ab1f312229
   |66c6bb554ab22ec6a67 |4c95bd1fab40fb0a6d3

--- Comment #4 from ratijas  ---
Git commit 7bff5123264ab1f3122294c95bd1fab40fb0a6d3 by ivan tkachenko.
Committed on 31/03/2023 at 22:59.
Pushed by ratijas into branch 'kf5'.

CheckIndicator: Allow exclusive buttons to be detected via their ButtonGroup

This is a bit wasteful, as it creates a ButtonGroup attached object for
every menu item that does not have it. But it works. Unfortunately,
there is no better approach, as if ButtonGroup is bound to an item
later than this binding is established, we won't know about it.

All components using CheckIndicator, except MenuItem, were modified to
override this new more advanced heuristic with a fixed elementType, so
they don't waste memory on attached objects, and always have
predictable appearance.

See also: https://invent.kde.org/frameworks/kirigami/-/merge_requests/1014

M  +1-0org.kde.desktop/CheckBox.qml
M  +1-0org.kde.desktop/CheckDelegate.qml
M  +6-1org.kde.desktop/CheckIndicator.qml
M  +1-0org.kde.desktop/RadioButton.qml
M  +1-0org.kde.desktop/RadioDelegate.qml
A  +135  -0tests/exclusive-menuitem.qml [License: GPL(v2.0+)
LGPL(v3.0)]

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/7bff5123264ab1f3122294c95bd1fab40fb0a6d3

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 467390] Use of checkboxes for mutually exclusive menu items is very misleading

2023-03-31 Thread ratijas
https://bugs.kde.org/show_bug.cgi?id=467390

ratijas  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/qqc2-desktop-style/c
   ||ommit/9dadd05de66a135ea0c3c
   ||66c6bb554ab22ec6a67
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #3 from ratijas  ---
Git commit 9dadd05de66a135ea0c3c66c6bb554ab22ec6a67 by ivan tkachenko.
Committed on 31/03/2023 at 22:56.
Pushed by ratijas into branch 'master'.

CheckIndicator: Allow exclusive buttons to be detected via their ButtonGroup

This is a bit wasteful, as it creates a ButtonGroup attached object for
every menu item that does not have it. But it works. Unfortunately,
there is no better approach, as if ButtonGroup is bound to an item
later than this binding is established, we won't know about it.

All components using CheckIndicator, except MenuItem, were modified to
override this new more advanced heuristic with a fixed elementType, so
they don't waste memory on attached objects, and always have
predictable appearance.

See also: https://invent.kde.org/frameworks/kirigami/-/merge_requests/1014

M  +1-0org.kde.desktop/CheckBox.qml
M  +1-0org.kde.desktop/CheckDelegate.qml
M  +6-1org.kde.desktop/CheckIndicator.qml
M  +1-0org.kde.desktop/RadioButton.qml
M  +1-0org.kde.desktop/RadioDelegate.qml
A  +135  -0tests/exclusive-menuitem.qml [License: GPL(v2.0+)
LGPL(v3.0)]

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/9dadd05de66a135ea0c3c66c6bb554ab22ec6a67

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 467390] Use of checkboxes for mutually exclusive menu items is very misleading

2023-03-15 Thread Arjen Hiemstra
https://bugs.kde.org/show_bug.cgi?id=467390

--- Comment #2 from Arjen Hiemstra  ---
Note that this is fixable by creating an ActionGroup outside the menu and using
the `ActionGroup.group` attached property to put actions into that group. See
https://invent.kde.org/plasma/plasma-systemmonitor/-/blob/master/src/faces/processtable/contents/ui/FullRepresentation.qml#L130
for an example.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-qqc2-desktop-style] [Bug 467390] Use of checkboxes for mutually exclusive menu items is very misleading

2023-03-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=467390

Nate Graham  changed:

   What|Removed |Added

Summary|Use of check boxes is very  |Use of checkboxes for
   |misleading  |mutually exclusive menu
   ||items is very misleading
   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.