[konsole] [Bug 405158] Konsole Crashes When Logging Out All Tabs in a Window Using "Copy Input To" Feature

2019-04-25 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=405158

Christoph Feck  changed:

   What|Removed |Added

 CC||fabio.coa...@gmail.com

--- Comment #5 from Christoph Feck  ---
*** Bug 403114 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 405158] Konsole Crashes When Logging Out All Tabs in a Window Using "Copy Input To" Feature

2019-04-11 Thread J Petersen
https://bugs.kde.org/show_bug.cgi?id=405158

--- Comment #4 from J Petersen  ---
Nevermind. It is being pulled in to FC for testing now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 405158] Konsole Crashes When Logging Out All Tabs in a Window Using "Copy Input To" Feature

2019-04-11 Thread J Petersen
https://bugs.kde.org/show_bug.cgi?id=405158

--- Comment #3 from J Petersen  ---
I apologize if this is the wrong place to ask this. 

Can anyone give me an idea when this fix might make it down into Fedora Core 29
(currently on konsole5-18.12.2-1.fc29)? This issue affects me daily still.
Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 405158] Konsole Crashes When Logging Out All Tabs in a Window Using "Copy Input To" Feature

2019-03-13 Thread Kurt Hindenburg
https://bugs.kde.org/show_bug.cgi?id=405158

Kurt Hindenburg  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/kon
   ||sole/cb49c985a31692806be5f8
   ||f717d79b1425cfcbc9
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Kurt Hindenburg  ---
Git commit cb49c985a31692806be5f8f717d79b1425cfcbc9 by Kurt Hindenburg, on
behalf of David Hallas.
Committed on 14/03/2019 at 03:01.
Pushed by hindenburg into branch 'master'.

Fixes crash when using the Copy Input To All Tabs feature

Summary:
Fixes crash when using the Copy Input To All Tabs feature. The crash is
caused because the sessions are removed from the SessionManager before
the MainWindow is updated. When the MainWindow receives the
activeViewChanged signal it assumes that the
SessionManager::sessionProfile returns a valid Profile pointer, but in
this case it has already been freed and is therefore nullptr. The fix is
to simply check if the new active Session has a valid Profile, if not
simply ignore it.

Test Plan:
1. Open Konsole window
2. Open multiple tabs within that Konsole window
3. (apparently an important piece) Scroll through the tabs and go back to the
first one opened, on the far left of the tab bar
4. Select Edit menu -> Copy Input To -> All Tabs in Current Window
5. Type a ctrl-D to issue logout command to all tabs in window

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: hindenburg, konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D19642

M  +3-0src/MainWindow.cpp

https://commits.kde.org/konsole/cb49c985a31692806be5f8f717d79b1425cfcbc9

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 405158] Konsole Crashes When Logging Out All Tabs in a Window Using "Copy Input To" Feature

2019-03-09 Thread David Hallas
https://bugs.kde.org/show_bug.cgi?id=405158

David Hallas  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Assignee|konsole-de...@kde.org   |da...@davidhallas.dk
 Status|REPORTED|ASSIGNED
 CC||da...@davidhallas.dk

--- Comment #1 from David Hallas  ---
Added a patch that fixes the crash

https://phabricator.kde.org/D19642

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 405158] Konsole Crashes When Logging Out All Tabs in a Window Using "Copy Input To" Feature

2019-03-07 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=405158

Kai Uwe Broulik  changed:

   What|Removed |Added

Product|kde |konsole
 CC||k...@privat.broulik.de
  Component|general |general
   Assignee|unassigned-b...@kde.org |konsole-de...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.