[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-08-01 Thread Adam Batkin
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #38 from Adam Batkin  ---
I don't want to unilaterally change the title of this bug, but - given that
half a dozen or so (duplicate) bugs have been opened in the past few weeks,
complaining that the konsole toolbars can't be hidden - it may be worthwhile to
come up with a better title for this bug (so people can find it). Specifically,
those users weren't concerned (yet) that their no-toolbar setting wasn't
persistent, they were complaining that no option exists to hide the toolbars.

(when you do a search for "toolbar" with product=konsole, it appears that there
are no relevant issues, since all of the closed ones are filtered out, and -
from the title - this one does not appear relevant)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-08-01 Thread Adam Batkin
https://bugs.kde.org/show_bug.cgi?id=430036

Adam Batkin  changed:

   What|Removed |Added

 CC||devguy...@gmail.com

--- Comment #37 from Adam Batkin  ---
*** Bug 440286 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-08-01 Thread Adam Batkin
https://bugs.kde.org/show_bug.cgi?id=430036

Adam Batkin  changed:

   What|Removed |Added

 CC||a...@batkin.net

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-08-01 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #36 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Ahmad Samir from comment #33)
> Please test https://invent.kde.org/utilities/konsole/-/merge_requests/447

Pulled that and built with it just a moment ago.  We'll see how it goes as soon
as the rest of my kde rebuilds finish (under 10 to go) and I can reboot.

Tho mr435 from comment #23 had fixed the toolbar problem for me, but this one
(mr447) is supposed to fix other problems (that weren't affecting me) that it
didn't, but as sandsmark says on the mr, "the change is a bit complex", as is
this heap of intertwined bugs where the simple fix for one triggers another, so
we'll see...

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-31 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430036

Ahmad Samir  changed:

   What|Removed |Added

 CC||7egg...@gmx.de

--- Comment #35 from Ahmad Samir  ---
*** Bug 440443 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-29 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430036

Ahmad Samir  changed:

   What|Removed |Added

 CC||dmi...@pankratov.net

--- Comment #34 from Ahmad Samir  ---
*** Bug 440394 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-29 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430036

Ahmad Samir  changed:

   What|Removed |Added

 CC||a.samir...@gmail.com

--- Comment #33 from Ahmad Samir  ---
Please test https://invent.kde.org/utilities/konsole/-/merge_requests/447

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-29 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #32 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Garry Williams from comment #30)
> The bug is fixed in the -1 version and comes back in the -3 version.  I have
> never seen a -2 version of either package.

Oops.  That was my mistake.  I saw the .2 and looking for a context of
something before -3, was reading it as -2.

(In reply to Adam Williamson from comment #29)
> The change between Fedora -2 and -3 was indeed a backport from upstream. It
> was a backport of https://github.com/KDE/konsole/commit/b43548b , which
> fixes bug #437791 (the Konsole window initially appearing at a very small
> size on launch).

And yes, git b43548b was implicated in the set of commits between konsole and
kxmlgui.  As I said, with the patch in the remaining pr it all seems to be
straightened out on master/head of both, here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-29 Thread Adam Williamson
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #31 from Adam Williamson  ---
ah, sorry, forgot to explain that - for the F34 branch -2 is effectively a
no-op. -2 was a straight rebuild on the Rawhide branch for the Rawhide mass
rebuild, it did not happen on the F34 branch. But the commit for -2 was merged
into the F34 branch presumably as the maintainer is keeping those branches
equal for now (this is a fairly common strategy).

So still the only actual difference betweeen -1 and -3 is the same patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-29 Thread Garry Williams
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #30 from Garry Williams  ---
Just to be clear, I saw this bug come back after installing (from Fedora
updates-testing) konsole5-21.04.2-3.fc34 and konsole5-part-21.04.2-3.fc34.

I see the bug fixed by downgrading to konsole5-21.04.2-1.fc34 and
konsole5-part-21.04.2-1.fc34.

The bug is fixed in the -1 version and comes back in the -3 version.  I have
never seen a -2 version of either package.

(See my comment #27.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-29 Thread Adam Williamson
https://bugs.kde.org/show_bug.cgi?id=430036

Adam Williamson  changed:

   What|Removed |Added

 CC||ad...@happyassassin.net

--- Comment #29 from Adam Williamson  ---
The change between Fedora -2 and -3 was indeed a backport from upstream. It was
a backport of https://github.com/KDE/konsole/commit/b43548b , which fixes bug
#437791 (the Konsole window initially appearing at a very small size on
launch).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-28 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #28 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Garry Williams from comment #27)
> I install konsole5-21.04.2-3.fc34 and konsole5-part-21.04.2-3.fc34 and the
> bug comes back -- I cannot make the toolbars go away permanently.
> 
> I downgrade to konsole5-21.04.2-1.fc34 and konsole5-part-21.04.2-1.fc34 and
> the toolbars are gone and do not come back.
> 
> No other change was made and I did this multiple times.
> 
> 21.04.2-3.fc34 introduces the bug.  Downgrading fixes the bug.

If I'm correctly reading those Fedora version numbers the -N segment (where N
is a number) is Fedora's patch-level on top of the upstream version given by
the rest of the version number.

If that's correct, the -2 and -3 indicate Fedora patch-levels on top of the
same upstream version 21.04.2.  The problem you're seeing is thus between
Fedora patch-levels 2 and 3 of upstream version 21.04.2, placing it in Fedora's
court.

Now it is true that many distro-level patches will originate upstream, and I
suspect that's the case here as well.  At the upstream-kde individual
git-commit level there were several sub-bugs as konsole worked around the
original bug that I believe was in kxmlgui, but kxmlgui caught that bug and
fixed it while introducing another, at least as seen by the work-around konsole
code.  It ultimately took several commits to both the konsole and kxmlgui
repositories to fix the mess and clear up all the (sub-)bugs, and as of my
update yesterday, the last one (the merge-request linked in comment #23, )
hasn't actually been committed yet, so upstream's still in flux.  But I've been
applying that merge-request as a local patch and with it, at least for me as
original bug reporter, all of konsole's toolbar-handling bugs appear to be
fixed. =:^)

So from here you have several options:

1) Just wait, possibly keeping konsole at an unaffected -2 patch-level until a
fix is available as an update beyond -3.  Eventually konsole will merge that
last mr and make a new release, and you'll get a fixed version from fedora, due
to fedora either updating to the upstream release with the fix or doing another
fedora patch-level update with the fix on the same upstream version they're
using now.

2) File a fedora bug, asking them to do another patch-level bump with the mr
included as a fedora patch.

3) Build konsole from sources yourself, applying the mr as a local patch to fix
the problem.  Note that depending on the fedora version of kxmlgui you may have
to build a current version of it locally as well, and then build konsole on top
of that.  Should you choose to do this, you can of course do #2 as well,
putting your results in the fedora bug.

(Being a Gentooer it's possible my patch-level interpretation is incorrect but
most distros have something similar; for Gentoo it's -rN, r for revision,
example -r2, 21.04.2-r2.  Of course gentooers build from source by default and
the local application of random patches like that in the mr is relatively
trivial, but upgrading a package is in general a lot more work than it is on a
binary distro because it /normally/ means building from sources.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-28 Thread Garry Williams
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #27 from Garry Williams  ---
(In reply to tcanabrava from comment #8)
> konsole has no code to manage toolbars,

Perhaps not, but...

I install konsole5-21.04.2-3.fc34 and konsole5-part-21.04.2-3.fc34 and the bug
comes back -- I cannot make the toolbars go away permanently.

I downgrade to konsole5-21.04.2-1.fc34 and konsole5-part-21.04.2-1.fc34 and the
toolbars are gone and do not come back.

No other change was made and I did this multiple times.

21.04.2-3.fc34 introduces the bug.  Downgrading fixes the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-28 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430036

Ahmad Samir  changed:

   What|Removed |Added

 CC||jmscdba+...@gmail.com

--- Comment #26 from Ahmad Samir  ---
*** Bug 440358 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-28 Thread Rex Dieter
https://bugs.kde.org/show_bug.cgi?id=430036

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-23 Thread Jinesh Choksi
https://bugs.kde.org/show_bug.cgi?id=430036

Jinesh Choksi  changed:

   What|Removed |Added

 CC||jin...@onelittlehope.com

--- Comment #25 from Jinesh Choksi  ---
*** Bug 439571 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-10 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #24 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Duncan from comment #20)
> (In reply to Martin Sandsmark from comment #17)
> > Even more funny, I can't remove the toolbar without manually editing the
> > konsoleui.rc.
> 
> This might be dated (still on 81f1c5352

It was.  Missing the ability to turn off the toolbars after update to
26018e3aa, today.

Comment #23's mr gives me back the options and turns off the toolbars again.

I tried without a konsolerc to try to see if it triggered the 1px-window again,
and then realized it wasn't going to be a valid test as I have kwin
window-rules for konsole that set the size.  Of course I could try without them
too, but I think it's better just to let others test that.

Meanwhile, this gave me an excuse to try commenting out my
konsole-wrapper-script workaround from comment #0, to see if with the new code
the bug I originally filed this on is still triggering.  Short test so far but
I no longer see it! =:^)  Assuming the mr gets merged I'll test for a few more
days and set resolved/fixed if no further problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-08 Thread Grósz Dániel
https://bugs.kde.org/show_bug.cgi?id=430036

Grósz Dániel  changed:

   What|Removed |Added

 CC||groszdaniel...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-08 Thread Bug Janitor Service
https://bugs.kde.org/show_bug.cgi?id=430036

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #23 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/konsole/-/merge_requests/435

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-08 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #22 from Martin Sandsmark  ---
Aaand sorry for the comment spamming, but b43548b22 was to work around a bug in
kxmlgui which has since been fixed in kxmlgui:
https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/53

So it should be safe to revert.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-08 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #21 from Martin Sandsmark  ---
Reverting b43548b22 Konsole both remembers whether the toolbar should be shown,
and the missing options in the settings menu are back (and probably some other
stuff I didn't notice).

For reference, here's the code that isn't run after b43548b22, should probably
copy it into konsole unless it's okay to revert b43548b22:
https://invent.kde.org/frameworks/kxmlgui/-/blob/master/src/kxmlguiwindow.cpp#L262-299

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-08 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #20 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Martin Sandsmark from comment #17)
> Even more funny, I can't remove the toolbar without manually editing the
> konsoleui.rc. There's supposed to be a "Show toolbar" under the Settings
> menu, right? It's there in all other KDE applications here...

This might be dated (still on 81f1c5352 which I updated to on July 2), but
here, konsole has a "Toolbars Shown" submenu, with "Main Toolbar" and "Session
Toolbar" checkbox entries.

So no "Show Toolbar" checkbox, it's two checkboxes under "Toolbars Shown".  I
think that got me when I was first looking into this bug as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-08 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #19 from Martin Sandsmark  ---
Checked the kxmlgui createGUI() doc, and it seems very likely, should probably
check what other stuff it sets up that we need:
"In a regular app you usually want to use setupGUI() instead of this one
since it does more things for free like setting up the toolbar/shortcut edit
actions, etc."

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-08 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #18 from Martin Sandsmark  ---
I can't test (for some reason konsole now segfaults on launch after latest
pull), but the switch from setupGUI() to createGUI() in b43548b22 might be
related?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-08 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #17 from Martin Sandsmark  ---
(In reply to tcanabrava from comment #16)
> Martin, I don’t see anything related to the loss of visibility on the
> updated xml :/

Nothing really stands out to me either, except the version bump and the
reordering of the arguments for the actions somehow getting reordered
parameters (or whatever the XML terminology is).

Even more funny, I can't remove the toolbar without manually editing the
konsoleui.rc. There's supposed to be a "Show toolbar" under the Settings menu,
right? It's there in all other KDE applications here...

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #16 from tcanabr...@kde.org ---
Martin, I don’t see anything related to the loss of visibility on the
updated xml :/


On Tue, 6 Jul 2021 at 13:28 Martin Sandsmark 
wrote:

> https://bugs.kde.org/show_bug.cgi?id=430036
>
> --- Comment #15 from Martin Sandsmark  ---
> Also seems to happen when I updated from 6723627d to master. A bit hard to
> bisect because of the nature of it.
>
> I version control my konsole config, so this seems to be the relevant
> change
> Konsole in master applies to its kxmglgui rc file that breaks it fwiw:
>
>   --- kxmlgui5/konsole/konsoleui.rc
>   +++ kxmlgui5/konsole/konsoleui.rc
>   @@ -1,6 +1,6 @@
>
>
>   -
>   +
> 
>  
>   File
>   @@ -50,6 +50,10 @@
>   
>   
>  
>   +  
>   +   Plugins
>   +   
>   +  
>  
>   Help
>  
>   @@ -62,10 +66,10 @@
>  
> 
> 
>   -  
>   -  
>   -  
>   -  
>   -  
>   +  
>   +  
>   +  
>   +  
>   +  
> 
>
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-06 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #15 from Martin Sandsmark  ---
Also seems to happen when I updated from 6723627d to master. A bit hard to
bisect because of the nature of it.

I version control my konsole config, so this seems to be the relevant change
Konsole in master applies to its kxmglgui rc file that breaks it fwiw:

  --- kxmlgui5/konsole/konsoleui.rc
  +++ kxmlgui5/konsole/konsoleui.rc
  @@ -1,6 +1,6 @@
   
   
  -
  +

 
  File
  @@ -50,6 +50,10 @@
  
  
 
  +  
  +   Plugins
  +   
  +  
 
  Help
 
  @@ -62,10 +66,10 @@
 


  -  
  -  
  -  
  -  
  -  
  +  
  +  
  +  
  +  
  +  

   

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-05 Thread S. Bryant
https://bugs.kde.org/show_bug.cgi?id=430036

S. Bryant  changed:

   What|Removed |Added

 CC||st...@bawue.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-05 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #14 from Martin Sandsmark  ---
(In reply to Martin Sandsmark from comment #13)
> I still have the same issue with latest master.
> 
> And it appeared after upgrading konsole, not kxmlgui, so the bug is in
> konsole

The upgrade was from b21938e5 to 036e4e87 fwiw.

It also seems to have somehow lost/reset my default profile, and I can't seem
to disable the resize hints popping up (if I turn it on it stopped for a while
in new windows, but now they're suddenly back).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-05 Thread Martin Sandsmark
https://bugs.kde.org/show_bug.cgi?id=430036

Martin Sandsmark  changed:

   What|Removed |Added

 CC||martin.sandsm...@kde.org

--- Comment #13 from Martin Sandsmark  ---
I still have the same issue with latest master.

And it appeared after upgrading konsole, not kxmlgui, so the bug is in konsole

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-07-04 Thread Vadym Krevs
https://bugs.kde.org/show_bug.cgi?id=430036

Vadym Krevs  changed:

   What|Removed |Added

 CC||vkr...@yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-06-25 Thread Garry Williams
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #12 from Garry Williams  ---
(In reply to Garry Williams from comment #11)
> konsole version 21.04.2 fixed the problem for me.

Also, kf5-kxmlgui-5.83.0-1.fc34.x86_64

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-06-25 Thread Garry Williams
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #11 from Garry Williams  ---
konsole version 21.04.2 fixed the problem for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-06-08 Thread Ahmad Samir
https://bugs.kde.org/show_bug.cgi?id=430036

Ahmad Samir  changed:

   What|Removed |Added

 CC||gtwilli...@gmail.com

--- Comment #10 from Ahmad Samir  ---
*** Bug 438160 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-06-07 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #9 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to tcanabrava from comment #8)
> konsole has no code to manage toolbars, this is handled by the kxmlgui library

Thanks for the pointer.  I had decided it wasn't konsole here too, but in a
jump of illogic concluded that meant qt, forgetting about the frameworks, and
wasn't going to even attempt qt code.  But kxmlgui's friendlier territory as
it's both considerably smaller and and one of the "most kde packages" I'm
already running live-git, so I may actually take a look at it.

> I'm trying to debug this but *currently* I'm not affected.

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-06-07 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #8 from tcanabr...@kde.org ---
konsole has no code to manage toolbars, this is handled by the kxmlgui
library, I'm trying to debug this but *currently* I'm not affected.


On Mon, Jun 7, 2021 at 2:42 AM  wrote:

> https://bugs.kde.org/show_bug.cgi?id=430036
>
> n...@leippe.com changed:
>
>What|Removed |Added
>
> 
>  Status|REPORTED|CONFIRMED
>  Ever confirmed|0   |1
>
> --- Comment #7 from n...@leippe.com ---
> It's actually worse than I originally thought.
> Both toolbars are returning w/o any user changes being made on *active
> windows*.
>
> 1) Ctrl-shift-N an open konsole (that doesn't have the toolbars).
> 2) Sometimes this new konsole has the toolbars
> 2a) if it does, remove them
> 3) use it, keep it open
>
> 4) at some time later check it and you'll see the toolbars have magically
> reappeared.
> 5) remove them, return to 3 and repeat...
>
> They will *not* stay away.
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-06-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=430036

n...@leippe.com changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #7 from n...@leippe.com ---
It's actually worse than I originally thought.
Both toolbars are returning w/o any user changes being made on *active
windows*.

1) Ctrl-shift-N an open konsole (that doesn't have the toolbars).
2) Sometimes this new konsole has the toolbars
2a) if it does, remove them
3) use it, keep it open

4) at some time later check it and you'll see the toolbars have magically
reappeared.
5) remove them, return to 3 and repeat...

They will *not* stay away.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-05-21 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #6 from Duncan <1i5t5.dun...@cox.net> ---
Looking at the config file, looks like there's specific line entries for
menubar, statusbar, etc, but not for the toolbar.  Presumably toolbar "state"
is stored in the generic and opaque (that is non-plain-text, apparently
text-encoded binary) "State" entry, probably along with a bunch of other stuff,
making it rather more delicate and prone to corruption than a dedicated
separate-line plain-text setting. =:^(

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-05-20 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #5 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to nick from comment #4) ...

... So no for-sure confirmation on the closing one and immediately opening a
new one race, but dozens of konsoles and no definite negative-confirmation
either, so it's possible.

FWIW, while I may well have high single-digits or even plausibly in the teens
of konsoles open it'd be very rare to have "dozens" open, to the point I'm not
sure I /ever/ have.  But  of about three use-cases here, the one definitely
closes/open konsoles fast enough that one closing could still be writing the
config while another opens, thus producing that race I believe to be the
trigger here.

What we know:

* The no-toolbars config option is is honored at least some of the time, so
it's written and read back correctly, even if it appears to be inconsistently.

* Using a wrapper script that rewrites the konsolerc file from backup before
launch appears to be a solid workaround -- I've *never* seen the problem since
I instituted the wrapper -- so provided konsole can read the config file, it
does seem to do so and the config appears to be correctly loaded from the file
(as long as it can be read).

* SOMETHING is therefore inconsistently either rewriting the config, OR is
preventing reading the config correctly at startup.

Of course my *theory* is that it's the latter, due to the file being locked for
writing by an unloading instance at the same time a newly launching instance
attempts to read it, thus creating a race such that the new instance can't read
the config and defaults to showing the toolbar.  And that both of us use enough
konsoles that it's plausible one is starting while another is quitting
(definitely the case here, plausibly the case for you) would seem to support
the theory.

A plausible second step that just occurred to me now:  While one would hope
that (in this era of limited-write ssds) konsole doesn't needlessly rewrite its
config /every/ time it loads, the logic could very well be that it treats *any*
error reading the config file as if the file doesn't exist, implying it's a
first-run, and thus writes out its default config as what it believes to be the
not-yet-existing file, instead of waiting for a config change to write it out,
as would normally be the case.

That would explain why when it toggles back to show-toolbar, it's then
consistent on every load until the toolbar is manually turned off again.

While I'm not particularly comfortable reading code (and definitely not writing
it, tho I I'm getting a bit more comfortable hack-patching existing code), I
should take a look and see if I can figure out what it's actually doing.  If it
turns out it's either unconditionally rewriting the config at every load, or
it's treating /any/ error reading the config as a fresh config and writing out
the default config...

BTW, I believe you can bug-status confirm the bug if you feel comfortable doing
so.  (I'd feel weird confirming my own bug, but now that you're seeing it too I
believe it's confirmable.)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-05-20 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #4 from n...@leippe.com ---
I haven't paid close attention to my use cases, but for sure this happens (just
tested again):
1 - I have dozens of konsoles open.
2 - I pick one and remove the toolbars and hide the main menu
3 - Ctrl-Shift-n to open a new konsole window
4 - the new window is fine.
5 - wait a while
6 - Ctrl-Shift-n from the first konsole again, now the new window has the
toolbars again.
7 - remove them in the new window
8 - Ctrl-Shift-n from the first konsole again and now the new window also
doesn't have the toolbars again.

That first one is peristently open the whole time.
Among my dozens of other konsole windows every time I use one I remove the
toolbars.
I frequently open new konsoles, and randomly the toolbars start reappearing on
the new ones even though the source konsole has had them removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-05-20 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #3 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to nick from comment #2)
> Not sure if this is the same cause [...] It's getting really irritating.

I believe it is, and yes, it is. =:^(  Thanks for the bug confirmation.

The good news is the wrapper-script workaround is solid -- I've not had to
worry about the problem since I set that up.  The bad news is of course the
hassle of the workaround, including remembering to manually update the backup
on deliberate config change.

Question:  Does your use-case involve the rapid konsole closing and
re-launching of my use-case that I suspect is triggering the race I believe to
be the root of the problem?  If so that's further confirmation of that theory. 
If not, the problem is worse than I suspected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-05-20 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=430036

n...@leippe.com changed:

   What|Removed |Added

 CC||n...@leippe.com

--- Comment #2 from n...@leippe.com ---
Not sure if this is the same cause, but recently since my latest update from
20.12.3 to 21.04.0 there is now both a "main toolbar" and "session toolbar",
and even though I keep having to show the menubar, unselect them to hide them,
then hide my menubar again, they keep coming back. It's getting really
irritating.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2021-03-13 Thread Duncan
https://bugs.kde.org/show_bug.cgi?id=430036

--- Comment #1 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Duncan from comment #0)
> So now I resorted to copying konsolerc to a backup, and a $HOME/bin/konsole
> wrapper script that copies it back over konsolerc before doing exec
> /bin/konsole.

FWIW that has been working reliably for me for I guess 3+ months now.  It's a
kludge of a workaround but it's consistently working, unlike the option without
the kludge.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2020-12-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=430036

Nate Graham  changed:

   What|Removed |Added

 CC||tum...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 430036] konsole repeatedly losing no-toolbar setting

2020-12-07 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=430036

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.