[kwin] [Bug 234153] Effects grabbing keyboard prevent screen locking

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=234153

David Edmundson  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/3604aaf74cac587757b20daea
   ||108f80ade9973d5

--- Comment #18 from David Edmundson  ---
Git commit 3604aaf74cac587757b20daea108f80ade9973d5 by David Edmundson.
Committed on 23/06/2019 at 16:00.
Pushed by davidedmundson into branch 'master'.

Close screen grabbing effect when screensaver starts

Summary:
The screenlock fails on X11 if it can't grab the keyboard.

We can't nicely solve the generic case. We can solve the common case of
a kwin effect being active.

It's not critical, arguably not even desirable to have these effects
persist after the screen is locked through an external trigger. We can
just close the effect early.

Key grabs have to be relased early before the close animation completes
so that the locker doesn't have a race based on animation times.

It's not ideal, but no worse than the current state for not much work.

Test Plan:
locked screen on a timer
opened various effects

Reviewers: #kwin, zzag

Reviewed By: #kwin, zzag

Subscribers: ngraham, zzag, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D20890

M  +1-0CMakeLists.txt
M  +1-0effects.cpp
M  +10   -0effects/cube/cube.cpp
M  +8-0effects/desktopgrid/desktopgrid.cpp
M  +4-0effects/flipswitch/flipswitch.cpp
M  +3-0effects/presentwindows/presentwindows.cpp
M  +7-0libkwineffects/kwineffects.h
M  +7-2screenlockerwatcher.cpp
M  +4-1screenlockerwatcher.h

https://commits.kde.org/kwin/3604aaf74cac587757b20daea108f80ade9973d5

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 234153] Effects grabbing keyboard prevent screen locking

[David Edmundson]

https://bugs.kde.org/show_bug.cgi?id=234153

David Edmundson  changed:

   What|Removed |Added

 CC||rinkydink...@gmail.com

--- Comment #17 from David Edmundson  ---
*** Bug 406709 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 234153] Effects grabbing keyboard prevent screen locking

[Martin Flöser]

https://bugs.kde.org/show_bug.cgi?id=234153

Martin Flöser  changed:

   What|Removed |Added

 CC||aleseco.f...@gmail.com

--- Comment #16 from Martin Flöser  ---
*** Bug 406636 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 234153] Effects grabbing keyboard prevent screen locking

[Martin Gräßlin via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=234153

Martin Gräßlin  changed:

   What|Removed |Added

 CC||fmet...@gmail.com

--- Comment #15 from Martin Gräßlin  ---
*** Bug 364634 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.